From 251e70b219aa12752a75c442581ae9ed8ce7461f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= Date: Thu, 30 Mar 2023 10:35:08 +0200 Subject: Fix OTP-26+ warnings in test suites --- test/metrics_SUITE.erl | 8 ++++---- test/tracer_SUITE.erl | 9 ++------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/test/metrics_SUITE.erl b/test/metrics_SUITE.erl index 74a259f..ad4f5fb 100644 --- a/test/metrics_SUITE.erl +++ b/test/metrics_SUITE.erl @@ -469,7 +469,7 @@ error_response(Config) -> [{_, #{ spawn := ProcSpawn, exit := ProcExit, - reason := {crash, _StackTrace} + reason := {crash, StackTrace} }}] = maps:to_list(Procs), true = ProcSpawn =< ProcExit, %% Confirm other metadata are as expected. @@ -477,7 +477,7 @@ error_response(Config) -> ref := _, pid := From, streamid := 1, - reason := {internal_error, {'EXIT', _Pid, {crash, _StackTrace}}, 'Stream process crashed.'}, + reason := {internal_error, {'EXIT', _Pid, {crash, StackTrace}}, 'Stream process crashed.'}, req := #{}, informational := [], user_data := #{} @@ -526,7 +526,7 @@ error_response_after_reply(Config) -> [{_, #{ spawn := ProcSpawn, exit := ProcExit, - reason := {crash, _StackTrace} + reason := {crash, StackTrace} }}] = maps:to_list(Procs), true = ProcSpawn =< ProcExit, %% Confirm other metadata are as expected. @@ -534,7 +534,7 @@ error_response_after_reply(Config) -> ref := _, pid := From, streamid := 1, - reason := {internal_error, {'EXIT', _Pid, {crash, _StackTrace}}, 'Stream process crashed.'}, + reason := {internal_error, {'EXIT', _Pid, {crash, StackTrace}}, 'Stream process crashed.'}, req := #{}, informational := [], user_data := #{} diff --git a/test/tracer_SUITE.erl b/test/tracer_SUITE.erl index d5683a0..d87a8dc 100644 --- a/test/tracer_SUITE.erl +++ b/test/tracer_SUITE.erl @@ -29,13 +29,8 @@ suite() -> %% We initialize trace patterns here. Appropriate would be in %% init_per_suite/1, but this works just as well. all() -> - case code:is_module_native(?MODULE) of - true -> - {skip, "The Cowboy tracer is not compatible with native code."}; - false -> - cowboy_tracer_h:set_trace_patterns(), - cowboy_test:common_all() - end. + cowboy_tracer_h:set_trace_patterns(), + cowboy_test:common_all(). %% We want tests for each group to execute sequentially %% because we need to modify the protocol options. Groups -- cgit v1.2.3