From b0519af42a4d3ee7e345967206bd1d0050e9061b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= Date: Wed, 29 Nov 2017 21:38:10 +0100 Subject: Don't include a content-length in 204 responses --- src/cowboy_req.erl | 5 +++++ test/rfc7230_SUITE.erl | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/cowboy_req.erl b/src/cowboy_req.erl index da3a0a4..e38b76c 100644 --- a/src/cowboy_req.erl +++ b/src/cowboy_req.erl @@ -725,6 +725,11 @@ reply(Status, Headers, SendFile = {sendfile, _, Len, _}, Req) do_reply(Status, Headers#{ <<"content-length">> => integer_to_binary(Len) }, SendFile, Req); +%% 204 responses must not include content-length. (RFC7230 3.3.1, RFC7230 3.3.2) +reply(Status=204, Headers, Body, Req) -> + do_reply(Status, Headers, Body, Req); +reply(Status= <<"204",_/bits>>, Headers, Body, Req) -> + do_reply(Status, Headers, Body, Req); reply(Status, Headers, Body, Req) when is_integer(Status); is_binary(Status) -> do_reply(Status, Headers#{ diff --git a/test/rfc7230_SUITE.erl b/test/rfc7230_SUITE.erl index bca620d..9175fa9 100644 --- a/test/rfc7230_SUITE.erl +++ b/test/rfc7230_SUITE.erl @@ -1764,7 +1764,7 @@ no_content_length_in_204_response(Config) -> "(RFC7230 3.3.1, RFC7230 3.3.2)"), Client = raw_open(Config), ok = raw_send(Client, [ - "GET /resp/reply4/204 HTTP/1.1\r\n" + "GET /resp/reply3/204 HTTP/1.1\r\n" "Host: localhost\r\n" "\r\n"]), {_, 204, _, Rest} = cow_http:parse_status_line(raw_recv_head(Client)), -- cgit v1.2.3