aboutsummaryrefslogtreecommitdiffstats
path: root/test/handlers
diff options
context:
space:
mode:
authorLoïc Hoguin <[email protected]>2018-10-31 10:50:57 +0100
committerLoïc Hoguin <[email protected]>2018-10-31 10:50:57 +0100
commita8335c63df31f21d88e9d7d1f2b64d32a674cd7a (patch)
tree2c8adc564263b49621ed969e0e08976258a35ffa /test/handlers
parent07078eb47bfc2a774e4ce00d2a215c301f4f4ea7 (diff)
downloadcowboy-a8335c63df31f21d88e9d7d1f2b64d32a674cd7a.tar.gz
cowboy-a8335c63df31f21d88e9d7d1f2b64d32a674cd7a.tar.bz2
cowboy-a8335c63df31f21d88e9d7d1f2b64d32a674cd7a.zip
Always dialyze tests and fix some cowboy_req specs
Diffstat (limited to 'test/handlers')
-rw-r--r--test/handlers/resp_h.erl4
-rw-r--r--test/handlers/resp_iolist_body_h.erl2
-rw-r--r--test/handlers/stream_handler_h.erl1
-rw-r--r--test/handlers/switch_protocol_flush_h.erl2
-rw-r--r--test/handlers/ws_terminate_h.erl3
5 files changed, 11 insertions, 1 deletions
diff --git a/test/handlers/resp_h.erl b/test/handlers/resp_h.erl
index 625a2ea..bfcb95c 100644
--- a/test/handlers/resp_h.erl
+++ b/test/handlers/resp_h.erl
@@ -2,6 +2,10 @@
-module(resp_h).
+%% @todo Probably should have a separate handler for errors,
+%% so that we can dialyze all the other correct calls.
+-dialyzer({nowarn_function, do/3}).
+
-export([init/2]).
init(Req, Opts) ->
diff --git a/test/handlers/resp_iolist_body_h.erl b/test/handlers/resp_iolist_body_h.erl
index 938f561..d8989b5 100644
--- a/test/handlers/resp_iolist_body_h.erl
+++ b/test/handlers/resp_iolist_body_h.erl
@@ -2,6 +2,8 @@
-module(resp_iolist_body_h).
+-dialyzer(no_improper_lists).
+
-export([init/2]).
init(Req0, State) ->
diff --git a/test/handlers/stream_handler_h.erl b/test/handlers/stream_handler_h.erl
index 0f245c6..2196be3 100644
--- a/test/handlers/stream_handler_h.erl
+++ b/test/handlers/stream_handler_h.erl
@@ -107,6 +107,7 @@ early_error(StreamID, Reason, PartialReq, Resp, Opts) ->
end.
%% @todo It would be good if we could allow this function to return normally.
+-spec takeover(_, _, _, _, _, _, _) -> no_return().
takeover(Parent, Ref, Socket, Transport, Opts, Buffer, State=#state{pid=Pid}) ->
Pid ! {Pid, self(), takeover, Parent, Ref, Socket, Transport, Opts, Buffer, State},
exit(normal).
diff --git a/test/handlers/switch_protocol_flush_h.erl b/test/handlers/switch_protocol_flush_h.erl
index 3d525ee..1b06df2 100644
--- a/test/handlers/switch_protocol_flush_h.erl
+++ b/test/handlers/switch_protocol_flush_h.erl
@@ -27,6 +27,8 @@ info(_, _, State) ->
terminate(_, _, _) ->
ok.
+%% @todo It would be good if we could allow this function to return normally.
+-spec takeover(_, _, _, _, _, _, _) -> no_return().
takeover(_, _, _, _, _, _, Pid) ->
Msgs = receive_all([]),
Pid ! {Pid, Msgs},
diff --git a/test/handlers/ws_terminate_h.erl b/test/handlers/ws_terminate_h.erl
index 4621df6..12e6d1a 100644
--- a/test/handlers/ws_terminate_h.erl
+++ b/test/handlers/ws_terminate_h.erl
@@ -31,4 +31,5 @@ websocket_info(_, State) ->
{ok, State}.
terminate(Reason, Req, #state{pid=Pid}) ->
- Pid ! {terminate, Reason, Req}.
+ Pid ! {terminate, Reason, Req},
+ ok.