diff options
author | Loïc Hoguin <[email protected]> | 2020-05-20 13:41:05 +0200 |
---|---|---|
committer | Loïc Hoguin <[email protected]> | 2020-05-20 13:41:05 +0200 |
commit | 39b2816255503910dc23e2fdf703ee63bbc8953e (patch) | |
tree | 65f9b843db941fd7ba1f3926b77ab34cbc5675f8 /test/rfc7230_SUITE.erl | |
parent | 8337aca4d31ffa8120704057675aacbbaa280975 (diff) | |
download | cowboy-39b2816255503910dc23e2fdf703ee63bbc8953e.tar.gz cowboy-39b2816255503910dc23e2fdf703ee63bbc8953e.tar.bz2 cowboy-39b2816255503910dc23e2fdf703ee63bbc8953e.zip |
204 and 304 responses must not include a body
When calling cowboy_req:reply/4 with a body a crash will occur
resulting in a 500 response. When calling cowboy_req:stream_reply/2,3
and then attempting to send a body a crash will occur.
Diffstat (limited to 'test/rfc7230_SUITE.erl')
-rw-r--r-- | test/rfc7230_SUITE.erl | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/test/rfc7230_SUITE.erl b/test/rfc7230_SUITE.erl index e110441..9846a0f 100644 --- a/test/rfc7230_SUITE.erl +++ b/test/rfc7230_SUITE.erl @@ -1886,22 +1886,22 @@ no_body_in_head_response(Config) -> %1xx responses never include a message body. (RFC7230 3.3) no_body_in_204_response(Config) -> - doc("204 responses never include a message body. (RFC7230 3.3)"), + doc("204 responses never include a message body. Cowboy produces " + "a 500 error response when attempting to do so. (RFC7230 3.3)"), Client = raw_open(Config), ok = raw_send(Client, [ - "GET /resp/reply2/204 HTTP/1.1\r\n" + "GET /resp/reply4/204body HTTP/1.1\r\n" "Host: localhost\r\n" "\r\n"]), - {_, 204, _, Rest} = cow_http:parse_status_line(raw_recv_head(Client)), - {_, <<>>} = cow_http:parse_headers(Rest), - {error, timeout} = raw_recv(Client, 1, 1000), + {_, 500, _, _} = cow_http:parse_status_line(raw_recv_head(Client)), ok. no_body_in_204_response_stream(Config) -> - doc("204 responses never include a message body. (RFC7230 3.3)"), + doc("204 responses never include a message body. Attempting to " + "stream the body produces a crash on the server-side. (RFC7230 3.3)"), Client = raw_open(Config), ok = raw_send(Client, [ - "GET /resp/stream_reply2/204 HTTP/1.1\r\n" + "GET /resp/stream_reply2/204body HTTP/1.1\r\n" "Host: localhost\r\n" "\r\n"]), {_, 204, _, Rest} = cow_http:parse_status_line(raw_recv_head(Client)), @@ -1910,22 +1910,22 @@ no_body_in_204_response_stream(Config) -> ok. no_body_in_304_response(Config) -> - doc("304 responses never include a message body. (RFC7230 3.3)"), + doc("304 responses never include a message body. Cowboy produces " + "a 500 error response when attempting to do so. (RFC7230 3.3)"), Client = raw_open(Config), ok = raw_send(Client, [ - "GET /resp/reply2/304 HTTP/1.1\r\n" + "GET /resp/reply4/304body HTTP/1.1\r\n" "Host: localhost\r\n" "\r\n"]), - {_, 304, _, Rest} = cow_http:parse_status_line(raw_recv_head(Client)), - {_, <<>>} = cow_http:parse_headers(Rest), - {error, timeout} = raw_recv(Client, 1, 1000), + {_, 500, _, _} = cow_http:parse_status_line(raw_recv_head(Client)), ok. no_body_in_304_response_stream(Config) -> - doc("304 responses never include a message body. (RFC7230 3.3)"), + doc("304 responses never include a message body. Attempting to " + "stream the body produces a crash on the server-side. (RFC7230 3.3)"), Client = raw_open(Config), ok = raw_send(Client, [ - "GET /resp/stream_reply2/304 HTTP/1.1\r\n" + "GET /resp/stream_reply2/304body HTTP/1.1\r\n" "Host: localhost\r\n" "\r\n"]), {_, 304, _, Rest} = cow_http:parse_status_line(raw_recv_head(Client)), |