diff options
| author | Loïc Hoguin <[email protected]> | 2013-01-20 18:57:42 +0100 |
|---|---|---|
| committer | Loïc Hoguin <[email protected]> | 2013-01-20 19:06:28 +0100 |
| commit | 823a82b8f2ebb5e00140ada1d1ba17e27df8d97a (patch) | |
| tree | f895589544f76d4fe9b6ed4a4dc00980c6597e81 /test | |
| parent | 4b15d8f6e3692caa796e7e7bf0bdfbd977d00e30 (diff) | |
| download | cowboy-823a82b8f2ebb5e00140ada1d1ba17e27df8d97a.tar.gz cowboy-823a82b8f2ebb5e00140ada1d1ba17e27df8d97a.tar.bz2 cowboy-823a82b8f2ebb5e00140ada1d1ba17e27df8d97a.zip | |
Fix an issue for replies in onresponse mishandling headers
Reported and fixed over email by Adrian Roe.
Diffstat (limited to 'test')
| -rw-r--r-- | test/http_SUITE.erl | 34 |
1 files changed, 33 insertions, 1 deletions
diff --git a/test/http_SUITE.erl b/test/http_SUITE.erl index 3200188..67920a8 100644 --- a/test/http_SUITE.erl +++ b/test/http_SUITE.erl @@ -45,6 +45,7 @@ -export([nc_zero/1]). -export([onrequest/1]). -export([onrequest_reply/1]). +-export([onresponse_capitalize/1]). -export([onresponse_crash/1]). -export([onresponse_reply/1]). -export([pipeline/1]). @@ -84,7 +85,8 @@ all() -> {group, http_compress}, {group, https_compress}, {group, onrequest}, - {group, onresponse} + {group, onresponse}, + {group, onresponse_capitalize} ]. groups() -> @@ -146,6 +148,9 @@ groups() -> {onresponse, [], [ onresponse_crash, onresponse_reply + ]}, + {onresponse_capitalize, [], [ + onresponse_capitalize ]} ]. @@ -250,6 +255,18 @@ init_per_group(onresponse, Config) -> ]), {ok, Client} = cowboy_client:init([]), [{scheme, <<"http">>}, {port, Port}, {opts, []}, + {transport, Transport}, {client, Client}|Config]; +init_per_group(onresponse_capitalize, Config) -> + Port = 33086, + Transport = ranch_tcp, + {ok, _} = cowboy:start_http(onresponse_capitalize, 100, [{port, Port}], [ + {env, [{dispatch, init_dispatch(Config)}]}, + {max_keepalive, 50}, + {onresponse, fun onresponse_capitalize_hook/4}, + {timeout, 500} + ]), + {ok, Client} = cowboy_client:init([]), + [{scheme, <<"http">>}, {port, Port}, {opts, []}, {transport, Transport}, {client, Client}|Config]. end_per_group(Group, Config) when Group =:= https; Group =:= https_compress -> @@ -671,6 +688,21 @@ onrequest_hook(Req) -> Req3 end. +onresponse_capitalize(Config) -> + Client = ?config(client, Config), + {ok, Client2} = cowboy_client:request(<<"GET">>, + build_url("/", Config), Client), + {ok, Transport, Socket} = cowboy_client:transport(Client2), + {ok, Data} = Transport:recv(Socket, 0, 1000), + false = nomatch =:= binary:match(Data, <<"Content-Length">>). + +%% Hook for the above onresponse_capitalize test. +onresponse_capitalize_hook(Status, Headers, Body, Req) -> + Headers2 = [{cowboy_bstr:capitalize_token(N), V} + || {N, V} <- Headers], + {ok, Req2} = cowboy_req:reply(Status, Headers2, Body, Req), + Req2. + onresponse_crash(Config) -> Client = ?config(client, Config), {ok, Client2} = cowboy_client:request(<<"GET">>, |