From 800a4890092ebd30551c49fdae606ed5182bfdb1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= <essen@ninenines.eu>
Date: Wed, 21 Nov 2018 14:29:36 +0100
Subject: Move a old HTTP test cases to new plain_handler test suite
---
test/old_http_SUITE.erl | 9 +-----
test/plain_handler_SUITE.erl | 73 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 74 insertions(+), 8 deletions(-)
create mode 100644 test/plain_handler_SUITE.erl
diff --git a/test/old_http_SUITE.erl b/test/old_http_SUITE.erl
index ff0d4b2..6dbd2d6 100644
--- a/test/old_http_SUITE.erl
+++ b/test/old_http_SUITE.erl
@@ -113,20 +113,13 @@ do_get(Path, Config) ->
check_status(Config) ->
Tests = [
- {200, "/simple"},
- {500, "/handler_errors?case=init_before_reply"}
+ {200, "/simple"}
],
_ = [{Status, URL} = begin
Ret = do_get(URL, Config),
{Ret, URL}
end || {Status, URL} <- Tests].
-error_init_after_reply(Config) ->
- ConnPid = gun_open(Config),
- Ref = gun:get(ConnPid, "/handler_errors?case=init_after_reply"),
- {response, nofin, 200, _} = gun:await(ConnPid, Ref),
- ok.
-
rest_param_all(Config) ->
ConnPid = gun_open(Config),
%% Accept without param.
diff --git a/test/plain_handler_SUITE.erl b/test/plain_handler_SUITE.erl
new file mode 100644
index 0000000..e980d5b
--- /dev/null
+++ b/test/plain_handler_SUITE.erl
@@ -0,0 +1,73 @@
+%% Copyright (c) 2018, Loïc Hoguin <essen@ninenines.eu>
+%%
+%% Permission to use, copy, modify, and/or distribute this software for any
+%% purpose with or without fee is hereby granted, provided that the above
+%% copyright notice and this permission notice appear in all copies.
+%%
+%% THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+%% WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+%% MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+%% ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+%% WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+%% ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+%% OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+
+-module(plain_handler_SUITE).
+-compile(export_all).
+-compile(nowarn_export_all).
+
+-import(ct_helper, [config/2]).
+-import(ct_helper, [doc/1]).
+-import(cowboy_test, [gun_open/1]).
+
+%% ct.
+
+all() ->
+ cowboy_test:common_all().
+
+groups() ->
+ cowboy_test:common_groups(ct_helper:all(?MODULE)).
+
+init_per_suite(Config) ->
+ ct_helper:create_static_dir(config(priv_dir, Config) ++ "/static"),
+ Config.
+
+end_per_suite(Config) ->
+ ct_helper:delete_static_dir(config(priv_dir, Config) ++ "/static").
+
+init_per_group(Name, Config) ->
+ cowboy_test:init_common_groups(Name, Config, ?MODULE).
+
+end_per_group(Name, _) ->
+ cowboy:stop_listener(Name).
+
+%% Routes.
+
+init_dispatch(_) ->
+ cowboy_router:compile([{"localhost", [
+ {"/crash/no_reply", crash_h, no_reply},
+ {"/crash/reply", crash_h, reply}
+ ]}]).
+
+%% Tests.
+
+crash_after_reply(Config) ->
+ doc("A plain handler crash after a response was sent "
+ "results in no 500 response."),
+ ConnPid = gun_open(Config),
+ Ref = gun:get(ConnPid, "/crash/reply", [
+ {<<"accept-encoding">>, <<"gzip">>}
+ ]),
+ {response, fin, 200, _} = gun:await(ConnPid, Ref),
+ {error, timeout} = gun:await(ConnPid, Ref, 1000),
+ gun:close(ConnPid).
+
+crash_before_reply(Config) ->
+ doc("A plain handler crash before a response was sent "
+ "results in a 500 response."),
+ ConnPid = gun_open(Config),
+ Ref = gun:get(ConnPid, "/crash/no_reply", [
+ {<<"accept-encoding">>, <<"gzip">>}
+ ]),
+ {response, fin, 500, _} = gun:await(ConnPid, Ref),
+ gun:close(ConnPid).
--
cgit v1.2.3