From e4f1c332a3027b236ad07b25ffb033a11b195855 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= Date: Mon, 5 Mar 2018 16:48:56 +0100 Subject: Add a test suite for RFC7538; update Cowlib to 2.2.0 This adds the 308 status code and fixes a few small parsing bugs. --- Makefile | 2 +- test/rfc7538_SUITE.erl | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 test/rfc7538_SUITE.erl diff --git a/Makefile b/Makefile index 89bdc9d..89b288e 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ CT_OPTS += -ct_hooks cowboy_ct_hook [] # -boot start_sasl LOCAL_DEPS = crypto DEPS = cowlib ranch -dep_cowlib = git https://github.com/ninenines/cowlib 2.1.0 +dep_cowlib = git https://github.com/ninenines/cowlib 2.2.0 dep_ranch = git https://github.com/ninenines/ranch 1.4.0 DOC_DEPS = asciideck diff --git a/test/rfc7538_SUITE.erl b/test/rfc7538_SUITE.erl new file mode 100644 index 0000000..5eb9705 --- /dev/null +++ b/test/rfc7538_SUITE.erl @@ -0,0 +1,52 @@ +%% Copyright (c) 2018, Loïc Hoguin +%% +%% Permission to use, copy, modify, and/or distribute this software for any +%% purpose with or without fee is hereby granted, provided that the above +%% copyright notice and this permission notice appear in all copies. +%% +%% THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +%% WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +%% MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +%% ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +%% WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +%% ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +%% OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + +-module(rfc7538_SUITE). +-compile(export_all). +-compile(nowarn_export_all). + +-import(ct_helper, [config/2]). +-import(ct_helper, [doc/1]). +-import(cowboy_test, [gun_open/1]). + +all() -> + cowboy_test:common_all(). + +groups() -> + cowboy_test:common_groups(ct_helper:all(?MODULE)). + +init_per_group(Name, Config) -> + cowboy_test:init_common_groups(Name, Config, ?MODULE). + +end_per_group(Name, _) -> + cowboy:stop_listener(Name). + +init_dispatch(_) -> + cowboy_router:compile([{"[...]", [ + {"/resp/:key[/:arg]", resp_h, []} + ]}]). + +status_code_308(Config) -> + doc("The 308 Permanent Redirect status code can be sent. (RFC7538 3)"), + ConnPid = gun_open(Config), + Ref = gun:get(ConnPid, "/resp/reply2/308", [ + {<<"accept-encoding">>, <<"gzip">>} + ]), + {response, _, 308, _} = gun:await(ConnPid, Ref), + ok. + +%% @todo +% The server SHOULD generate a Location header field ([RFC7231], +% Section 7.1.2) in the response containing a preferred URI reference +% for the new permanent URI. -- cgit v1.2.3