From 8497c8bbcdcfd8754c500e65557ee09d9bd1bed0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= Date: Thu, 20 Sep 2012 06:22:51 +0200 Subject: Don't use decode_packet/3 for parsing the request-line First step in making all methods and header names binaries to get rid of many inconsistencies caused by decode_packet/3. Methods are all binary now. Note that since they are case sensitive, the usual methods become <<"GET">>, <<"POST">> and so on. --- examples/echo_get/src/toppage_handler.erl | 4 ++-- examples/echo_post/src/toppage_handler.erl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'examples') diff --git a/examples/echo_get/src/toppage_handler.erl b/examples/echo_get/src/toppage_handler.erl index a8666dc..6d914ec 100644 --- a/examples/echo_get/src/toppage_handler.erl +++ b/examples/echo_get/src/toppage_handler.erl @@ -16,9 +16,9 @@ handle(Req, State) -> {ok, Req4} = echo(Method, Echo, Req3), {ok, Req4, State}. -echo('GET', undefined, Req) -> +echo(<<"GET">>, undefined, Req) -> cowboy_req:reply(400, [], <<"Missing echo parameter.">>, Req); -echo('GET', Echo, Req) -> +echo(<<"GET">>, Echo, Req) -> cowboy_req:reply(200, [{<<"Content-Encoding">>, <<"utf-8">>}], Echo, Req); echo(_, _, Req) -> diff --git a/examples/echo_post/src/toppage_handler.erl b/examples/echo_post/src/toppage_handler.erl index f8659c9..69aeb9f 100644 --- a/examples/echo_post/src/toppage_handler.erl +++ b/examples/echo_post/src/toppage_handler.erl @@ -16,11 +16,11 @@ handle(Req, State) -> {ok, Req4} = maybe_echo(Method, HasBody, Req3), {ok, Req4, State}. -maybe_echo('POST', true, Req) -> +maybe_echo(<<"POST">>, true, Req) -> {ok, PostVals, Req2} = cowboy_req:body_qs(Req), Echo = proplists:get_value(<<"echo">>, PostVals), echo(Echo, Req2); -maybe_echo('POST', false, Req) -> +maybe_echo(<<"POST">>, false, Req) -> cowboy_req:reply(400, [], <<"Missing body.">>, Req); maybe_echo(_, _, Req) -> %% Method not allowed. -- cgit v1.2.3