From bfee20e61e9f6f4ad2e2d39d68c9c94910c67bac Mon Sep 17 00:00:00 2001 From: Steve Strong Date: Wed, 13 Mar 2019 11:36:04 +0000 Subject: Bind erlang:get_stacktrace prior to making other calls If we bind too late there might be an exception triggered in the terminate function and we will not get the correct stacktrace as a result. --- src/cowboy_handler.erl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/cowboy_handler.erl') diff --git a/src/cowboy_handler.erl b/src/cowboy_handler.erl index 26aa30e..bf42b77 100644 --- a/src/cowboy_handler.erl +++ b/src/cowboy_handler.erl @@ -47,8 +47,9 @@ execute(Req, Env=#{handler := Handler, handler_opts := HandlerOpts}) -> {Mod, Req2, State, Opts} -> Mod:upgrade(Req2, Env, Handler, State, Opts) catch Class:Reason -> + StackTrace = erlang:get_stacktrace(), terminate({crash, Class, Reason}, Req, HandlerOpts, Handler), - erlang:raise(Class, Reason, erlang:get_stacktrace()) + erlang:raise(Class, Reason, StackTrace) end. -spec terminate(any(), Req | undefined, any(), module()) -> ok when Req::cowboy_req:req(). -- cgit v1.2.3