From 9090cd976553a8527d59e2638793011a3604e262 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= <essen@ninenines.eu>
Date: Mon, 17 Sep 2012 12:27:42 +0200
Subject: Replace many proplists:get_value/{2,3} calls by BIFs

Originally suggested by Roberto Ostinelli.
---
 src/cowboy_protocol.erl | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

(limited to 'src/cowboy_protocol.erl')

diff --git a/src/cowboy_protocol.erl b/src/cowboy_protocol.erl
index 8020b31..f4cbed5 100644
--- a/src/cowboy_protocol.erl
+++ b/src/cowboy_protocol.erl
@@ -80,18 +80,26 @@ start_link(ListenerPid, Socket, Transport, Opts) ->
 
 %% Internal.
 
+%% @doc Faster alternative to proplists:get_value/3.
+%% @private
+get_value(Key, Opts, Default) ->
+	case lists:keyfind(Key, 1, Opts) of
+		{_, Value} -> Value;
+		_ -> Default
+	end.
+
 %% @private
 -spec init(pid(), inet:socket(), module(), any()) -> ok.
 init(ListenerPid, Socket, Transport, Opts) ->
-	Dispatch = proplists:get_value(dispatch, Opts, []),
-	MaxEmptyLines = proplists:get_value(max_empty_lines, Opts, 5),
-	MaxKeepalive = proplists:get_value(max_keepalive, Opts, infinity),
-	MaxLineLength = proplists:get_value(max_line_length, Opts, 4096),
-	OnRequest = proplists:get_value(onrequest, Opts),
-	OnResponse = proplists:get_value(onresponse, Opts),
-	Timeout = proplists:get_value(timeout, Opts, 5000),
+	Dispatch = get_value(dispatch, Opts, []),
+	MaxEmptyLines = get_value(max_empty_lines, Opts, 5),
+	MaxKeepalive = get_value(max_keepalive, Opts, infinity),
+	MaxLineLength = get_value(max_line_length, Opts, 4096),
+	OnRequest = get_value(onrequest, Opts, undefined),
+	OnResponse = get_value(onresponse, Opts, undefined),
+	Timeout = get_value(timeout, Opts, 5000),
 	URLDecDefault = {fun cowboy_http:urldecode/2, crash},
-	URLDec = proplists:get_value(urldecode, Opts, URLDecDefault),
+	URLDec = get_value(urldecode, Opts, URLDecDefault),
 	ok = ranch:accept_ack(ListenerPid),
 	wait_request(#state{listener=ListenerPid, socket=Socket, transport=Transport,
 		dispatch=Dispatch, max_empty_lines=MaxEmptyLines,
-- 
cgit v1.2.3