From bfee20e61e9f6f4ad2e2d39d68c9c94910c67bac Mon Sep 17 00:00:00 2001 From: Steve Strong Date: Wed, 13 Mar 2019 11:36:04 +0000 Subject: Bind erlang:get_stacktrace prior to making other calls If we bind too late there might be an exception triggered in the terminate function and we will not get the correct stacktrace as a result. --- src/cowboy_websocket.erl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/cowboy_websocket.erl') diff --git a/src/cowboy_websocket.erl b/src/cowboy_websocket.erl index a94a5ce..9fc2752 100644 --- a/src/cowboy_websocket.erl +++ b/src/cowboy_websocket.erl @@ -503,9 +503,10 @@ handler_call(State=#state{handler=Handler}, HandlerState, {stop, HandlerState2} -> websocket_close(State, HandlerState2, stop) catch Class:Reason -> + StackTrace = erlang:get_stacktrace(), websocket_send_close(State, {crash, Class, Reason}), handler_terminate(State, HandlerState, {crash, Class, Reason}), - erlang:raise(Class, Reason, erlang:get_stacktrace()) + erlang:raise(Class, Reason, StackTrace) end. -spec handler_call_result(#state{}, any(), parse_state(), fun(), commands()) -> no_return(). -- cgit v1.2.3