From c4e43ec26ad5193b9665f159d294d133a2d34a85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= Date: Wed, 22 Nov 2017 15:39:39 +0100 Subject: Add more rfc7230 tests and better handle bad chunk sizes Bad chunk sizes used to be accepted and could result in a badly parsed body or a timeout. They are now properly rejected. Chunk extensions now have a hard limit of 129 characters. I haven't heard of anyone using them and Cowboy does not provide an interface for them, but we can always increase or make configurable if it ever becomes necessary (but I honestly doubt it). Also a test from the old http suite could be removed. Yay! --- test/http_SUITE.erl | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'test/http_SUITE.erl') diff --git a/test/http_SUITE.erl b/test/http_SUITE.erl index c2e7912..33e7183 100644 --- a/test/http_SUITE.erl +++ b/test/http_SUITE.erl @@ -307,19 +307,6 @@ http10_keepalive_forced(Config) -> _ -> ok end. -keepalive_max(Config) -> - ConnPid = gun_open(Config), - Refs = [gun:get(ConnPid, "/", [{<<"connection">>, <<"keep-alive">>}]) - || _ <- lists:seq(1, 99)], - CloseRef = gun:get(ConnPid, "/", [{<<"connection">>, <<"keep-alive">>}]), - _ = [begin - {response, nofin, 200, Headers} = gun:await(ConnPid, Ref), - false = lists:keymember(<<"connection">>, 1, Headers) - end || Ref <- Refs], - {response, nofin, 200, Headers} = gun:await(ConnPid, CloseRef), - {_, <<"close">>} = lists:keyfind(<<"connection">>, 1, Headers), - gun_down(ConnPid). - keepalive_nl(Config) -> ConnPid = gun_open(Config), Refs = [begin -- cgit v1.2.3