From 8cb9d242b0a665cada6de8b9a9dfa329e0c06ee9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= <essen@ninenines.eu>
Date: Tue, 31 Jan 2023 11:07:31 +0100
Subject: Initial HTTP/3 implementation

This includes Websocket over HTTP/3.

Since quicer, which provides the QUIC implementation,
is a NIF, Cowboy cannot depend directly on it. In order
to enable QUIC and HTTP/3, users have to set the
COWBOY_QUICER environment variable:

  export COWBOY_QUICER=1

In order to run the test suites, the same must be done
for Gun:

  export GUN_QUICER=1

HTTP/3 support is currently not available on Windows
due to compilation issues of quicer which have yet to
be looked at or resolved.

HTTP/3 support is also unavailable on the upcoming
OTP-27 due to compilation errors in quicer dependencies.
Once resolved HTTP/3 should work on OTP-27.

Because of how QUIC currently works, it's possible
that streams that get reset after sending a response
do not receive that response. The test suite was
modified to accomodate for that. A future extension
to QUIC will allow us to gracefully reset streams.

This also updates Erlang.mk.
---
 test/rest_handler_SUITE.erl | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

(limited to 'test/rest_handler_SUITE.erl')

diff --git a/test/rest_handler_SUITE.erl b/test/rest_handler_SUITE.erl
index e026552..6c1f1c1 100644
--- a/test/rest_handler_SUITE.erl
+++ b/test/rest_handler_SUITE.erl
@@ -32,7 +32,7 @@ init_per_group(Name, Config) ->
 	cowboy_test:init_common_groups(Name, Config, ?MODULE).
 
 end_per_group(Name, _) ->
-	cowboy:stop_listener(Name).
+	cowboy_test:stop_group(Name).
 
 %% Dispatch configuration.
 
@@ -85,7 +85,7 @@ accept_callback_missing(Config) ->
 		{<<"accept-encoding">>, <<"gzip">>},
 		{<<"content-type">>, <<"text/plain">>}
 	], <<"Missing!">>),
-	{response, fin, 500, _} = gun:await(ConnPid, Ref),
+	{response, fin, 500, _} = do_maybe_h3_error(gun:await(ConnPid, Ref)),
 	ok.
 
 accept_callback_patch_false(Config) ->
@@ -472,7 +472,7 @@ delete_resource_missing(Config) ->
 	Ref = gun:delete(ConnPid, "/delete_resource?missing", [
 		{<<"accept-encoding">>, <<"gzip">>}
 	]),
-	{response, _, 500, _} = gun:await(ConnPid, Ref),
+	{response, _, 500, _} = do_maybe_h3_error(gun:await(ConnPid, Ref)),
 	ok.
 
 create_resource_created(Config) ->
@@ -650,10 +650,16 @@ do_generate_etag(Config, Qs, ReqHeaders, Status, Etag) ->
 		{<<"accept-encoding">>, <<"gzip">>}
 		|ReqHeaders
 	]),
-	{response, _, Status, RespHeaders} = gun:await(ConnPid, Ref),
+	{response, _, Status, RespHeaders} = do_maybe_h3_error(gun:await(ConnPid, Ref)),
 	Etag = lists:keyfind(<<"etag">>, 1, RespHeaders),
 	ok.
 
+%% See do_maybe_h3_error2 comment.
+do_maybe_h3_error({error, {stream_error, {stream_error, h3_internal_error, _}}}) ->
+	{response, fin, 500, []};
+do_maybe_h3_error(Result) ->
+	Result.
+
 if_range_etag_equal(Config) ->
 	doc("When the if-range header matches, a 206 partial content "
 		"response is expected for an otherwise valid range request. (RFC7233 3.2)"),
@@ -806,7 +812,7 @@ provide_callback_missing(Config) ->
 	doc("A 500 response must be sent when the ProvideCallback can't be called."),
 	ConnPid = gun_open(Config),
 	Ref = gun:get(ConnPid, "/provide_callback_missing", [{<<"accept-encoding">>, <<"gzip">>}]),
-	{response, fin, 500, _} = gun:await(ConnPid, Ref),
+	{response, fin, 500, _} = do_maybe_h3_error(gun:await(ConnPid, Ref)),
 	ok.
 
 provide_range_callback(Config) ->
@@ -962,7 +968,7 @@ provide_range_callback_missing(Config) ->
 		{<<"accept-encoding">>, <<"gzip">>},
 		{<<"range">>, <<"bytes=0-">>}
 	]),
-	{response, fin, 500, _} = gun:await(ConnPid, Ref),
+	{response, fin, 500, _} = do_maybe_h3_error(gun:await(ConnPid, Ref)),
 	ok.
 
 range_ignore_unknown_unit(Config) ->
-- 
cgit v1.2.3