From 0a5fadc60bc586946ebd3b17839bcaf13b76f6d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= <essen@ninenines.eu>
Date: Mon, 13 Aug 2018 17:23:48 +0200
Subject: Improve errors for when the ProvideCallback is missing

---
 test/handlers/provide_callback_missing_h.erl | 11 +++++++++++
 test/rest_handler_SUITE.erl                  |  8 ++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 test/handlers/provide_callback_missing_h.erl

(limited to 'test')

diff --git a/test/handlers/provide_callback_missing_h.erl b/test/handlers/provide_callback_missing_h.erl
new file mode 100644
index 0000000..c9419ad
--- /dev/null
+++ b/test/handlers/provide_callback_missing_h.erl
@@ -0,0 +1,11 @@
+-module(provide_callback_missing_h).
+
+-export([init/2]).
+-export([content_types_provided/2]).
+
+init(Req, State) ->
+	{cowboy_rest, Req, State}.
+
+content_types_provided(Req, State) ->
+	ct_helper_error_h:ignore(cowboy_rest, set_resp_body, 2),
+	{[{<<"text/plain">>, provide}], Req, State}.
diff --git a/test/rest_handler_SUITE.erl b/test/rest_handler_SUITE.erl
index ec7c97d..1d9619c 100644
--- a/test/rest_handler_SUITE.erl
+++ b/test/rest_handler_SUITE.erl
@@ -38,6 +38,7 @@ end_per_group(Name, _) ->
 
 init_dispatch(_) ->
 	cowboy_router:compile([{'_', [
+		{"/provide_callback_missing", provide_callback_missing_h, []},
 		{"/switch_handler", switch_handler_h, run},
 		{"/switch_handler_opts", switch_handler_h, hibernate}
 	]}]).
@@ -52,6 +53,13 @@ do_decode(Headers, Body) ->
 
 %% Tests.
 
+provide_callback_missing(Config) ->
+	doc("A 500 response must be sent when the ProvideCallback can't be called."),
+	ConnPid = gun_open(Config),
+	Ref = gun:get(ConnPid, "/provide_callback_missing", [{<<"accept-encoding">>, <<"gzip">>}]),
+	{response, fin, 500, _} = gun:await(ConnPid, Ref),
+	ok.
+
 switch_handler(Config) ->
 	doc("Switch REST to loop handler for streaming the response body."),
 	ConnPid = gun_open(Config),
-- 
cgit v1.2.3