From 91ae70b06c9cc486ea2c2cf91b94de799ceb53b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= Date: Sun, 19 Feb 2017 09:46:11 +0100 Subject: Change the order of set_resp_cookie arguments The Opts value is put last, to be more consistent with the rest of the cowboy_req module. Additionally a test handler was fixed which reduced the number of errors in http_SUITE. --- test/handlers/resp_h.erl | 3 ++- test/http_SUITE_data/http_set_resp.erl | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'test') diff --git a/test/handlers/resp_h.erl b/test/handlers/resp_h.erl index 5e6696e..694f04a 100644 --- a/test/handlers/resp_h.erl +++ b/test/handlers/resp_h.erl @@ -20,7 +20,8 @@ do(<<"set_resp_cookie3">>, Req0, Opts) -> end, {ok, cowboy_req:reply(200, #{}, "OK", Req), Opts}; do(<<"set_resp_cookie4">>, Req0, Opts) -> - Req = cowboy_req:set_resp_cookie(<<"mycookie">>, "myvalue", #{path => cowboy_req:path(Req0)}, Req0), + Req = cowboy_req:set_resp_cookie(<<"mycookie">>, "myvalue", Req0, + #{path => cowboy_req:path(Req0)}), {ok, cowboy_req:reply(200, #{}, "OK", Req), Opts}; do(<<"set_resp_header">>, Req0, Opts) -> Req = cowboy_req:set_resp_header(<<"content-type">>, <<"text/plain">>, Req0), diff --git a/test/http_SUITE_data/http_set_resp.erl b/test/http_SUITE_data/http_set_resp.erl index 6ac4c8e..e575aab 100644 --- a/test/http_SUITE_data/http_set_resp.erl +++ b/test/http_SUITE_data/http_set_resp.erl @@ -12,7 +12,7 @@ init(Req, Opts) -> end, Req, maps:to_list(Headers)), Req3 = cowboy_req:set_resp_body(Body, Req2), Req4 = cowboy_req:set_resp_header(<<"x-cowboy-test">>, <<"ok">>, Req3), - Req5 = cowboy_req:set_resp_cookie(<<"cake">>, <<"lie">>, [], Req4), + Req5 = cowboy_req:set_resp_cookie(<<"cake">>, <<"lie">>, Req4), case cowboy_req:has_resp_header(<<"x-cowboy-test">>, Req5) of false -> {ok, Req5, Opts}; true -> -- cgit v1.2.3