From 05e085d5ab4161c6d1c630e36721e5ae1bb32b0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-S=C3=A9bastien=20P=C3=A9dron?= Date: Thu, 22 Oct 2015 15:16:08 +0200 Subject: Use `:` as a noop instead of `echo -n` The `-n` flag is not standard and not portable. It is supported by many Bourne shell to suppress the trailing newline character. But some old shells do not support this and "-n" is printed. This is the case for instance on some old versions of Mac OS X where `/bin/sh` is Bash 3.2. --- core/core.mk | 2 +- core/deps.mk | 4 ++-- core/erlc.mk | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/core.mk b/core/core.mk index 407b940..17cdf1e 100644 --- a/core/core.mk +++ b/core/core.mk @@ -82,7 +82,7 @@ all:: deps app rel # Noop to avoid a Make warning when there's nothing to do. rel:: - $(verbose) echo -n + $(verbose) : check:: clean app tests diff --git a/core/deps.mk b/core/deps.mk index 76f54d7..bf39be1 100644 --- a/core/deps.mk +++ b/core/deps.mk @@ -62,7 +62,7 @@ endif $(verbose) mkdir -p $(ERLANG_MK_TMP) $(verbose) for dep in $(ALL_DEPS_DIRS) ; do \ if grep -qs ^$$dep$$ $(ERLANG_MK_TMP)/deps.log; then \ - echo -n; \ + :; \ else \ echo $$dep >> $(ERLANG_MK_TMP)/deps.log; \ if [ -f $$dep/GNUmakefile ] || [ -f $$dep/makefile ] || [ -f $$dep/Makefile ]; then \ @@ -127,7 +127,7 @@ define dep_autopatch_erlang_mk endef else define dep_autopatch_erlang_mk - echo -n + : endef endif diff --git a/core/erlc.mk b/core/erlc.mk index 02524b4..39ad574 100644 --- a/core/erlc.mk +++ b/core/erlc.mk @@ -78,7 +78,7 @@ endef endif app-build: ebin/$(PROJECT).app - $(verbose) echo -n + $(verbose) : # Source files. -- cgit v1.2.3