From 648610ae3585c9cd9ffd827ad04cb2dd2858825b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= Date: Tue, 1 Oct 2019 21:53:48 +0200 Subject: Cowlib no longer returns lingering_data tuples --- src/gun_http2.erl | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/gun_http2.erl b/src/gun_http2.erl index 1cfbd4a..79d7841 100644 --- a/src/gun_http2.erl +++ b/src/gun_http2.erl @@ -196,15 +196,15 @@ frame(State=#http2_state{http2_machine=HTTP2Machine0}, Frame, EvHandler, EvHandl EvHandlerState0 end, case cow_http2_machine:frame(Frame, HTTP2Machine0) of + %% We only update the connection's window when receiving a lingering data frame. + {ok, HTTP2Machine} when element(1, Frame) =:= data -> + {update_window(State#http2_state{http2_machine=HTTP2Machine}), EvHandlerState}; {ok, HTTP2Machine} -> {maybe_ack(State#http2_state{http2_machine=HTTP2Machine}, Frame), EvHandlerState}; {ok, {data, StreamID, IsFin, Data}, HTTP2Machine} -> data_frame(State#http2_state{http2_machine=HTTP2Machine}, StreamID, IsFin, Data, EvHandler, EvHandlerState); - {ok, {lingering_data, _StreamID, DataLen}, HTTP2Machine} -> - {lingering_data_frame(State#http2_state{http2_machine=HTTP2Machine}, DataLen), - EvHandlerState}; {ok, {headers, StreamID, IsFin, Headers, PseudoHeaders, BodyLen}, HTTP2Machine} -> headers_frame(State#http2_state{http2_machine=HTTP2Machine}, StreamID, IsFin, Headers, PseudoHeaders, BodyLen, @@ -242,11 +242,6 @@ maybe_ack(State=#http2_state{socket=Socket, transport=Transport}, Frame) -> end, State. -lingering_data_frame(State, _DataLen) -> - %% We only update the connection's window when receiving - %% a lingering data frame. - update_window(State). - data_frame(State0, StreamID, IsFin, Data, EvHandler, EvHandlerState0) -> Stream = #stream{ref=StreamRef, reply_to=ReplyTo, flow=Flow0, handler_state=Handlers0} = get_stream_by_id(State0, StreamID), -- cgit v1.2.3