From 00cc1f385f94823a0684deee001b643091e235b0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= <essen@ninenines.eu>
Date: Thu, 26 Sep 2019 13:16:56 +0200
Subject: Add reply_to option to ws_upgrade; remove notowner entirely

The reply_to option is also propagated when we switch protocols.
---
 test/raw_SUITE.erl | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 test/ws_SUITE.erl  | 18 ++++++++++++++++
 2 files changed, 79 insertions(+)

(limited to 'test')

diff --git a/test/raw_SUITE.erl b/test/raw_SUITE.erl
index 6a843ea..18ab3b5 100644
--- a/test/raw_SUITE.erl
+++ b/test/raw_SUITE.erl
@@ -159,6 +159,33 @@ do_connect_raw(OriginTransport, ProxyTransport) ->
 	}]} = gun:info(ConnPid),
 	gun:close(ConnPid).
 
+connect_raw_reply_to(_) ->
+	doc("When using CONNECT to establish a connection with the reply_to option set, "
+		"Gun must honor this option in the raw protocol."),
+	Self = self(),
+	ReplyTo = spawn(fun() ->
+		{ConnPid, StreamRef} = receive Msg -> Msg after 1000 -> error(timeout) end,
+		{response, fin, 200, _} = gun:await(ConnPid, StreamRef),
+		Self ! {self(), ready},
+		{data, nofin, <<"Hello world!">>} = gun:await(ConnPid, undefined),
+		Self ! {self(), ok}
+	end),
+	{ok, OriginPid, OriginPort} = init_origin(tcp, raw, fun do_echo/3),
+	{ok, ProxyPid, ProxyPort} = rfc7231_SUITE:do_proxy_start(tcp),
+	{ok, ConnPid} = gun:open("localhost", ProxyPort),
+	{ok, http} = gun:await_up(ConnPid),
+	StreamRef = gun:connect(ConnPid, #{
+		host => "localhost",
+		port => OriginPort,
+		protocols => [raw]
+	}, [], #{reply_to => ReplyTo}),
+	ReplyTo ! {ConnPid, StreamRef},
+	{request, <<"CONNECT">>, _, 'HTTP/1.1', _} = receive_from(ProxyPid),
+	handshake_completed = receive_from(OriginPid),
+	receive {ReplyTo, ready} -> ok after 1000 -> error(timeout) end,
+	gun:data(ConnPid, undefined, nofin, <<"Hello world!">>),
+	receive {ReplyTo, ok} -> gun:close(ConnPid) after 1000 -> error(timeout) end.
+
 http11_upgrade_raw_tcp(_) ->
 	doc("Use the HTTP Upgrade mechanism to switch to the raw protocol over TCP."),
 	do_http11_upgrade_raw(tcp).
@@ -202,6 +229,40 @@ do_http11_upgrade_raw(OriginTransport) ->
 	} = gun:info(ConnPid),
 	gun:close(ConnPid).
 
+http11_upgrade_raw_reply_to(_) ->
+	doc("When upgrading an HTTP/1.1 connection with the reply_to option set, "
+		"Gun must honor this option in the raw protocol."),
+	Self = self(),
+	ReplyTo = spawn(fun() ->
+		{ConnPid, StreamRef} = receive Msg -> Msg after 1000 -> error(timeout) end,
+		{upgrade, [<<"custom/1.0">>], _} = gun:await(ConnPid, StreamRef),
+		Self ! {self(), ready},
+		{data, nofin, <<"Hello world!">>} = gun:await(ConnPid, undefined),
+		Self ! {self(), ok}
+	end),
+	{ok, OriginPid, OriginPort} = init_origin(tcp, raw,
+		fun (Parent, ClientSocket, ClientTransport) ->
+			%% We skip the request and send a 101 response unconditionally.
+			{ok, _} = ClientTransport:recv(ClientSocket, 0, 5000),
+			ClientTransport:send(ClientSocket,
+				"HTTP/1.1 101 Switching Protocols\r\n"
+				"Connection: upgrade\r\n"
+				"Upgrade: custom/1.0\r\n"
+				"\r\n"),
+			do_echo(Parent, ClientSocket, ClientTransport)
+		end),
+	{ok, ConnPid} = gun:open("localhost", OriginPort),
+	{ok, http} = gun:await_up(ConnPid),
+	handshake_completed = receive_from(OriginPid),
+	StreamRef = gun:get(ConnPid, "/", #{
+		<<"connection">> => <<"upgrade">>,
+		<<"upgrade">> => <<"custom/1.0">>
+	}, #{reply_to => ReplyTo}),
+	ReplyTo ! {ConnPid, StreamRef},
+	receive {ReplyTo, ready} -> ok after 1000 -> error(timeout) end,
+	gun:data(ConnPid, undefined, nofin, <<"Hello world!">>),
+	receive {ReplyTo, ok} -> gun:close(ConnPid) after 1000 -> error(timeout) end.
+
 %% The origin server will echo everything back.
 
 do_echo(Parent, ClientSocket, ClientTransport) ->
diff --git a/test/ws_SUITE.erl b/test/ws_SUITE.erl
index 55cdfba..d4413fb 100644
--- a/test/ws_SUITE.erl
+++ b/test/ws_SUITE.erl
@@ -122,6 +122,24 @@ reject_upgrade(Config) ->
 		error(timeout)
 	end.
 
+reply_to(Config) ->
+	doc("Ensure we can send a list of frames in one gun:ws_send call."),
+	Self = self(),
+	Frame = {text, <<"Hello!">>},
+	ReplyTo = spawn(fun() ->
+		{ConnPid, StreamRef} = receive Msg -> Msg after 1000 -> error(timeout) end,
+		{upgrade, [<<"websocket">>], _} = gun:await(ConnPid, StreamRef),
+		Self ! {self(), ready},
+		{ws, Frame} = gun:await(ConnPid, StreamRef),
+		Self ! {self(), ok}
+	end),
+	{ok, ConnPid} = gun:open("localhost", config(port, Config)),
+	{ok, _} = gun:await_up(ConnPid),
+	StreamRef = gun:ws_upgrade(ConnPid, "/", [], #{reply_to => ReplyTo}),
+	ReplyTo ! {ConnPid, StreamRef},
+	receive {ReplyTo, ready} -> gun:ws_send(ConnPid, Frame) after 1000 -> error(timeout) end,
+	receive {ReplyTo, ok} -> gun:close(ConnPid) after 1000 -> error(timeout) end.
+
 send_many(Config) ->
 	doc("Ensure we can send a list of frames in one gun:ws_send call."),
 	{ok, ConnPid} = gun:open("localhost", config(port, Config)),
-- 
cgit v1.2.3