<div dir="ltr">Perfect, thanks a lot!<div>Cheers,</div><div>Ł.</div></div><div class="gmail_extra"> <div class="gmail_quote">On Mon, Feb 3, 2014 at 8:15 PM, Loïc Hoguin <<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sure. It won't be called if not a GET or HEAD request so that's probably the best value you can return in your case.<div class="im"> On 02/03/2014 08:08 PM, Łukasz Biedrycki wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"> Ok, it is more clear for me. Last question I have is about content_types_provided function. Is it safe to define it like this? content_types_provided(R, S) -> </div> ContentTypes = [{{<<"application">>, <<"json">>, '*'}, *undefined*}],<div class="im"> {ContentTypes, Req, State}. Callback in content_types_provided is useless for POST requests, as it won’t be called. </div> Is it safe to use *undefined *atom, to have a source code clearer?<div class="im"> On Mon, Feb 3, 2014 at 7:37 PM, Loïc Hoguin <<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a> </div><div class="im"> <mailto:<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a>>> wrote: If Accept is sent and is different than text/html, yes. This is how HTTP is defined. If the client says it speaks only content-type X but you can only reply with content-type Y, you error out early and stop processing the request. On the other hand if the client doesn't say what content-type it speaks then the server can choose whichever one it wants. On 02/03/2014 07:26 PM, Łukasz Biedrycki wrote: My application sends both headers: “Content-type” and “Accept” header using POST method. For POST rest handler do I have to specify both: content_types_accepted and content_types_provided to manage this kind of request? On Mon, Feb 3, 2014 at 7:23 PM, Loïc Hoguin <<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a> <mailto:<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a>> </div><div><div class="h5"> <mailto:<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a> <mailto:<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a>>>> wrote: The content-type provided is relevant for any response, not just responses to GET requests. It defaults to text/html. If your client doesn't send that content-type, you have to define the callback. I notice that the documentation is incorrect about the relevant methods for this callback, I will open a ticket to fix it soon. On 02/03/2014 07:13 PM, Łukasz Biedrycki wrote: Hi, I have a rest handler that accepts POST and PUT requests with “application/json” content type. I have content_types_accepted function defined as follows: content_types_accepted(Req, State) -> {[{‘application/json', from_json}], Req, State}. The problem I have is within a request that has two headers: *Content-type*: application/json *Accept*: application/json With this combination I receive *406*. You can repeat it with test: http_SUITE.erl: 1072 rest_postonly(Config) -> 1073 Client = ?config(client, Config), 1074 Headers = [ 1075 {<<"content-type">>, <<"text/plain">>}, 1076 {<<"accept">>, <<"text/plain">>} 1077 ], 1078 {ok, Client2} = </div></div> cowboy_client:request(<<"POST"____>>,<div class="im"> 1079 build_url("/postonly", Config), Headers, "12345", Client), 1080 {ok, 204, _, _} = </div> cowboy_client:response(____Client2).<div class="im"> My solution to that was to add a content_types_provided function: content_types_provided(Req, State) -> ContentTypes = [{{<<"application">>, <<"json">>, '*'}, to_json}], {ContentTypes, Req, State}. But it is useless as *to_json* callback registered is not called anyhow. Adding *content_types_provided* function is a correct solution in this case? Or I am missing something here? “Accept” header is not relevant only in case of GET requests? Thank for help, Łukasz Biedrycki </div> ___________________________________________________<div class="im"> Extend mailing list <a href="mailto:Extend@lists.ninenines.eu" target="_blank">Extend@lists.ninenines.eu</a> <mailto:<a href="mailto:Extend@lists.ninenines.eu" target="_blank">Extend@lists.ninenines.eu</a>> </div> <mailto:<a href="mailto:Extend@lists." target="_blank">Extend@lists.</a>__<a href="http://ninenines.eu" target="_blank">ninenines.eu</a> <mailto:<a href="mailto:Extend@lists.ninenines.eu" target="_blank">Extend@lists.ninenines.eu</a>>> <a href="https://lists.ninenines.eu/____listinfo/extend" target="_blank">https://lists.ninenines.eu/____listinfo/extend</a> <<a href="https://lists.ninenines.eu/__listinfo/extend" target="_blank">https://lists.ninenines.eu/__listinfo/extend</a>><div class="im"> <<a href="https://lists.ninenines.eu/__listinfo/extend" target="_blank">https://lists.ninenines.eu/__listinfo/extend</a> <<a href="https://lists.ninenines.eu/listinfo/extend" target="_blank">https://lists.ninenines.eu/listinfo/extend</a>>> -- Loïc Hoguin <a href="http://ninenines.eu" target="_blank">http://ninenines.eu</a> -- Loïc Hoguin <a href="http://ninenines.eu" target="_blank">http://ninenines.eu</a> </div></blockquote><div class="HOEnZb"><div class="h5"> -- Loïc Hoguin <a href="http://ninenines.eu" target="_blank">http://ninenines.eu</a> </div></div></blockquote></div> </div>