otp.git/lib/diameter/src/base, branch HansN-patch-1

Merge branch 'anders/diameter/20.3/OTP-14946' into maint

2018-03-06T08:31:37+00:00

* anders/diameter/20.3/OTP-14946:
  vsn -> 2.1.4
  Update appup for 20.3
  Update service_info examples in doc
  Fix inaccurate comment

Merge branch 'anders/diameter/terminate/ERIERL-124' into maint

2018-03-05T10:33:53+00:00

* anders/diameter/terminate/ERIERL-124:
  Fix handling of SUSPECT connections at service termination

Fix inaccurate comment

2018-03-05T10:30:23+00:00

A peer_fsm process can be started long before a connection is
established in the listening case. The time reported in a 'peer' tuple
in service_info is of connection establishment.

Fix handling of SUSPECT connections at service termination

2018-02-01T10:36:43+00:00

A peer connection in watchdog state SUSPECT is represented by a peer
table entry in diameter_service, but not by a request table entry in
diameter_peer, so diameter_service:terminate/2 could result in failures
like this:

exception error: no match of right hand side value []
  in function diameter_traffic:peer_down/1 (base/diameter_traffic.erl, line 141)
  in call from lists:foldl/3 (lists.erl, line 1263)
  in call from ets:do_foldl/4 (ets.erl, line 611)
  in call from ets:foldl/3 (ets.erl, line 600)
  in call from diameter_service:terminate/2 (base/diameter_service.erl, line 557)
  in call from gen_server:try_terminate/3 (gen_server.erl, line 648)
  in call from gen_server:terminate/10 (gen_server.erl, line 833)
  in call from gen_server:handle_msg/6 (gen_server.erl, line 679)

Fix diameter_reg:subscribe/2 remove notification

2017-12-15T15:55:22+00:00

Commit fae8ca0c broke notification by removing table elements before
matching for them, causing diameter_tcp/sctp listening processes to
live on after diameter:remove_transport/2.

Commit 58091992 added diameter_reg:subscribe/2, and commit 5ca5fb71
started using it for listener exit.

Fix error handling when decoding an AVP with an alternate dictionary

2017-10-14T11:31:23+00:00

The options map wasn't updated after the AVP was identified, with
the resulting consequences for M-bit interpretation.

Remove unused function arguments

2017-10-13T15:09:56+00:00

Which may have been used in the past, but aren't now.

Fix faulty recursion

2017-10-13T15:09:02+00:00

The wrong variable was passed into the decode recursion, causing the
options map to be contaminated by strict_mbit and failed_avp
modifications that should only apply to component AVPs in the Grouped
case. Decode errors and M-bits could be ignored as a result.

Update appup and code_change for ERIERL-83

2017-10-05T12:41:56+00:00

Fix missing monitor in diameter_reg

2017-10-05T12:41:08+00:00

Commit fae8ca0c inadvertently removed the monitor at add/1 and
add_new/1. As a result, process death did not remove associations,
causing table diameter_reg to leak entries and stop/start of a service
to fail.

Add a testcase to detect the problem, which existing testcases miss.