* anders/diameter/timer_confusion/OTP-11168:
  Rename reconnect_timer -> connect_timer

The former was misleading since the timer only applies to initial
connection attempts, reconnection attempts being governed by
watchdog_timer. The name is a historic remnant from a (dark, pre-OTP)
time in which RFC 3539 was followed less slavishly than it is now, and
the timer actually did apply to reconnection attempts.

Note that connect_timer corresponds to RFC 6733 Tc, while watchdog_timer
corresponds to RFC 3539 TwInit. The latter RFC makes clear that TwInit
should apply to reconnection attempts. It's less clear if only RFC 6733
is read.

Note also that reconnect_timer is still accepted for backwards
compatibility. It would be possible to add an option to make
reconnect_timer behave strictly as the name suggests (ie. ignore RFC 3539
and interpret RFC 6733 at face value; something that has some value for
testing at least) but no such option is implemented in this commit.

* anders/diameter/capx_dictionary/OTP-11361:
  Don't hardcode diameter_base @prefix on common dictionary

* anders/diameter/5014_failure/OTP-11395:
  Fix handling of 5014, DIAMETER_INVALID_AVP_LENGTH

The error was detected as 5004 (DIAMETER_INVALID_AVP_VALUE) for
stringish Diameter types, in which case an AVP length that pointed past
the end of a message resulted in encode failure of the suggested
Failed-AVP.

Should have been fixed in commit 4ce2d3a6.

Commit e762d7d1 broke outgoing DWA by setting new Hop-by-Hop and
End-to-End identifiers instead of those of the incoming DWR.

* anders/diameter/spawn_opt/OTP-11299:
  Fix broken spawn_opt

* anders/diameter/failed_avp/OTP-11293:
  Fix Failed-AVP construction for CEA/DWA/DPA

Send of Failed-AVP resulted in encode failure.