Previously this test suite used a short-cut that didn't work well with the new crypto
API being experimented with in other branches.

This commit uses the legacy decode and decryption functions in ssh_transport. It is of
course normally a bad idea to test something with itself. However, other test suites
test the interoperability with OpenSSH and by that implicitly of the decoding/decryption.

The ssh_protocol_SUITE tests sending malformed and even malicious PDUs to the Erlang/OTP
SSH implementation. Therefore the tests in this suite is not dependent on being different
than thoose of the system under test.

The testing with a remote client in a docker and a local server could
show some hazards.  For instance instructing the client to sftp a
file to the server is not necessarily ready in the server's file system
when the common_test is scheduled.

To avoid that the test suite dooms a file operation to not have been
performed, simply sleep at increasing times for a while with testing
if it is done.  After a while give up and signal a fault.

* hans/ssh/port_leak/OTP-15397:
  ssh: Fix port leakage for daemons failing at start
  ssh: Add port close test

# Conflicts:
#	lib/ssh/test/ssh_basic_SUITE.erl

We need to test the Engine interface not only for loading, key retrieval and hashing,
so it is complemented with a fake rsa method to check sign/verify also.

* hans/ssh/eddsa/OTP-15094:
  ssh: Add Edward curves to the documentation
  ssh: Update test cases for eddsa
  ssh: Add public keys 'ssh-ed25519' and 'ssh-ed448'

Also rename the corresponding testcase in ssh_options_SUITE and add logging.