* dgud/observer/fix-atom-tostr/OTP-12634:
  observer: Fix crash in process_window

Links can be to named processes, convert atom to list

* anders/diameter/hardening/OTP-12628:
  Remove potentially large error reason in call to diameter_lib:log/4
  Limit FQDN in DiameterURI to 255 octets
  Limit DiameterURI ports to 0-65535 digits on decode
  Add service_opt() incoming_maxlen
  Add guard to reject {spawn_opt, false} as transport/service_opt()

The function is intended to be traced on, to see abnormalities (mostly)
without producing excessive output. In the case of decode failure, the
error reason can be things like {badmatch, HugeBinary}.

Missed in commit 0058430.

As for the port number in the parent commit, a FQDN can't be arbitrarily
long, at most 255 octets. Make decode fail if it's more.

A port number is a 16-bit integer, but the regexp used to parse it in
commit 1590920 slavishly followed the RFC 6733 grammar in matching an
arbitrary number of digits. Make decode fail if it's anything more than
5, to avoid doing erlang:list_to_integer/1 on arbitrarily large lists.
Also make it fail if the resulting integer is outside of the expected
range.

To bound the length of incoming messages that will be decoded. A message
longer than the specified number of bytes is discarded. An
incoming_maxlen_exceeded counter is incremented to make note of the
occurrence.

The motivation is to prevent a sufficiently malicious peer from
generating significant load by sending long messages with many AVPs for
diameter to decode. The 24-bit message length header accomodates

  (16#FFFFFF - 20) div 12 = 1398099

Unsigned32 AVPs for example, which the current record-valued decode is
too slow with in practice. A bound of 16#FFFF bytes allows for 5461
small AVPs, which is probably more than enough for the majority of
applications, but the default is the full 16#FFFFFF.

It was possible to configure the option, but doing so caused the service
to fail when starting a watchdog process:

   {function_clause,
       [{diameter_service,'-spawn_opts/1-lc$^0/1-0-',
            [false],
            [{file,"base/diameter_service.erl"},{line,846}]},
        {diameter_service,start,5,
            [{file,"base/diameter_service.erl"},{line,820}]},
        {diameter_service,start,3,
            [{file,"base/diameter_service.erl"},{line,782}]},
        {diameter_service,handle_call,3,
            [{file,"base/diameter_service.erl"},{line,385}]},
        {gen_server,try_handle_call,4,[{file,"gen_server.erl"},{line,607}]},
        {gen_server,handle_msg,5,[{file,"gen_server.erl"},{line,639}]},
        {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,237}]}]}

Tests for the option in the config suite were also missing.

Bungled in commit 78b3dc6.