diff options
author | Sverker Eriksson <[email protected]> | 2018-06-07 20:16:28 +0200 |
---|---|---|
committer | Sverker Eriksson <[email protected]> | 2018-06-07 20:16:28 +0200 |
commit | 8376b2cfcc4ab37ea398c2c564d2ba64d485896a (patch) | |
tree | 0d470b91b5e1a2be1be34ed57b5e565d6cec9e54 | |
parent | 0387fa9f4d88c2fa8578ead94c04deb9b04e506a (diff) | |
parent | 6ccf40d1b46a3e880134994bd71836f15a3358d4 (diff) | |
download | otp-8376b2cfcc4ab37ea398c2c564d2ba64d485896a.tar.gz otp-8376b2cfcc4ab37ea398c2c564d2ba64d485896a.tar.bz2 otp-8376b2cfcc4ab37ea398c2c564d2ba64d485896a.zip |
Merge branch 'sverker/ets-auto-unfix-delete-race/OTP-15109'
* sverker/ets-auto-unfix-delete-race/OTP-15109:
erts: Fix race between ets table deletion and auto-unfix
-rw-r--r-- | erts/emulator/beam/erl_db.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/erts/emulator/beam/erl_db.c b/erts/emulator/beam/erl_db.c index 5bae1730e4..82e31f4cab 100644 --- a/erts/emulator/beam/erl_db.c +++ b/erts/emulator/beam/erl_db.c @@ -1969,8 +1969,6 @@ BIF_RETTYPE ets_delete_1(BIF_ALIST_1) save_owned_table(BIF_P, tb); } - tid_clear(BIF_P, tb); - if (is_table_named(tb)) remove_named_tab(tb, 0); @@ -1979,6 +1977,7 @@ BIF_RETTYPE ets_delete_1(BIF_ALIST_1) tb->common.heir = am_none; reds -= free_fixations_locked(BIF_P, tb); + tid_clear(BIF_P, tb); db_unlock(tb, LCK_WRITE); reds = free_table_continue(BIF_P, tb, reds); @@ -3755,7 +3754,6 @@ erts_db_process_exiting(Process *c_p, ErtsProcLocks c_p_locks) && give_away_to_heir(c_p, tb)) { break; } - tid_clear(c_p, tb); /* Clear all access bits. */ tb->common.status &= ~(DB_PROTECTED | DB_PUBLIC | DB_PRIVATE); tb->common.status |= DB_DELETE; @@ -3765,6 +3763,7 @@ erts_db_process_exiting(Process *c_p, ErtsProcLocks c_p_locks) free_heir_data(tb); reds -= free_fixations_locked(c_p, tb); + tid_clear(c_p, tb); db_unlock(tb, LCK_WRITE); state->op = FREE_OWNED_TABLE; break; @@ -3912,7 +3911,7 @@ static void free_fixations_op(DbFixation* fix, void* vctx) struct free_fixations_ctx* ctx = (struct free_fixations_ctx*) vctx; erts_aint_t diff; - ASSERT(!btid2tab(fix->tabs.btid)); + ASSERT(btid2tab(fix->tabs.btid) == ctx->tb); ASSERT(fix->counter > 0); ASSERT(ctx->tb->common.status & DB_DELETE); |