Merge branch 'raimo/improve-doc-indexing/ERL-666' into maint

* raimo/improve-doc-indexing/ERL-666:
  Correct doc markers
  Improve indexing of cref docs

2 files changed, 88 insertions, 19 deletions

diff --git a/erts/doc/src/escript.xml b/erts/doc/src/escript.xml
index 9b0d42185e..be1664b39f 100644
--- a/erts/doc/src/escript.xml
+++ b/erts/doc/src/escript.xml
@@ -4,7 +4,7 @@
 <comref>
   <header>
     <copyright>
-      <year>2007</year><year>2017</year>
+      <year>2007</year><year>2018</year>
       <holder>Ericsson AB. All Rights Reserved.</holder>
     </copyright>
     <legalnotice>
@@ -155,9 +155,12 @@ io:setopts([{encoding, unicode}])</code>
           for example:</p>
         <pre>
 halt(1).</pre>
-        <p>To retrieve the pathname of the script, call
-          <seealso marker="#script_name_0">
-          <c>escript:script_name()</c></seealso> from your script
+        <p>
+	  To retrieve the pathname of the script, call
+	  <seealso marker="#script_name-0">
+	    <c>escript:script_name()</c>
+	  </seealso>
+	  from your script
 	  (the pathname is usually, but not always, absolute).</p>
         <p>If the file contains source code (as in the example above),
           it is processed by the
@@ -229,6 +232,7 @@ $ <input>escript factorial.beam 5</input>
 factorial 5 = 120
 $ <input>escript factorial.zip 5</input>
 factorial 5 = 120</pre>
+        <marker id="create-2"/>
       </desc>
     </func>
 
@@ -259,7 +263,7 @@ factorial 5 = 120</pre>
           zip:create_option()</seealso>]</v>
       </type>
       <desc>
-        <p><marker id="create_2"></marker>
+        <p>
           Creates an escript from a list of sections. The
           sections can be specified in any order. An escript begins with an
           optional <c>Header</c> followed by a mandatory <c>Body</c>. If
@@ -344,6 +348,7 @@ ok
                  {{2010,3,2},{0,59,22}},
                  54,1,0,0,0,0,0},
       &lt;&lt;"%% demo.erl\n-module(demo).\n-export([main/1]).\n\n%% Demo\nmain(_Arg"...&gt;&gt;}]}</pre>
+        <marker id="extract-2"/>
       </desc>
     </func>
 
@@ -368,9 +373,11 @@ ok
         <v>SourceCode = BeamCode = ZipArchive = binary()</v>
       </type>
       <desc>
-        <p><marker id="extract_2"></marker>
-          Parses an escript and extracts its sections. This is the reverse
-          of <seealso marker="#create_2"><c>create/2</c></seealso>.</p>
+        <p>
+	  Parses an escript and extracts its sections.
+	  This is the reverse of
+	  <seealso marker="#create-2"><c>create/2</c></seealso>.
+	</p>
         <p>All sections are returned even if they do not exist in the
           escript. If a particular section happens to have the same
           value as the default value, the extracted value is set to the
@@ -393,6 +400,7 @@ ok
 {ok,[{{archive,&lt;&lt;80,75,3,4,20,0,0,0,8,0,118,7,98,60,105,
                 152,61,93,107,0,0,0,118,0,...&gt;&gt;}
      {emu_args,undefined}]}</pre>
+        <marker id="script_name-0"/>
       </desc>
     </func>
 
@@ -403,7 +411,7 @@ ok
         <v>File = filename()</v>
       </type>
       <desc>
-        <p><marker id="script_name_0"></marker>
+        <p>
           Returns the name of the escript that is executed.
           If the function is invoked outside the context
           of an escript, the behavior is undefined.</p>
diff --git a/lib/erl_docgen/priv/xsl/db_eix.xsl b/lib/erl_docgen/priv/xsl/db_eix.xsl
index b496614854..6bce577f08 100644
--- a/lib/erl_docgen/priv/xsl/db_eix.xsl
+++ b/lib/erl_docgen/priv/xsl/db_eix.xsl
@@ -3,7 +3,7 @@
      #
      # %CopyrightBegin%
      # 
-     # Copyright Ericsson AB 2009-2016. All Rights Reserved.
+     # Copyright Ericsson AB 2009-2018. All Rights Reserved.
      # 
      # Licensed under the Apache License, Version 2.0 (the "License");
      # you may not use this file except in compliance with the License.
@@ -199,11 +199,34 @@
   <xsl:template name="name">
     <xsl:param name="lastfuncsblock"/>
 
+    <xsl:variable name="signature">
+      <xsl:variable name="signature1">
+	<xsl:choose>
+	  <xsl:when test="ancestor::cref">
+	    <xsl:value-of
+		select="normalize-space(nametext)"/>
+	  </xsl:when>
+	  <xsl:otherwise>
+	    <xsl:value-of
+		select="normalize-space(substring-before(., '->'))"/>
+	  </xsl:otherwise>
+	</xsl:choose>
+      </xsl:variable>
+      <xsl:choose>
+	<xsl:when test="string-length($signature1) > 0">
+	  <xsl:value-of select="$signature1"/>
+	</xsl:when>
+	<xsl:otherwise>
+	  <xsl:value-of select="normalize-space(.)"/>
+	</xsl:otherwise>
+      </xsl:choose>
+    </xsl:variable>
+
     <xsl:variable name="tmpstring">
-      <xsl:value-of select="substring-before(substring-after(., '('), '->')"/>
+      <xsl:value-of select="substring-after($signature, '(')"/>
     </xsl:variable>
 
-    <xsl:variable name="ustring">
+    <xsl:variable name="argstring">
       <xsl:choose>
 	<xsl:when test="string-length($tmpstring) > 0">
 	  <xsl:call-template name="remove-paren">
@@ -219,10 +242,19 @@
     </xsl:variable>
 
     <xsl:variable name="arity">
-      <xsl:call-template name="calc-arity">
-	<xsl:with-param name="string" select="substring-before($ustring, ')')"/>
-	<xsl:with-param name="no-of-pars" select="0"/>
-      </xsl:call-template>
+      <xsl:choose>
+	<xsl:when
+	    test="string-length(substring-before(., '->')) > 0">
+	  <xsl:call-template name="calc-arity">
+	    <xsl:with-param
+		name="string"
+		select="substring-before($argstring, ')')"/>
+	    <xsl:with-param name="no-of-pars" select="0"/>
+	  </xsl:call-template>
+	</xsl:when>
+	<xsl:otherwise/>
+      </xsl:choose>
+
     </xsl:variable>
 
     <xsl:variable name="fname">
@@ -250,10 +282,18 @@
     </xsl:variable>
     
     <xsl:text>  {"</xsl:text><xsl:value-of select="$fname"/>
+    <xsl:text>", "</xsl:text>
+    <xsl:call-template name="escape-doublequotes">
+      <xsl:with-param name="string" select="$signature"/>
+    </xsl:call-template>
     <xsl:text>", "</xsl:text><xsl:value-of select="$fname"/>
-    <xsl:text>(</xsl:text><xsl:value-of select="normalize-space($tmpstring)"/>
-    <xsl:text>", "</xsl:text><xsl:value-of select="$fname"/>
-    <xsl:text>-</xsl:text><xsl:value-of select="$arity"/><xsl:text>"}</xsl:text>
+    <xsl:choose>
+      <xsl:when test="string-length($arity) > 0">
+	<xsl:text>-</xsl:text><xsl:value-of select="$arity"/>
+      </xsl:when>
+      <xsl:otherwise/>
+    </xsl:choose>
+    <xsl:text>"}</xsl:text>
     
     <xsl:choose>
       <xsl:when test="($lastfuncsblock = 'true') and (position() = last())">
@@ -345,6 +385,27 @@
 
   </xsl:template>
 
+  <xsl:template name="escape-doublequotes">
+    <xsl:param name="string"/>
+    <xsl:param name="pPat">"</xsl:param>
+    <xsl:param name="pRep">\"</xsl:param>
+
+    <xsl:choose>
+      <xsl:when test="not(contains($string, $pPat))">
+	<xsl:copy-of select="$string"/>
+      </xsl:when>
+      <xsl:otherwise>
+	<xsl:copy-of select="substring-before($string, $pPat)"/>
+	<xsl:copy-of select="$pRep"/>
+	<xsl:call-template name="escape-doublequotes">
+	  <xsl:with-param
+	      name="string"
+	      select="substring-after($string, $pPat)"/>
+	</xsl:call-template>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:template>
+
   <!-- default content handling -->
   <xsl:template match="text()"/>