Merge branch 'peppe/common_test/index_last_test/OTP-14281' into maint

* peppe/common_test/index_last_test/OTP-14281:
  Show links to latest test run by using an html redirection file

OTP-14281

2 files changed, 43 insertions, 8 deletions

diff --git a/lib/common_test/src/ct_logs.erl b/lib/common_test/src/ct_logs.erl
index ba7660fe6a..81b5bad2bc 100644
--- a/lib/common_test/src/ct_logs.erl
+++ b/lib/common_test/src/ct_logs.erl
@@ -3144,8 +3144,8 @@ locate_priv_file(FileName) ->
 			filename:join(get(ct_run_dir), FileName);
 		    _ ->			
 			%% executed on other process than ct_logs
-			{ok,RunDir} = get_log_dir(true),
-			filename:join(RunDir, FileName)
+			{ok,LogDir} = get_log_dir(true),
+			filename:join(LogDir, FileName)
 		end,
 	    case filelib:is_file(PrivResultFile) of
 		true ->
@@ -3227,6 +3227,10 @@ get_ts_html_wrapper(TestName, Logdir, PrintLabel, Cwd, TableCols, Encoding) ->
 					  ?all_runs_name), Cwd),
     TestIndex = make_relative(filename:join(filename:dirname(CtLogdir),
 					    ?index_name), Cwd),
+    LatestTest = make_relative(filename:join(filename:dirname(CtLogdir),
+                                           ?suitelog_name++".latest.html"),
+                             Cwd),
+
     case Basic of
 	true ->
 	    TileFile = filename:join(filename:join(CTPath,"priv"),"tile1.jpg"),
@@ -3253,7 +3257,9 @@ get_ts_html_wrapper(TestName, Logdir, PrintLabel, Cwd, TableCols, Encoding) ->
 	      "<a href=\"", uri(AllRuns),
 	      "\">Test run history\n</a>  |  ",
 	      "<a href=\"", uri(TestIndex),
-	      "\">Top level test index\n</a>\n</p>\n",
+	      "\">Top level test index\n</a>  |  ",
+	      "<a href=\"", uri(LatestTest),
+              "\">Latest test result</a>\n</p>\n",
 	      Copyright,"</center>\n</body>\n</html>\n"]};
 	_ ->
 	    Copyright = 
@@ -3300,7 +3306,9 @@ get_ts_html_wrapper(TestName, Logdir, PrintLabel, Cwd, TableCols, Encoding) ->
 	      "<a href=\"", uri(AllRuns),
 	      "\">Test run history\n</a>  |  ",
 	      "<a href=\"", uri(TestIndex),
-	      "\">Top level test index\n</a>\n</p>\n",
+	      "\">Top level test index\n</a>  |  ",
+	      "<a href=\"", uri(LatestTest),
+              "\">Latest test result</a>\n</p>\n",
 	      Copyright,"</center>\n</body>\n</html>\n"]}
     end.
 
diff --git a/lib/common_test/src/test_server_ctrl.erl b/lib/common_test/src/test_server_ctrl.erl
index 71978c7267..f54518fc80 100644
--- a/lib/common_test/src/test_server_ctrl.erl
+++ b/lib/common_test/src/test_server_ctrl.erl
@@ -89,6 +89,7 @@
 -define(logdir_ext, ".logs").
 -define(data_dir_suffix, "_data/").
 -define(suitelog_name, "suite.log").
+-define(suitelog_latest_name, "suite.log.latest").
 -define(coverlog_name, "cover.html").
 -define(raw_coverlog_name, "cover.log").
 -define(cross_coverlog_name, "cross_cover.html").
@@ -1150,6 +1151,12 @@ init_tester(Mod, Func, Args, Dir, Name, {_,_,MinLev}=Levels,
     end,
 
     %% before first print, read and set logging options
+    FWLogDir =
+        case test_server_sup:framework_call(get_log_dir, [], []) of
+            {ok,FwDir} -> FwDir;
+            _          -> filename:dirname(Dir)
+        end,
+    put(test_server_framework_logdir, FWLogDir),
     LogOpts = test_server_sup:framework_call(get_logopts, [], []),
     put(test_server_logopts, LogOpts),
 
@@ -1711,6 +1718,12 @@ start_log_file() ->
     test_server_io:set_fd(html, Html),
     test_server_io:set_fd(unexpected_io, Unexpected),
 
+    %% we must assume the redirection file (to the latest suite index) can
+    %% be stored on the level above the log directory of the current test
+    TopDir = filename:dirname(get(test_server_framework_logdir)),
+    RedirectLink = filename:join(TopDir, ?suitelog_latest_name ++ ?html_ext),
+    make_html_link(RedirectLink, HtmlName, redirect),
+
     make_html_link(filename:absname(?last_test ++ ?html_ext),
 		   HtmlName, filename:basename(Dir)),
     LinkName = filename:join(Dir, ?last_link),
@@ -1739,11 +1752,18 @@ make_html_link(LinkName, Target, Explanation) ->
 	       false ->
 		   "file:" ++ uri_encode(Target)
 	   end,
-    H = [html_header(Explanation),
-	 "<h1>Last test</h1>\n"
-	 "<a href=\"",Href,"\">",Explanation,"</a>\n"
-	 "</body>\n</html>\n"],
+    H = if Explanation == redirect ->
+                Meta = ["<meta http-equiv=\"refresh\" "
+                        "content=\"0; url=", Href, "\" />\n"],
+                [html_header("redirect", Meta), "</html>\n"];
+           true ->
+                [html_header(Explanation),
+                 "<h1>Last test</h1>\n"
+                 "<a href=\"",Href,"\">",Explanation,"</a>\n"
+                 "</body>\n</html>\n"]
+        end,
     ok = write_html_file(LinkName, H).
+    
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %% start_minor_log_file(Mod, Func, ParallelTC) -> AbsName
@@ -5655,6 +5675,13 @@ html_header(Title) ->
      "<body bgcolor=\"white\" text=\"black\" "
      "link=\"blue\" vlink=\"purple\" alink=\"red\">\n"].
 
+html_header(Title, Meta) ->
+    ["<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 3.2 Final//EN\">\n"
+     "<!-- autogenerated by '", atom_to_list(?MODULE), "'. -->\n"
+     "<html>\n"
+     "<head>\n"
+     "<title>", Title, "</title>\n"] ++ Meta ++ ["</head>\n"].
+
 open_html_file(File) ->
     open_utf8_file(File).