Merge remote-tracking branch 'origin/peppe/common_test/ct_netconfc_action_ok' into maint

* origin/peppe/common_test/ct_netconfc_action_ok:
  Handle {ok,Data} in RPC reply (decode_rpc_reply)

OTP-12491

1 files changed, 9 insertions, 2 deletions

diff --git a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
index 2bcfeeec0c..6f5db21f57 100644
--- a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
+++ b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
@@ -488,8 +488,15 @@ action(Config) ->
     DataDir = ?config(data_dir,Config),
     {ok,Client} = open_success(DataDir),
     Data = [{myactionreturn,[{xmlns,"myns"}],["value"]}],
-    ?NS:expect_reply(action,{data,Data}),
-    {ok,Data} = ct_netconfc:action(Client,{myaction,[{xmlns,"myns"}],[]}),
+    %% test either to receive {data,Data} or {ok,Data},
+    %% both need to be handled
+    {Reply,RetVal} = case element(3, now()) rem 2 of
+			 0 -> {{data,Data},{ok,Data}};
+			 1 -> {{ok,Data},ok}
+		     end,
+    ct:log("Client will receive {~w,Data}", [element(1,Reply)]),
+    ?NS:expect_reply(action,Reply),
+    RetVal = ct_netconfc:action(Client,{myaction,[{xmlns,"myns"}],[]}),
     ?NS:expect_do_reply('close-session',close,ok),
     ?ok = ct_netconfc:close_session(Client),
     ok.