Update guards to the modern interface

1 files changed, 36 insertions, 36 deletions

diff --git a/lib/inviso/src/inviso_tool.erl b/lib/inviso/src/inviso_tool.erl
index 7126ba4387..05158f58fe 100644
--- a/lib/inviso/src/inviso_tool.erl
+++ b/lib/inviso/src/inviso_tool.erl
@@ -267,9 +267,9 @@ stop(UntouchedNodes) ->
 %% tracing.

 reconnect_nodes() ->

     gen_server:call(?MODULE,{reconnect_nodes,local_runtime},?CALL_TIMEOUT).

-reconnect_nodes(Node) when atom(Node) ->

+reconnect_nodes(Node) when is_atom(Node) ->
     reconnect_nodes([Node]);

-reconnect_nodes(Nodes) when list(Nodes) ->

+reconnect_nodes(Nodes) when is_list(Nodes) ->
     gen_server:call(?MODULE,{reconnect_nodes,Nodes},?CALL_TIMEOUT).

 %% -----------------------------------------------------------------------------

 

@@ -572,7 +572,7 @@ reactivator_reply(TPid,Counter) ->
 

 init(Config) ->

     case fetch_configuration(Config) of     % From conf-file and Config.

-	{ok,LD} when record(LD,ld) ->

+	{ok,LD} when is_record(LD,ld) ->
 	    case start_inviso_at_c_node(LD) of

 		{ok,CPid} ->

 		    LD2=start_runtime_components(LD),

@@ -650,7 +650,7 @@ start_runtime_components_2([],_,LD) ->
 

 start_runtime_components_mk_opts(Node,{M,F,Args}) ->

     case catch apply(M,F,[Node|Args]) of

-	{ok,Opts} when list(Opts) ->

+	{ok,Opts} when is_list(Opts) ->
 	    start_runtime_component_mk_opts_add_dependency(Opts);

 	_ ->

 	    [?DEFAULT_DEPENDENCY]

@@ -698,7 +698,7 @@ handle_call({reconnect_nodes,Nodes},_From,LD) ->
 		    {reply,

 		     build_reconnect_nodes_reply(Nodes,Nodes2,NodesErr,NewLD#ld.nodes),

 		     NewLD};

-		list(Nodes) ->

+		is_list(Nodes) ->
 		    {reply,

 		     {ok,build_reconnect_nodes_reply(Nodes,Nodes2,NodesErr,NewLD#ld.nodes)},

 		     NewLD}

@@ -711,7 +711,7 @@ handle_call({start_session,MoreTDGargs},_From,LD=#ld{session_state=SState}) ->
     case is_tracing(SState) of

 	false ->                               % No session running.

 	    if

-		list(MoreTDGargs) ->

+		is_list(MoreTDGargs) ->
 		    DateTime=calendar:universal_time(),

 		    {M,F,Args}=LD#ld.tdg,

 		    TDGargs=inviso_tool_lib:mk_tdg_args(DateTime,MoreTDGargs++Args),

@@ -757,15 +757,15 @@ handle_call({reinitiate_session,Nodes},_From,LD=#ld{session_state=SState}) ->
     end;

 

 handle_call({restore_session,{FileName,MoreTDGargs}},_From,LD=#ld{chl=OldCHL})

-  when list(MoreTDGargs) ->

+  when is_list(MoreTDGargs) ->
     case is_tracing(LD#ld.session_state) of

 	false ->

 	    case catch make_absolute_path(FileName,LD#ld.dir) of

-		AbsFileName when list(AbsFileName) ->

+		AbsFileName when is_list(AbsFileName) ->
 		    case file:read_file(AbsFileName) of

 			{ok,Bin} ->

 			    if

-				list(MoreTDGargs) ->

+				is_list(MoreTDGargs) ->
 				    case catch replace_history_chl(OldCHL,

 								   binary_to_term(Bin)) of

 					{ok,CHL} -> % The file was well formatted.

@@ -803,7 +803,7 @@ handle_call({restore_session,MoreTDGargs},_From,LD=#ld{chl=CHL}) ->
 	    case history_exists_chl(CHL) of

 		true ->                        % There is a history to redo.

 		    if

-			list(MoreTDGargs) ->

+			is_list(MoreTDGargs) ->
 			    case h_restore_session(MoreTDGargs,LD) of

 				{ok,{SessionNr,ReturnVal,NewLD}} ->

 				    {reply,

@@ -879,7 +879,7 @@ handle_call({sync_atc,{TC,Id,Vars,TimeOut}},_From,LD=#ld{session_state=SState})
     case is_tracing(SState) of

 	true ->

 	    if

-		integer(TimeOut);TimeOut==infinity ->

+		is_integer(TimeOut);TimeOut==infinity ->
 		    case h_sync_atc(TC,Id,Vars,TimeOut,LD) of

 			{ok,NewLD,Result} ->

 			    {reply,Result,NewLD};

@@ -897,7 +897,7 @@ handle_call({sync_rtc,{TC,Vars,TimeOut}},_From,LD=#ld{session_state=SState}) ->
     case is_tracing(SState) of

 	true ->

 	    if

-		integer(TimeOut);TimeOut==infinity ->

+		is_integer(TimeOut);TimeOut==infinity ->
 		    case h_sync_rtc(TC,Vars,TimeOut,LD) of

 			{ok,NewLD,Result} ->

 			    {reply,Result,NewLD};

@@ -929,7 +929,7 @@ handle_call({sync_dtc,{TC,Id,TimeOut}},_From,LD=#ld{session_state=SState}) ->
     case is_tracing(SState) of              % Check that we are tracing now.

 	true ->

 	    if

-		integer(TimeOut);TimeOut==infinity ->

+		is_integer(TimeOut);TimeOut==infinity ->
 		    case h_sync_dtc(TC,Id,TimeOut,LD) of

 			{ok,NewLD,Result} ->

 			    {reply,Result,NewLD};

@@ -947,7 +947,7 @@ handle_call({inviso,{Cmd,Args}},_From,LD=#ld{session_state=SState}) ->
     case is_tracing(SState) of

 	true ->

 	    if

-		list(Args) ->

+		is_list(Args) ->
 		    case h_inviso(Cmd,Args,LD) of

 			{ok,{Reply,NewLD}} ->

 			    {reply,Reply,NewLD};

@@ -1156,7 +1156,7 @@ h_reconnect_nodes(local_runtime,LD=#ld{nodes=NodesD}) -> % Non-distributed.
 	_ ->                                   % Allready connected!

 	    {ok,{[],{error,already_connected},LD}}

     end;

-h_reconnect_nodes(Nodes,LD=#ld{nodes=NodesD}) when list(Nodes) ->

+h_reconnect_nodes(Nodes,LD=#ld{nodes=NodesD}) when is_list(Nodes) ->
     {Nodes2,NodesErr}=

 	lists:foldl(fun(N,{Nodes2,NodesErr})->

 			    case get_state_nodes(N,NodesD) of

@@ -1246,7 +1246,7 @@ h_start_session_ctp_all_2([],Errors,Nodes) ->
 %% Help function doing the actual init_tracing.

 h_start_session_2(undefined,TracerData,_Errors) -> % Non distributed case.

     case inviso:init_tracing(TracerData) of

-	{ok,LogResult} when list(LogResult) ->

+	{ok,LogResult} when is_list(LogResult) ->
 	    {ok,{ok,LogResult}};

 	{error,already_initated} ->         % Perhaps adopted!?

 	    {ok,{error,already_initiated}}; % Not necessarily wrong.

@@ -1360,7 +1360,7 @@ h_reinitiate_session_2(local_runtime,NodesD,undefined) -> % Non distributed case
 	_ ->

 	    {ok,{[],{error,already_in_session}}}

     end;

-h_reinitiate_session_2(Nodes,NodesD,CNode) when list(Nodes) ->

+h_reinitiate_session_2(Nodes,NodesD,CNode) when is_list(Nodes) ->
     {ok,lists:foldl(fun(N,{Nodes2,NodesErr})->

 			    case get_state_nodes(N,NodesD) of

 				{inactive,running} -> % Only ok case.

@@ -1515,7 +1515,7 @@ h_atc(TC,Id,Vars,LD=#ld{c_node=CNode,tc_dict=TCdict,chl=CHL},Nodes) ->
 		    case check_bindings(Vars,TraceCase) of

 			{ok,Bindings} ->    % Necessary vars exists in Vars.

 			    if

-				list(Nodes) -> % Nodes predefined.

+				is_list(Nodes) -> % Nodes predefined.
 				    h_atc_2(TC,Id,CNode,CHL,LD,TraceCase,Bindings,Nodes);

 				true ->     % Use all tracing and running nodes.

 				    Nodes1=get_nodenames_running_nodes(LD#ld.nodes),

@@ -1769,13 +1769,13 @@ h_reactivate(Node,CNode) ->
 h_save_history(HDir,Dir,FileName,SortedLog) ->

     Dir0=

 	if

-	    list(HDir) ->                   % There is a history dir specified.

+	    is_list(HDir) ->                   % There is a history dir specified.
 		HDir;                       % Use it then.

 	    true ->

 		Dir                         % Else use the tool dir.

 	end,

     case catch make_absolute_path(FileName,Dir0) of

-	AbsFileName when list(AbsFileName) ->

+	AbsFileName when is_list(AbsFileName) ->
 	    Log2=build_saved_history_data(SortedLog), % Remove stopped tracecases.

 	    case file:write_file(AbsFileName,term_to_binary(Log2)) of

 		ok ->

@@ -1801,7 +1801,7 @@ h_get_autostart_data(local_runtime,_,Dependency,ASD,M,F,TDGargs,OptsG) ->
     Opts=[Dependency|lists:keydelete(dependency,1,Opts0)],

     {ok,{ASD,{ok,{Opts,{tdg,{M,F,CompleteTDGargs}}}}}};

 

-h_get_autostart_data(Nodes,CNode,Dependency,ASD,M,F,TDGargs,OptsG) when list(Nodes) ->

+h_get_autostart_data(Nodes,CNode,Dependency,ASD,M,F,TDGargs,OptsG) when is_list(Nodes) ->
     {ok,{ASD,h_get_autostart_data_2(Nodes,CNode,Dependency,M,F,TDGargs,OptsG)}};

 h_get_autostart_data(Nodes,_CNode,_Dependency,_ASD,_M,_F,_TDGargs,_OptsG) ->

     {error,{badarg,Nodes}}.

@@ -2144,14 +2144,14 @@ expand_module_regexps(Args,_RegExpNode,_Nodes,false) ->
     {ok,Args};

 expand_module_regexps([PatternList],RegExpNode,Nodes,{tp,1,1}) ->

     case catch expand_module_regexps_tp(PatternList,RegExpNode,Nodes) of

-	NewPatternList when list(NewPatternList) ->

+	NewPatternList when is_list(NewPatternList) ->
 	    {ok,[NewPatternList]};

 	{error,Reason} ->

 	    {error,Reason}

     end;

 expand_module_regexps([PatternList],RegExpNode,Nodes,{ctp,1,1}) ->

     case catch expand_module_regexps_ctp(PatternList,RegExpNode,Nodes) of

-	NewPatternList when list(NewPatternList) ->

+	NewPatternList when is_list(NewPatternList) ->
 	    {ok,[NewPatternList]};

 	{error,Reason} ->

 	    {error,Reason}

@@ -2164,9 +2164,9 @@ expand_module_regexps([M,F,Arity],RegExpNode,Nodes,{ctp,3,1}) ->
     expand_module_regexps([[{M,F,Arity}]],RegExpNode,Nodes,{ctp,1,1}).

 

 

-expand_module_regexps_tp([E={M,_,_,_,_}|Rest],RegExpNode,Nodes) when atom(M) ->

+expand_module_regexps_tp([E={M,_,_,_,_}|Rest],RegExpNode,Nodes) when is_atom(M) ->
     [E|expand_module_regexps_tp(Rest,RegExpNode,Nodes)];

-expand_module_regexps_tp([{M,F,Arity,MS,Opts}|Rest],RegExpNode,Nodes) when list(M);tuple(M) ->

+expand_module_regexps_tp([{M,F,Arity,MS,Opts}|Rest],RegExpNode,Nodes) when is_list(M);is_tuple(M) ->
     case inviso_tool_lib:expand_module_names([RegExpNode],

 					     M,

 					     [{expand_only_at,RegExpNode}]) of

@@ -2193,9 +2193,9 @@ expand_module_regexps_tp_2([M|MRest],F,Arity,MS,Opts,Rest,RegExpNode,Nodes) ->
 expand_module_regexps_tp_2([],_,_,_,_,Rest,RegExpNode,Nodes) ->

     expand_module_regexps_tp(Rest,RegExpNode,Nodes).

 

-expand_module_regexps_ctp([E={M,_,_}|Rest],RegExpNode,Nodes) when atom(M) ->

+expand_module_regexps_ctp([E={M,_,_}|Rest],RegExpNode,Nodes) when is_atom(M) ->
     [E|expand_module_regexps_ctp(Rest,RegExpNode,Nodes)];

-expand_module_regexps_ctp([{M,F,Arity}|Rest],RegExpNode,Nodes) when list(M);tuple(M) ->

+expand_module_regexps_ctp([{M,F,Arity}|Rest],RegExpNode,Nodes) when is_list(M);is_tuple(M) ->
     case inviso_tool_lib:expand_module_names([RegExpNode],

 					     M,

 					     [{expand_only_at,RegExpNode}]) of

@@ -2450,7 +2450,7 @@ fetch_configuration(Config) ->
 %% Returns {ok,FileName} or 'false'. The latter if no name could be determined.

 fetch_config_filename(Config) ->

     case catch lists:keysearch(config_file,1,Config) of

-	{value,{_,FName}} when list(FName) ->

+	{value,{_,FName}} when is_list(FName) ->
 	    {ok,FName};

 	_ ->                                % No filename in the start argument.

 	    fetch_config_filename_2()

@@ -2458,7 +2458,7 @@ fetch_config_filename(Config) ->
 

 fetch_config_filename_2() ->

     case application:get_env(inviso_tool_config_file) of

-	{ok,FName} when list(FName) ->

+	{ok,FName} when is_list(FName) ->
 	    {ok,FName};

 	_ ->                                % Application parameter not specified.

 	    false                           % Means no config file will be used.

@@ -2499,14 +2499,14 @@ read_config_list_2(LD,Terms,Tag) ->
 %% Function updating a named field in a record. Returns a new record. Note that

 %% this function must be maintained due the fact that field names are removed

 %% at compile time.

-update_ld_record(LD,nodes,Value) when record(LD,ld) ->

+update_ld_record(LD,nodes,Value) when is_record(LD,ld) ->
     case mk_nodes(Value) of

 	{ok,NodesD} ->

 	    LD#ld{nodes=NodesD};

 	error ->

 	    LD

     end;

-update_ld_record(LD,Tag,Value) when record(LD,ld) ->

+update_ld_record(LD,Tag,Value) when is_record(LD,ld) ->
     Index=

 	case Tag of

 	    c_node ->                       % atom()

@@ -2546,7 +2546,7 @@ update_ld_record(LD,Tag,Value) when record(LD,ld) ->
 %%   ActivationFileName=DeactivationFileName=string()

 read_trace_case_definitions(LD) ->

     case LD#ld.tc_def_file of

-	TCfileName when list(TCfileName) ->

+	TCfileName when is_list(TCfileName) ->
 	    case catch file:consult(TCfileName) of

 		{ok,Terms} ->

 		    Dir=LD#ld.dir,          % The working directory of the tool.

@@ -2636,8 +2636,8 @@ get_status(CNode,Nodes) ->
 %%     We can end up here if a session is stopped with this node suspended.

 

 %% Returns a nodes database structure filled with the nodes Nodes.

-mk_nodes(Nodes) when list(Nodes) ->

-    {ok,lists:map(fun(N) when atom(N)->{N,down} end,Nodes)};

+mk_nodes(Nodes) when is_list(Nodes) ->
+    {ok,lists:map(fun(N) when is_atom(N)->{N,down} end,Nodes)};
 mk_nodes(local_runtime) ->                  % The non-distributed case.

     down;

 mk_nodes(_Nodes) ->

@@ -2783,7 +2783,7 @@ set_suspended_nodes(_,{up,{State,_}}) ->
 %% This function is called when reactivation is completed. Hence it moves the

 %% node to no longer suspended. Note this can mean that the node is either

 %% tracing or inactive. Reactivation is not allowed for a node have trace_failure.

-set_running_nodes(Node,NodesD) when list(NodesD) ->

+set_running_nodes(Node,NodesD) when is_list(NodesD) ->
     case lists:keysearch(Node,1,NodesD) of

 	{value,{_,AvailableStatus}} ->

 	    lists:keyreplace(Node,1,NodesD,{Node,set_running_nodes_2(AvailableStatus)});

@@ -2902,7 +2902,7 @@ get_available_nodes([]) ->
 %% suspended or not.

 %% Returns {State,Status} | reactivating | down

 %% where 

-get_state_nodes(Node,NodesD) when list(NodesD) ->

+get_state_nodes(Node,NodesD) when is_list(NodesD) ->
     case lists:keysearch(Node,1,NodesD) of

 	{value,{_,AvailableStatus}} ->

 	    get_state_nodes_2(AvailableStatus);