diff options
author | Björn Gustavsson <[email protected]> | 2017-11-21 09:16:56 +0100 |
---|---|---|
committer | Björn Gustavsson <[email protected]> | 2017-11-21 12:39:59 +0100 |
commit | 892dd54fa032de737defbee22534117b1c261c60 (patch) | |
tree | 14866de218b0e2a757f66c10691448d1084f8023 /lib/observer/test/crashdump_viewer_SUITE.erl | |
parent | 533ea3ef982965a8e75305f6cd5b89e8fb046d35 (diff) | |
download | otp-892dd54fa032de737defbee22534117b1c261c60.tar.gz otp-892dd54fa032de737defbee22534117b1c261c60.tar.bz2 otp-892dd54fa032de737defbee22534117b1c261c60.zip |
Correct parsing of sub binaries
Correct several problems parsing sub binaries. A sub binary
would often be replaced with '#CDVNonexistingBinary'.
When parsing a sub binary, we must scan ahead to find the
definition of the refc or heap binary being referenced.
Diffstat (limited to 'lib/observer/test/crashdump_viewer_SUITE.erl')
-rw-r--r-- | lib/observer/test/crashdump_viewer_SUITE.erl | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/observer/test/crashdump_viewer_SUITE.erl b/lib/observer/test/crashdump_viewer_SUITE.erl index 29b9e406ae..b2777aed46 100644 --- a/lib/observer/test/crashdump_viewer_SUITE.erl +++ b/lib/observer/test/crashdump_viewer_SUITE.erl @@ -403,6 +403,10 @@ special(File,Procs) -> verify_binaries(Binaries, proplists:get_value(bins,Dict)), io:format(" binaries ok",[]), + SubBinaries = crashdump_helper:create_sub_binaries(Binaries), + verify_binaries(SubBinaries, proplists:get_value(sub_bins,Dict)), + io:format(" sub binaries ok",[]), + #proc{last_calls=LastCalls} = ProcDetails, true = length(LastCalls) =< 4, @@ -461,7 +465,9 @@ special(File,Procs) -> %% i.e. no binary exist in the dump [#proc{pid=Pid0}|_Rest] = lists:keysort(#proc.name,Procs), Pid = pid_to_list(Pid0), - {ok,ProcDetails=#proc{},[]} = crashdump_viewer:proc_details(Pid), + %%WarnIncompleteHeap = ["WARNING: This process has an incomplete heap. Some information might be missing."], + {ok,ProcDetails=#proc{},[]} = + crashdump_viewer:proc_details(Pid), io:format(" process details ok",[]), #proc{dict=Dict} = ProcDetails, |