From 3e4422d3cf97d25423b6f5be714639e666b222d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn-Egil=20Dahlberg?= <egil@erlang.org>
Date: Fri, 27 Jun 2014 15:24:20 +0200
Subject: compiler: Use variables in Map cerl inliner

---
 lib/compiler/src/cerl.erl        |  4 +++-
 lib/compiler/src/cerl_inline.erl | 36 ++++++++++++++++--------------------
 lib/compiler/src/cerl_trees.erl  |  4 ++--
 3 files changed, 21 insertions(+), 23 deletions(-)

diff --git a/lib/compiler/src/cerl.erl b/lib/compiler/src/cerl.erl
index 9d6768b157..7a2c3d70de 100644
--- a/lib/compiler/src/cerl.erl
+++ b/lib/compiler/src/cerl.erl
@@ -3063,10 +3063,12 @@ pat_vars(Node, Vs) ->
 	map ->
 	    pat_list_vars(map_es(Node), Vs);
 	map_pair ->
-	    pat_list_vars([map_pair_op(Node),map_pair_key(Node),map_pair_val(Node)],Vs);
+	    %% map_pair_key is not a pattern var, excluded
+	    pat_list_vars([map_pair_op(Node),map_pair_val(Node)],Vs);
 	binary ->
 	    pat_list_vars(binary_segments(Node), Vs);
 	bitstr ->
+	    %% bitstr_size is not a pattern var, excluded
 	    pat_vars(bitstr_val(Node), Vs);
 	alias ->
 	    pat_vars(alias_pat(Node), [alias_var(Node) | Vs])
diff --git a/lib/compiler/src/cerl_inline.erl b/lib/compiler/src/cerl_inline.erl
index 75740e8b9d..f8489a800b 100644
--- a/lib/compiler/src/cerl_inline.erl
+++ b/lib/compiler/src/cerl_inline.erl
@@ -1341,23 +1341,23 @@ i_bitstr(E, Ren, Env, S) ->
     S3 = count_size(weight(bitstr), S2),
     {update_c_bitstr(E, Val, Size, Unit, Type, Flags), S3}.
 
-i_map(E, Ctx, Ren, Env, S) ->
+i_map(E, Ctx, Ren, Env, S0) ->
     %% Visit the segments for value.
-    {M1, S1} = i(map_arg(E), value, Ren, Env, S),
+    {M1, S1} = i(map_arg(E), value, Ren, Env, S0),
     {Es, S2} = mapfoldl(fun (E, S) ->
 		i_map_pair(E, Ctx, Ren, Env, S)
 	end, S1, map_es(E)),
     S3 = count_size(weight(map), S2),
     {update_c_map(E, M1,Es), S3}.
 
-i_map_pair(E, Ctx, Ren, Env, S) ->
-    %% It is not necessary to visit the Op and Key fields,
-    %% since these are always literals.
-    {Val, S1} = i(map_pair_val(E), Ctx, Ren, Env, S),
+i_map_pair(E, Ctx, Ren, Env, S0) ->
+    %% It is not necessary to visit the Op field
+    %% since it is always a literal.
+    {Key, S1} = i(map_pair_key(E), value, Ren, Env, S0),
+    {Val, S2} = i(map_pair_val(E), Ctx, Ren, Env, S1),
     Op = map_pair_op(E),
-    Key = map_pair_key(E),
-    S2 = count_size(weight(map_pair), S1),
-    {update_c_map_pair(E, Op, Key, Val), S2}.
+    S3 = count_size(weight(map_pair), S2),
+    {update_c_map_pair(E, Op, Key, Val), S3}.
 
 
 %% This is a simplified version of `i_pattern', for lists of parameter
@@ -1420,15 +1420,11 @@ i_pattern(E, Ren, Env, Ren0, Env0, S) ->
 	    S2 = count_size(weight(binary), S1),
 	    {update_c_binary(E, Es), S2};
 	map ->
-	    %% map patterns should not have args
-	    M = map_arg(E),
-
 	    {Es, S1} = mapfoldl(fun (E, S) ->
 			i_map_pair_pattern(E, Ren, Env, Ren0, Env0, S)
-		end,
-		S, map_es(E)),
+		end, S, map_es(E)),
 	    S2 = count_size(weight(map), S1),
-	    {update_c_map(E, M, Es), S2};
+	    {update_c_map(E, map_arg(E), Es), S2};
 	_ ->
 	    case is_literal(E) of
 		true ->
@@ -1464,12 +1460,12 @@ i_bitstr_pattern(E, Ren, Env, Ren0, Env0, S) ->
 
 i_map_pair_pattern(E, Ren, Env, Ren0, Env0, S) ->
     %% It is not necessary to visit the Op it is always a literal.
-    %% Same goes for Key
-    {Val, S1} = i_pattern(map_pair_val(E), Ren, Env, Ren0, Env0, S),
+    %% Key is an expression
+    {Key, S1} = i(map_pair_key(E), value, Ren0, Env0, S),
+    {Val, S2} = i_pattern(map_pair_val(E), Ren, Env, Ren0, Env0, S1),
     Op = map_pair_op(E), %% should be 'exact' literal
-    Key  = map_pair_key(E),
-    S2 = count_size(weight(map_pair), S1),
-    {update_c_map_pair(E, Op, Key, Val), S2}.
+    S3 = count_size(weight(map_pair), S2),
+    {update_c_map_pair(E, Op, Key, Val), S3}.
 
 
 %% ---------------------------------------------------------------------
diff --git a/lib/compiler/src/cerl_trees.erl b/lib/compiler/src/cerl_trees.erl
index e53bdd4efb..b93da8e97f 100644
--- a/lib/compiler/src/cerl_trees.erl
+++ b/lib/compiler/src/cerl_trees.erl
@@ -520,9 +520,9 @@ variables(T, S) ->
 	tuple ->
 	    vars_in_list(tuple_es(T), S);
 	map ->
-	    vars_in_list(map_es(T), S);
+	    vars_in_list([map_arg(T)|map_es(T)], S);
 	map_pair ->
-	    vars_in_list([map_pair_op(T),map_pair_key(T), map_pair_val(T)], S);
+	    vars_in_list([map_pair_op(T),map_pair_key(T),map_pair_val(T)], S);
 	'let' ->
 	    Vs = variables(let_body(T), S),
 	    Vs1 = var_list_names(let_vars(T)),
-- 
cgit v1.2.3