From 8099c11c626a501aceebcb49eda042c4f3357db8 Mon Sep 17 00:00:00 2001
From: Hans Nilsson <hans@erlang.org>
Date: Tue, 7 Jun 2016 17:00:16 +0200
Subject: ftp: Introduce search path for ftp servers to use in ftp_SUITE

---
 lib/inets/test/ftp_SUITE.erl | 41 ++++++++++++++++++++++++++---------------
 1 file changed, 26 insertions(+), 15 deletions(-)

diff --git a/lib/inets/test/ftp_SUITE.erl b/lib/inets/test/ftp_SUITE.erl
index a8d39e3fe7..5867828a1f 100644
--- a/lib/inets/test/ftp_SUITE.erl
+++ b/lib/inets/test/ftp_SUITE.erl
@@ -114,6 +114,7 @@ ftp_tests()->
 %%% ftpservers		list of servers to check if they are available
 %%%			The element is:
 %%%			  {Name,         % string(). The os command name
+%%%                        Path,         % string(). The os PATH syntax, e.g "/bin:/usr/bin"
 %%%			   StartCommand, % fun()->{ok,start_result()} | {error,string()}.
 %%%			                 % The command to start the daemon with.
 %%%			   ChkUp,        % fun(start_result()) -> string(). Os command to check
@@ -129,12 +130,13 @@ ftp_tests()->
 
 -define(default_ftp_servers,
 	[{"vsftpd",
-	  fun(__CONF__) -> 
+	  "/sbin:/usr/sbin:/usr/local/sbin",
+	  fun(__CONF__, AbsName) -> 
 		  DataDir = proplists:get_value(data_dir,__CONF__),
 		  ConfFile = filename:join(DataDir, "vsftpd.conf"),
 		  PrivDir = proplists:get_value(priv_dir,__CONF__),
 		  AnonRoot = PrivDir,
-		  Cmd = ["vsftpd "++filename:join(DataDir,"vsftpd.conf"),
+		  Cmd = [AbsName ++" "++filename:join(DataDir,"vsftpd.conf"),
 			 " -oftpd_banner=erlang_otp_testing",
 			 " -oanon_root=\"",AnonRoot,"\"",
 			 " -orsa_cert_file=\"",filename:join(DataDir,"server-cert.pem"),"\"",
@@ -856,28 +858,37 @@ chk_no_dir(PathList, Config) ->
 
 %%--------------------------------------------------------------------
 find_executable(Config) ->
-    FTPservers = case proplists:get_value(ftpservers,Config) of
-		     undefined -> ?default_ftp_servers;
-		     L -> L
-		 end,
-    case lists:dropwhile(fun not_available/1, FTPservers) of
-	[] -> false;
-	[FTPD_data|_] -> {ok, FTPD_data}
-    end.
+    search_executable(proplists:get_value(ftpservers, Config, ?default_ftp_servers)).
+
+
+search_executable([{Name,Paths,_StartCmd,_ChkUp,_StopCommand,_ConfigUpd,_Host,_Port}|Srvrs]) ->
+    case os_find(Name,Paths) of
+	false ->
+	    search_executable(Srvrs);
+	AbsName -> 
+	    ct:comment("Found ~p",[AbsName]),
+	    {ok, {AbsName,_StartCmd,_ChkUp,_StopCommand,_ConfigUpd,_Host,_Port}}
+    end;
+search_executable([]) ->
+    false.
 
-not_available({Name,_StartCmd,_ChkUp,_StopCommand,_ConfigUpd,_Host,_Port}) ->
-    os:find_executable(Name) == false.
 
+os_find(Name, Paths) ->
+    case os:find_executable(Name, Paths) of
+	false -> os:find_executable(Name);
+	AbsName -> AbsName
+    end.
 
+%%%----------------------------------------------------------------
 start_ftpd(Config) ->
-    {Name,StartCmd,_ChkUp,_StopCommand,ConfigRewrite,Host,Port} = proplists:get_value(ftpd_data, Config),
-    case StartCmd(Config) of
+    {AbsName,StartCmd,_ChkUp,_StopCommand,ConfigRewrite,Host,Port} = proplists:get_value(ftpd_data, Config),
+    case StartCmd(Config, AbsName) of
 	{ok,StartResult} ->
 	    [{ftpd_host,Host},
 	     {ftpd_port,Port},
 	     {ftpd_start_result,StartResult} | ConfigRewrite(Config)];
 	{error,Msg} ->
-	    {skip, [Name," not started: ",Msg]}
+	    {skip, [AbsName," not started: ",Msg]}
     end.
 
 stop_ftpd(Config) ->
-- 
cgit v1.2.3


From 78d071ee4404ad5473dd2f866632fc4c145ab7f2 Mon Sep 17 00:00:00 2001
From: Hans Nilsson <hans@erlang.org>
Date: Wed, 8 Jun 2016 16:45:05 +0200
Subject: ftp: logging of server start in ftp_SUITE

---
 lib/inets/test/ftp_SUITE.erl | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/lib/inets/test/ftp_SUITE.erl b/lib/inets/test/ftp_SUITE.erl
index 5867828a1f..e2dec0c42a 100644
--- a/lib/inets/test/ftp_SUITE.erl
+++ b/lib/inets/test/ftp_SUITE.erl
@@ -864,6 +864,7 @@ find_executable(Config) ->
 search_executable([{Name,Paths,_StartCmd,_ChkUp,_StopCommand,_ConfigUpd,_Host,_Port}|Srvrs]) ->
     case os_find(Name,Paths) of
 	false ->
+	    ct:log("~p not found",[Name]),
 	    search_executable(Srvrs);
 	AbsName -> 
 	    ct:comment("Found ~p",[AbsName]),
@@ -880,13 +881,26 @@ os_find(Name, Paths) ->
     end.
 
 %%%----------------------------------------------------------------
-start_ftpd(Config) ->
-    {AbsName,StartCmd,_ChkUp,_StopCommand,ConfigRewrite,Host,Port} = proplists:get_value(ftpd_data, Config),
-    case StartCmd(Config, AbsName) of
+start_ftpd(Config0) ->
+    {AbsName,StartCmd,_ChkUp,_StopCommand,ConfigRewrite,Host,Port} =
+	proplists:get_value(ftpd_data, Config0),
+    case StartCmd(Config0, AbsName) of
 	{ok,StartResult} ->
-	    [{ftpd_host,Host},
-	     {ftpd_port,Port},
-	     {ftpd_start_result,StartResult} | ConfigRewrite(Config)];
+	    Config = [{ftpd_host,Host},
+		      {ftpd_port,Port},
+		      {ftpd_start_result,StartResult} | ConfigRewrite(Config0)],
+	    try
+		ftp__close(ftp__open(Config,[verbose]))
+	    of
+		Config1 when is_list(Config1) ->
+		    ct:log("Usuable ftp server ~p started on ~p:~p",[AbsName,Host,Port]),
+		    Config
+	    catch
+		Class:Exception ->
+		    ct:log("Ftp server ~p started on ~p:~p but is unusable:~n~p:~p",
+			   [AbsName,Host,Port,Class,Exception]),
+		    {skip, [AbsName," started but unusuable"]}
+	    end;
 	{error,Msg} ->
 	    {skip, [AbsName," not started: ",Msg]}
     end.
-- 
cgit v1.2.3