From 60a6858785f49357757691956295dbcb304c0508 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Mon, 31 Aug 2015 12:36:36 +0200
Subject: compile_SUITE: Add test of warnings

Make sure that all warnings produced when compiling the
test suite contains filenames and line numbers.
---
 lib/compiler/test/compile_SUITE.erl | 44 +++++++++++++++++++++++++++++++++++--
 1 file changed, 42 insertions(+), 2 deletions(-)

diff --git a/lib/compiler/test/compile_SUITE.erl b/lib/compiler/test/compile_SUITE.erl
index df401ccc2b..cbdd9ce8cd 100644
--- a/lib/compiler/test/compile_SUITE.erl
+++ b/lib/compiler/test/compile_SUITE.erl
@@ -31,7 +31,9 @@
 	 other_output/1, encrypted_abstr/1,
 	 bad_record_use1/1, bad_record_use2/1, strict_record/1,
 	 missing_testheap/1, cover/1, env/1, core/1, asm/1,
-	 sys_pre_attributes/1, dialyzer/1]).
+	 sys_pre_attributes/1, dialyzer/1,
+	 warnings/1
+	]).
 
 -export([init/3]).
 
@@ -48,7 +50,7 @@ all() ->
      other_output, encrypted_abstr,
      {group, bad_record_use}, strict_record,
      missing_testheap, cover, env, core, asm,
-     sys_pre_attributes, dialyzer].
+     sys_pre_attributes, dialyzer, warnings].
 
 groups() -> 
     [{bad_record_use, [],
@@ -895,6 +897,44 @@ dialyzer(Config) ->
     [{a,b,c}] = M:M(),
     ok.
 
+
+%% Test that warnings contain filenames and line numbers.
+warnings(_Config) ->
+    TestDir = filename:dirname(code:which(?MODULE)),
+    Files = filelib:wildcard(filename:join(TestDir, "*.erl")),
+    test_lib:p_run(fun do_warnings/1, Files).
+
+do_warnings(F) ->
+    {ok,_,_,Ws} = compile:file(F, [binary,bin_opt_info,return]),
+    do_warnings_1(Ws, F).
+
+do_warnings_1([{"no_file",Ws}|_], F) ->
+    io:format("~s:\nMissing file for warnings: ~p\n",
+	      [F,Ws]),
+    error;
+do_warnings_1([{Name,Ws}|T], F) ->
+    case filename:extension(Name) of
+	".erl" ->
+	    do_warnings_2(Ws, T, F);
+	_ ->
+	    io:format("~s:\nNo .erl extension\n", [F]),
+	    error
+    end;
+do_warnings_1([], _) -> ok.
+
+do_warnings_2([{Int,_,_}=W|T], Next, F) ->
+    if
+	is_integer(Int) ->
+	    do_warnings_2(T, Next, F);
+	true ->
+	    io:format("~s:\nMissing line number: ~p\n",
+		      [F,W]),
+	    error
+    end;
+do_warnings_2([], Next, F) ->
+    do_warnings_1(Next, F).
+
+
 %%%
 %%% Utilities.
 %%%
-- 
cgit v1.2.3