From 7603a4fb82f72a72045eed26dd55de3067cfe344 Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Fri, 6 Jul 2018 20:12:28 +0200
Subject: erts: Fix buggy calls to erts_sys_explicit_8bit_getenv

Two of them only affect valgrind builds
and the one for ERL_CRASH_DUMP_NICE seems benign.

Return value changed in c2d70945dce9cb09d5d7120d6e9ddf7faac8d230
old -> new
-1 ->  0  not found
 0 ->  1  found ok
 1 -> -1  found but too big
---
 erts/emulator/beam/dist.c         | 2 +-
 erts/emulator/beam/erl_bif_info.c | 2 +-
 erts/emulator/sys/unix/sys.c      | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/erts/emulator/beam/dist.c b/erts/emulator/beam/dist.c
index 70474898b2..db35137e92 100644
--- a/erts/emulator/beam/dist.c
+++ b/erts/emulator/beam/dist.c
@@ -1207,7 +1207,7 @@ erts_dsig_send_group_leader(ErtsDSigData *dsdp, Eterm leader, Eterm remote)
 #  define PURIFY_MSG(msg)                                                    \
     do {								     \
 	char buf__[1]; size_t bufsz__ = sizeof(buf__);			     \
-	if (erts_sys_explicit_8bit_getenv("VALGRIND_LOG_XML", buf__, &bufsz__) >= 0) { \
+	if (erts_sys_explicit_8bit_getenv("VALGRIND_LOG_XML", buf__, &bufsz__) != 0) { \
 	    VALGRIND_PRINTF_XML("<erlang_error_log>"			     \
 			    "%s, line %d: %s</erlang_error_log>\n",	     \
 			    __FILE__, __LINE__, msg);			     \
diff --git a/erts/emulator/beam/erl_bif_info.c b/erts/emulator/beam/erl_bif_info.c
index 5789fa8e71..39442e52c6 100644
--- a/erts/emulator/beam/erl_bif_info.c
+++ b/erts/emulator/beam/erl_bif_info.c
@@ -2098,7 +2098,7 @@ static int check_if_xml(void)
 {
     char buf[1];
     size_t bufsz = sizeof(buf);
-    return erts_sys_explicit_8bit_getenv("VALGRIND_LOG_XML", buf, &bufsz) >= 0;
+    return erts_sys_explicit_8bit_getenv("VALGRIND_LOG_XML", buf, &bufsz) != 0;
 }
 #else
 #define check_if_xml() 0
diff --git a/erts/emulator/sys/unix/sys.c b/erts/emulator/sys/unix/sys.c
index 189ca083d7..36579ffdb4 100644
--- a/erts/emulator/sys/unix/sys.c
+++ b/erts/emulator/sys/unix/sys.c
@@ -452,9 +452,9 @@ prepare_crash_dump(int secs)
 
     envsz = sizeof(env);
     i = erts_sys_explicit_8bit_getenv("ERL_CRASH_DUMP_NICE", env, &envsz);
-    if (i >= 0) {
+    if (i != 0) {
 	int nice_val;
-	nice_val = i != 1 ? 0 : atoi(env);
+	nice_val = (i != 1) ? 0 : atoi(env);
 	if (nice_val > 39) {
 	    nice_val = 39;
 	}
-- 
cgit v1.2.3


From edabb78bccd26fe817844d92cd04d8ac7fb8e817 Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Tue, 3 Jul 2018 20:31:20 +0200
Subject: erts: Fix benign bug in cerl for valgrind

benign until valgrind version 4.* shows up.
---
 erts/etc/unix/cerl.src | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/erts/etc/unix/cerl.src b/erts/etc/unix/cerl.src
index 896e4c8e45..2e034513b0 100644
--- a/erts/etc/unix/cerl.src
+++ b/erts/etc/unix/cerl.src
@@ -264,13 +264,14 @@ if [ "x$GDB" = "x" ]; then
 	valversion=`valgrind --version`
 	valmajor=`echo $valversion | sed 's,[a-z]*\-\([0-9]*\).*,\1,'`
         valminor=`echo $valversion | sed 's,[a-z]*\-[0-9]*.\([0-9]*\).*,\1,'`
+	valint=`echo "$valmajor * 1000 + $valminor" | bc`
 	if [ "x$VALGRIND_LOG_XML" = "x" ]; then
 	    valgrind_xml=
 	    log_file_prefix="--log-file="
 	else
 	    export VALGRIND_LOG_XML
 	    valgrind_xml="--xml=yes"
-	    if [ $valmajor -gt 2 -a $valminor -gt 4 ]; then
+	    if [ $valint -gt 3004 ]; then
 		log_file_prefix="--xml-file="
 	    else
 		log_file_prefix="--log-file="
@@ -279,7 +280,7 @@ if [ "x$GDB" = "x" ]; then
 	if [ "x$VALGRIND_LOG_DIR" = "x" ]; then
 	    valgrind_log=
 	else
-	    if [ $valmajor -gt 2 -a $valminor -gt 4 ]; then
+	    if [ $valint -gt 3004 ]; then
 		valgrind_log="$log_file_prefix$VALGRIND_LOG_DIR/$VALGRIND_LOGFILE_PREFIX$VALGRIND_LOGFILE_INFIX$EMU_NAME.log.$$"
 	    else
 		valgrind_log="$log_file_prefix$VALGRIND_LOG_DIR/$VALGRIND_LOGFILE_PREFIX$VALGRIND_LOGFILE_INFIX$EMU_NAME.log"
-- 
cgit v1.2.3


From 3e2508e0f6dbd973d80c96418a989d1fa525767a Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Tue, 3 Jul 2018 21:45:29 +0200
Subject: erl_interface: Add valgrind ability for test port programs

Run under valgrind if environment variable VALGRIND_LOG_DIR is set.
---
 lib/erl_interface/test/ei_accept_SUITE.erl        |  9 ++-
 lib/erl_interface/test/ei_connect_SUITE.erl       | 16 +++--
 lib/erl_interface/test/ei_decode_SUITE.erl        | 20 +++---
 lib/erl_interface/test/ei_decode_encode_SUITE.erl |  6 +-
 lib/erl_interface/test/ei_encode_SUITE.erl        | 22 ++++---
 lib/erl_interface/test/ei_format_SUITE.erl        | 12 ++--
 lib/erl_interface/test/ei_print_SUITE.erl         | 12 ++--
 lib/erl_interface/test/ei_tmo_SUITE.erl           | 28 ++++----
 lib/erl_interface/test/erl_connect_SUITE.erl      | 10 ++-
 lib/erl_interface/test/erl_eterm_SUITE.erl        | 78 ++++++++++++-----------
 lib/erl_interface/test/erl_ext_SUITE.erl          | 13 ++--
 lib/erl_interface/test/erl_format_SUITE.erl       | 10 ++-
 lib/erl_interface/test/erl_global_SUITE.erl       |  9 ++-
 lib/erl_interface/test/erl_match_SUITE.erl        |  7 +-
 lib/erl_interface/test/port_call_SUITE.erl        |  6 +-
 lib/erl_interface/test/runner.erl                 | 56 +++++++++++++---
 16 files changed, 204 insertions(+), 110 deletions(-)

diff --git a/lib/erl_interface/test/ei_accept_SUITE.erl b/lib/erl_interface/test/ei_accept_SUITE.erl
index 85c567acd3..78a433d21b 100644
--- a/lib/erl_interface/test/ei_accept_SUITE.erl
+++ b/lib/erl_interface/test/ei_accept_SUITE.erl
@@ -25,6 +25,7 @@
 -include("ei_accept_SUITE_data/ei_accept_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          ei_accept/1, ei_threaded_accept/1,
          monitor_ei_process/1]).
 
@@ -38,8 +39,11 @@ all() ->
     [ei_accept, ei_threaded_accept,
      monitor_ei_process].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 ei_accept(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
 
     Myname = hd(tl(string:tokens(atom_to_list(node()), "@"))),
@@ -91,7 +95,7 @@ ei_threaded_accept(Config) when is_list(Config) ->
 
 %% Test erlang:monitor toward erl_interface "processes"
 monitor_ei_process(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
 
     Myname = hd(tl(string:tokens(atom_to_list(node()), "@"))),
@@ -99,7 +103,6 @@ monitor_ei_process(Config) when is_list(Config) ->
     EINode = list_to_atom("c42@"++Myname),
     io:format("EINode ~p ~n",  [EINode]),
 
-    Self = self(),
     Port = 6543,
     {ok, ListenFd} = ei_publish(P, Port),
     MRef1 = erlang:monitor(process, {any, EINode}),
diff --git a/lib/erl_interface/test/ei_connect_SUITE.erl b/lib/erl_interface/test/ei_connect_SUITE.erl
index 66498deadc..24cd384295 100644
--- a/lib/erl_interface/test/ei_connect_SUITE.erl
+++ b/lib/erl_interface/test/ei_connect_SUITE.erl
@@ -25,6 +25,7 @@
 -include("ei_connect_SUITE_data/ei_connect_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          ei_send/1,
          ei_reg_send/1,
          ei_format_pid/1,
@@ -44,8 +45,11 @@ all() ->
     [ei_send, ei_reg_send, ei_rpc, ei_format_pid, ei_send_funs,
      ei_threaded_send, ei_set_get_tracelevel].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 ei_send(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = ei_connect(P, node()),
 
@@ -58,7 +62,7 @@ ei_send(Config) when is_list(Config) ->
 
 ei_format_pid(Config) when is_list(Config) ->
     S = self(),
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = ei_connect(P, node()),
 
@@ -70,7 +74,7 @@ ei_format_pid(Config) when is_list(Config) ->
     ok.
 
 ei_send_funs(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = ei_connect(P, node()),
 
@@ -88,7 +92,7 @@ ei_send_funs(Config) when is_list(Config) ->
     ok.
 
 ei_reg_send(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = ei_connect(P, node()),
 
@@ -137,7 +141,7 @@ start_einode(Einode, N, Host) ->
     ok.
 
 ei_rpc(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = ei_connect(P, node()),
 
@@ -150,7 +154,7 @@ ei_rpc(Config) when is_list(Config) ->
     ok.
 
 ei_set_get_tracelevel(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     5 = ei_set_get_tracelevel(P, 5),
     0 = ei_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = ei_connect(P, node()),
diff --git a/lib/erl_interface/test/ei_decode_SUITE.erl b/lib/erl_interface/test/ei_decode_SUITE.erl
index 74fb9b8916..499f10611e 100644
--- a/lib/erl_interface/test/ei_decode_SUITE.erl
+++ b/lib/erl_interface/test/ei_decode_SUITE.erl
@@ -25,6 +25,7 @@
 -include("ei_decode_SUITE_data/ei_decode_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          test_ei_decode_long/1,
          test_ei_decode_ulong/1,
          test_ei_decode_longlong/1,
@@ -42,6 +43,9 @@ all() ->
      test_ei_decode_char, test_ei_decode_nonoptimal,
      test_ei_decode_misc, test_ei_decode_utf8_atom].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 %% ---------------------------------------------------------------------------
 
 % NOTE: for historical reasons we don't pach as tight as we can,
@@ -51,7 +55,7 @@ all() ->
 %% ######################################################################## %%
 
 test_ei_decode_long(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_decode_long),
+    P = runner:start(Config, ?test_ei_decode_long),
     send_integers(P),
     runner:recv_eot(P),
     ok.
@@ -60,7 +64,7 @@ test_ei_decode_long(Config) when is_list(Config) ->
 %% ######################################################################## %%
 
 test_ei_decode_ulong(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_decode_ulong),
+    P = runner:start(Config, ?test_ei_decode_ulong),
     send_integers(P),
     runner:recv_eot(P),
     ok.
@@ -77,7 +81,7 @@ test_ei_decode_longlong(Config) when is_list(Config) ->
         vxworks ->
             {skip,"Skipped on VxWorks"};
         _ ->
-            P = runner:start(?test_ei_decode_longlong),
+            P = runner:start(Config, ?test_ei_decode_longlong),
             send_integers2(P),
             runner:recv_eot(P),
             ok
@@ -91,7 +95,7 @@ test_ei_decode_ulonglong(Config) when is_list(Config) ->
         vxworks ->
             {skip,"Skipped on VxWorks"};
         _ ->
-            P = runner:start(?test_ei_decode_ulonglong),
+            P = runner:start(Config, ?test_ei_decode_ulonglong),
             send_integers2(P),
             runner:recv_eot(P),
             ok
@@ -104,7 +108,7 @@ test_ei_decode_ulonglong(Config) when is_list(Config) ->
 %% FIXME maybe the API should change to use "unsigned char" to be clear?!
 
 test_ei_decode_char(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_decode_char),
+    P = runner:start(Config, ?test_ei_decode_char),
 
     send_term_as_binary(P,0),
     send_term_as_binary(P,16#7f),
@@ -119,7 +123,7 @@ test_ei_decode_char(Config) when is_list(Config) ->
 %% ######################################################################## %%
 
 test_ei_decode_nonoptimal(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_decode_nonoptimal),
+    P = runner:start(Config, ?test_ei_decode_nonoptimal),
 
     send_non_optimal_pos(P),			% decode_char
     send_non_optimal(P),			% decode_long
@@ -168,7 +172,7 @@ send_non_optimal_neg(P) ->
 %% ######################################################################## %%
 
 test_ei_decode_misc(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_decode_misc),
+    P = runner:start(Config, ?test_ei_decode_misc),
 
     send_term_as_binary(P,0.0),
     send_term_as_binary(P,-1.0),
@@ -199,7 +203,7 @@ test_ei_decode_misc(Config) when is_list(Config) ->
 %% ######################################################################## %%
 
 test_ei_decode_utf8_atom(Config) ->
-    P = runner:start(?test_ei_decode_utf8_atom),
+    P = runner:start(Config, ?test_ei_decode_utf8_atom),
 
     send_latin1_atom_as_binary(P,"å"),
     send_latin1_atom_as_binary(P,"ä"),
diff --git a/lib/erl_interface/test/ei_decode_encode_SUITE.erl b/lib/erl_interface/test/ei_decode_encode_SUITE.erl
index 160720b413..6476e92be9 100644
--- a/lib/erl_interface/test/ei_decode_encode_SUITE.erl
+++ b/lib/erl_interface/test/ei_decode_encode_SUITE.erl
@@ -25,6 +25,7 @@
 -include("ei_decode_encode_SUITE_data/ei_decode_encode_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          test_ei_decode_encode/1]).
 
 suite() ->
@@ -33,6 +34,9 @@ suite() ->
 all() -> 
     [test_ei_decode_encode].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 %% ---------------------------------------------------------------------------
 
 % NOTE: these types have no meaning on the C side so we pass them
@@ -42,7 +46,7 @@ all() ->
 %% ######################################################################## %%
 
 test_ei_decode_encode(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_decode_encode),
+    P = runner:start(Config, ?test_ei_decode_encode),
 
     Fun   = fun (X) -> {X,true} end,
     Pid   = self(),
diff --git a/lib/erl_interface/test/ei_encode_SUITE.erl b/lib/erl_interface/test/ei_encode_SUITE.erl
index 8857b092f3..8c3b0e193b 100644
--- a/lib/erl_interface/test/ei_encode_SUITE.erl
+++ b/lib/erl_interface/test/ei_encode_SUITE.erl
@@ -25,6 +25,7 @@
 -include("ei_encode_SUITE_data/ei_encode_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          test_ei_encode_long/1,
          test_ei_encode_ulong/1,
          test_ei_encode_longlong/1,
@@ -45,6 +46,9 @@ all() ->
      test_ei_encode_fails, test_ei_encode_utf8_atom,
      test_ei_encode_utf8_atom_len].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 
 %% ---------------------------------------------------------------------------
 
@@ -55,7 +59,7 @@ all() ->
 %% ######################################################################## %%
 
 test_ei_encode_long(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_encode_long),
+    P = runner:start(Config, ?test_ei_encode_long),
 
     {<<97,0>>                        ,0}   = get_buf_and_term(P),
     {<<97,255>>                      ,255} = get_buf_and_term(P),
@@ -77,7 +81,7 @@ test_ei_encode_long(Config) when is_list(Config) ->
 %% ######################################################################## %%
 
 test_ei_encode_ulong(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_encode_ulong),
+    P = runner:start(Config, ?test_ei_encode_ulong),
 
     {<<97,0>>                          ,0}   = get_buf_and_term(P),
     {<<97,255>>                        ,255} = get_buf_and_term(P),
@@ -101,7 +105,7 @@ test_ei_encode_longlong(Config) when is_list(Config) ->
         vxworks ->
             {skip,"Skipped on VxWorks"};
         _ ->
-            P = runner:start(?test_ei_encode_longlong),
+            P = runner:start(Config, ?test_ei_encode_longlong),
 
             {<<97,0>>                        ,0}   = get_buf_and_term(P),
             {<<97,255>>                      ,255} = get_buf_and_term(P),
@@ -132,7 +136,7 @@ test_ei_encode_ulonglong(Config) when is_list(Config) ->
         vxworks ->
             {skip,"Skipped on VxWorks"};
         _ ->
-            P = runner:start(?test_ei_encode_ulonglong),
+            P = runner:start(Config, ?test_ei_encode_ulonglong),
 
             {<<97,0>>                          ,0} = get_buf_and_term(P),
             {<<97,255>>                        ,255} = get_buf_and_term(P),
@@ -158,7 +162,7 @@ test_ei_encode_ulonglong(Config) when is_list(Config) ->
 %% FIXME maybe the API should change to use "unsigned char" to be clear?!
 
 test_ei_encode_char(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_encode_char),
+    P = runner:start(Config, ?test_ei_encode_char),
 
     {<<97,  0>>,0} = get_buf_and_term(P),
     {<<97,127>>,16#7f} = get_buf_and_term(P),
@@ -171,7 +175,7 @@ test_ei_encode_char(Config) when is_list(Config) ->
 %% ######################################################################## %%
 
 test_ei_encode_misc(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_encode_misc),
+    P = runner:start(Config, ?test_ei_encode_misc),
 
     <<131>>  = get_binaries(P),
 
@@ -217,7 +221,7 @@ test_ei_encode_misc(Config) when is_list(Config) ->
 %% ######################################################################## %%
 
 test_ei_encode_fails(Config) when is_list(Config) ->
-    P = runner:start(?test_ei_encode_fails),
+    P = runner:start(Config, ?test_ei_encode_fails),
 
     XAtom = list_to_atom(lists:duplicate(255, $x)),
     YAtom = list_to_atom(lists:duplicate(255, $y)),
@@ -236,7 +240,7 @@ test_ei_encode_fails(Config) when is_list(Config) ->
 %% ######################################################################## %%
 
 test_ei_encode_utf8_atom(Config) ->
-    P = runner:start(?test_ei_encode_utf8_atom),
+    P = runner:start(Config, ?test_ei_encode_utf8_atom),
 
     {<<119,2,195,133>>,'Å'} = get_buf_and_term(P),
     {<<119,2,195,133>>,'Å'} = get_buf_and_term(P),
@@ -251,7 +255,7 @@ test_ei_encode_utf8_atom(Config) ->
 
 %% ######################################################################## %%
 test_ei_encode_utf8_atom_len(Config) ->
-    P = runner:start(?test_ei_encode_utf8_atom_len),
+    P = runner:start(Config, ?test_ei_encode_utf8_atom_len),
 
     {<<119,2,195,133>>,'Å'} = get_buf_and_term(P),
     {<<119,4,195,133,195,132>>,'ÅÄ'} = get_buf_and_term(P),
diff --git a/lib/erl_interface/test/ei_format_SUITE.erl b/lib/erl_interface/test/ei_format_SUITE.erl
index 07ee479b1f..b11a6ff164 100644
--- a/lib/erl_interface/test/ei_format_SUITE.erl
+++ b/lib/erl_interface/test/ei_format_SUITE.erl
@@ -26,6 +26,7 @@
 
 -export([format_wo_ver/1,
          all/0, suite/0,
+         init_per_testcase/2,
          atoms/1,
          tuples/1,
          lists/1]).
@@ -41,10 +42,13 @@ suite() ->
 all() -> 
     [format_wo_ver, atoms, tuples, lists].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 %% Tests formatting various atoms.
 
 atoms(Config) when is_list(Config) ->
-    P = runner:start(?atoms),
+    P = runner:start(Config, ?atoms),
 
     {term, ''} = get_term(P),
     {term, 'a'} = get_term(P),
@@ -84,7 +88,7 @@ atoms(Config) when is_list(Config) ->
 %% Tests formatting various tuples
 
 tuples(Config) when is_list(Config) ->
-    P = runner:start(?tuples),
+    P = runner:start(Config, ?tuples),
 
     {term, {}} = get_term(P),
     {term, {a}} = get_term(P),
@@ -105,7 +109,7 @@ tuples(Config) when is_list(Config) ->
 %% Tests formatting various lists
 
 lists(Config) when is_list(Config) ->
-    P = runner:start(?lists),
+    P = runner:start(Config, ?lists),
 
     {term, []} = get_term(P),
     {term, [a]} = get_term(P),
@@ -146,7 +150,7 @@ lists(Config) when is_list(Config) ->
 
 
 format_wo_ver(Config) when is_list(Config) ->
-    P = runner:start(?format_wo_ver),
+    P = runner:start(Config, ?format_wo_ver),
 
     {term, [-1, 2, $c, {a, "b"}, {c, 10}]} = get_term(P),
 
diff --git a/lib/erl_interface/test/ei_print_SUITE.erl b/lib/erl_interface/test/ei_print_SUITE.erl
index 6d5c341eae..cad2686018 100644
--- a/lib/erl_interface/test/ei_print_SUITE.erl
+++ b/lib/erl_interface/test/ei_print_SUITE.erl
@@ -25,6 +25,7 @@
 -include("ei_print_SUITE_data/ei_print_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          atoms/1, tuples/1, lists/1, strings/1]).
 
 -import(runner, [get_term/1]).
@@ -38,10 +39,13 @@ suite() ->
 all() -> 
     [atoms, tuples, lists, strings].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 %% Tests formatting various atoms.
 
 atoms(Config) when is_list(Config) ->
-    P = runner:start(?atoms),
+    P = runner:start(Config, ?atoms),
 
     {term, "''"} = get_term(P),
     {term, "a"} = get_term(P),
@@ -79,7 +83,7 @@ atoms(Config) when is_list(Config) ->
 %% Tests formatting various tuples
 
 tuples(Config) when is_list(Config) ->
-    P = runner:start(?tuples),
+    P = runner:start(Config, ?tuples),
 
     {term, "{}"} = get_term(P),
     {term, "{a}"} = get_term(P),
@@ -100,7 +104,7 @@ tuples(Config) when is_list(Config) ->
 %% Tests formatting various lists
 
 lists(Config) when is_list(Config) ->
-    P = runner:start(?lists),
+    P = runner:start(Config, ?lists),
 
     {term, "[]"} = get_term(P),
     {term, "[a]"} = get_term(P),
@@ -125,7 +129,7 @@ lists(Config) when is_list(Config) ->
     ok.
 
 strings(Config) when is_list(Config) ->
-    P = runner:start(?strings),
+    P = runner:start(Config, ?strings),
 
     {term, "\"\\n\""} = get_term(P),
     {term, "\"\\r\\n\""} = get_term(P),
diff --git a/lib/erl_interface/test/ei_tmo_SUITE.erl b/lib/erl_interface/test/ei_tmo_SUITE.erl
index 003fe20594..1e76a99e1e 100644
--- a/lib/erl_interface/test/ei_tmo_SUITE.erl
+++ b/lib/erl_interface/test/ei_tmo_SUITE.erl
@@ -39,14 +39,16 @@ all() ->
     [framework_check, ei_accept_tmo, ei_connect_tmo,
      ei_send_tmo, ei_recv_tmo].
 
-init_per_testcase(_Case, Config) ->
+init_per_testcase(Case, Config) ->
+    Config1 = runner:init_per_testcase(?MODULE, Case, Config),
+
     % test if platform is vxworks_simso
     {_,Host} = split(node()),
     Bool = case atom_to_list(Host) of
                [$v,$x,$s,$i,$m | _] -> true;
                _ -> false
            end,
-    [{vxsim,Bool}|Config].
+    [{vxsim,Bool} | Config1].
 
 end_per_testcase(_Case, _Config) ->
     ok.
@@ -55,7 +57,7 @@ end_per_testcase(_Case, _Config) ->
 framework_check(Config) when is_list(Config) ->
     %%dbg:tracer(),
     %%dbg:p(self()),
-    P = runner:start(?framework_check),
+    P = runner:start(Config, ?framework_check),
     runner:send_term(P,{hello,world}),
     {term, {hello,world}} = runner:get_term(P),
     runner:recv_eot(P),
@@ -71,7 +73,7 @@ ei_recv_tmo(Config) when is_list(Config) ->
 
 do_one_recv(Config,CNode) ->
     {_,Host} = split(node()),
-    P1 = runner:start(?recv_tmo),
+    P1 = runner:start(Config, ?recv_tmo),
     runner:send_term(P1,{CNode,
                          erlang:get_cookie(),
                          node()}),
@@ -84,7 +86,7 @@ do_one_recv(Config,CNode) ->
     runner:recv_eot(P1).
 
 do_one_recv_failure(Config,CNode) ->
-    P1 = runner:start(?recv_tmo),
+    P1 = runner:start(Config, ?recv_tmo),
     runner:send_term(P1,{CNode,
                          erlang:get_cookie(),
                          node()}),
@@ -110,7 +112,7 @@ ei_send_tmo(Config) when is_list(Config) ->
 
 do_one_send(Config,From,CNode) ->
     {_,Host} = split(node()),
-    P1 = runner:start(?send_tmo),
+    P1 = runner:start(Config, ?send_tmo),
     runner:send_term(P1,{CNode,
                          erlang:get_cookie(),
                          node()}),
@@ -139,7 +141,7 @@ do_one_send_failure(Config,From,FakeName,CName,VxSim) ->
                       exit(Else)
               end,
     EpmdSocket = register(OurName, LSocket, 1, 5),
-    P3 = runner:start(?send_tmo),
+    P3 = runner:start(Config, ?send_tmo),
     Cookie = kaksmula_som_ingen_bryr_sig_om,
     runner:send_term(P3,{CName,
                          Cookie,
@@ -202,7 +204,7 @@ ei_connect_tmo(Config) when is_list(Config) ->
     %dbg:p(self()),
     VxSim = proplists:get_value(vxsim, Config),
     DummyNode = make_and_check_dummy(),
-    P = runner:start(?connect_tmo),
+    P = runner:start(Config, ?connect_tmo),
     runner:send_term(P,{c_nod_connect_tmo_1,
                         kaksmula_som_ingen_bryr_sig_om,
                         DummyNode}),
@@ -219,7 +221,7 @@ ei_connect_tmo(Config) when is_list(Config) ->
            end
     end,
     runner:recv_eot(P),
-    P2 = runner:start(?connect_tmo),
+    P2 = runner:start(Config, ?connect_tmo),
     runner:send_term(P2,{c_nod_connect_tmo_2,
                          erlang:get_cookie(),
                          node()}),
@@ -237,7 +239,7 @@ ei_connect_tmo(Config) when is_list(Config) ->
                       exit(Else)
               end,
     EpmdSocket = register(OurName, LSocket, 1, 5),
-    P3 = runner:start(?connect_tmo),
+    P3 = runner:start(Config, ?connect_tmo),
     Cookie = kaksmula_som_ingen_bryr_sig_om,
     runner:send_term(P3,{c_nod_connect_tmo_3,
                          Cookie,
@@ -266,12 +268,12 @@ ei_connect_tmo(Config) when is_list(Config) ->
 ei_accept_tmo(Config) when is_list(Config) ->
     %%dbg:tracer(),
     %%dbg:p(self()),
-    P = runner:start(?accept_tmo),
+    P = runner:start(Config, ?accept_tmo),
     runner:send_term(P,{c_nod_som_ingen_kontaktar_1,
                         kaksmula_som_ingen_bryr_sig_om}),
     {term,{-1,ETimedout,ETimedout}} = runner:get_term(P, 10000),
     runner:recv_eot(P),
-    P2 = runner:start(?accept_tmo),
+    P2 = runner:start(Config, ?accept_tmo),
     runner:send_term(P2,{c_nod_som_vi_kontaktar_1,
                          erlang:get_cookie()}),
     receive after 1000 -> ok end,
@@ -280,7 +282,7 @@ ei_accept_tmo(Config) when is_list(Config) ->
     {term, X} = runner:get_term(P2, 10000),
     runner:recv_eot(P2),
     true = is_integer(X),
-    P3 = runner:start(?accept_tmo),
+    P3 = runner:start(Config, ?accept_tmo),
     runner:send_term(P3,{c_nod_som_vi_kontaktar_2,
                          erlang:get_cookie()}),
     receive after 1000 -> ok end,
diff --git a/lib/erl_interface/test/erl_connect_SUITE.erl b/lib/erl_interface/test/erl_connect_SUITE.erl
index cd73f07b8f..ad4e34c548 100644
--- a/lib/erl_interface/test/erl_connect_SUITE.erl
+++ b/lib/erl_interface/test/erl_connect_SUITE.erl
@@ -25,6 +25,7 @@
 -include("erl_connect_SUITE_data/erl_connect_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          erl_send/1, erl_reg_send/1,
          erl_send_cookie_file/1]).
 
@@ -38,8 +39,11 @@ all() ->
     [erl_send, erl_reg_send, erl_send_cookie_file].
 
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 erl_send(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     1 = erl_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = erl_connect(P, node()),
 
@@ -56,7 +60,7 @@ erl_send_cookie_file(Config) when is_list(Config) ->
         vxworks ->
             {skip,"Skipped on VxWorks"};
         _ ->
-            P = runner:start(?interpret),
+            P = runner:start(Config, ?interpret),
             1 = erl_connect_init(P, 42, '', 0),
             {ok,Fd} = erl_connect(P, node()),
 
@@ -70,7 +74,7 @@ erl_send_cookie_file(Config) when is_list(Config) ->
     end.
 
 erl_reg_send(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     1 = erl_connect_init(P, 42, erlang:get_cookie(), 0),
     {ok,Fd} = erl_connect(P, node()),
 
diff --git a/lib/erl_interface/test/erl_eterm_SUITE.erl b/lib/erl_interface/test/erl_eterm_SUITE.erl
index 3d1e33081b..84b58fed54 100644
--- a/lib/erl_interface/test/erl_eterm_SUITE.erl
+++ b/lib/erl_interface/test/erl_eterm_SUITE.erl
@@ -35,6 +35,7 @@
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          build_terms/1, round_trip_conversion/1,
          decode_terms/1, decode_float/1,
          t_erl_mk_int/1, t_erl_mk_list/1,
@@ -94,6 +95,9 @@ all() ->
      high_chaparal, broken_data, cnode_1].
 
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %%%
 %%%	1.   B a s i c    t e s t s
@@ -104,7 +108,7 @@ all() ->
 %% a list and verifies that the result is as expected.
 
 build_terms(Config) when is_list(Config) ->
-    P = runner:start(?build_terms),
+    P = runner:start(Config, ?build_terms),
     {term, Term} = get_term(P),
     io:format("Received: ~p", [Term]),
     [ARefLN, ARef, APortLN, APort, APidLN, APid,
@@ -136,7 +140,7 @@ build_terms(Config) when is_list(Config) ->
 %% This test is run entirely in C code.
 
 round_trip_conversion(Config) when is_list(Config) ->
-    runner:test(?round_trip_conversion),
+    runner:test(Config, ?round_trip_conversion),
     ok.
 
 %% This test sends a list of all data types to the C code function,
@@ -156,7 +160,7 @@ decode_terms(Config) when is_list(Config) ->
              {element1, 42, 767}, "A string",
              1, -1, 0, 3.0, ABinary, 'I am an atom'],
 
-    P = runner:start(?decode_terms),
+    P = runner:start(Config, ?decode_terms),
     runner:send_term(P, Terms),
     runner:recv_eot(P),
 
@@ -165,7 +169,7 @@ decode_terms(Config) when is_list(Config) ->
 %% Decodes the floating point number 3.1415.
 
 decode_float(Config) when is_list(Config) ->
-    P = runner:start(?decode_float),
+    P = runner:start(Config, ?decode_float),
     runner:send_term(P, 3.1415),
     runner:recv_eot(P),
     ok.
@@ -173,7 +177,7 @@ decode_float(Config) when is_list(Config) ->
 %% Tests the erl_free_compound() function.
 
 t_erl_free_compound(Config) when is_list(Config) ->
-    runner:test(?t_erl_free_compound),
+    runner:test(Config, ?t_erl_free_compound),
     ok.
 
 
@@ -186,7 +190,7 @@ t_erl_free_compound(Config) when is_list(Config) ->
 %% This tests the erl_mk_list() function.
 
 t_erl_mk_list(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_list),
+    P = runner:start(Config, ?t_erl_mk_list),
 
     {term, []} = get_term(P),
     {term, [abc]} = get_term(P),
@@ -200,7 +204,7 @@ t_erl_mk_list(Config) when is_list(Config) ->
 %% This tests the erl_mk_int() function.
 
 t_erl_mk_int(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_int),
+    P = runner:start(Config, ?t_erl_mk_int),
 
     {term, 0} = get_term(P),
     {term, 127} = get_term(P),
@@ -255,14 +259,14 @@ t_erl_mk_int(Config) when is_list(Config) ->
 %% Basic test of erl_copy_term().
 
 basic_copy(Config) when is_list(Config) ->
-    runner:test(?basic_copy),
+    runner:test(Config, ?basic_copy),
     ok.
 
 
 %% This tests the erl_mk_tuple() function.
 
 t_erl_mk_tuple(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_tuple),
+    P = runner:start(Config, ?t_erl_mk_tuple),
 
     {term, {madonna, 21, 'mad donna', 12}} = get_term(P),
     {term, {'Madonna',21,{children,{"Isabella",2}},
@@ -275,7 +279,7 @@ t_erl_mk_tuple(Config) when is_list(Config) ->
 %% This tests the erl_mk_atom() function.
 
 t_erl_mk_atom(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_atom),
+    P = runner:start(Config, ?t_erl_mk_atom),
 
     {term, madonna} = (get_term(P)),
     {term, 'Madonna'} = (get_term(P)),
@@ -295,7 +299,7 @@ t_erl_mk_atom(Config) when is_list(Config) ->
 %% This tests the erl_mk_binary() function.
 
 t_erl_mk_binary(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_binary),
+    P = runner:start(Config, ?t_erl_mk_binary),
 
     {term, Bin} = (get_term(P)),
     "{madonna,21,'mad donna',1234.567.890, !#$%&/()=?+-@, \" \\}" = binary_to_list(Bin),
@@ -307,7 +311,7 @@ t_erl_mk_binary(Config) when is_list(Config) ->
 %% This tests the erl_mk_empty_list() function.
 
 t_erl_mk_empty_list(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_empty_list),
+    P = runner:start(Config, ?t_erl_mk_empty_list),
 
     {term, []} = get_term(P),
 
@@ -322,7 +326,7 @@ t_erl_mk_float(Config) when is_list(Config) ->
         vxworks ->
             {skipped, "Floating point numbers never compare equal on PPC"};
         _ ->
-            P = runner:start(?t_erl_mk_float),
+            P = runner:start(Config, ?t_erl_mk_float),
             {term, {3.1415, 1.999999, 2.000000, 2.000001,
                     2.000002, 12345.67890}} = get_term(P),
             runner:recv_eot(P),
@@ -333,7 +337,7 @@ t_erl_mk_float(Config) when is_list(Config) ->
 %% This tests the erl_mk_pid() function.
 
 t_erl_mk_pid(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_pid),
+    P = runner:start(Config, ?t_erl_mk_pid),
 
     {term, A_pid} = (get_term(P)),
     {pid, kalle@localhost, 3, 2} = nc2vinfo(A_pid),
@@ -342,7 +346,7 @@ t_erl_mk_pid(Config) when is_list(Config) ->
     ok.
 
 t_erl_mk_xpid(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_xpid),
+    P = runner:start(Config, ?t_erl_mk_xpid),
 
     {term, A_pid} = (get_term(P)),
     {pid, kalle@localhost, 32767, 8191} = nc2vinfo(A_pid),
@@ -354,7 +358,7 @@ t_erl_mk_xpid(Config) when is_list(Config) ->
 %% This tests the erl_mk_port() function.
 
 t_erl_mk_port(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_port),
+    P = runner:start(Config, ?t_erl_mk_port),
 
     {term, A_port} = (get_term(P)),
     {port, kalle@localhost, 4} = nc2vinfo(A_port),
@@ -363,7 +367,7 @@ t_erl_mk_port(Config) when is_list(Config) ->
     ok.
 
 t_erl_mk_xport(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_xport),
+    P = runner:start(Config, ?t_erl_mk_xport),
 
     {term, A_port} = (get_term(P)),
     {port, kalle@localhost, 268435455} = nc2vinfo(A_port),
@@ -375,7 +379,7 @@ t_erl_mk_xport(Config) when is_list(Config) ->
 %% This tests the erl_mk_ref() function.
 
 t_erl_mk_ref(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_ref),
+    P = runner:start(Config, ?t_erl_mk_ref),
 
     {term, A_ref} = (get_term(P)),
     {ref, kalle@localhost, _Length, [6]} = nc2vinfo(A_ref),
@@ -384,7 +388,7 @@ t_erl_mk_ref(Config) when is_list(Config) ->
     ok.
 
 t_erl_mk_long_ref(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_long_ref),
+    P = runner:start(Config, ?t_erl_mk_long_ref),
 
     {term, A_ref} = (get_term(P)),
     {ref, kalle@localhost, _Length, [4294967295,4294967295,262143]}
@@ -397,7 +401,7 @@ t_erl_mk_long_ref(Config) when is_list(Config) ->
 %% This tests the erl_mk_string() function.
 
 t_erl_mk_string(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_string),
+    P = runner:start(Config, ?t_erl_mk_string),
 
     {term, "madonna"} = (get_term(P)),
     {term, "Madonna"} = (get_term(P)),
@@ -417,7 +421,7 @@ t_erl_mk_string(Config) when is_list(Config) ->
 %% This tests the erl_mk_estring() function.
 
 t_erl_mk_estring(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_estring),
+    P = runner:start(Config, ?t_erl_mk_estring),
 
     {term, "madonna"} = (get_term(P)),
     {term, "Madonna"} = (get_term(P)),
@@ -437,7 +441,7 @@ t_erl_mk_estring(Config) when is_list(Config) ->
 %% This tests the erl_mk_uint() function.
 
 t_erl_mk_uint(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_uint),
+    P = runner:start(Config, ?t_erl_mk_uint),
 
     {term, 54321} = (get_term(P)),
     {term, 2147483647} = (get_term(P)),
@@ -453,7 +457,7 @@ t_erl_mk_uint(Config) when is_list(Config) ->
 %% This tests the erl_mk_var() function.
 
 t_erl_mk_var(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_mk_var),
+    P = runner:start(Config, ?t_erl_mk_var),
 
     {term, 1} = (get_term(P)),
     {term, 0} = (get_term(P)),
@@ -470,7 +474,7 @@ t_erl_mk_var(Config) when is_list(Config) ->
 %% This tests the erl_cons() function.
 
 t_erl_cons(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_cons),
+    P = runner:start(Config, ?t_erl_cons),
 
     {term, [madonna, 21]} = get_term(P),
 
@@ -490,7 +494,7 @@ t_erl_cons(Config) when is_list(Config) ->
 %% Tests the erl_length() function.
 
 t_erl_length(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_length),
+    P = runner:start(Config, ?t_erl_length),
 
     0 = erl_length(P, []),
     1 = erl_length(P, [a]),
@@ -513,7 +517,7 @@ erl_length(Port, List) ->
 %% Tests the erl_hd() function.
 
 t_erl_hd(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_hd),
+    P = runner:start(Config, ?t_erl_hd),
 
     'NULL' = erl_hd(P, 42),
     'NULL' = erl_hd(P, abc),
@@ -537,7 +541,7 @@ erl_hd(Port, List) ->
 %% Tests the erl_tail() function.
 
 t_erl_tl(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_tl),
+    P = runner:start(Config, ?t_erl_tl),
 
     'NULL' = erl_tl(P, 42),
     'NULL' = erl_tl(P, abc),
@@ -561,20 +565,20 @@ erl_tl(Port, List) ->
 %% Tests the type checking macros (done in the C program).
 
 type_checks(Config) when is_list(Config) ->
-    runner:test(?type_checks),
+    runner:test(Config, ?type_checks),
     ok.
 
 %% Tests the extractor macros (done in the C program).
 
 extractor_macros(Config) when is_list(Config) ->
-    runner:test(?extractor_macros),
+    runner:test(Config, ?extractor_macros),
     ok.
 
 
 %% This tests the erl_size() function.
 
 t_erl_size(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_size),
+    P = runner:start(Config, ?t_erl_size),
 
     {term, 0} = (get_term(P)),
     {term, 4} = (get_term(P)),
@@ -589,7 +593,7 @@ t_erl_size(Config) when is_list(Config) ->
 %% This tests the erl_var_content() function.
 
 t_erl_var_content(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_var_content),
+    P = runner:start(Config, ?t_erl_var_content),
 
     {term, 17} = (get_term(P)),
     {term, "http://www.madonna.com"} = (get_term(P)),
@@ -604,7 +608,7 @@ t_erl_var_content(Config) when is_list(Config) ->
 %% This tests the erl_element() function.
 
 t_erl_element(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_element),
+    P = runner:start(Config, ?t_erl_element),
 
     {term, madonna} = get_term(P),
     {term, 21} = get_term(P),
@@ -630,7 +634,7 @@ t_erl_element(Config) when is_list(Config) ->
 %% Tests the erl_iolist_length() function.
 
 t_erl_iolist_length(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_iolist_length),
+    P = runner:start(Config, ?t_erl_iolist_length),
 
     %% Flat lists.
 
@@ -697,7 +701,7 @@ erl_iolist_length(Port, List) ->
 %% Tests the erl_iolist_to_binary() function.
 
 t_erl_iolist_to_binary(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_iolist_to_binary),
+    P = runner:start(Config, ?t_erl_iolist_to_binary),
 
     %% Flat lists.
 
@@ -768,7 +772,7 @@ iolist_to_list(Port, Term) ->
 %% Tests the erl_iolist_to_string() function.
 
 t_erl_iolist_to_string(Config) when is_list(Config) ->
-    P = runner:start(?t_erl_iolist_to_string),
+    P = runner:start(Config, ?t_erl_iolist_to_string),
 
     %% Flat lists.
 
@@ -947,14 +951,14 @@ collect_line1([C|Rest], Result) ->
 %% Test case submitted by Per Lundgren, ERV.
 
 high_chaparal(Config) when is_list(Config) ->
-    P = runner:start(?high_chaparal),
+    P = runner:start(Config, ?high_chaparal),
     {term, [hello, world]} = get_term(P),
     runner:recv_eot(P),
     ok.
 
 %% OTP-7448
 broken_data(Config) when is_list(Config) ->
-    P = runner:start(?broken_data),
+    P = runner:start(Config, ?broken_data),
     runner:recv_eot(P),
     ok.
 
diff --git a/lib/erl_interface/test/erl_ext_SUITE.erl b/lib/erl_interface/test/erl_ext_SUITE.erl
index afaba1fd93..806339b122 100644
--- a/lib/erl_interface/test/erl_ext_SUITE.erl
+++ b/lib/erl_interface/test/erl_ext_SUITE.erl
@@ -25,6 +25,7 @@
 -include("erl_ext_SUITE_data/ext_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          compare_tuple/1,
          compare_list/1,
          compare_string/1,
@@ -40,28 +41,30 @@ all() ->
     [compare_tuple, compare_list, compare_string,
      compare_list_string, compare_nc_ext].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
 
 compare_tuple(Config) when is_list(Config) ->
-    P = runner:start(?compare_tuple),
+    P = runner:start(Config, ?compare_tuple),
     runner:recv_eot(P),
     ok.
 
 compare_list(Config) when is_list(Config) ->
-    P = runner:start(?compare_list),
+    P = runner:start(Config, ?compare_list),
     runner:recv_eot(P),
     ok.
 
 compare_string(Config) when is_list(Config) ->
-    P = runner:start(?compare_string),
+    P = runner:start(Config, ?compare_string),
     runner:recv_eot(P),
     ok.
 
 compare_list_string(Config) when is_list(Config) ->
-    P = runner:start(?compare_list_string),
+    P = runner:start(Config, ?compare_list_string),
     runner:recv_eot(P),
     ok.
 
 compare_nc_ext(Config) when is_list(Config) ->
-    P = runner:start(?compare_nc_ext),
+    P = runner:start(Config, ?compare_nc_ext),
     runner:recv_eot(P),
     ok.
diff --git a/lib/erl_interface/test/erl_format_SUITE.erl b/lib/erl_interface/test/erl_format_SUITE.erl
index c1a7d8377e..d984dcb08e 100644
--- a/lib/erl_interface/test/erl_format_SUITE.erl
+++ b/lib/erl_interface/test/erl_format_SUITE.erl
@@ -25,6 +25,7 @@
 -include("erl_format_SUITE_data/format_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          atoms/1, tuples/1, lists/1]).
 
 -import(runner, [get_term/1]).
@@ -38,10 +39,13 @@ suite() ->
 all() -> 
     [atoms, tuples, lists].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
+
 %% Tests formatting various atoms.
 
 atoms(Config) when is_list(Config) ->
-    P = runner:start(?atoms),
+    P = runner:start(Config, ?atoms),
 
     {term, ''} = get_term(P),
     {term, 'a'} = get_term(P),
@@ -79,7 +83,7 @@ atoms(Config) when is_list(Config) ->
 %% Tests formatting various tuples
 
 tuples(Config) when is_list(Config) ->
-    P = runner:start(?tuples),
+    P = runner:start(Config, ?tuples),
 
     {term, {}} = get_term(P),
     {term, {a}} = get_term(P),
@@ -100,7 +104,7 @@ tuples(Config) when is_list(Config) ->
 %% Tests formatting various lists
 
 lists(Config) when is_list(Config) ->
-    P = runner:start(?lists),
+    P = runner:start(Config, ?lists),
 
     {term, []} = get_term(P),
     {term, [a]} = get_term(P),
diff --git a/lib/erl_interface/test/erl_global_SUITE.erl b/lib/erl_interface/test/erl_global_SUITE.erl
index ecc6753c7f..560afd58ba 100644
--- a/lib/erl_interface/test/erl_global_SUITE.erl
+++ b/lib/erl_interface/test/erl_global_SUITE.erl
@@ -25,6 +25,7 @@
 -include("erl_global_SUITE_data/erl_global_test_cases.hrl").
 
 -export([all/0,suite/0,
+         init_per_testcase/2,
          erl_global_registration/1,
          erl_global_whereis/1, erl_global_names/1]).
 
@@ -39,9 +40,11 @@ suite() ->
     [{ct_hooks,[ts_install_cth]},
      {timetrap, {seconds, 30}}].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
 
 erl_global_registration(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     {ok, Fd} = erl_connect(P, node(), 42, erlang:get_cookie(), 0),
 
     ok = erl_global_register(P, Fd, ?GLOBAL_NAME),
@@ -53,7 +56,7 @@ erl_global_registration(Config) when is_list(Config) ->
     ok.
 
 erl_global_whereis(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     {ok, Fd} = erl_connect(P, node(), 42, erlang:get_cookie(), 0),
 
     Self = self(),
@@ -66,7 +69,7 @@ erl_global_whereis(Config) when is_list(Config) ->
     ok.
 
 erl_global_names(Config) when is_list(Config) ->
-    P = runner:start(?interpret),
+    P = runner:start(Config, ?interpret),
     {ok, Fd} = erl_connect(P, node(), 42, erlang:get_cookie(), 0),
 
     Self = self(),
diff --git a/lib/erl_interface/test/erl_match_SUITE.erl b/lib/erl_interface/test/erl_match_SUITE.erl
index 5566714092..f1f6892ae0 100644
--- a/lib/erl_interface/test/erl_match_SUITE.erl
+++ b/lib/erl_interface/test/erl_match_SUITE.erl
@@ -25,6 +25,7 @@
 -include("erl_match_SUITE_data/match_test_cases.hrl").
 
 -export([all/0, suite/0,
+         init_per_testcase/2,
          atoms/1, lists/1, tuples/1, references/1, pids/1, ports/1,
          bind/1, integers/1, floats/1, binaries/1, strings/1]).
 
@@ -40,6 +41,8 @@ all() ->
     [atoms, lists, tuples, references, pids, ports, bind,
      integers, floats, binaries, strings].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
 
 atoms(Config) when is_list(Config) ->
     P = start_matcher(Config),
@@ -239,7 +242,7 @@ bind(Config) when is_list(Config) ->
     ok.
 
 start_bind(Config) ->
-    runner:start(?erl_match_bind).
+    runner:start(Config, ?erl_match_bind).
 
 bind_ok(Port, Bind, Term) ->
     true = erl_bind(Port, Bind, Term).
@@ -258,7 +261,7 @@ erl_bind(Port, Pattern, Term) ->
 
 
 start_matcher(Config) ->
-    runner:start(?erl_match_server).
+    runner:start(Config, ?erl_match_server).
 
 eq(Port, Pattern, Term) ->
     true = erl_match(Port, Pattern, Term).
diff --git a/lib/erl_interface/test/port_call_SUITE.erl b/lib/erl_interface/test/port_call_SUITE.erl
index fb10bd895f..d31b2372ab 100644
--- a/lib/erl_interface/test/port_call_SUITE.erl
+++ b/lib/erl_interface/test/port_call_SUITE.erl
@@ -32,7 +32,9 @@
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 
--export([all/0, suite/0, basic/1]).
+-export([all/0, suite/0,
+         init_per_testcase/2,
+         basic/1]).
 
 % Private exports
 -include_lib("common_test/include/ct.hrl").
@@ -44,6 +46,8 @@ suite() ->
 all() -> 
     [basic].
 
+init_per_testcase(Case, Config) ->
+    runner:init_per_testcase(?MODULE, Case, Config).
 
 basic(Config) when is_list(Config) ->
     case os:type() of
diff --git a/lib/erl_interface/test/runner.erl b/lib/erl_interface/test/runner.erl
index 947e56c4e0..484890006e 100644
--- a/lib/erl_interface/test/runner.erl
+++ b/lib/erl_interface/test/runner.erl
@@ -21,8 +21,9 @@
 %%
 -module(runner).
 
--export([test/1, test/2,
-	 start/1, send_term/2, finish/1, send_eot/1, recv_eot/1,
+-export([test/2, test/3,
+         init_per_testcase/3,
+	 start/2, send_term/2, finish/1, send_eot/1, recv_eot/1,
 	 get_term/1, get_term/2]).
 
 -define(default_timeout, 5000).
@@ -32,11 +33,11 @@
 %% This function is useful for test cases written in C which requires
 %% no further input, and only returns a result by calling report().
 
-test(Tc) ->
-    test(Tc, ?default_timeout).
+test(Config, Tc) ->
+    test(Config, Tc, ?default_timeout).
 
-test(Tc, Timeout) ->
-    Port = start(Tc),
+test(Config, Tc, Timeout) ->
+    Port = start(Config, Tc),
     
     case get_term(Port, Timeout) of
 	eot ->
@@ -54,12 +55,51 @@ test(Tc, Timeout) ->
 %%
 %% Returns: {ok, Port}
 
-start({Prog, Tc}) when is_list(Prog), is_integer(Tc) ->
-    Port = open_port({spawn, Prog}, [{packet, 4}, exit_status]),
+start(Config, {Prog, Tc}) when is_list(Prog), is_integer(Tc) ->
+    Port = open_port({spawn, prog_cmd(Config, Prog)},
+                     [{packet, 4}, exit_status]),
     Command = [Tc div 256, Tc rem 256],
     Port ! {self(), {command, Command}},
     Port.
 
+prog_cmd(Config, Prog) ->
+    case proplists:get_value(valgrind_cmd_fun, Config) of
+        undefined ->
+            Prog;
+        Fun when is_function(Fun) ->
+            Fun(Prog)
+    end.
+
+init_per_testcase(Suite, Case, Config) ->
+    case os:getenv("VALGRIND_LOG_DIR") of
+        false ->
+            Config;
+        LogDir ->
+            Valgrind = case os:find_executable("valgrind") of
+                           false ->
+                               ct:fail("VALGRIND_LOG_DIR set, "
+                                       "but no valgrind executable found");
+                           VG -> VG
+                       end,
+
+            LogFileOpt = case os:getenv("VALGRIND_LOG_XML") of
+                             false ->
+                                 " --log-file=";
+                             "yes" ->
+                                 " --xml=yes --xml-file="
+                         end,
+            Fun = fun(Prog) ->
+                          LogFile = io_lib:format("erl_interface-~w.~w-~s.log.%p",
+                                                  [Suite, Case, filename:basename(Prog)]),
+                          Valgrind
+                              ++ LogFileOpt ++ filename:join(LogDir,LogFile)
+                              ++ " " ++ os:getenv("VALGRIND_MISC_FLAGS","")
+                              ++ " " ++ Prog
+                  end,
+            [{valgrind_cmd_fun, Fun} | Config]
+    end.
+
+
 %% Finishes a test case by send an 'eot' message to the C program
 %% and waiting for an 'eot'.
 %%
-- 
cgit v1.2.3


From bd228591a434bd0a15f5220e66a8bb623b410e2f Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Tue, 10 Jul 2018 13:40:42 +0200
Subject: erts: Remove use of VALGRIND_PRINTF_XML

which only existed in a patched version of valgrind (by pan)
no longer used.

Instead we use standard VALGRIND_PRINTF which will end up like this
if valgrind log format is XML and valgrind version >= 3.9:

<clientmsg>
  <tid>7</tid>
  <threadname>3_scheduler</threadname>
  <text>Test case #20 ei_encode_SUITE:test_ei_encode_long/1
  </text>
</clientmsg>

Note the extra trailing whitespace that may occure before </text>.
---
 erts/emulator/beam/dist.c         | 15 +--------------
 erts/emulator/beam/erl_bif_info.c | 28 +++-------------------------
 2 files changed, 4 insertions(+), 39 deletions(-)

diff --git a/erts/emulator/beam/dist.c b/erts/emulator/beam/dist.c
index db35137e92..61090e2c47 100644
--- a/erts/emulator/beam/dist.c
+++ b/erts/emulator/beam/dist.c
@@ -1200,21 +1200,8 @@ erts_dsig_send_group_leader(ErtsDSigData *dsdp, Eterm leader, Eterm remote)
 #include <valgrind/valgrind.h>
 #include <valgrind/memcheck.h>
 
-#ifndef HAVE_VALGRIND_PRINTF_XML
-#define VALGRIND_PRINTF_XML VALGRIND_PRINTF
-#endif
-
 #  define PURIFY_MSG(msg)                                                    \
-    do {								     \
-	char buf__[1]; size_t bufsz__ = sizeof(buf__);			     \
-	if (erts_sys_explicit_8bit_getenv("VALGRIND_LOG_XML", buf__, &bufsz__) != 0) { \
-	    VALGRIND_PRINTF_XML("<erlang_error_log>"			     \
-			    "%s, line %d: %s</erlang_error_log>\n",	     \
-			    __FILE__, __LINE__, msg);			     \
-	} else {							     \
-	    VALGRIND_PRINTF("%s, line %d: %s", __FILE__, __LINE__, msg);     \
-	}								     \
-    } while (0)
+    VALGRIND_PRINTF("%s, line %d: %s", __FILE__, __LINE__, msg)
 #else
 #  define PURIFY_MSG(msg)
 #endif
diff --git a/erts/emulator/beam/erl_bif_info.c b/erts/emulator/beam/erl_bif_info.c
index 39442e52c6..7fada0d548 100644
--- a/erts/emulator/beam/erl_bif_info.c
+++ b/erts/emulator/beam/erl_bif_info.c
@@ -2093,17 +2093,6 @@ current_stacktrace(ErtsHeapFactory *hfact, Process* rp,
     return res;
 }
 
-#if defined(VALGRIND)
-static int check_if_xml(void)
-{
-    char buf[1];
-    size_t bufsz = sizeof(buf);
-    return erts_sys_explicit_8bit_getenv("VALGRIND_LOG_XML", buf, &bufsz) != 0;
-}
-#else
-#define check_if_xml() 0
-#endif
-
 /*
  * This function takes care of calls to erlang:system_info/1 when the argument
  * is a tuple.
@@ -2200,15 +2189,9 @@ info_1_tuple(Process* BIF_P,	/* Pointer to current process. */
 #endif
 	} else if (is_list(*tp)) {
 #if defined(PURIFY)
-#define ERTS_ERROR_CHECKER_PRINTF purify_printf
-#define ERTS_ERROR_CHECKER_PRINTF_XML purify_printf
+#  define ERTS_ERROR_CHECKER_PRINTF purify_printf
 #elif defined(VALGRIND)
-#define ERTS_ERROR_CHECKER_PRINTF VALGRIND_PRINTF
-#  ifndef HAVE_VALGRIND_PRINTF_XML
-#    define ERTS_ERROR_CHECKER_PRINTF_XML VALGRIND_PRINTF
-#  else
-#    define ERTS_ERROR_CHECKER_PRINTF_XML VALGRIND_PRINTF_XML
-#  endif
+#  define ERTS_ERROR_CHECKER_PRINTF VALGRIND_PRINTF
 #endif
 	    ErlDrvSizeT buf_size = 8*1024; /* Try with 8KB first */
 	    char *buf = erts_alloc(ERTS_ALC_T_TMP, buf_size);
@@ -2224,12 +2207,7 @@ info_1_tuple(Process* BIF_P,	/* Pointer to current process. */
 		ASSERT(r == buf_size - 1);
 	    }
 	    buf[buf_size - 1 - r] = '\0';
-	    if (check_if_xml()) {
-		ERTS_ERROR_CHECKER_PRINTF_XML("<erlang_info_log>"
-					      "%s</erlang_info_log>\n", buf);
-	    } else {
-		ERTS_ERROR_CHECKER_PRINTF("%s\n", buf);
-	    }
+            ERTS_ERROR_CHECKER_PRINTF("%s\n", buf);
 	    erts_free(ERTS_ALC_T_TMP, (void *) buf);
 	    BIF_RET(am_true);
 #undef ERTS_ERROR_CHECKER_PRINTF
-- 
cgit v1.2.3


From e4d7df2f1e2eba5d5a87b9a57b983cf2e3ea7b25 Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Tue, 3 Jul 2018 20:33:13 +0200
Subject: erl_interface: Initialize erl_errno to zero

Makes valgrind happy.
---
 lib/erl_interface/src/misc/ei_pthreads.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/erl_interface/src/misc/ei_pthreads.c b/lib/erl_interface/src/misc/ei_pthreads.c
index 25608edeec..8b34364659 100644
--- a/lib/erl_interface/src/misc/ei_pthreads.c
+++ b/lib/erl_interface/src/misc/ei_pthreads.c
@@ -206,6 +206,7 @@ volatile int *__erl_errno_place(void)
 	use_fallback = 1;
 	return &fallback_errno;
     }
+    *erl_errno_p = 0;
 
     if (pthread_setspecific(erl_errno_key, erl_errno_p) != 0 ||
 	(erl_errno_p = pthread_getspecific(erl_errno_key)) == NULL) {
-- 
cgit v1.2.3


From 00a2f00485e88cda594361e271f90e5432edc275 Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Wed, 4 Jul 2018 17:26:20 +0200
Subject: erl_interface: Seal test case memory leaks

to appease valgrind.
---
 lib/erl_interface/test/ei_accept_SUITE_data/ei_accept_test.c | 11 ++++-------
 .../test/ei_connect_SUITE_data/ei_connect_test.c             | 12 +++++-------
 lib/erl_interface/test/ei_decode_SUITE_data/ei_decode_test.c |  5 +++++
 .../test/ei_decode_encode_SUITE_data/ei_decode_encode_test.c |  1 +
 4 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/lib/erl_interface/test/ei_accept_SUITE_data/ei_accept_test.c b/lib/erl_interface/test/ei_accept_SUITE_data/ei_accept_test.c
index 04bba90732..50df848b69 100644
--- a/lib/erl_interface/test/ei_accept_SUITE_data/ei_accept_test.c
+++ b/lib/erl_interface/test/ei_accept_SUITE_data/ei_accept_test.c
@@ -75,11 +75,7 @@ TESTCASE(interpret)
     ei_term term;
 
     ei_x_new(&x);
-    for (;;) {
-	if (get_bin_term(&x, &term)) {
-	    report(1);
-	    return;
-	} else {
+    while (get_bin_term(&x, &term) == 0) {
 	    char* buf = x.buff, func[MAXATOMLEN];
 	    int index = x.index, arity;
 	    if (term.ei_type != ERL_SMALL_TUPLE_EXT || term.arity != 2)
@@ -100,8 +96,9 @@ TESTCASE(interpret)
 		message("\"%d\" \n", func);
 		fail("bad command");
 	    }
-	}
-    }	
+    }
+    report(1);
+    ei_x_free(&x);
 }
 
 static void cmd_ei_connect_init(char* buf, int len)
diff --git a/lib/erl_interface/test/ei_connect_SUITE_data/ei_connect_test.c b/lib/erl_interface/test/ei_connect_SUITE_data/ei_connect_test.c
index 6a3796dd24..fbd86cdb50 100644
--- a/lib/erl_interface/test/ei_connect_SUITE_data/ei_connect_test.c
+++ b/lib/erl_interface/test/ei_connect_SUITE_data/ei_connect_test.c
@@ -74,11 +74,7 @@ TESTCASE(interpret)
     ei_term term;
 
     ei_x_new(&x);
-    for (;;) {
-	if (get_bin_term(&x, &term)) {
-	    report(1);
-	    return;
-	} else {
+    while (get_bin_term(&x, &term) == 0) {
 	    char* buf = x.buff, func[MAXATOMLEN];
 	    int index = x.index, arity;
 	    if (term.ei_type != ERL_SMALL_TUPLE_EXT || term.arity != 2)
@@ -99,8 +95,10 @@ TESTCASE(interpret)
 		message("\"%d\" \n", func);
 		fail("bad command");
 	    }
-	}
-    }	
+    }
+    report(1);
+    ei_x_free(&x);
+    return;
 }
 
 
diff --git a/lib/erl_interface/test/ei_decode_SUITE_data/ei_decode_test.c b/lib/erl_interface/test/ei_decode_SUITE_data/ei_decode_test.c
index b7a2c4bb8b..5a9be1e9a2 100644
--- a/lib/erl_interface/test/ei_decode_SUITE_data/ei_decode_test.c
+++ b/lib/erl_interface/test/ei_decode_SUITE_data/ei_decode_test.c
@@ -105,6 +105,7 @@ int ei_decode_my_string(const char *buf, int *index, char *to,
         fail1("size of encoded data (%d) is incorrect", size1);    \
       return; \
     } \
+    free_packet(buf); \
   } \
 
 #define EI_DECODE_2_FAIL(FUNC,SIZE,TYPE,VAL) \
@@ -148,6 +149,7 @@ int ei_decode_my_string(const char *buf, int *index, char *to,
       fail("size of encoded data should be 0"); \
       return; \
     } \
+    free_packet(buf); \
   } \
 
 #define dump(arr, num) {	    \
@@ -205,6 +207,7 @@ int ei_decode_my_string(const char *buf, int *index, char *to,
       fail("size of encoded data is incorrect"); \
       return; \
     } \
+    free_packet(buf); \
   } \
 
 #define EI_DECODE_STRING(FUNC,SIZE,VAL) \
@@ -248,6 +251,7 @@ int ei_decode_my_string(const char *buf, int *index, char *to,
       fail("size of encoded data should be 0"); \
       return; \
     } \
+    free_packet(buf); \
   } \
 
 //#define EI_DECODE_UTF8_STRING(FUNC,SIZE,VAL) 
@@ -310,6 +314,7 @@ int ei_decode_my_string(const char *buf, int *index, char *to,
       fail("size of encoded data is incorrect"); \
       return; \
     } \
+    free_packet(buf); \
   } \
 
 /* ******************************************************************** */
diff --git a/lib/erl_interface/test/ei_decode_encode_SUITE_data/ei_decode_encode_test.c b/lib/erl_interface/test/ei_decode_encode_SUITE_data/ei_decode_encode_test.c
index 467f789fdb..6285b5e199 100644
--- a/lib/erl_interface/test/ei_decode_encode_SUITE_data/ei_decode_encode_test.c
+++ b/lib/erl_interface/test/ei_decode_encode_SUITE_data/ei_decode_encode_test.c
@@ -466,6 +466,7 @@ void decode_encode_big(struct Type* t)
     send_buffer(arg.buff, arg.index);
     ei_x_free(&arg);
     ei_free_big(p);
+    free_packet(buf);
 }
 
 
-- 
cgit v1.2.3


From 2be45ea245e52e852a35fec9c5b53a1c55d546ff Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Tue, 3 Jul 2018 20:35:54 +0200
Subject: erl_interface: Fix bug in ei_*receive_msg* functions

---
 lib/erl_interface/src/connect/ei_connect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/erl_interface/src/connect/ei_connect.c b/lib/erl_interface/src/connect/ei_connect.c
index 34f4620866..fe5f38419e 100644
--- a/lib/erl_interface/src/connect/ei_connect.c
+++ b/lib/erl_interface/src/connect/ei_connect.c
@@ -999,7 +999,7 @@ int ei_do_receive_msg(int fd, int staticbuffer_p,
 	erl_errno = EMSGSIZE;
 	return ERL_ERROR;
     }
-    x->index = x->buffsz;
+    x->index = msglen;
     switch (msg->msgtype) {	/* FIXME does not handle trace tokens and monitors */
     case ERL_SEND:
     case ERL_REG_SEND:
-- 
cgit v1.2.3