From ddbf02af2391710921a73c2144a4c9f0a369a35c Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Thu, 5 Oct 2017 16:13:02 +0200
Subject: ssl: Use new string functions

The functions are not performance critical. Will be used
when errors occurs, CRL data base is managed or legacy OpenSSL names
are used for ciphers.
---
 lib/ssl/src/ssl.erl           | 2 +-
 lib/ssl/src/ssl_alert.erl     | 6 +++---
 lib/ssl/src/ssl_crl_cache.erl | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/ssl/src/ssl.erl b/lib/ssl/src/ssl.erl
index 4e592c02ec..62da498e76 100644
--- a/lib/ssl/src/ssl.erl
+++ b/lib/ssl/src/ssl.erl
@@ -1205,7 +1205,7 @@ binary_cipher_suites(Version, [Head | _] = Ciphers0) when is_list(Head) ->
     binary_cipher_suites(Version, Ciphers);
 binary_cipher_suites(Version, Ciphers0)  ->
     %% Format: "RC4-SHA:RC4-MD5"
-    Ciphers = [ssl_cipher:openssl_suite(C) || C <- string:tokens(Ciphers0, ":")],
+    Ciphers = [ssl_cipher:openssl_suite(C) || C <- string:lexemes(Ciphers0, ":")],
     binary_cipher_suites(Version, Ciphers).
 
 handle_eccs_option(Value, Version) when is_list(Value) ->
diff --git a/lib/ssl/src/ssl_alert.erl b/lib/ssl/src/ssl_alert.erl
index db415a3666..95ab955ad0 100644
--- a/lib/ssl/src/ssl_alert.erl
+++ b/lib/ssl/src/ssl_alert.erl
@@ -57,7 +57,7 @@ decode(Bin) ->
 reason_code(#alert{description = ?CLOSE_NOTIFY}, _) ->
     closed;
 reason_code(#alert{description = Description}, _) ->
-    {tls_alert, string:to_lower(description_txt(Description))}.
+    {tls_alert, string:casefold(description_txt(Description))}.
 
 %%--------------------------------------------------------------------
 -spec own_alert_txt(#alert{}) -> string().
@@ -66,7 +66,7 @@ reason_code(#alert{description = Description}, _) ->
 %% by the erlang implementation.
 %%--------------------------------------------------------------------
 own_alert_txt(#alert{level = Level, description = Description, where = {Mod,Line}, reason = undefined, role = Role}) ->
-    "at " ++ Mod ++ ":" ++ integer_to_list(Line) ++ " generated " ++ string:to_upper(atom_to_list(Role)) ++ " ALERT: " ++
+    "at " ++ Mod ++ ":" ++ integer_to_list(Line) ++ " generated " ++ string:uppercase(atom_to_list(Role)) ++ " ALERT: " ++
         level_txt(Level) ++ description_txt(Description);
 own_alert_txt(#alert{reason = Reason} = Alert) ->
     BaseTxt = own_alert_txt(Alert#alert{reason = undefined}),
@@ -81,7 +81,7 @@ own_alert_txt(#alert{reason = Reason} = Alert) ->
 %% the peer. 
 %%--------------------------------------------------------------------
 alert_txt(#alert{level = Level, description = Description, reason = undefined, role = Role}) ->
-    "received " ++ string:to_upper(atom_to_list(Role)) ++ " ALERT: " ++
+    "received " ++ string:uppercase(atom_to_list(Role)) ++ " ALERT: " ++
         level_txt(Level) ++ description_txt(Description);
 alert_txt(#alert{reason = Reason} = Alert) ->
     BaseTxt = alert_txt(Alert#alert{reason = undefined}),
diff --git a/lib/ssl/src/ssl_crl_cache.erl b/lib/ssl/src/ssl_crl_cache.erl
index 86c0207515..8817b0c884 100644
--- a/lib/ssl/src/ssl_crl_cache.erl
+++ b/lib/ssl/src/ssl_crl_cache.erl
@@ -94,7 +94,7 @@ delete({der, CRLs}) ->
 delete(URI) ->
     case http_uri:parse(URI) of
 	{ok, {http, _, _ , _, Path,_}} -> 
-	    ssl_manager:delete_crls(string:strip(Path, left, $/));
+	    ssl_manager:delete_crls(string:trim(Path, leading, "/"));
 	_ ->
 	    {error, {only_http_distribution_points_supported, URI}}
     end.
@@ -105,7 +105,7 @@ delete(URI) ->
 do_insert(URI, CRLs) ->
     case http_uri:parse(URI) of
 	{ok, {http, _, _ , _, Path,_}} -> 
-	    ssl_manager:insert_crls(string:strip(Path, left, $/), CRLs);
+	    ssl_manager:insert_crls(string:trim(Path, leading, "/"), CRLs);
 	_ ->
 	    {error, {only_http_distribution_points_supported, URI}}
     end.
@@ -162,7 +162,7 @@ cache_lookup(_, undefined) ->
     [];
 cache_lookup(URL, {{Cache, _}, _}) ->
     {ok, {_, _, _ , _, Path,_}} = http_uri:parse(URL), 
-    case ssl_pkix_db:lookup(string:strip(Path, left, $/), Cache) of
+    case ssl_pkix_db:lookup(string:trim(Path, leading, "/"), Cache) of
 	undefined ->
 	    [];
 	CRLs ->
-- 
cgit v1.2.3