From 60a6858785f49357757691956295dbcb304c0508 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Mon, 31 Aug 2015 12:36:36 +0200
Subject: compile_SUITE: Add test of warnings

Make sure that all warnings produced when compiling the
test suite contains filenames and line numbers.
---
 lib/compiler/test/compile_SUITE.erl | 44 +++++++++++++++++++++++++++++++++++--
 1 file changed, 42 insertions(+), 2 deletions(-)

diff --git a/lib/compiler/test/compile_SUITE.erl b/lib/compiler/test/compile_SUITE.erl
index df401ccc2b..cbdd9ce8cd 100644
--- a/lib/compiler/test/compile_SUITE.erl
+++ b/lib/compiler/test/compile_SUITE.erl
@@ -31,7 +31,9 @@
 	 other_output/1, encrypted_abstr/1,
 	 bad_record_use1/1, bad_record_use2/1, strict_record/1,
 	 missing_testheap/1, cover/1, env/1, core/1, asm/1,
-	 sys_pre_attributes/1, dialyzer/1]).
+	 sys_pre_attributes/1, dialyzer/1,
+	 warnings/1
+	]).
 
 -export([init/3]).
 
@@ -48,7 +50,7 @@ all() ->
      other_output, encrypted_abstr,
      {group, bad_record_use}, strict_record,
      missing_testheap, cover, env, core, asm,
-     sys_pre_attributes, dialyzer].
+     sys_pre_attributes, dialyzer, warnings].
 
 groups() -> 
     [{bad_record_use, [],
@@ -895,6 +897,44 @@ dialyzer(Config) ->
     [{a,b,c}] = M:M(),
     ok.
 
+
+%% Test that warnings contain filenames and line numbers.
+warnings(_Config) ->
+    TestDir = filename:dirname(code:which(?MODULE)),
+    Files = filelib:wildcard(filename:join(TestDir, "*.erl")),
+    test_lib:p_run(fun do_warnings/1, Files).
+
+do_warnings(F) ->
+    {ok,_,_,Ws} = compile:file(F, [binary,bin_opt_info,return]),
+    do_warnings_1(Ws, F).
+
+do_warnings_1([{"no_file",Ws}|_], F) ->
+    io:format("~s:\nMissing file for warnings: ~p\n",
+	      [F,Ws]),
+    error;
+do_warnings_1([{Name,Ws}|T], F) ->
+    case filename:extension(Name) of
+	".erl" ->
+	    do_warnings_2(Ws, T, F);
+	_ ->
+	    io:format("~s:\nNo .erl extension\n", [F]),
+	    error
+    end;
+do_warnings_1([], _) -> ok.
+
+do_warnings_2([{Int,_,_}=W|T], Next, F) ->
+    if
+	is_integer(Int) ->
+	    do_warnings_2(T, Next, F);
+	true ->
+	    io:format("~s:\nMissing line number: ~p\n",
+		      [F,W]),
+	    error
+    end;
+do_warnings_2([], Next, F) ->
+    do_warnings_1(Next, F).
+
+
 %%%
 %%% Utilities.
 %%%
-- 
cgit v1.2.3


From 05a9fe4e1176388c761ca7be9321608c3ba48810 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 1 Sep 2015 08:31:25 +0200
Subject: io_SUITE: Eliminate warnings for unused variables

---
 lib/stdlib/test/io_SUITE.erl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/io_SUITE.erl b/lib/stdlib/test/io_SUITE.erl
index 5df09b6a79..9147ec4548 100644
--- a/lib/stdlib/test/io_SUITE.erl
+++ b/lib/stdlib/test/io_SUITE.erl
@@ -2225,7 +2225,7 @@ compile_file(File, Text, Config) ->
     after ok %file:delete(Fname)
     end.
 
-io_lib_width_too_small(Config) ->
+io_lib_width_too_small(_Config) ->
     "**" = lists:flatten(io_lib:format("~2.3w", [3.14])),
     "**" = lists:flatten(io_lib:format("~2.5w", [3.14])),
     ok.
@@ -2271,7 +2271,7 @@ writes(N, F1) ->
     file:write(F1, "hello\n"),
     writes(N - 1, F1).
 
-format_string(Config) ->
+format_string(_Config) ->
     %% All but padding is tested by fmt/2.
     "xxxxxxsssx" = fmt("~10.4.xs", ["sss"]),
     "xxxxxxsssx" = fmt("~10.4.*s", [$x, "sss"]),
-- 
cgit v1.2.3


From 9ca2503cbbc7247108278ff2f5b9fe2b37450833 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 1 Sep 2015 08:45:28 +0200
Subject: io_SUITE: Add test for printing of maps

---
 lib/stdlib/test/io_SUITE.erl | 99 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 97 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/io_SUITE.erl b/lib/stdlib/test/io_SUITE.erl
index 9147ec4548..a290674524 100644
--- a/lib/stdlib/test/io_SUITE.erl
+++ b/lib/stdlib/test/io_SUITE.erl
@@ -32,7 +32,8 @@
 	 printable_range/1,
 	 io_lib_print_binary_depth_one/1, otp_10302/1, otp_10755/1,
          otp_10836/1, io_lib_width_too_small/1,
-         io_with_huge_message_queue/1, format_string/1]).
+         io_with_huge_message_queue/1, format_string/1,
+	 maps/1]).
 
 -export([pretty/2]).
 
@@ -73,7 +74,7 @@ all() ->
      printable_range,
      io_lib_print_binary_depth_one, otp_10302, otp_10755, otp_10836,
      io_lib_width_too_small, io_with_huge_message_queue,
-     format_string].
+     format_string, maps].
 
 groups() -> 
     [].
@@ -2276,3 +2277,97 @@ format_string(_Config) ->
     "xxxxxxsssx" = fmt("~10.4.xs", ["sss"]),
     "xxxxxxsssx" = fmt("~10.4.*s", [$x, "sss"]),
     ok.
+
+maps(_Config) ->
+    %% Note that order in which a map is printed is arbitrary.  In
+    %% practice, small maps (non-HAMT) are printed in key order, but
+    %% the breakpoint for creating big maps (HAMT) is lower in the
+    %% debug-compiled run-time system than in the optimized run-time
+    %% system.
+    %%
+    %% Therefore, play it completely safe by not assuming any order
+    %% in a map with more than one element.
+
+    "#{}" = fmt("~w", [#{}]),
+    "#{a=>b}" = fmt("~w", [#{a=>b}]),
+    re_fmt(<<"#\\{(a=>b|c=>d),[.][.][.]=>[.][.][.]\\}">>,
+	     "~W", [#{a=>b,c=>d},2]),
+    re_fmt(<<"#\\{(a=>b|c=>d|e=>f),[.][.][.]=>[.][.][.],[.][.][.]\\}">>,
+	   "~W", [#{a=>b,c=>d,e=>f},2]),
+
+    "#{}" = fmt("~p", [#{}]),
+    "#{a => b}" = fmt("~p", [#{a=>b}]),
+    "#{...}" = fmt("~P", [#{a=>b},1]),
+    re_fmt(<<"#\\{(a => b|c => d),[.][.][.]\\}">>,
+	   "~P", [#{a=>b,c=>d},2]),
+    re_fmt(<<"#\\{(a => b|c => d|e => f),[.][.][.]\\}">>,
+	   "~P", [#{a=>b,c=>d,e=>f},2]),
+
+    List = [{I,I*I} || I <- lists:seq(1, 20)],
+    Map = maps:from_list(List),
+
+    "#{...}" = fmt("~P", [Map,1]),
+
+    %% Print a map and parse it back to a map.
+    S = fmt("~p\n", [Map]),
+    io:format("~p\n", [S]),
+    Map = parse_map(S),
+
+    %% Smoke test of a map as key.
+    MapAsKey = #{Map => "value"},
+    io:format("~s\n", [fmt("~p", [MapAsKey])]),
+    ok.
+
+re_fmt(Pattern, Format, Args) ->
+    S = list_to_binary(fmt(Format, Args)),
+    case re:run(S, Pattern, [{capture,none}]) of
+	nomatch ->
+	    io:format("Pattern: ~s", [Pattern]),
+	    io:format("Result:  ~s", [S]),
+	    ?t:fail();
+	match ->
+	    ok
+    end.
+
+%% Parse a map consisting of integer keys and values.
+parse_map(S0) ->
+    S1 = parse_expect(S0, "#{"),
+    {M,S2} = parse_map_1(S1),
+    S = parse_expect(S2, "}"),
+    S = "",
+    M.
+
+parse_map_1(S0) ->
+    {Key,S1} = parse_number(S0),
+    S2 = parse_expect(S1, "=>"),
+    {Val,S3} = parse_number(S2),
+    case S3 of
+	","++S4 ->
+	    S5 = parse_skip_ws(S4),
+	    {Map,S} = parse_map_1(S5),
+	    {Map#{Key=>Val},S};
+	S ->
+	    {#{Key=>Val},S}
+    end.
+
+parse_number(S) ->
+    parse_number(S, none).
+
+parse_number([C|S], Acc0) when $0 =< C, C =< $9 ->
+    Acc = case Acc0 of
+	      none -> 0;
+	      _ when is_integer(Acc0) -> Acc0
+	  end,
+    parse_number(S, Acc*10+C-$0);
+parse_number(S, Acc) ->
+    {Acc,parse_skip_ws(S)}.
+
+parse_expect([H|T1], [H|T2]) ->
+    parse_expect(T1, T2);
+parse_expect(S, []) ->
+    parse_skip_ws(S).
+
+parse_skip_ws([C|S]) when C =< $\s ->
+    parse_skip_ws(S);
+parse_skip_ws(S) ->
+    S.
-- 
cgit v1.2.3


From 9d0f9ed8b6a055e069e26f77622985cd434378f9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 1 Sep 2015 09:52:07 +0200
Subject: io_SUITE: Speed up test for bad +pc option

Move the test for a bad +pc option to its own test case for
cleanliness. Use the os:cmd/1 function to avoid the annyoying
30 seconds time-out in test_server:start_node/3.
---
 lib/stdlib/test/io_SUITE.erl | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/lib/stdlib/test/io_SUITE.erl b/lib/stdlib/test/io_SUITE.erl
index a290674524..8a6b2725af 100644
--- a/lib/stdlib/test/io_SUITE.erl
+++ b/lib/stdlib/test/io_SUITE.erl
@@ -29,7 +29,7 @@
          manpage/1, otp_6708/1, otp_7084/1, otp_7421/1,
 	 io_lib_collect_line_3_wb/1, cr_whitespace_in_string/1,
 	 io_fread_newlines/1, otp_8989/1, io_lib_fread_literal/1,
-	 printable_range/1,
+	 printable_range/1, bad_printable_range/1,
 	 io_lib_print_binary_depth_one/1, otp_10302/1, otp_10755/1,
          otp_10836/1, io_lib_width_too_small/1,
          io_with_huge_message_queue/1, format_string/1,
@@ -71,7 +71,7 @@ all() ->
      manpage, otp_6708, otp_7084, otp_7421,
      io_lib_collect_line_3_wb, cr_whitespace_in_string,
      io_fread_newlines, otp_8989, io_lib_fread_literal,
-     printable_range,
+     printable_range, bad_printable_range,
      io_lib_print_binary_depth_one, otp_10302, otp_10755, otp_10836,
      io_lib_width_too_small, io_with_huge_message_queue,
      format_string, maps].
@@ -2063,8 +2063,6 @@ printable_range(Suite) when is_list(Suite) ->
 					 [{args, " +pclatin1 -pa " ++ Pa}]),
     unicode = rpc:call(UNode,io,printable_range,[]),
     latin1 = rpc:call(LNode,io,printable_range,[]),
-    {error, _} = test_server:start_node(printable_range_unnicode, slave,
-					[{args, " +pcunnicode -pa " ++ Pa}]),
     PrettyOptions = [{column,1},
 		     {line_length,109},
 		     {depth,30},
@@ -2114,6 +2112,17 @@ printable_range(Suite) when is_list(Suite) ->
     test_server:stop_node(DNode),
     ok.
 
+%% Make sure that a bad specification for a printable range is rejected.
+bad_printable_range(Config) when is_list(Config) ->
+    Cmd = lists:concat([lib:progname()," +pcunnnnnicode -run erlang halt"]),
+    case os:cmd(Cmd) of
+	"bad range of printable characters" ++ _ ->
+	    ok;
+	String ->
+	    io:format("~s\n", [String]),
+	    ?t:fail()
+    end.
+
 io_lib_print_binary_depth_one(doc) ->
     "Test binaries printed with a depth of one behave correctly";
 io_lib_print_binary_depth_one(Suite) when is_list(Suite) ->
-- 
cgit v1.2.3


From 3213c682e47f151283697a7a00f38bf2fbee670f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 1 Sep 2015 11:00:42 +0200
Subject: io_SUITE: Extend coverage of code for testing printable chars

---
 lib/stdlib/test/io_SUITE.erl | 82 +++++++++++++++++++++++++-------------------
 1 file changed, 46 insertions(+), 36 deletions(-)

diff --git a/lib/stdlib/test/io_SUITE.erl b/lib/stdlib/test/io_SUITE.erl
index 8a6b2725af..6e7e1584d9 100644
--- a/lib/stdlib/test/io_SUITE.erl
+++ b/lib/stdlib/test/io_SUITE.erl
@@ -2070,48 +2070,58 @@ printable_range(Suite) when is_list(Suite) ->
 		     {record_print_fun,
 		      fun(_,_) -> no end},
 		     {encoding,unicode}],
-    1025 = lists:max(lists:flatten(rpc:call(UNode,io_lib_pretty,print,
-					    [{hello, [1024,1025]},
-					     PrettyOptions]))),
-    125 = lists:max(lists:flatten(rpc:call(LNode,io_lib_pretty,print,
-					   [{hello, [1024,1025]},
-					    PrettyOptions]))),
-    125 = lists:max(lists:flatten(rpc:call(DNode,io_lib_pretty,print,
-					   [{hello, [1024,1025]},
-					    PrettyOptions]))),
-    1025 = lists:max(lists:flatten(rpc:call(UNode,io_lib_pretty,print,
-					    [{hello, <<1024/utf8,1025/utf8>>},
-					     PrettyOptions]))),
-    125 = lists:max(lists:flatten(rpc:call(LNode,io_lib_pretty,print,
-					   [{hello, <<1024/utf8,1025/utf8>>},
-					    PrettyOptions]))),
-    125 = lists:max(lists:flatten(rpc:call(DNode,io_lib_pretty,print,
-					   [{hello, <<1024/utf8,1025/utf8>>},
-					    PrettyOptions]))),
+    PrintableControls = "\t\v\b\f\e\r\n",
+
+    1025 = print_max(UNode, [{hello, [1024,1025]},
+			     PrettyOptions]),
+    125 = print_max(LNode,  [{hello, [1024,1025]},
+			     PrettyOptions]),
+    125 = print_max(DNode,  [{hello, [1024,1025]},
+			     PrettyOptions]),
+    1025 = print_max(UNode, [{hello, <<1024/utf8,1025/utf8>>},
+			     PrettyOptions]),
+    125 = print_max(LNode,  [{hello, <<1024/utf8,1025/utf8>>},
+			     PrettyOptions]),
+    125 = print_max(DNode,  [{hello, <<1024/utf8,1025/utf8>>},
+			     PrettyOptions]),
+    $v = print_max(UNode, [PrintableControls,PrettyOptions]),
+    $v = print_max(LNode, [PrintableControls,PrettyOptions]),
+    $v = print_max(DNode, [PrintableControls,PrettyOptions]),
+    16#10FFFF = print_max(UNode,
+			  [<<16#10FFFF/utf8,"\t\v\b\f\e\r\n">>,
+			   PrettyOptions]),
+    $> = print_max(LNode,
+		   [<<16#10FFFF/utf8,"\t\v\b\f\e\r\n">>,
+		    PrettyOptions]),
+    $> = print_max(DNode,
+		   [<<16#10FFFF/utf8,"\t\v\b\f\e\r\n">>,
+		    PrettyOptions]),
     
-    1025 = lists:max(lists:flatten(rpc:call(UNode,io_lib,format,
-					    ["~tp",[{hello, [1024,1025]}]]))),
-    125 = lists:max(lists:flatten(rpc:call(LNode,io_lib,format,
-					   ["~tp",[{hello, [1024,1025]}]]))),
-    125 = lists:max(lists:flatten(rpc:call(DNode,io_lib,format,
-					   ["~tp",[{hello, [1024,1025]}]]))),
-    1025 = lists:max(lists:flatten(rpc:call(UNode,io_lib,format,
-					    ["~tp",
-					     [{hello, 
-					       <<1024/utf8,1025/utf8>>}]]))),
-    125 = lists:max(lists:flatten(rpc:call(LNode,io_lib,format,
-					   ["~tp",
-					    [{hello,
-					      <<1024/utf8,1025/utf8>>}]]))),
-    125 = lists:max(lists:flatten(rpc:call(DNode,io_lib,format,
-					   ["~tp",
-					    [{hello,
-					      <<1024/utf8,1025/utf8>>}]]))),
+    1025 = format_max(UNode, ["~tp", [{hello, [1024,1025]}]]),
+    125 = format_max(LNode,  ["~tp", [{hello, [1024,1025]}]]),
+    125 = format_max(DNode,  ["~tp", [{hello, [1024,1025]}]]),
+    1025 = format_max(UNode, ["~tp", [{hello, <<1024/utf8,1025/utf8>>}]]),
+    125 = format_max(LNode,  ["~tp", [{hello, <<1024/utf8,1025/utf8>>}]]),
+    125 = format_max(DNode,  ["~tp", [{hello, <<1024/utf8,1025/utf8>>}]]),
+
+    $\e = format_max(UNode, ["~ts", [PrintableControls]]),
+    $\e = format_max(LNode, ["~ts", [PrintableControls]]),
+    $\e = format_max(DNode, ["~ts", [PrintableControls]]),
+
     test_server:stop_node(UNode),
     test_server:stop_node(LNode),
     test_server:stop_node(DNode),
     ok.
 
+print_max(Node, Args) ->
+    rpc_call_max(Node, io_lib_pretty, print, Args).
+
+format_max(Node, Args) ->
+    rpc_call_max(Node, io_lib, format, Args).
+
+rpc_call_max(Node, M, F, Args) ->
+    lists:max(lists:flatten(rpc:call(Node, M, F, Args))).
+
 %% Make sure that a bad specification for a printable range is rejected.
 bad_printable_range(Config) when is_list(Config) ->
     Cmd = lists:concat([lib:progname()," +pcunnnnnicode -run erlang halt"]),
-- 
cgit v1.2.3


From 25e79a057a6839287271fc7a04a03f7e6f04652d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 08:43:04 +0200
Subject: io_SUITE: Add coverage/1 to completely cover io_lib_pretty

---
 lib/stdlib/test/io_SUITE.erl | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/io_SUITE.erl b/lib/stdlib/test/io_SUITE.erl
index 6e7e1584d9..0e897631ff 100644
--- a/lib/stdlib/test/io_SUITE.erl
+++ b/lib/stdlib/test/io_SUITE.erl
@@ -33,7 +33,7 @@
 	 io_lib_print_binary_depth_one/1, otp_10302/1, otp_10755/1,
          otp_10836/1, io_lib_width_too_small/1,
          io_with_huge_message_queue/1, format_string/1,
-	 maps/1]).
+	 maps/1, coverage/1]).
 
 -export([pretty/2]).
 
@@ -74,7 +74,7 @@ all() ->
      printable_range, bad_printable_range,
      io_lib_print_binary_depth_one, otp_10302, otp_10755, otp_10836,
      io_lib_width_too_small, io_with_huge_message_queue,
-     format_string, maps].
+     format_string, maps, coverage].
 
 groups() -> 
     [].
@@ -2390,3 +2390,14 @@ parse_skip_ws([C|S]) when C =< $\s ->
     parse_skip_ws(S);
 parse_skip_ws(S) ->
     S.
+
+%% Cover the last uncovered lines for completeness.
+coverage(_Config) ->
+    S1 = io_lib_pretty:print({a,term}, fun(_, _) -> no end),
+    io:format("~s\n", [S1]),
+
+    %% The tuple of arity three will be ignored.
+    S2 = io_lib_pretty:print(lists:seq(1, 100), [{depth,1,1}]),
+    io:format("~s\n", [S2]),
+
+    ok.
-- 
cgit v1.2.3


From bd0b4805862c722807765396711d3e1e7ccbbd57 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Wed, 2 Sep 2015 15:58:33 +0200
Subject: proc_lib_SUITE: Eliminate compiler warnings

Use error/1 instead of forcing a badmatch.
---
 lib/stdlib/test/proc_lib_SUITE.erl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/proc_lib_SUITE.erl b/lib/stdlib/test/proc_lib_SUITE.erl
index 3a8fa74d36..857cd3f88d 100644
--- a/lib/stdlib/test/proc_lib_SUITE.erl
+++ b/lib/stdlib/test/proc_lib_SUITE.erl
@@ -369,7 +369,7 @@ init_dont_hang(Config) when is_list(Config) ->
     end.
 
 init_dont_hang_init(_Parent) ->
-    1 = 2.
+    error(bad_init).
 
 %% Test proc_lib:stop/1,3
 stop(_Config) ->
@@ -453,7 +453,7 @@ stop(_Config) ->
     ok.
 
 system_terminate(crash,_Parent,_Deb,_State) ->
-    1 = 2;
+    error({badmatch,2});
 system_terminate(Reason,_Parent,_Deb,_State) ->
     exit(Reason).
 
-- 
cgit v1.2.3


From ee12ac8b4134fad989a8fa3cfb58e8ec90002665 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Wed, 2 Sep 2015 16:29:46 +0200
Subject: proc_lib: Improve coverage for crash/1

First refactor the entire test case using helper functions
to facilitate further maintenance. Then test that proc_lib
can handle that the process dictionary has been erased
(that will cover more code in proc_lib).

We can also shave off 2 seconds of the execution time by
testing the 'shutdown' exit reasons at beginning of the
test case instead of doing it at the end.
---
 lib/stdlib/test/proc_lib_SUITE.erl | 174 +++++++++++++++++++++++--------------
 1 file changed, 108 insertions(+), 66 deletions(-)

diff --git a/lib/stdlib/test/proc_lib_SUITE.erl b/lib/stdlib/test/proc_lib_SUITE.erl
index 857cd3f88d..f7a6a38138 100644
--- a/lib/stdlib/test/proc_lib_SUITE.erl
+++ b/lib/stdlib/test/proc_lib_SUITE.erl
@@ -80,81 +80,123 @@ end_per_group(_GroupName, Config) ->
 crash(Config) when is_list(Config) ->
     error_logger:add_report_handler(?MODULE, self()),
 
-    Pid = proc_lib:spawn(?MODULE, sp1, []),
-    Pid ! die,
-    ?line Report = receive
-		       {crash_report, Pid, Report0} -> Report0
-		   after 2000 -> test_server:fail(no_crash_report)
-		   end,
-    ?line proc_lib:format(Report),
-    ?line [PidRep, []] = Report,
-    ?line {value, {initial_call,{?MODULE,sp1,[]}}} =
-	lists:keysearch(initial_call, 1, PidRep),
-    Self = self(),
-    ?line {value, {ancestors,[Self]}} =
-	lists:keysearch(ancestors, 1, PidRep),
-    ?line {value, {error_info,{exit,die,_StackTrace1}}} =
-	lists:keysearch(error_info, 1, PidRep),
-
-    F = fun sp1/0,
-    Pid1 = proc_lib:spawn(node(), F),
-    Pid1 ! die,
-    ?line [PidRep1, []] = receive
-		       {crash_report, Pid1, Report1} -> Report1
-		   after 2000 -> test_server:fail(no_crash_report)
-		   end,
-    ?line {value, {initial_call,{Fmod,Fname,[]}}} =
-	lists:keysearch(initial_call, 1, PidRep1),
-    ?line {module,Fmod} = erlang:fun_info(F, module),
-    ?line {name,Fname} = erlang:fun_info(F, name),
-    ?line {value, {ancestors,[Self]}} =
-	lists:keysearch(ancestors, 1, PidRep1),
-    ?line {value, {error_info,{exit,die,_StackTrace2}}} =
-	lists:keysearch(error_info, 1, PidRep1),
-
-    Pid2 = proc_lib:spawn(?MODULE, sp2, []),
-    test_server:sleep(100),
-    ?line {?MODULE,sp2,[]} = proc_lib:initial_call(Pid2),
-    ?line {?MODULE,sp2,0} = proc_lib:translate_initial_call(Pid2),
-    Pid2 ! die,
-    ?line [Pid2Rep, [{neighbour, LinkRep}]] =
-	receive
-	    {crash_report, Pid2, Report2} -> Report2
-	after 2000 -> test_server:fail(no_crash_report)
-	end,
-    ?line {value, {initial_call,{?MODULE,sp2,[]}}} =
-	lists:keysearch(initial_call, 1, Pid2Rep),
-    ?line {value, {ancestors,[Self]}} =
-	lists:keysearch(ancestors, 1, Pid2Rep),
-    ?line {value, {error_info,{exit,die,_StackTrace3}}} =
-	lists:keysearch(error_info, 1, Pid2Rep),
-    ?line {value, {initial_call,{?MODULE,sp1,[]}}} =
-	lists:keysearch(initial_call, 1, LinkRep),
-
     %% Make sure that we don't get a crash report if a process
     %% terminates with reason 'shutdown' or reason {shutdown,Reason}.
-    ?line process_flag(trap_exit, true),
-    ?line Pid3 = proc_lib:spawn_link(erlang, apply,
-				     [fun() -> exit(shutdown) end,[]]),
-
-    ?line Pid4 = proc_lib:spawn_link(erlang, apply,
-				     [fun() -> exit({shutdown,{a,b,c}}) end,[]]),
+    process_flag(trap_exit, true),
+    Pid0 = proc_lib:spawn_link(erlang, apply,
+			       [fun() -> exit(shutdown) end,[]]),
+    Pid1 = proc_lib:spawn_link(erlang, apply,
+			       [fun() -> exit({shutdown,{a,b,c}}) end,[]]),
+
+    receive {'EXIT',Pid0,shutdown} -> ok end,
+    receive {'EXIT',Pid1,{shutdown,{a,b,c}}} -> ok end,
+    process_flag(trap_exit, false),
+    %% We expect any unexpected messages to be caught below,
+    %% so we don't have explicitly wait some time to be sure.
+
+    %% Spawn export function.
+    Pid2 = proc_lib:spawn(?MODULE, sp1, []),
+    Pid2 ! die,
+    Exp2 = [{initial_call,{?MODULE,sp1,[]}},
+	    {ancestors,[self()]},
+	    {error_info,{exit,die,{stacktrace}}}],
+    analyse_crash(Pid2, Exp2, []),
 
-    ?line receive {'EXIT',Pid3,shutdown} -> ok end,
-    ?line receive {'EXIT',Pid4,{shutdown,{a,b,c}}} -> ok end,
-    ?line process_flag(trap_exit, false),
+    %% Spawn fun.
+    F = fun sp1/0,
+    Pid3 = proc_lib:spawn(node(), F),
+    Pid3 ! die,
+    {module,?MODULE} = erlang:fun_info(F, module),
+    {name,Fname} = erlang:fun_info(F, name),
+    Exp3 = [{initial_call,{?MODULE,Fname,[]}},
+	    {ancestors,[self()]},
+	    {error_info,{exit,die,{stacktrace}}}],
+    analyse_crash(Pid3, Exp3, []),
 
-    receive
-	Any ->
-	    ?line ?t:fail({unexpected_message,Any})
-	after 2000 ->
-		ok
-	end,
+    %% Spawn function with neighbour.
+    Pid4 = proc_lib:spawn(?MODULE, sp2, []),
+    test_server:sleep(100),
+    {?MODULE,sp2,[]} = proc_lib:initial_call(Pid4),
+    {?MODULE,sp2,0} = proc_lib:translate_initial_call(Pid4),
+    Pid4 ! die,
+    Exp4 = [{initial_call,{?MODULE,sp2,[]}},
+	    {ancestors,[self()]},
+	    {error_info,{exit,die,{stacktrace}}}],
+    Links4 = [[{initial_call,{?MODULE,sp1,[]}},
+	       {ancestors,[Pid4,self()]}]],
+    analyse_crash(Pid4, Exp4, Links4),
+
+    %% Make sure that we still get a crash report if the
+    %% process dictionary have been tampered with.
+
+    Pid5 = proc_lib:spawn(erlang, apply,
+			  [fun() ->
+				   erase(),
+				   exit(abnormal)
+			   end,[]]),
+    Exp5 = [{initial_call,absent},
+	    {ancestors,[]},
+	    {error_info,{exit,abnormal,{stacktrace}}}],
+    analyse_crash(Pid5, Exp5, []),
 
     error_logger:delete_report_handler(?MODULE),
     ok.
 
+analyse_crash(Pid, Expected0, ExpLinks) ->
+    Expected = [{pid,Pid}|Expected0],
+    receive
+	{crash_report, Pid, Report} ->
+	    _ = proc_lib:format(Report),	%Smoke test.
+	    [Crash,Links] = Report,
+	    analyse_crash_1(Expected, Crash),
+	    analyse_links(ExpLinks, Links);
+	Unexpected ->
+	    io:format("~p\n", [Unexpected]),
+	    test_server:fail(unexpected_message)
+    after 5000 ->
+	    test_server:fail(no_crash_report)
+    end.
+
+analyse_links([H|Es], [{neighbour,N}|Links]) ->
+    analyse_crash_1(H, N),
+    analyse_links(Es, Links);
+analyse_links([], []) ->
+    ok.
 
+analyse_crash_1([{Key,absent}|T], Report) ->
+    false = lists:keymember(Key, 1, Report),
+    analyse_crash_1(T, Report);
+analyse_crash_1([{Key,Pattern}|T], Report) ->
+    case lists:keyfind(Key, 1, Report) of
+	false ->
+	    io:format("~p", [Report]),
+	    test_server:fail({missing_key,Key});
+	{Key,Info} ->
+	    try
+		match_info(Pattern, Info)
+	    catch
+		no_match ->
+		    io:format("key: ~p", [Key]),
+		    io:format("pattern: ~p", [Pattern]),
+		    io:format("actual: ~p", [Report]),
+		    test_server:fail(no_match)
+	    end,
+	    analyse_crash_1(T, Report)
+    end;
+analyse_crash_1([], _Report) ->
+    [].
+
+match_info(T, T) ->
+    ok;
+match_info({stacktrace}, Stk) when is_list(Stk) ->
+    ok;
+match_info([H1|T1], [H2|T2]) ->
+    match_info(H1, H2),
+    match_info(T1, T2);
+match_info(Tuple1, Tuple2) when tuple_size(Tuple1) =:= tuple_size(Tuple2) ->
+    match_info(tuple_to_list(Tuple1), tuple_to_list(Tuple2));
+match_info(_, _) ->
+    throw(no_match).
 
 sync_start_nolink(Config) when is_list(Config) ->
     _Pid = spawn_link(?MODULE, sp5, [self()]),
-- 
cgit v1.2.3


From 72bfa81400ee24f38ac4044420b080e66a5da37a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Thu, 3 Sep 2015 15:39:02 +0200
Subject: gen_event_SUITE: Remove unnecessary sleep calls

The calls to test_server:sleep/1 are unnecessary as the swapping
of handlers happens in a single process. Even though the
{swap_info,...} message is sent asynchronously, the
gen_event:which_handlers/1 call will not have a chance to
execute until the handlers have been swapped.
---
 lib/stdlib/test/gen_event_SUITE.erl | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/lib/stdlib/test/gen_event_SUITE.erl b/lib/stdlib/test/gen_event_SUITE.erl
index 7a6fcba4e5..b019f98b69 100644
--- a/lib/stdlib/test/gen_event_SUITE.erl
+++ b/lib/stdlib/test/gen_event_SUITE.erl
@@ -412,7 +412,6 @@ notify(Config) when is_list(Config) ->
 		  ok
 	  end,
     ?line ok = gen_event:notify(my_dummy_handler, {swap_event,dummy1_h,swap}),
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
     ?line ok = gen_event:notify(my_dummy_handler, Event),
     ?line receive
@@ -445,7 +444,6 @@ notify(Config) when is_list(Config) ->
 	  end,
     ?line ok = gen_event:notify(my_dummy_handler,
 				{swap_event, {dummy1_h, 9}, swap}),
-    ?t:sleep(1000),
     ?line [{dummy1_h,9}] = gen_event:which_handlers(my_dummy_handler),
     ?line ok = gen_event:notify(my_dummy_handler, Event),
     ?line receive
@@ -485,7 +483,6 @@ notify(Config) when is_list(Config) ->
 
     ?line ok = gen_event:add_sup_handler(my_dummy_handler, dummy_h, [self()]),
     ?line ok = gen_event:notify(my_dummy_handler, {swap_event,dummy1_h,swap}),
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
 
     ?line ok = gen_event:notify(my_dummy_handler, do_crash),
@@ -496,7 +493,6 @@ notify(Config) when is_list(Config) ->
 
     ?line ok = gen_event:add_sup_handler(my_dummy_handler, dummy_h, [self()]),
     ?line ok = gen_event:notify(my_dummy_handler, {swap_event,dummy1_h,swap}),
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
 
     ?line ok = gen_event:notify(my_dummy_handler, delete_event),
@@ -529,7 +525,6 @@ sync_notify(Config) when is_list(Config) ->
 	  end,
     ?line ok = gen_event:sync_notify(my_dummy_handler,
 				     {swap_event, dummy1_h, swap}),
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
     ?line ok = gen_event:sync_notify(my_dummy_handler, Event),
     ?line receive
@@ -562,7 +557,6 @@ sync_notify(Config) when is_list(Config) ->
 	  end,
     ?line ok = gen_event:sync_notify(my_dummy_handler,
 				     {swap_event, {dummy1_h, 9}, swap}),
-    ?t:sleep(1000),
     ?line [{dummy1_h,9}] = gen_event:which_handlers(my_dummy_handler),
     ?line ok = gen_event:sync_notify(my_dummy_handler, Event),
     ?line receive
@@ -603,7 +597,6 @@ sync_notify(Config) when is_list(Config) ->
     ?line ok = gen_event:add_sup_handler(my_dummy_handler, dummy_h, [self()]),
     ?line ok = gen_event:sync_notify(my_dummy_handler,
 				     {swap_event,dummy1_h,swap}),
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
 
     ?line ok = gen_event:sync_notify(my_dummy_handler, do_crash),
@@ -615,7 +608,6 @@ sync_notify(Config) when is_list(Config) ->
     ?line ok = gen_event:add_sup_handler(my_dummy_handler, dummy_h, [self()]),
     ?line ok = gen_event:sync_notify(my_dummy_handler,
 				     {swap_event,dummy1_h,swap}),
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
 
     ?line ok = gen_event:sync_notify(my_dummy_handler, delete_event),
@@ -789,7 +781,6 @@ info(Config) when is_list(Config) ->
 		  ok
 	  end,
     ?line my_dummy_handler ! {swap_info,dummy1_h,swap},
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
     ?line my_dummy_handler ! Info,
     ?line receive
@@ -821,7 +812,6 @@ info(Config) when is_list(Config) ->
 		  ok
 	  end,
     ?line my_dummy_handler ! {swap_info,{dummy1_h,2},swap},
-    ?t:sleep(1000),
     ?line [{dummy1_h,2}] = gen_event:which_handlers(my_dummy_handler),
     ?line my_dummy_handler ! Info,
     ?line receive
@@ -853,7 +843,6 @@ info(Config) when is_list(Config) ->
 		  ok
 	  end,
     ?line my_dummy_handler ! {swap_info,dummy1_h,swap},
-    ?t:sleep(1000),
     ?line [dummy1_h] = gen_event:which_handlers(my_dummy_handler),
     ?line my_dummy_handler ! Info,
     ?line receive
-- 
cgit v1.2.3


From 88d3f61e3724957f60c9e8a786e8533d8aa1f362 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Fri, 4 Sep 2015 10:28:54 +0200
Subject: io_proto_SUITE: Refactor up rtnode() and friends

Introduce a new {getline_pred, Fun, Msg} action that is useful
in itself, but can also be used to share more code for
{getline, Match} and {getline_re, Match}.

Also get rid of the ?line macros in rtnode() so that we can
somewhat reduce the ridculous indentation level.
---
 lib/stdlib/test/io_proto_SUITE.erl | 148 +++++++++++++++++--------------------
 1 file changed, 69 insertions(+), 79 deletions(-)

diff --git a/lib/stdlib/test/io_proto_SUITE.erl b/lib/stdlib/test/io_proto_SUITE.erl
index 1337b7dde2..658c6442b1 100644
--- a/lib/stdlib/test/io_proto_SUITE.erl
+++ b/lib/stdlib/test/io_proto_SUITE.erl
@@ -1378,47 +1378,43 @@ rtnode(C,N) ->
 rtnode(Commands,Nodename,ErlPrefix) ->
     rtnode(Commands,Nodename,ErlPrefix,[]).
 rtnode(Commands,Nodename,ErlPrefix,Extra) ->
-    ?line case get_progs() of
-	      {error,_Reason} ->
-		  ?line {skip,"No runerl present"};
-	      {RunErl,ToErl,Erl} ->
-		  ?line case create_tempdir() of
-			    {error, Reason2} ->
-				?line {skip, Reason2};
-			    Tempdir ->
-				?line SPid = 
-				    start_runerl_node(RunErl,ErlPrefix++
-							  "\\\""++Erl++"\\\"",
-						      Tempdir,Nodename, Extra),
-				?line CPid = start_toerl_server(ToErl,Tempdir),
-				?line erase(getline_skipped),
-				?line Res = 
-				    (catch get_and_put(CPid, Commands,1)),
-				?line case stop_runerl_node(CPid) of
-					  {error,_} ->
-					      ?line CPid2 = 
-						  start_toerl_server
-						    (ToErl,Tempdir),
-					      ?line erase(getline_skipped),
-					      ?line ok = get_and_put
-							   (CPid2, 
-							    [{putline,[7]},
-							     {sleep,
-							      timeout(short)},
-							     {putline,""},
-							     {getline," -->"},
-							     {putline,"s"},
-							     {putline,"c"},
-							     {putline,""}],1),
-					      ?line stop_runerl_node(CPid2);
-					  _ ->
-					      ?line ok
-				      end,
-				?line wait_for_runerl_server(SPid),
-				?line ok = ?RM_RF(Tempdir),
-				?line ok = Res
-			end
-	  end.
+    case get_progs() of
+	{error,_Reason} ->
+	    {skip,"No runerl present"};
+	{RunErl,ToErl,Erl} ->
+	    case create_tempdir() of
+		{error, Reason2} ->
+		    {skip, Reason2};
+		Tempdir ->
+		    SPid = start_runerl_node(RunErl, ErlPrefix++
+						 "\\\""++Erl++"\\\"",
+					     Tempdir, Nodename, Extra),
+		    CPid = start_toerl_server(ToErl, Tempdir),
+		    put(getline_skipped, []),
+		    Res = (catch get_and_put(CPid, Commands, 1)),
+		    case stop_runerl_node(CPid) of
+			{error,_} ->
+			    CPid2 = start_toerl_server(ToErl, Tempdir),
+			    put(getline_skipped, []),
+			    ok = get_and_put
+				   (CPid2,
+				    [{putline,[7]},
+				     {sleep,
+				      timeout(short)},
+				     {putline,""},
+				     {getline," -->"},
+				     {putline,"s"},
+				     {putline,"c"},
+				     {putline,""}], 1),
+			    stop_runerl_node(CPid2);
+			_ ->
+			    ok
+		    end,
+		    wait_for_runerl_server(SPid),
+		    ok = ?RM_RF(Tempdir),
+		    ok = Res
+	    end
+    end.
 
 timeout(long) ->
     2 * timeout(normal);
@@ -1462,57 +1458,51 @@ get_and_put(CPid, [{sleep, X}|T],N) ->
     after X ->
 	    get_and_put(CPid,T,N+1)
     end;
-get_and_put(CPid, [{getline, Match}|T],N) ->
+get_and_put(CPid, [{getline_pred,Pred,Msg}|T]=T0, N)
+  when is_function(Pred) ->
     ?dbg({getline, Match}),
     CPid ! {self(), {get_line, timeout(normal)}},
     receive
 	{get_line, timeout} ->
 	    error_logger:error_msg("~p: getline timeout waiting for \"~s\" "
 				   "(command number ~p, skipped: ~p)~n",
-				   [?MODULE, Match,N,get(getline_skipped)]),
+				   [?MODULE,Msg,N,get(getline_skipped)]),
 	    {error, timeout};
 	{get_line, Data} ->
 	    ?dbg({data,Data}),
-	    case lists:prefix(Match, Data) of
-		true ->
-		    erase(getline_skipped),
+	    case Pred(Data) of
+		yes ->
+		    put(getline_skipped, []),
 		    get_and_put(CPid, T,N+1);
-		false ->
-		    case get(getline_skipped) of
-			undefined ->
-			    put(getline_skipped,[Data]);
-			List ->
-			    put(getline_skipped,List ++ [Data])
-		    end,
-		    get_and_put(CPid,  [{getline, Match}|T],N)
+		no ->
+		    error_logger:error_msg("~p: getline match failure "
+					   "\"~s\" "
+					   "(command number ~p)\n",
+					   [?MODULE,Msg,N]),
+		    {error, no_match};
+		maybe ->
+		    List = get(getline_skipped),
+		    put(getline_skipped, List ++ [Data]),
+		    get_and_put(CPid, T0, N)
 	    end
     end;
+get_and_put(CPid, [{getline, Match}|T],N) ->
+    ?dbg({getline, Match}),
+    F = fun(Data) ->
+		case lists:prefix(Match, Data) of
+		    true -> yes;
+		    false -> maybe
+		end
+	end,
+    get_and_put(CPid, [{getline_pred,F,Match}|T], N);
 get_and_put(CPid, [{getline_re, Match}|T],N) ->
-    ?dbg({getline_re, Match}),
-    CPid ! {self(), {get_line, timeout(normal)}},
-    receive
-	{get_line, timeout} ->
-	    error_logger:error_msg("~p: getline_re timeout waiting for \"~s\" "
-				   "(command number ~p, skipped: ~p)~n",
-				   [?MODULE, Match,N,get(getline_skipped)]),
-	    {error, timeout};
-	{get_line, Data} ->
-	    ?dbg({data,Data}),
-	    case re:run(Data, Match,[{capture,none}]) of
-		match ->
-		    erase(getline_skipped),
-		    get_and_put(CPid, T,N+1);
-		_ ->
-		    case get(getline_skipped) of
-			undefined ->
-			    put(getline_skipped,[Data]);
-			List ->
-			    put(getline_skipped,List ++ [Data])
-		    end,
-		    get_and_put(CPid,  [{getline_re, Match}|T],N)
-	    end
-    end;
-
+    F = fun(Data) ->
+		case re:run(Data, Match, [{capture,none}]) of
+		    match -> yes;
+		    _ -> maybe
+		end
+	end,
+    get_and_put(CPid, [{getline_pred,F,Match}|T], N);
 get_and_put(CPid, [{putline_raw, Line}|T],N) ->
     ?dbg({putline_raw, Line}),
     CPid ! {self(), {send_line, Line}},
-- 
cgit v1.2.3


From ccee216a6cc1bc619806007891e9d9d9c30e8826 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Fri, 4 Sep 2015 10:32:07 +0200
Subject: io_proto_SUITE: Speed up determination of default shell

Use getline_pred action that fails fast if the shell is not
the oldshell, to avoid having to wait for the timeout.
---
 lib/stdlib/test/io_proto_SUITE.erl | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/lib/stdlib/test/io_proto_SUITE.erl b/lib/stdlib/test/io_proto_SUITE.erl
index 658c6442b1..811c7ed7bb 100644
--- a/lib/stdlib/test/io_proto_SUITE.erl
+++ b/lib/stdlib/test/io_proto_SUITE.erl
@@ -1791,10 +1791,22 @@ get_data_within(Port, Timeout, Acc) ->
     end.
 
 get_default_shell() ->
+    Match = fun(Data) ->
+		    case lists:prefix("undefined", Data) of
+			true ->
+			    yes;
+			false ->
+			    case re:run(Data, "<\\d+[.]\\d+[.]\\d+>",
+					[{capture,none}]) of
+				match -> no;
+				_ -> maybe
+			    end
+		    end
+	    end,
     try
 	rtnode([{putline,""},
 		{putline, "whereis(user_drv)."},
-		{getline, "undefined"}],[]),
+		{getline_pred, Match, "matching of user_drv pid"}], []),
 	old
     catch _E:_R ->
 	    ?dbg({_E,_R}),
-- 
cgit v1.2.3


From b322b7b3fb6765a6965726efa8afac572e60eec7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Fri, 4 Sep 2015 15:20:27 +0200
Subject: id_transform_SUITE: Modernize test suite

Remove handling of Clearcase; remove ?line macros.
---
 lib/stdlib/test/id_transform_SUITE.erl | 53 ++++++++++------------------------
 1 file changed, 16 insertions(+), 37 deletions(-)

diff --git a/lib/stdlib/test/id_transform_SUITE.erl b/lib/stdlib/test/id_transform_SUITE.erl
index 41de016f8d..1cff990697 100644
--- a/lib/stdlib/test/id_transform_SUITE.erl
+++ b/lib/stdlib/test/id_transform_SUITE.erl
@@ -56,47 +56,26 @@ end_per_group(_GroupName, Config) ->
 
 id_transform(doc) -> "Test erl_id_trans.";
 id_transform(Config) when is_list(Config) ->
-    ?line File=filename:join([code:lib_dir(stdlib),"examples",
-			      "erl_id_trans.erl"]),
-    ?line {ok,erl_id_trans,Bin}=compile:file(File,[binary]),
-    ?line {module,erl_id_trans}=code:load_binary(erl_id_trans,File,Bin),
-    ?line case test_server:purify_is_running() of
-	      false ->
-		  Dog = ct:timetrap(?t:hours(1)),
-		  ?line Res = run_in_test_suite(),
-		  ?t:timetrap_cancel(Dog),
-		  Res;
-	      true ->
-		  {skip,"Purify (too slow)"}
-	  end.
+    File = filename:join([code:lib_dir(stdlib),"examples",
+			"erl_id_trans.erl"]),
+    {ok,erl_id_trans,Bin} = compile:file(File,[binary]),
+    {module,erl_id_trans} = code:load_binary(erl_id_trans, File, Bin),
+    case test_server:purify_is_running() of
+	false ->
+	    Dog = ct:timetrap(?t:hours(1)),
+	    Res = run_in_test_suite(),
+	    ?t:timetrap_cancel(Dog),
+	    Res;
+	true ->
+	    {skip,"Valgrind (too slow)"}
+    end.
 
 run_in_test_suite() ->
-    LibDir = code:lib_dir(),
     SuperDir = filename:dirname(filename:dirname(code:which(?MODULE))),
     TestDirs = filelib:wildcard(filename:join([SuperDir,"*_test"])),
-    {All,Res} = case LibDir of
-		    "/clearcase/otp/erts/lib" ->
-			%% Only test_suites 'cause clearcase is too slow...
-			{false,run_list(TestDirs)};
-		    _ ->
-			{true,run_codepath_and(TestDirs)}
-		end,
-    Comment0 = case All of
-		   true -> [];
-		   false -> "Only testsuite directories traversed"
-	       end,
-    case Res of
-	{error,Reason} when Comment0 =/= [] ->
-	    {failed,Comment0++"; "++Reason};
-	{error,Reason} ->
-	    {failed,Reason};
-	ok ->
-	    {comment,Comment0}
-    end.
-
-run_codepath_and(DirList) ->
     AbsDirs = [filename:absname(X) || X <- code:get_path()],
-    run_list(ordsets:from_list([X || X <- AbsDirs] ++ DirList)).
+    Dirs = ordsets:from_list(AbsDirs ++ TestDirs),
+    run_list(Dirs).
 
 run_list(PathL) ->
     io:format("Where to search for beam files:\n~p\n", [PathL]),
@@ -123,7 +102,7 @@ run_list(PathL) ->
     end,
     case length(SevereFailures) of
 	0 -> ok;
-	Len -> {error,integer_to_list(Len)++" failures"}
+	Len -> {failed,integer_to_list(Len)++" failures"}
     end.
     
 
-- 
cgit v1.2.3


From 1d00d0df6ff344e3a0ef58a5636ad32259ca31b0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 08:53:22 +0200
Subject: lists_SUITE: Correct test of lists:flatten/2

The test that was supposed to call lists:flatten/2 called
lists:flatten/1!
---
 lib/stdlib/test/lists_SUITE.erl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index e886a797f0..4a15bb9b81 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -2351,11 +2351,11 @@ flatten_1_e(Config) when is_list(Config) ->
 %%% clear-cut. Right now, I think that any term should be allowed.
 %%% But I also wish this function didn't exist at all.
 
-flatten_2(doc) ->   ["flatten/2"];
-flatten_2(suite) -> [];
+%% Test lists:flatten/2.
 flatten_2(Config) when is_list(Config) ->
-    ?line [] = lists:flatten([]),
-    ?line [a] = lists:flatten([a]),
+    [] = lists:flatten([], []),
+    [a] = lists:flatten([a], []),
+    [a,b,c,[no,flatten]] = lists:flatten([[a,[b,c]]], [[no,flatten]]),
     ok.
 
 flatten_2_e(doc) ->   ["flatten/2 error cases"];
-- 
cgit v1.2.3


From e882c376be9c62950ed84ae0ba7936cf4c827462 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 09:00:22 +0200
Subject: lists_SUITE: Extend flatten/1 test to also test flatlength/1

---
 lib/stdlib/test/lists_SUITE.erl | 28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index 4a15bb9b81..e0dd34e82d 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -2326,18 +2326,24 @@ sublist_3_e(Config) when is_list(Config) ->
 -define(flatten_error1(X), ?line {'EXIT', _} = (catch lists:flatten(X))).
 -define(flatten_error2(X,Y), ?line {'EXIT', _} = (catch lists:flatten(X,Y))).
 
-flatten_1(doc) ->   ["flatten/1"];
-flatten_1(suite) -> [];
+%% Test lists:flatten/1,2 and lists:flatlength/1.
 flatten_1(Config) when is_list(Config) ->
-    ?line [] = lists:flatten([]),
-    ?line [1,2] = lists:flatten([1,2]),
-    ?line [1,2] = lists:flatten([1,[2]]),
-    ?line [1,2] = lists:flatten([[1],2]),
-    ?line [1,2] = lists:flatten([[1],[2]]),
-    ?line [1,2] = lists:flatten([[1,2]]),
-    ?line [a,b,c,d] = lists:flatten([[a],[b,c,[d]]]),
-
-    ok.
+    [] = lists_flatten([]),
+    [1,2] = lists_flatten([1,2]),
+    [1,2] = lists_flatten([1,[2]]),
+    [1,2] = lists_flatten([[1],2]),
+    [1,2] = lists_flatten([[1],[2]]),
+    [1,2] = lists_flatten([[1,2]]),
+    [a,b,c,d] = lists_flatten([[a],[b,c,[d]]]),
+
+    ok.
+
+lists_flatten(List) ->
+    Flat = lists:flatten(List),
+    Flat = lists:flatten(List, []),
+    Len = lists:flatlength(List),
+    Len = length(Flat),
+    Flat.
 
 flatten_1_e(doc) ->   ["flatten/1 error cases"];
 flatten_1_e(suite) -> [];
-- 
cgit v1.2.3


From 358d73bb6432367823eda3636f9ce167c73750b0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 09:10:13 +0200
Subject: lists_SUITE: Test lists:keyreplace/4

---
 lib/stdlib/test/lists_SUITE.erl | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index e0dd34e82d..cf42ac473d 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -38,7 +38,7 @@
 % Test cases must be exported.
 -export([member/1, reverse/1,
 	 keymember/1, keysearch_keyfind/1,
-         keystore/1, keytake/1,
+         keystore/1, keytake/1, keyreplace/1,
 	 append_1/1, append_2/1,
 	 seq_loop/1, seq_2/1, seq_3/1, seq_2_e/1, seq_3_e/1,
 	
@@ -82,7 +82,8 @@ suite() -> [{ct_hooks,[ts_install_cth]}].
 
 all() -> 
     [{group, append}, reverse, member, keymember,
-     keysearch_keyfind, keystore, keytake, dropwhile, {group,sort},
+     keysearch_keyfind, keystore, keytake, keyreplace,
+     dropwhile, {group,sort},
      {group, usort}, {group, keysort}, {group, ukeysort},
      {group, funsort}, {group, ufunsort}, {group, sublist},
      {group, flatten}, {group, seq}, zip_unzip, zip_unzip3,
@@ -382,6 +383,17 @@ keytake(Config) when is_list(Config) ->
     ?line false = lists:keytake(4, 2, L),
     ok.
 
+%% Test lists:keyreplace/4.
+keyreplace(Config) when is_list(Config) ->
+    [{new,42}] = lists:keyreplace(k, 1, [{k,1}], {new,42}),
+    [atom,{new,a,b}] = lists:keyreplace(k, 1, [atom,{k,1}], {new,a,b}),
+    [a,{x,y,z}] = lists:keyreplace(a, 5, [a,{x,y,z}], {no,use}),
+
+    %% Error cases.
+    {'EXIT',_} = (catch lists:keyreplace(k, 1, [], not_tuple)),
+    {'EXIT',_} = (catch lists:keyreplace(k, 0, [], {a,b})),
+    ok.
+
 merge(doc) ->   ["merge functions"];
 merge(suite) -> [];
 merge(Config) when is_list(Config) ->
-- 
cgit v1.2.3


From c72d9efd26926768f1f02004d863feb7ac528a40 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 09:17:54 +0200
Subject: lists_SUITE: Run test cases in each group in parallel

On my computer, this will shave off more than one second of the
runnning time and about 4 seconds when cover is being run.
---
 lib/stdlib/test/lists_SUITE.erl | 50 +++++++++++++++++++++++++----------------
 1 file changed, 31 insertions(+), 19 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index cf42ac473d..14e6a12fda 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -81,38 +81,50 @@
 suite() -> [{ct_hooks,[ts_install_cth]}].
 
 all() -> 
-    [{group, append}, reverse, member, keymember,
-     keysearch_keyfind, keystore, keytake, keyreplace,
-     dropwhile, {group,sort},
-     {group, usort}, {group, keysort}, {group, ukeysort},
-     {group, funsort}, {group, ufunsort}, {group, sublist},
-     {group, flatten}, {group, seq}, zip_unzip, zip_unzip3,
-     zipwith, zipwith3, filter_partition, {group, tickets},
-     suffix, subtract].
+    [{group, append},
+     {group, key},
+     {group,sort},
+     {group, usort},
+     {group, keysort},
+     {group, ukeysort},
+     {group, funsort},
+     {group, ufunsort},
+     {group, sublist},
+     {group, flatten},
+     {group, seq},
+     {group, tickets},
+     {group, zip},
+     {group, misc}].
 
 groups() -> 
-    [{append, [], [append_1, append_2]},
-     {usort, [],
+    [{append, [parallel], [append_1, append_2]},
+     {usort, [parallel],
       [umerge, rumerge, usort_1, usort_rand, usort_stable]},
-     {keysort, [],
+     {keysort, [parallel],
       [keymerge, rkeymerge, keysort_1, keysort_rand,
        keysort_i, keysort_stable, keysort_error]},
-     {sort,[],[merge, rmerge, sort_1, sort_rand]},
-     {ukeysort, [],
+     {key, [parallel], [keymember, keysearch_keyfind, keystore,
+			keytake, keyreplace]},
+     {sort,[parallel],[merge, rmerge, sort_1, sort_rand]},
+     {ukeysort, [parallel],
       [ukeymerge, rukeymerge, ukeysort_1, ukeysort_rand,
        ukeysort_i, ukeysort_stable, ukeysort_error]},
-     {funsort, [],
+     {funsort, [parallel],
       [funmerge, rfunmerge, funsort_1, funsort_stable,
        funsort_error, funsort_rand]},
-     {ufunsort, [],
+     {ufunsort, [parallel],
       [ufunmerge, rufunmerge, ufunsort_1, ufunsort_stable,
        ufunsort_error, ufunsort_rand]},
-     {seq, [], [seq_loop, seq_2, seq_3, seq_2_e, seq_3_e]},
-     {sublist, [],
+     {seq, [parallel], [seq_loop, seq_2, seq_3, seq_2_e, seq_3_e]},
+     {sublist, [parallel],
       [sublist_2, sublist_3, sublist_2_e, sublist_3_e]},
-     {flatten, [],
+     {flatten, [parallel],
       [flatten_1, flatten_2, flatten_1_e, flatten_2_e]},
-     {tickets, [], [otp_5939, otp_6023, otp_6606, otp_7230]}].
+     {tickets, [parallel], [otp_5939, otp_6023, otp_6606, otp_7230]},
+     {zip, [parallel], [zip_unzip, zip_unzip3, zipwith, zipwith3]},
+     {misc, [parallel], [reverse, member, dropwhile, filter_partition,
+			 suffix, subtract]}
+    ].
 
 init_per_suite(Config) ->
     Config.
-- 
cgit v1.2.3


From 02d26a9d7b28909edbc84b993b643a34325e90b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 10:39:52 +0200
Subject: lists_SUITE: Add test for lists:takewhile/1

---
 lib/stdlib/test/lists_SUITE.erl | 33 ++++++++++++++++++++++++++++++---
 1 file changed, 30 insertions(+), 3 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index 14e6a12fda..6bed793028 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -44,7 +44,7 @@
 	
 	 sublist_2/1, sublist_3/1, sublist_2_e/1, sublist_3_e/1,
 	 flatten_1/1, flatten_2/1, flatten_1_e/1, flatten_2_e/1,
-	 dropwhile/1,
+	 dropwhile/1, takewhile/1,
 	 sort_1/1, sort_stable/1, merge/1, rmerge/1, sort_rand/1,
 	 usort_1/1, usort_stable/1, umerge/1, rumerge/1,usort_rand/1,
 	 keymerge/1, rkeymerge/1,
@@ -122,8 +122,8 @@ groups() ->
       [flatten_1, flatten_2, flatten_1_e, flatten_2_e]},
      {tickets, [parallel], [otp_5939, otp_6023, otp_6606, otp_7230]},
      {zip, [parallel], [zip_unzip, zip_unzip3, zipwith, zipwith3]},
-     {misc, [parallel], [reverse, member, dropwhile, filter_partition,
-			 suffix, subtract]}
+     {misc, [parallel], [reverse, member, dropwhile, takewhile,
+			 filter_partition, suffix, subtract]}
     ].
 
 init_per_suite(Config) ->
@@ -358,6 +358,33 @@ dropwhile(Config) when is_list(Config) ->
 
     ok.
 
+takewhile(Config) when is_list(Config) ->
+    F = fun(C) -> C =/= $@ end,
+
+    [] = lists:takewhile(F, []),
+    [a] = lists:takewhile(F, [a]),
+    [a,b] = lists:takewhile(F, [a,b]),
+    [a,b,c] = lists:takewhile(F, [a,b,c]),
+
+    [] = lists:takewhile(F, [$@]),
+    [] = lists:takewhile(F, [$@,$@]),
+    [a] = lists:takewhile(F, [a,$@]),
+
+    [$k] = lists:takewhile(F, [$k,$@]),
+    [$k,$l] = lists:takewhile(F, [$k,$l,$@,$@]),
+    [a] = lists:takewhile(F, [a,$@,$@,$@]),
+
+    [] = lists:takewhile(F, [$@,a,$@,b]),
+    [] = lists:takewhile(F, [$@,$@,a,$@,b]),
+    [] = lists:takewhile(F, [$@,$@,$@,a,$@,b]),
+
+    Long = lists:seq(1, 1024),
+    Shorter = lists:seq(1, 400),
+
+    Shorter = lists:takewhile(fun(E) -> E =< 400 end, Long),
+
+    ok.
+
 keystore(doc) ->
     ["OTP-XXX."];
 keystore(suite) -> [];
-- 
cgit v1.2.3


From 2ae8ec4507c090d51df41e21f7ad7786de040aad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 10:25:55 +0200
Subject: lists_SUITE: Add hof/1 to test all high-order functions

---
 lib/stdlib/test/lists_SUITE.erl | 42 +++++++++++++++++++++++++++++++++++++++--
 1 file changed, 40 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index 6bed793028..a0f7fd2744 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -62,7 +62,7 @@
 	 zip_unzip/1, zip_unzip3/1, zipwith/1, zipwith3/1,
 	 filter_partition/1, 
 	 otp_5939/1, otp_6023/1, otp_6606/1, otp_7230/1,
-	 suffix/1, subtract/1, droplast/1]).
+	 suffix/1, subtract/1, droplast/1, hof/1]).
 
 %% Sort randomized lists until stopped.
 %%
@@ -123,7 +123,8 @@ groups() ->
      {tickets, [parallel], [otp_5939, otp_6023, otp_6606, otp_7230]},
      {zip, [parallel], [zip_unzip, zip_unzip3, zipwith, zipwith3]},
      {misc, [parallel], [reverse, member, dropwhile, takewhile,
-			 filter_partition, suffix, subtract]}
+			 filter_partition, suffix, subtract,
+			 hof]}
     ].
 
 init_per_suite(Config) ->
@@ -2708,3 +2709,40 @@ droplast(Config) when is_list(Config) ->
     ?line {'EXIT', {function_clause, _}} = (catch lists:droplast(x)),
 
     ok.
+
+%% Briefly test the common high-order functions to ensure they
+%% are covered.
+hof(Config) when is_list(Config) ->
+    L = [1,2,3],
+    [1,4,9] = lists:map(fun(N) -> N*N end, L),
+    [1,4,5,6] = lists:flatmap(fun(1) -> [1];
+				 (2) -> [];
+				 (3) -> [4,5,6]
+			      end, L),
+    [{1,[a]},{2,[b]},{3,[c]}] =
+	lists:keymap(fun(A) -> [A] end, 2, [{1,a},{2,b},{3,c}]),
+
+    [1,3] = lists:filter(fun(N) -> N rem 2 =:= 1 end, L),
+    FilterMapFun = fun(1) -> true;
+		      (2) -> {true,42};
+		      (3) -> false
+		   end,
+    [1,42] = lists:filtermap(FilterMapFun, L),
+    [1,42] = lists:zf(FilterMapFun, L),
+
+    [3,2,1] = lists:foldl(fun(E, A) -> [E|A] end, [], L),
+    [1,2,3] = lists:foldr(fun(E, A) -> [E|A] end, [], L),
+    {[1,4,9],[3,2,1]} = lists:mapfoldl(fun(E, A) ->
+					       {E*E,[E|A]}
+				       end, [], L),
+    {[1,4,9],[1,2,3]} = lists:mapfoldr(fun(E, A) ->
+					       {E*E,[E|A]}
+				       end, [], L),
+
+    true = lists:any(fun(N) -> N =:= 2 end, L),
+    false = lists:any(fun(N) -> N =:= 42 end, L),
+
+    true = lists:all(fun(N) -> is_integer(N) end, L),
+    false = lists:all(fun(N) -> N rem 2 =:= 0 end, L),
+
+    ok.
-- 
cgit v1.2.3


From 6b39473811ed8b10f6ee08f2871b971e702317bd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 13:46:56 +0200
Subject: lists_SUITE: Add a test case for lists:prefix/2

---
 lib/stdlib/test/lists_SUITE.erl | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index a0f7fd2744..175eb29af9 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -62,7 +62,7 @@
 	 zip_unzip/1, zip_unzip3/1, zipwith/1, zipwith3/1,
 	 filter_partition/1, 
 	 otp_5939/1, otp_6023/1, otp_6606/1, otp_7230/1,
-	 suffix/1, subtract/1, droplast/1, hof/1]).
+	 prefix/1, suffix/1, subtract/1, droplast/1, hof/1]).
 
 %% Sort randomized lists until stopped.
 %%
@@ -123,7 +123,7 @@ groups() ->
      {tickets, [parallel], [otp_5939, otp_6023, otp_6606, otp_7230]},
      {zip, [parallel], [zip_unzip, zip_unzip3, zipwith, zipwith3]},
      {misc, [parallel], [reverse, member, dropwhile, takewhile,
-			 filter_partition, suffix, subtract,
+			 filter_partition, prefix, suffix, subtract,
 			 hof]}
     ].
 
@@ -2629,6 +2629,19 @@ otp_6606(Config) when is_list(Config) ->
     ?line L2 = lists:sort(L2),
     ok.
 
+%% Test lists:prefix/2.
+prefix(Config) when is_list(Config) ->
+    true = lists:prefix([], []),
+    true = lists:prefix([], lists:seq(1, 10)),
+    true = lists:prefix([a], [a,b]),
+    true = lists:prefix(lists:seq(1, 10), lists:seq(1, 100)),
+
+    false = lists:prefix([a], []),
+    false = lists:prefix([a], [b]),
+    false = lists:prefix([a], [b,a]),
+
+    ok.
+
 %% Test lists:suffix/2.
 suffix(Config) when is_list(Config) ->
     ?line true = lists:suffix([], []),
-- 
cgit v1.2.3


From 8cbbc7b8577b4aecf681c38cd03c3387f7e605ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 14:15:30 +0200
Subject: lists_SUITE: Test lists:split/2

---
 lib/stdlib/test/lists_SUITE.erl | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index 175eb29af9..c84b4d9a5d 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -62,7 +62,8 @@
 	 zip_unzip/1, zip_unzip3/1, zipwith/1, zipwith3/1,
 	 filter_partition/1, 
 	 otp_5939/1, otp_6023/1, otp_6606/1, otp_7230/1,
-	 prefix/1, suffix/1, subtract/1, droplast/1, hof/1]).
+	 prefix/1, suffix/1, subtract/1, droplast/1, hof/1,
+	 split/1]).
 
 %% Sort randomized lists until stopped.
 %%
@@ -124,7 +125,7 @@ groups() ->
      {zip, [parallel], [zip_unzip, zip_unzip3, zipwith, zipwith3]},
      {misc, [parallel], [reverse, member, dropwhile, takewhile,
 			 filter_partition, prefix, suffix, subtract,
-			 hof]}
+			 hof, split]}
     ].
 
 init_per_suite(Config) ->
@@ -2759,3 +2760,31 @@ hof(Config) when is_list(Config) ->
     false = lists:all(fun(N) -> N rem 2 =:= 0 end, L),
 
     ok.
+
+%% Test lists:split/2
+split(Config) when is_list(Config) ->
+    Lens = lists:seq(0, 32),
+    do_split(Lens),
+
+    %% Error cases.
+    {'EXIT',_} = (catch lists:split(a, [])),
+    {'EXIT',_} = (catch lists:split(-1, [])),
+    {'EXIT',_} = (catch lists:split(0, {a,b})),
+    ok.
+
+do_split([Len|Lens]) ->
+    List = [rand:uniform(1000) || _ <- lists:seq(1, Len)],
+    do_split_1(0, Len, List),
+    do_split(Lens);
+do_split([]) ->
+    ok.
+
+do_split_1(N, Len, List)  when N =:= Len + 1 ->
+    {'EXIT',_} = (catch lists:split(N, List));
+do_split_1(N, Len, List) ->
+    {A,B} = lists:split(N, List),
+    List = A ++ B,
+    N = length(A),
+    LenB = length(B),
+    LenB = Len - N,
+    do_split_1(N+1, Len, List).
-- 
cgit v1.2.3


From c54430d8d47993ccc10651d2049961b4ab122a90 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 14:21:17 +0200
Subject: lists_SUITE: Test lists:concat/2

---
 lib/stdlib/test/lists_SUITE.erl | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index c84b4d9a5d..5a447d58a4 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -63,7 +63,7 @@
 	 filter_partition/1, 
 	 otp_5939/1, otp_6023/1, otp_6606/1, otp_7230/1,
 	 prefix/1, suffix/1, subtract/1, droplast/1, hof/1,
-	 split/1]).
+	 split/1, concat/1]).
 
 %% Sort randomized lists until stopped.
 %%
@@ -125,7 +125,7 @@ groups() ->
      {zip, [parallel], [zip_unzip, zip_unzip3, zipwith, zipwith3]},
      {misc, [parallel], [reverse, member, dropwhile, takewhile,
 			 filter_partition, prefix, suffix, subtract,
-			 hof, split]}
+			 hof, split, concat]}
     ].
 
 init_per_suite(Config) ->
@@ -2788,3 +2788,9 @@ do_split_1(N, Len, List) ->
     LenB = length(B),
     LenB = Len - N,
     do_split_1(N+1, Len, List).
+
+%% Test lists:concat/1 mainly for coverage.
+concat(Config) when is_list(Config) ->
+    S = integer_to_list(42) ++ "pi: " ++ float_to_list(math:pi()),
+    S = lists:concat([42,pi,": ",math:pi()]),
+    ok.
-- 
cgit v1.2.3


From 78eb4a1ff9cafe394e338abb7297a1199c5eba85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 15:11:28 +0200
Subject: base64_SUITE: Speed up roundtrip/1

Refactor roundtrip/1 into 4 test cases that can be run in parallel.
Assuming that there are 4 cores available, the group of 4 test
cases will run at roughly one fourth of the time for the original
test case.
---
 lib/stdlib/test/base64_SUITE.erl | 38 +++++++++++++++++++---------
 lib/stdlib/test/lists_SUITE.erl  | 54 +++-------------------------------------
 2 files changed, 29 insertions(+), 63 deletions(-)

diff --git a/lib/stdlib/test/base64_SUITE.erl b/lib/stdlib/test/base64_SUITE.erl
index cca9b967d5..75eebba6c6 100644
--- a/lib/stdlib/test/base64_SUITE.erl
+++ b/lib/stdlib/test/base64_SUITE.erl
@@ -30,7 +30,8 @@
 %% Test cases must be exported.
 -export([base64_encode/1, base64_decode/1, base64_otp_5635/1,
 	 base64_otp_6279/1, big/1, illegal/1, mime_decode/1,
-	 mime_decode_to_string/1, roundtrip/1]).
+	 mime_decode_to_string/1,
+	 roundtrip_1/1, roundtrip_2/1, roundtrip_3/1, roundtrip_4/1]).
 
 init_per_testcase(_, Config) ->
     Dog = test_server:timetrap(?t:minutes(4)),
@@ -50,10 +51,11 @@ suite() -> [{ct_hooks,[ts_install_cth]}].
 all() -> 
     [base64_encode, base64_decode, base64_otp_5635,
      base64_otp_6279, big, illegal, mime_decode, mime_decode_to_string,
-     roundtrip].
+     {group, roundtrip}].
 
 groups() -> 
-    [].
+    [{roundtrip, [parallel],
+      [roundtrip_1, roundtrip_2, roundtrip_3, roundtrip_4]}].
 
 init_per_suite(Config) ->
     Config.
@@ -242,21 +244,33 @@ mime_decode_to_string(Config) when is_list(Config) ->
 
 %%-------------------------------------------------------------------------
 
-roundtrip(Config) when is_list(Config) ->
-    Sizes = lists:seq(1, 255) ++ lists:seq(2400-5, 2440),
-    roundtrip_1(Sizes, []).
+roundtrip_1(Config) when is_list(Config) ->
+    do_roundtrip(1).
 
-roundtrip_1([NextSize|Sizes], Current) ->
+roundtrip_2(Config) when is_list(Config) ->
+    do_roundtrip(2).
+
+roundtrip_3(Config) when is_list(Config) ->
+    do_roundtrip(3).
+
+roundtrip_4(Config) when is_list(Config) ->
+    do_roundtrip(4).
+
+do_roundtrip(Offset) ->
+    Sizes = lists:seq(Offset, 255, 4) ++ lists:seq(2400-6+Offset, 2440, 4),
+    do_roundtrip_1(Sizes, []).
+
+do_roundtrip_1([NextSize|Sizes], Current) ->
     Len = length(Current),
     io:format("~p", [Len]),
-    do_roundtrip(Current),
+    do_roundtrip_2(Current),
     Next = random_byte_list(NextSize - Len, Current),
-    roundtrip_1(Sizes, Next);
-roundtrip_1([], Last) ->
+    do_roundtrip_1(Sizes, Next);
+do_roundtrip_1([], Last) ->
     io:format("~p", [length(Last)]),
-    do_roundtrip(Last).
+    do_roundtrip_2(Last).
 
-do_roundtrip(List) ->
+do_roundtrip_2(List) ->
     Bin = list_to_binary(List),
     Base64Bin = base64:encode(List),
     Base64Bin = base64:encode(Bin),
diff --git a/lib/stdlib/test/lists_SUITE.erl b/lib/stdlib/test/lists_SUITE.erl
index 5a447d58a4..a0f7fd2744 100644
--- a/lib/stdlib/test/lists_SUITE.erl
+++ b/lib/stdlib/test/lists_SUITE.erl
@@ -62,8 +62,7 @@
 	 zip_unzip/1, zip_unzip3/1, zipwith/1, zipwith3/1,
 	 filter_partition/1, 
 	 otp_5939/1, otp_6023/1, otp_6606/1, otp_7230/1,
-	 prefix/1, suffix/1, subtract/1, droplast/1, hof/1,
-	 split/1, concat/1]).
+	 suffix/1, subtract/1, droplast/1, hof/1]).
 
 %% Sort randomized lists until stopped.
 %%
@@ -124,8 +123,8 @@ groups() ->
      {tickets, [parallel], [otp_5939, otp_6023, otp_6606, otp_7230]},
      {zip, [parallel], [zip_unzip, zip_unzip3, zipwith, zipwith3]},
      {misc, [parallel], [reverse, member, dropwhile, takewhile,
-			 filter_partition, prefix, suffix, subtract,
-			 hof, split, concat]}
+			 filter_partition, suffix, subtract,
+			 hof]}
     ].
 
 init_per_suite(Config) ->
@@ -2630,19 +2629,6 @@ otp_6606(Config) when is_list(Config) ->
     ?line L2 = lists:sort(L2),
     ok.
 
-%% Test lists:prefix/2.
-prefix(Config) when is_list(Config) ->
-    true = lists:prefix([], []),
-    true = lists:prefix([], lists:seq(1, 10)),
-    true = lists:prefix([a], [a,b]),
-    true = lists:prefix(lists:seq(1, 10), lists:seq(1, 100)),
-
-    false = lists:prefix([a], []),
-    false = lists:prefix([a], [b]),
-    false = lists:prefix([a], [b,a]),
-
-    ok.
-
 %% Test lists:suffix/2.
 suffix(Config) when is_list(Config) ->
     ?line true = lists:suffix([], []),
@@ -2760,37 +2746,3 @@ hof(Config) when is_list(Config) ->
     false = lists:all(fun(N) -> N rem 2 =:= 0 end, L),
 
     ok.
-
-%% Test lists:split/2
-split(Config) when is_list(Config) ->
-    Lens = lists:seq(0, 32),
-    do_split(Lens),
-
-    %% Error cases.
-    {'EXIT',_} = (catch lists:split(a, [])),
-    {'EXIT',_} = (catch lists:split(-1, [])),
-    {'EXIT',_} = (catch lists:split(0, {a,b})),
-    ok.
-
-do_split([Len|Lens]) ->
-    List = [rand:uniform(1000) || _ <- lists:seq(1, Len)],
-    do_split_1(0, Len, List),
-    do_split(Lens);
-do_split([]) ->
-    ok.
-
-do_split_1(N, Len, List)  when N =:= Len + 1 ->
-    {'EXIT',_} = (catch lists:split(N, List));
-do_split_1(N, Len, List) ->
-    {A,B} = lists:split(N, List),
-    List = A ++ B,
-    N = length(A),
-    LenB = length(B),
-    LenB = Len - N,
-    do_split_1(N+1, Len, List).
-
-%% Test lists:concat/1 mainly for coverage.
-concat(Config) when is_list(Config) ->
-    S = integer_to_list(42) ++ "pi: " ++ float_to_list(math:pi()),
-    S = lists:concat([42,pi,": ",math:pi()]),
-    ok.
-- 
cgit v1.2.3


From d9117a4ae9e35bd1917272460d0e8a52133046d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 8 Sep 2015 15:26:27 +0200
Subject: rand_SUITE: Speed up basic_stats/1

Refactor basic_stats/1 into three separate test cases that can be
run in parallel.
---
 lib/stdlib/test/rand_SUITE.erl | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/lib/stdlib/test/rand_SUITE.erl b/lib/stdlib/test/rand_SUITE.erl
index b03caebe91..111bf620de 100644
--- a/lib/stdlib/test/rand_SUITE.erl
+++ b/lib/stdlib/test/rand_SUITE.erl
@@ -25,7 +25,9 @@
 	]).
 
 -export([interval_int/1, interval_float/1, seed/1,
-         api_eq/1, reference/1, basic_stats/1,
+         api_eq/1, reference/1,
+	 basic_stats_uniform_1/1, basic_stats_uniform_2/1,
+	 basic_stats_normal/1,
 	 plugin/1, measure/1
 	]).
 
@@ -51,11 +53,13 @@ all() ->
     [seed, interval_int, interval_float,
      api_eq,
      reference,
-     basic_stats,
+     {group, basic_stats},
      plugin, measure
     ].
 
-groups() -> [].
+groups() ->
+    [{basic_stats, [parallel],
+      [basic_stats_uniform_1, basic_stats_uniform_2, basic_stats_normal]}].
 
 init_per_suite(Config) ->  Config.
 end_per_suite(_Config) -> ok.
@@ -291,14 +295,19 @@ gen(_, _, Acc) -> lists:reverse(Acc).
 %% The algorithms must have good properties to begin with
 %%
 
-basic_stats(doc) -> ["Check that the algorithms generate sound values."];
-basic_stats(suite) -> [];
-basic_stats(Config) when is_list(Config) ->
-    io:format("Testing uniform~n",[]),
+%% Check that the algorithms generate sound values.
+
+basic_stats_uniform_1(Config) when is_list(Config) ->
     [basic_uniform_1(?LOOP, rand:seed_s(Alg), 0.0, array:new([{default, 0}]))
      || Alg <- algs()],
+    ok.
+
+basic_stats_uniform_2(Config) when is_list(Config) ->
     [basic_uniform_2(?LOOP, rand:seed_s(Alg), 0, array:new([{default, 0}]))
      || Alg <- algs()],
+    ok.
+
+basic_stats_normal(Config) when is_list(Config) ->
     io:format("Testing normal~n",[]),
     [basic_normal_1(?LOOP, rand:seed_s(Alg), 0, 0) || Alg <- algs()],
     ok.
-- 
cgit v1.2.3