From ce2a4e4409a5b0da5522056c29df27ab0afe95ee Mon Sep 17 00:00:00 2001 From: Lukas Larsson Date: Thu, 20 Jun 2019 16:09:53 +0200 Subject: Add 'make dialyzer' target to top and apps --- Makefile.in | 5 ++++- lib/asn1/Makefile | 7 +------ lib/common_test/Makefile | 3 +++ lib/compiler/Makefile | 2 ++ lib/debugger/Makefile | 2 ++ lib/dialyzer/Makefile | 2 ++ lib/diameter/Makefile | 5 +---- lib/edoc/Makefile | 6 ++---- lib/eldap/Makefile | 2 ++ lib/erl_docgen/Makefile | 1 + lib/et/Makefile | 2 ++ lib/eunit/Makefile | 8 +------- lib/ftp/Makefile | 40 +--------------------------------------- lib/hipe/Makefile | 2 ++ lib/inets/Makefile | 40 +--------------------------------------- lib/megaco/Makefile | 25 +++++-------------------- lib/observer/Makefile | 1 + lib/odbc/Makefile | 6 ------ lib/public_key/Makefile | 2 ++ lib/reltool/Makefile | 2 ++ lib/runtime_tools/Makefile | 1 + lib/sasl/Makefile | 2 ++ lib/snmp/Makefile | 38 +------------------------------------- lib/ssh/Makefile | 1 + lib/ssl/Makefile | 2 ++ lib/stdlib/Makefile | 2 ++ lib/tftp/Makefile | 34 +--------------------------------- lib/tools/Makefile | 2 ++ lib/xmerl/Makefile | 7 +------ make/app_targets.mk | 43 ++++++++++++++++++++++++++++++++++++++++++- 30 files changed, 92 insertions(+), 203 deletions(-) diff --git a/Makefile.in b/Makefile.in index 3c4a6da85e..55decd8794 100644 --- a/Makefile.in +++ b/Makefile.in @@ -1142,7 +1142,10 @@ bootstrap_clean: # ---------------------------------------------------------------------- -.PHONY: test +.PHONY: test dialyzer test: all release release_tests $(ERL_TOP)/make/test_target_script.sh $(ERL_TOP) + +dialyzer: all + $(ERL_TOP)/scripts/run-dialyzer diff --git a/lib/asn1/Makefile b/lib/asn1/Makefile index 63cb770043..10a8795703 100644 --- a/lib/asn1/Makefile +++ b/lib/asn1/Makefile @@ -54,12 +54,7 @@ SPECIAL_TARGETS = include $(ERL_TOP)/make/otp_subdir.mk -.PHONY: info version - -info: - @echo "APP_RELEASE_DIR: $(APP_RELEASE_DIR)" - @echo "APP_DIR: $(APP_DIR)" - @echo "APP_TAR_FILE: $(APP_TAR_FILE)" +.PHONY: version version: @echo "$(VSN)" diff --git a/lib/common_test/Makefile b/lib/common_test/Makefile index 35739462c5..5ac76f0044 100644 --- a/lib/common_test/Makefile +++ b/lib/common_test/Makefile @@ -45,4 +45,7 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=compiler tools crypto runtime_tools syntax_tools ftp inets \ + debugger sasl snmp ssh reltool observer xmerl + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/compiler/Makefile b/lib/compiler/Makefile index 3678f48b7c..f18df11e9f 100644 --- a/lib/compiler/Makefile +++ b/lib/compiler/Makefile @@ -36,4 +36,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=crypto hipe + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/debugger/Makefile b/lib/debugger/Makefile index f91b8bfa5e..3a06d72c5d 100644 --- a/lib/debugger/Makefile +++ b/lib/debugger/Makefile @@ -35,4 +35,6 @@ SPECIAL_TARGETS = # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=wx + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/dialyzer/Makefile b/lib/dialyzer/Makefile index ab0b94748e..53083f267d 100644 --- a/lib/dialyzer/Makefile +++ b/lib/dialyzer/Makefile @@ -42,4 +42,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=compiler syntax_tools hipe wx + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/diameter/Makefile b/lib/diameter/Makefile index 8c3c0ff0cc..a25baeb929 100644 --- a/lib/diameter/Makefile +++ b/lib/diameter/Makefile @@ -27,9 +27,6 @@ SPECIAL_TARGETS = include $(ERL_TOP)/make/otp_subdir.mk -info: - @echo "APP_VSN = $(APP_VSN)" - -.PHONY: info +DIA_PLT_APPS=ssl runtime_tools syntax_tools include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/edoc/Makefile b/lib/edoc/Makefile index 6dfc6f51c7..a8258015b1 100644 --- a/lib/edoc/Makefile +++ b/lib/edoc/Makefile @@ -69,7 +69,7 @@ SPECIAL_TARGETS = include $(ERL_TOP)/make/otp_subdir.mk -.PHONY: info version +.PHONY: version version: @@ -92,9 +92,6 @@ edocs: -pa $(XMERL_DIR)/ebin -run edoc_run application \ "'$(APPNAME)'" '"."' '$(DOC_OPTS)' -info: - @echo $(HTML_FILES) - app_release: tar @@ -125,5 +122,6 @@ tar: $(APP_TAR_FILE) $(APP_TAR_FILE): $(APP_DIR) (cd $(APP_RELEASE_DIR); gtar zcf $(APP_TAR_FILE) $(DIR_NAME)) +DIA_PLT_APPS=syntax_tools xmerl inets include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/eldap/Makefile b/lib/eldap/Makefile index 98b5203dfd..30a8f778ab 100644 --- a/lib/eldap/Makefile +++ b/lib/eldap/Makefile @@ -38,4 +38,6 @@ SPECIAL_TARGETS = # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=asn ssl + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/erl_docgen/Makefile b/lib/erl_docgen/Makefile index a13a3c4f94..7e9cc824ec 100644 --- a/lib/erl_docgen/Makefile +++ b/lib/erl_docgen/Makefile @@ -36,5 +36,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=edoc xmerl include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/et/Makefile b/lib/et/Makefile index 98e15dc179..1b89cff83e 100644 --- a/lib/et/Makefile +++ b/lib/et/Makefile @@ -35,4 +35,6 @@ SPECIAL_TARGETS = # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=runtime_tools wx + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/eunit/Makefile b/lib/eunit/Makefile index acc765faf9..d0dd447a6c 100644 --- a/lib/eunit/Makefile +++ b/lib/eunit/Makefile @@ -48,13 +48,7 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk - -.PHONY: info version - -info: - @echo "APP_RELEASE_DIR: $(APP_RELEASE_DIR)" - @echo "APP_DIR: $(APP_DIR)" - @echo "APP_TAR_FILE: $(APP_TAR_FILE)" +.PHONY: version version: @echo "$(VSN)" diff --git a/lib/ftp/Makefile b/lib/ftp/Makefile index e6bceebe15..a26d1de0a0 100644 --- a/lib/ftp/Makefile +++ b/lib/ftp/Makefile @@ -32,49 +32,11 @@ VSN = $(FTP_VSN) SPECIAL_TARGETS = -DIA_PLT = ./priv/plt/$(APPLICATION).plt -DIA_ANALYSIS = $(basename $(DIA_PLT)).dialyzer_analysis - - # ---------------------------------------------------- # Default Subdir Targets # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk -.PHONY: info gclean dialyzer dialyzer_plt dclean - -info: - @echo "OS: $(OS)" - @echo "DOCB: $(DOCB)" - @echo "" - @echo "FTP_VSN: $(FTP_VSN)" - @echo "APP_VSN: $(APP_VSN)" - @echo "" - @echo "DIA_PLT: $(DIA_PLT)" - @echo "DIA_ANALYSIS: $(DIA_ANALYSIS)" - @echo "" - -gclean: - git clean -fXd - -dclean: - rm -f $(DIA_PLT) - rm -f $(DIA_ANALYSIS) - -dialyzer_plt: $(DIA_PLT) - -$(DIA_PLT): - @echo "Building $(APPLICATION) plt file" - @dialyzer --build_plt \ - --output_plt $@ \ - -r ../$(APPLICATION)/ebin \ - --output $(DIA_ANALYSIS) \ - --verbose - -dialyzer: $(DIA_PLT) - @echo "Running dialyzer on $(APPLICATION)" - @dialyzer --plt $< \ - ../$(APPLICATION)/ebin \ - --verbose +DIA_PLT_APPS = runtime_tools ssl include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/hipe/Makefile b/lib/hipe/Makefile index a1c5f9c83f..4998522943 100644 --- a/lib/hipe/Makefile +++ b/lib/hipe/Makefile @@ -75,4 +75,6 @@ distclean: realclean: $(V_at)$(MAKE) MAKETARGET="realclean" all-subdirs all-subdirs-x +DIA_PLT_APPS=compiler syntax_tools + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/inets/Makefile b/lib/inets/Makefile index 9a03ee93df..a7723dc0d8 100644 --- a/lib/inets/Makefile +++ b/lib/inets/Makefile @@ -32,49 +32,11 @@ VSN = $(INETS_VSN) SPECIAL_TARGETS = -DIA_PLT = ./priv/plt/$(APPLICATION).plt -DIA_ANALYSIS = $(basename $(DIA_PLT)).dialyzer_analysis - - # ---------------------------------------------------- # Default Subdir Targets # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk -.PHONY: info gclean dialyzer dialyzer_plt dclean - -info: - @echo "OS: $(OS)" - @echo "DOCB: $(DOCB)" - @echo "" - @echo "INETS_VSN: $(INETS_VSN)" - @echo "APP_VSN: $(APP_VSN)" - @echo "" - @echo "DIA_PLT: $(DIA_PLT)" - @echo "DIA_ANALYSIS: $(DIA_ANALYSIS)" - @echo "" - -gclean: - git clean -fXd - -dclean: - rm -f $(DIA_PLT) - rm -f $(DIA_ANALYSIS) - -dialyzer_plt: $(DIA_PLT) - -$(DIA_PLT): - @echo "Building $(APPLICATION) plt file" - @dialyzer --build_plt \ - --output_plt $@ \ - -r ../$(APPLICATION)/ebin \ - --output $(DIA_ANALYSIS) \ - --verbose - -dialyzer: $(DIA_PLT) - @echo "Running dialyzer on $(APPLICATION)" - @dialyzer --plt $< \ - ../$(APPLICATION)/ebin \ - --verbose +DIA_PLT_APPS=runtime_tools ftp mnesia ssl tftp include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/megaco/Makefile b/lib/megaco/Makefile index c88327c615..624c4b0619 100644 --- a/lib/megaco/Makefile +++ b/lib/megaco/Makefile @@ -110,7 +110,7 @@ DIA_ANALYSIS = $(basename $(DIA_PLT)).dialyzer_analysis # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk -.PHONY: reconf conf dconf econf configure setup info version \ +.PHONY: reconf conf dconf econf configure setup info_megaco version \ app_install dialyzer reconf: @@ -136,16 +136,15 @@ configure: configure.in setup: (cd src && $(MAKE) $@) -info: +info_megaco: @echo "APP_RELEASE_DIR: $(APP_RELEASE_DIR)" @echo "APP_DIR: $(APP_DIR)" @echo "APP_TAR_FILE: $(APP_TAR_FILE)" @echo "OTP_INSTALL_DIR: $(OTP_INSTALL_DIR)" @echo "APP_INSTALL_DIR: $(APP_INSTALL_DIR)" @echo "" - @echo "DIA_PLT: $(DIA_PLT)" - @echo "DIA_ANALYSIS: $(DIA_ANALYSIS)" - @echo "" + +info: info_megaco version: @echo "$(VSN)" @@ -204,20 +203,6 @@ tar: $(APP_TAR_FILE) $(APP_TAR_FILE): $(APP_DIR) (cd "$(APP_RELEASE_DIR)"; gtar zcf "$(subst $(space),\ ,$@)" $(DIR_NAME)) -dialyzer_plt: $(DIA_PLT) - -$(DIA_PLT): - @echo "Building $(APPLICATION) plt file" - @dialyzer --build_plt \ - --output_plt $@ \ - -r ../$(APPLICATION)/ebin \ - --output $(DIA_ANALYSIS) \ - --verbose - -dialyzer: $(DIA_PLT) - @echo "Running dialyzer on $(APPLICATION)" - @dialyzer --plt $< \ - ../$(APPLICATION)/ebin \ - --verbose +DIA_PLT_APPS=asn1 runtime_tools et debugger include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/observer/Makefile b/lib/observer/Makefile index 4770a72ba8..ffd73051b9 100644 --- a/lib/observer/Makefile +++ b/lib/observer/Makefile @@ -36,5 +36,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=runtime_tools et wx include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/odbc/Makefile b/lib/odbc/Makefile index dfa224ecd6..ee39992a84 100644 --- a/lib/odbc/Makefile +++ b/lib/odbc/Makefile @@ -69,12 +69,6 @@ do_configure: configure configure: configure.in autoconf -.PHONY: info - -info: - @echo "ODBC_VSN: $(ODBC_VSN)" - - # ---------------------------------------------------- # Application (source) release targets # ---------------------------------------------------- diff --git a/lib/public_key/Makefile b/lib/public_key/Makefile index 3b6cb3ce6c..ed8901a8af 100644 --- a/lib/public_key/Makefile +++ b/lib/public_key/Makefile @@ -38,4 +38,6 @@ SPECIAL_TARGETS = # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=asn crypto + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/reltool/Makefile b/lib/reltool/Makefile index 70c80e1c3c..0a39d7daa8 100644 --- a/lib/reltool/Makefile +++ b/lib/reltool/Makefile @@ -36,4 +36,6 @@ SPECIAL_TARGETS = # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=wx sasl + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/runtime_tools/Makefile b/lib/runtime_tools/Makefile index 9a0822b9b6..4b0f1633ab 100644 --- a/lib/runtime_tools/Makefile +++ b/lib/runtime_tools/Makefile @@ -36,5 +36,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=mnesia include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/sasl/Makefile b/lib/sasl/Makefile index 1710606d3d..06af80fd35 100644 --- a/lib/sasl/Makefile +++ b/lib/sasl/Makefile @@ -36,4 +36,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=tools + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/snmp/Makefile b/lib/snmp/Makefile index 34ab309cfa..52debf1670 100644 --- a/lib/snmp/Makefile +++ b/lib/snmp/Makefile @@ -71,24 +71,6 @@ do_configure: configure configure: configure.in autoconf -.PHONY: info gclean - -info: - @echo "OS: $(OS)" - @echo "DOCB: $(DOCB)" - @echo "" - @echo "SNMP_VSN: $(SNMP_VSN)" - @echo "APP_VSN: $(APP_VSN)" - @echo "" - @echo "DIA_PLT: $(DIA_PLT)" - @echo "DIA_ANALYSIS: $(DIA_ANALYSIS)" - @echo "" - - -gclean: - git clean -fXd - - # ---------------------------------------------------- # Application (source) release targets # ---------------------------------------------------- @@ -130,24 +112,6 @@ tar: $(APP_TAR_FILE) $(APP_TAR_FILE): $(APP_DIR) (cd $(APP_RELEASE_DIR); gtar zcf $(APP_TAR_FILE) $(DIR_NAME)) -dclean: - rm -f $(DIA_PLT) - rm -f $(DIA_ANALYSIS) - -dialyzer_plt: $(DIA_PLT) - -$(DIA_PLT): - @echo "Building $(APPLICATION) plt file" - @dialyzer --build_plt \ - --output_plt $@ \ - -r ../$(APPLICATION)/ebin \ - --output $(DIA_ANALYSIS) \ - --verbose - -dialyzer: $(DIA_PLT) - @echo "Running dialyzer on $(APPLICATION)" - @dialyzer --plt $< \ - ../$(APPLICATION)/ebin \ - --verbose +DIA_PLT_APPS=runtime_tools crypto mnesia include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/ssh/Makefile b/lib/ssh/Makefile index ab3948df75..b96cc2bbaa 100644 --- a/lib/ssh/Makefile +++ b/lib/ssh/Makefile @@ -37,5 +37,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=crypto runtime_tools public_key include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/ssl/Makefile b/lib/ssl/Makefile index c761979474..526560288f 100644 --- a/lib/ssl/Makefile +++ b/lib/ssl/Makefile @@ -38,4 +38,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=crypto runtime_tools inets public_key + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/stdlib/Makefile b/lib/stdlib/Makefile index 0444cedadb..cae3844126 100644 --- a/lib/stdlib/Makefile +++ b/lib/stdlib/Makefile @@ -36,4 +36,6 @@ SPECIAL_TARGETS = # include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=compiler crypto + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/tftp/Makefile b/lib/tftp/Makefile index 348a4a86b6..d0397beaa0 100644 --- a/lib/tftp/Makefile +++ b/lib/tftp/Makefile @@ -43,38 +43,6 @@ include $(ERL_TOP)/make/otp_subdir.mk .PHONY: info gclean dialyzer dialyzer_plt dclean -info: - @echo "OS: $(OS)" - @echo "DOCB: $(DOCB)" - @echo "" - @echo "TFTP_VSN: $(TFTP_VSN)" - @echo "APP_VSN: $(APP_VSN)" - @echo "" - @echo "DIA_PLT: $(DIA_PLT)" - @echo "DIA_ANALYSIS: $(DIA_ANALYSIS)" - @echo "" - -gclean: - git clean -fXd - -dclean: - rm -f $(DIA_PLT) - rm -f $(DIA_ANALYSIS) - -dialyzer_plt: $(DIA_PLT) - -$(DIA_PLT): - @echo "Building $(APPLICATION) plt file" - @dialyzer --build_plt \ - --output_plt $@ \ - -r ../$(APPLICATION)/ebin \ - --output $(DIA_ANALYSIS) \ - --verbose - -dialyzer: $(DIA_PLT) - @echo "Running dialyzer on $(APPLICATION)" - @dialyzer --plt $< \ - ../$(APPLICATION)/ebin \ - --verbose +DIA_PLT_APPS= include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/tools/Makefile b/lib/tools/Makefile index 811926e20d..d849989a2d 100644 --- a/lib/tools/Makefile +++ b/lib/tools/Makefile @@ -36,4 +36,6 @@ SPECIAL_TARGETS = # ---------------------------------------------------- include $(ERL_TOP)/make/otp_subdir.mk +DIA_PLT_APPS=compiler runtime_tools + include $(ERL_TOP)/make/app_targets.mk diff --git a/lib/xmerl/Makefile b/lib/xmerl/Makefile index 84b243fe68..65a0af9e4a 100644 --- a/lib/xmerl/Makefile +++ b/lib/xmerl/Makefile @@ -50,12 +50,7 @@ SPECIAL_TARGETS = include $(ERL_TOP)/make/otp_subdir.mk -.PHONY: info version - -info: - @echo "APP_RELEASE_DIR: $(APP_RELEASE_DIR)" - @echo "APP_DIR: $(APP_DIR)" - @echo "APP_TAR_FILE: $(APP_TAR_FILE)" +.PHONY: version version: @echo "$(VSN)" diff --git a/make/app_targets.mk b/make/app_targets.mk index 3f28a529d4..e9aaa4193c 100644 --- a/make/app_targets.mk +++ b/make/app_targets.mk @@ -18,8 +18,49 @@ # %CopyrightEnd% # +APPLICATION ?= $(basename $(notdir $(PWD))) -.PHONY: test +.PHONY: test info gclean dialyzer dialyzer_plt dclean test: $(ERL_TOP)/make/test_target_script.sh $(ERL_TOP) + +info: + @echo "$(APPLICATION)_VSN: $(VSN)" + @echo "APP_VSN: $(APP_VSN)" + @echo "" + @echo "DIA_PLT: $(DIA_PLT)" + @echo "DIA_ANALYSIS: $(DIA_ANALYSIS)" + @echo "" + +gclean: + git clean -fXd + + +DIA_DEFAULT_PLT_APPS = erts kernel stdlib $(APPLICATION) +DIA_PLT_DIR = ./priv/plt +DIA_PLT = $(DIA_PLT_DIR)/$(APPLICATION).plt +DIA_ANALYSIS = $(basename $(DIA_PLT)).dialyzer_analysis + +dialyzer_plt: $(DIA_PLT) + +$(DIA_PLT_DIR): + @mkdir -p $@ + +$(DIA_PLT): $(DIA_PLT_DIR) + @echo "Building $(APPLICATION) plt file" + @$(ERL_TOP)/bin/dialyzer --build_plt \ + --output_plt $@ \ + --apps $(sort $(DIA_PLT_APPS) $(DIA_DEFAULT_PLT_APPS)) \ + --output $(DIA_ANALYSIS) \ + --verbose + +dialyzer: $(DIA_PLT) + @echo "Running dialyzer on $(APPLICATION)" + @dialyzer --plt $< \ + ../$(APPLICATION)/ebin \ + --verbose + +dclean: + rm -f $(DIA_PLT) + rm -f $(DIA_ANALYSIS) -- cgit v1.2.3 From 1012012d4799de44c26826584fd155a95a0c92aa Mon Sep 17 00:00:00 2001 From: Lukas Larsson Date: Tue, 6 Aug 2019 15:59:16 +0200 Subject: otp: Add make dialyzer and make xmllint documentation --- CONTRIBUTING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8814e506f9..b754fbd662 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,7 +30,7 @@ By making a contribution to this project, I certify that: Erlang/otp is licensed under the Apache License 2.0 -As stated in: LICENSE.txt +As stated in: [LICENSE.txt](LICENSE.txt) http://developercertificate.org/ @@ -95,6 +95,9 @@ a discussion on the mailing list. * Make sure existing test cases don't fail. It is not necessary to run all tests (that would take many hours), but you should at least run the tests for the application you have changed. See [Running tests](https://github.com/erlang/otp/wiki/Running-tests). +* Make sure the documentation builds and is according to the dtd. eg. `make xmllint` or `cd lib/stdlib/ && make xmllint` +* Make sure no new dialyzer warnings have been added. eg. `make dialyzer` or `cd lib/stdlib/ && make dialyzer` +* Make sure that travis passes, if you go to https://travis-ci.org/$YOUR_GITHUB_USER/otp/ you can enable travis builds for you otp fork. Make sure that your branch contains clean commits: -- cgit v1.2.3