From 8b9b6e1436e255b8cd40ed8ab44bc0c7a90ef798 Mon Sep 17 00:00:00 2001 From: Lukas Larsson Date: Tue, 15 Feb 2011 13:37:19 +0100 Subject: Cleanup code to fix dialyzer warning --- lib/common_test/src/ct_hooks.erl | 2 +- lib/common_test/src/ct_run.erl | 12 +----------- lib/common_test/src/ct_testspec.erl | 2 -- 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/lib/common_test/src/ct_hooks.erl b/lib/common_test/src/ct_hooks.erl index 8e80ce8f37..77b7566d9e 100644 --- a/lib/common_test/src/ct_hooks.erl +++ b/lib/common_test/src/ct_hooks.erl @@ -94,7 +94,7 @@ init_tc(_Mod, TC, Config) -> {skip, Reason :: term()} | {auto_skip, Reason :: term()} | {fail, Reason :: term()} | - ok. + ok | '$ct_no_change'. end_tc(ct_framework, _Func, _Args, Result, _Return) -> Result; diff --git a/lib/common_test/src/ct_run.erl b/lib/common_test/src/ct_run.erl index 36fccf65f3..f50a46a241 100644 --- a/lib/common_test/src/ct_run.erl +++ b/lib/common_test/src/ct_run.erl @@ -1072,15 +1072,7 @@ refresh_logs(LogDir) -> which(logdir, undefined) -> "."; which(logdir, Dir) -> - Dir; -which(multiply_timetraps, undefined) -> - 1; -which(multiply_timetraps, MT) -> - MT; -which(scale_timetraps, undefined) -> - false; -which(scale_timetraps, ST) -> - ST. + Dir. choose_val(undefined, V1) -> V1; @@ -2068,8 +2060,6 @@ get_start_opt(Key, IfExists, IfNotExists, Args) -> Val; {value,{Key,_Val}} -> IfExists; - _ when is_function(IfNotExists) -> - IfNotExists(); _ -> IfNotExists end. diff --git a/lib/common_test/src/ct_testspec.erl b/lib/common_test/src/ct_testspec.erl index db1d4c5fb0..2b6abefb72 100644 --- a/lib/common_test/src/ct_testspec.erl +++ b/lib/common_test/src/ct_testspec.erl @@ -394,8 +394,6 @@ filter_init_terms([Term|Ts], NewTerms, Spec)-> filter_init_terms([], NewTerms, Spec)-> {lists:reverse(NewTerms), Spec}. -add_option([], _, List, _)-> - List; add_option({Key, Value}, Node, List, WarnIfExists) when is_list(Value)-> OldOptions = case lists:keyfind(Node, 1, List) of {Node, Options}-> -- cgit v1.2.3