From 90989e58d9e7f7c6fc3c4b52e4191d66d8ff2a96 Mon Sep 17 00:00:00 2001
From: Siri Hansen <siri@erlang.org>
Date: Thu, 28 Apr 2016 09:52:48 +0200
Subject: [ttb] Allow setting trace flags on ports

---
 lib/observer/doc/src/ttb.xml | 30 ++++++++++++++++++------------
 lib/observer/src/ttb.erl     | 36 +++++++++++++++++++-----------------
 2 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/lib/observer/doc/src/ttb.xml b/lib/observer/doc/src/ttb.xml
index 76bbc777e8..94ecef24b4 100644
--- a/lib/observer/doc/src/ttb.xml
+++ b/lib/observer/doc/src/ttb.xml
@@ -229,27 +229,33 @@ ttb:p(all, call).</input></pre>
     </func>
 
     <func>
-      <name>p(Procs,Flags) -> Return</name>
-      <fsummary>Set the specified trace flags on the specified processes.</fsummary>
+      <name>p(Item,Flags) -> Return</name>
+      <fsummary>Set the specified trace flags on the specified processes or ports.</fsummary>
       <type>
-        <v>Return = {ok,[{Procs,MatchDesc}]}</v>
-        <v>Procs   = Process | [Process] | all | new | existing</v>
-        <v>Process = pid() | atom() | {global,atom()}</v>
+        <v>Return  = {ok,[{Item,MatchDesc}]}</v>
+        <v>Items   = Item | [Item]</v>
+	<v>Item    = pid() | port() | RegName | {global,GlobalRegName} |
+	  all | processes | ports |
+	  existing | existing_processes | existing_ports |
+	  new | new_processes | new_ports</v>
+        <v>RegName = atom()</v>
+	<v>GlobalRegName = term()</v>
         <v>Flags   = Flag | [Flag]</v>
       </type>
       <desc>
-        <p>Sets the specified trace flags on the specified
-          processes. Flag <c>timestamp</c> is always turned on.
+        <p>Sets the specified trace flags on the specified processes
+          or ports. Flag <c>timestamp</c> is always turned on.
           </p>
         <p>See the Reference Manual for module 
 	<seealso marker="runtime_tools:dbg"><c>dbg</c></seealso>
-          and the possible trace flags. Parameter
+          for the possible trace flags. Parameter
           <c>MatchDesc</c> is the same as returned from 
 	<c>dbg:p/2</c>.</p>
         <p>Processes can be specified as registered names, globally
-          registered names, or process identifiers. If a registered name
-          is specified, the flags are set on processes with this name on all
-          active nodes.</p>
+          registered names, or process identifiers. Ports can be
+          specified as registered names or port identifiers. If a
+          registered name is specified, the flags are set on
+          processes/ports with this name on all active nodes.</p>
         <p>Issuing this command starts the timer for this trace if option
           <c>timer</c> is specified with <c>tracer/2</c>.
         </p>
@@ -267,7 +273,7 @@ ttb:p(all, call).</input></pre>
           function calls are traced on that process if a trace
           pattern is set for the called function.</p>
 	<p>The <c>send</c> and <c>'receive'</c> flags enable tracing
-	  of all messages sent and received by the process. Trace
+	  of all messages sent and received by the process/port. Trace
 	  patterns set with <c>tpe</c> may limit traced messages based
 	  on the message content, the sender, and/or the receiver.</p>
 	<p>Trace patterns specify how to trace a function or a message
diff --git a/lib/observer/src/ttb.erl b/lib/observer/src/ttb.erl
index 32c2fad775..e41f2c36fc 100644
--- a/lib/observer/src/ttb.erl
+++ b/lib/observer/src/ttb.erl
@@ -398,16 +398,16 @@ arg_list([A1|A],Acc) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %%% Set trace flags on processes
-p(Procs0,Flags0) ->
+p(ProcsPorts0,Flags0) ->
     ensure_no_overloaded_nodes(),
-    store(p,[Procs0,Flags0]),
-    no_store_p(Procs0,Flags0).
-no_store_p(Procs0,Flags0) ->
+    store(p,[ProcsPorts0,Flags0]),
+    no_store_p(ProcsPorts0,Flags0).
+no_store_p(ProcsPorts0,Flags0) ->
     case transform_flags(to_list(Flags0)) of
 	{error,Reason} -> 
 	    {error,Reason};
 	Flags ->
-	    Procs = procs(Procs0),
+	    ProcsPorts = procs_ports(ProcsPorts0),
 	    case lists:foldl(fun(P,{PMatched,Ps}) -> case dbg:p(P,Flags) of
 					     {ok,Matched} -> 
 						 {[{P,Matched}|PMatched],[P|Ps]};
@@ -415,7 +415,7 @@ no_store_p(Procs0,Flags0) ->
 						 display_warning(P,Reason),
 						 {PMatched,Ps}
 						     end
-			     end,{[],[]},Procs) of
+			     end,{[],[]},ProcsPorts) of
 		{[],[]} -> {error, no_match};
 		{SuccMatched,Succ} ->
 		    no_store_write_trace_info(flags,{Succ,Flags}),
@@ -430,20 +430,22 @@ transform_flags(Flags) ->
     dbg:transform_flags([timestamp | Flags]).
 
 
-procs(Procs) when is_list(Procs) ->
-    lists:foldl(fun(P,Acc) -> proc(P)++Acc end,[],Procs);
-procs(Proc) ->
-    proc(Proc).
+procs_ports(Procs) when is_list(Procs) ->
+    lists:foldl(fun(P,Acc) -> proc_port(P)++Acc end,[],Procs);
+procs_ports(Proc) ->
+    proc_port(Proc).
 
-proc(Procs) when Procs=:=all; Procs=:=ports; Procs=:=processes;
-                 Procs=:=existing; Procs=:=existing_ports; Procs=:=existing_processes;
-                 Procs=:=new; Procs=:=new_ports; Procs=:=new_processes ->
-    [Procs];
-proc(Name) when is_atom(Name) ->
+proc_port(P) when P=:=all; P=:=ports; P=:=processes;
+                 P=:=existing; P=:=existing_ports; P=:=existing_processes;
+                 P=:=new; P=:=new_ports; P=:=new_processes ->
+    [P];
+proc_port(Name) when is_atom(Name) ->
     [Name]; % can be registered on this node or other node
-proc(Pid) when is_pid(Pid) ->
+proc_port(Pid) when is_pid(Pid) ->
     [Pid];
-proc({global,Name}) ->
+proc_port(Port) when is_port(Port) ->
+    [Port];
+proc_port({global,Name}) ->
     case global:whereis_name(Name) of
 	Pid when is_pid(Pid) ->
 	    [Pid];
-- 
cgit v1.2.3