From 489ee09fe1673043f6f6a93a1371b4e7b11ef4ff Mon Sep 17 00:00:00 2001
From: Siri Hansen <siri@erlang.org>
Date: Mon, 17 Dec 2012 18:02:15 +0100
Subject: [observer] Fix crashdump_viewer tests for R16

Generate dumps for r14, r15 and r16.
Save generated dumps if test fails.
---
 lib/observer/test/crashdump_viewer_SUITE.erl | 58 ++++++++++++++++++++++++----
 1 file changed, 51 insertions(+), 7 deletions(-)

diff --git a/lib/observer/test/crashdump_viewer_SUITE.erl b/lib/observer/test/crashdump_viewer_SUITE.erl
index 6f882d0be9..7487a004af 100644
--- a/lib/observer/test/crashdump_viewer_SUITE.erl
+++ b/lib/observer/test/crashdump_viewer_SUITE.erl
@@ -34,6 +34,7 @@
 
 -define(default_timeout, ?t:minutes(30)).
 -define(sl_alloc_vsns,[r9b]).
+-define(failed_file,"failed-cases.txt").
 
 init_per_testcase(_Case, Config) ->
     DataDir = ?config(data_dir,Config),
@@ -42,9 +43,18 @@ init_per_testcase(_Case, Config) ->
     catch crashdump_viewer:stop(),
     Dog = ?t:timetrap(?default_timeout),
     [{watchdog, Dog}|Config].
-end_per_testcase(_Case, Config) ->
+end_per_testcase(Case, Config) ->
     Dog=?config(watchdog, Config),
     ?t:timetrap_cancel(Dog),
+    case ?config(tc_status,Config) of
+	ok ->
+	    ok;
+	_Fail ->
+	    File = filename:join(?config(data_dir,Config),?failed_file),
+	    {ok,Fd}=file:open(File,[append]),
+	    file:write(Fd,io_lib:format("~w.~n",[Case])),
+	    file:close(Fd)
+    end,
     ok.
 
 suite() -> [{ct_hooks,[ts_install_cth]}].
@@ -67,15 +77,26 @@ init_per_suite(doc) ->
     ["Create a lot of crashdumps which can be used in the testcases below"];
 init_per_suite(Config) when is_list(Config) ->
     Dog = ?t:timetrap(?default_timeout),
+    delete_saved(Config),
     application:start(inets), % will be using the http client later
     httpc:set_options([{ipfamily,inet6fb4}]),
     DataDir = ?config(data_dir,Config),
-    Rels = [R || R <- [r13b,r14b], ?t:is_release_available(R)] ++ [current],
+    Rels = [R || R <- [r14b,r15b], ?t:is_release_available(R)] ++ [current],
     io:format("Creating crash dumps for the following releases: ~p", [Rels]),
     AllDumps = create_dumps(DataDir,Rels),
     ?t:timetrap_cancel(Dog),
     [{dumps,AllDumps}|Config].
 
+delete_saved(Config) ->
+    DataDir = ?config(data_dir,Config),
+    file:delete(filename:join(DataDir,?failed_file)),
+    SaveDir = filename:join(DataDir,"save"),
+    Dumps = filelib:wildcard(filename:join(SaveDir,"*")),
+    lists:foreach(fun(F) -> file:delete(F) end, Dumps),
+    file:del_dir(SaveDir),
+    ok.
+
+
 translate(suite) ->
     [];
 translate(doc) ->
@@ -196,6 +217,23 @@ end_per_suite(doc) ->
     ["Remove generated crashdumps"];
 end_per_suite(Config) when is_list(Config) ->
     Dumps = ?config(dumps,Config),
+    DataDir = ?config(data_dir,Config),
+    FailedFile = filename:join(DataDir,?failed_file),
+    case filelib:is_file(FailedFile) of
+	true ->
+	    SaveDir = filename:join(DataDir,"save"),
+	    file:make_dir(SaveDir),
+	    file:copy(FailedFile,filename:join(SaveDir,?failed_file)),
+	    lists:foreach(
+	      fun(CD) ->
+		      File = filename:basename(CD),
+		      New = filename:join(SaveDir,File),
+		      file:copy(CD,New)
+	      end, Dumps);
+	false ->
+	    ok
+    end,
+    file:delete(FailedFile),
     lists:foreach(fun(CD) -> ok = file:delete(CD) end,Dumps),
     lists:keydelete(dumps,1,Config).
 
@@ -568,11 +606,14 @@ expand_link(Html) ->
 
 
 port_details(Port) ->
-    Port1 = contents(Port,"port?port=Port<0.1>"),
-    "#Port<0.1>" = title(Port1),
-    
     Port0 = contents(Port,"port?port=Port<0.0>"),
-    "Could not find port: #Port<0.0>" = title(Port0).
+    Port1 = contents(Port,"port?port=Port<0.1>"),
+    case title(Port0) of
+	"#Port<0.0>" -> % R16 or later
+	    "Could not find port: #Port<0.1>" = title(Port1);
+	"Could not find port: #Port<0.0>" -> % R15 or earlier
+	    "#Port<0.1>" = title(Port1)
+    end.
 
 is_truncated(File) ->
     case filename:extension(filename:rootname(File)) of
@@ -752,6 +793,7 @@ rel_opt(Rel) ->
 	r12b -> [{erl,[{release,"r12b_patched"}]}];
 	r13b -> [{erl,[{release,"r13b_patched"}]}];
 	r14b -> [{erl,[{release,"r14b_latest"}]}]; %naming convention changed
+	r15b -> [{erl,[{release,"r15b_latest"}]}];
 	current -> []
     end.
 
@@ -764,7 +806,8 @@ dump_prefix(Rel) ->
 	r12b -> "r12b_dump.";
 	r13b -> "r13b_dump.";
 	r14b -> "r14b_dump.";
-	current -> "r15b_dump."
+	r15b -> "r15b_dump.";
+	current -> "r16b_dump."
     end.
 
 compat_rel(Rel) ->
@@ -776,5 +819,6 @@ compat_rel(Rel) ->
 	r12b -> "+R12 ";
 	r13b -> "+R13 ";
 	r14b -> "+R14 ";
+	r15b -> "+R15 ";
 	current -> ""
     end.
-- 
cgit v1.2.3


From 0b8a2e665aba75cb0b0be5c08d4cbbee508589b2 Mon Sep 17 00:00:00 2001
From: Siri Hansen <siri@erlang.org>
Date: Mon, 17 Dec 2012 18:24:57 +0100
Subject: [observer] Set ERL_CRASH_DUMP_SECONDS/=-1 on old releases

Else, crashdumps can not be generated.
---
 lib/observer/test/crashdump_viewer_SUITE.erl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/observer/test/crashdump_viewer_SUITE.erl b/lib/observer/test/crashdump_viewer_SUITE.erl
index 7487a004af..1b8796d464 100644
--- a/lib/observer/test/crashdump_viewer_SUITE.erl
+++ b/lib/observer/test/crashdump_viewer_SUITE.erl
@@ -732,6 +732,12 @@ dump_with_strange_module_name(DataDir,Rel,DumpName) ->
     CD.
 
 dump(Node,DataDir,Rel,DumpName) ->
+    case Rel of
+	_ when Rel<r15b, Rel=/=current ->
+	    rpc:call(Node,os,putenv,["ERL_CRASH_DUMP_SECONDS","600"]);
+	_ ->
+	    ok
+    end,
     rpc:call(Node,erlang,halt,[DumpName]),
     Crashdump0 = filename:join(filename:dirname(code:which(?t)),
 			       "erl_crash_dump.n1"),
-- 
cgit v1.2.3