From f2f8d87fb6a257aa8340cd51b9d5bf5c909ef90d Mon Sep 17 00:00:00 2001 From: Niclas Eklund Date: Mon, 20 Sep 2010 17:06:05 +0200 Subject: Move away from using deprecated public_key function pem_to_der. --- lib/ssh/src/ssh.appup.src | 2 ++ lib/ssh/src/ssh_file.erl | 17 +++++++++++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/lib/ssh/src/ssh.appup.src b/lib/ssh/src/ssh.appup.src index 619b4b736f..9c806bcd03 100644 --- a/lib/ssh/src/ssh.appup.src +++ b/lib/ssh/src/ssh.appup.src @@ -19,9 +19,11 @@ {"%VSN%", [ + {"2.0.2", [{load_module, ssh_file, soft_purge, soft_purge, []}]}, {"2.0.1", [{restart_application, ssh}]} ], [ + {"2.0.2", [{load_module, ssh_file, soft_purge, soft_purge, []}]}, {"2.0.1", [{restart_application, ssh}]} ] }. diff --git a/lib/ssh/src/ssh_file.erl b/lib/ssh/src/ssh_file.erl index 5572349fe7..13722656db 100755 --- a/lib/ssh/src/ssh_file.erl +++ b/lib/ssh/src/ssh_file.erl @@ -198,12 +198,17 @@ read_public_key_v1(File) -> %% pem_type("ssh-rsa") -> "RSA". read_private_key_v2(File, Type) -> - case catch (public_key:pem_to_der(File)) of - {ok, [{_, Bin, not_encrypted}]} -> - decode_private_key_v2(Bin, Type); - Error -> %% Note we do not handle password encrypted keys at the moment - {error, Error} - end. + case file:read_file(File) of + {ok, PemBin} -> + case catch (public_key:pem_decode(PemBin)) of + [{_, Bin, not_encrypted}] -> + decode_private_key_v2(Bin, Type); + Error -> %% Note we do not handle password encrypted keys at the moment + {error, Error} + end; + {error, Reason} -> + {error, Reason} + end. %% case file:read_file(File) of %% {ok,Bin} -> %% case read_pem(binary_to_list(Bin), pem_type(Type)) of -- cgit v1.2.3 From 637dff7790e3f195dff81a7cfb8af468dece8946 Mon Sep 17 00:00:00 2001 From: Niclas Eklund Date: Mon, 1 Nov 2010 12:42:05 +0100 Subject: The fix regarding OTP-8849 was not included in the previous version as stated. --- lib/ssh/doc/src/notes.xml | 17 +++++++++++++++-- lib/ssh/vsn.mk | 2 +- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/lib/ssh/doc/src/notes.xml b/lib/ssh/doc/src/notes.xml index 01478f870e..9bedd446f4 100644 --- a/lib/ssh/doc/src/notes.xml +++ b/lib/ssh/doc/src/notes.xml @@ -29,7 +29,21 @@ notes.xml -
Ssh 2.0.2 +
Ssh 2.0.3 +
Fixed Bugs and Malfunctions + + +

+ The fix regarding OTP-8849 was not included in the + previous version as stated.

+

+ Own Id: OTP-8918

+
+
+
+
+ +
Ssh 2.0.2
Fixed Bugs and Malfunctions @@ -60,7 +74,6 @@
-
Ssh 2.0.1
Fixed Bugs and Malfunctions diff --git a/lib/ssh/vsn.mk b/lib/ssh/vsn.mk index 5e92c5ea01..db03168ad9 100644 --- a/lib/ssh/vsn.mk +++ b/lib/ssh/vsn.mk @@ -1,5 +1,5 @@ #-*-makefile-*- ; force emacs to enter makefile-mode -SSH_VSN = 2.0.2 +SSH_VSN = 2.0.3 APP_VSN = "ssh-$(SSH_VSN)" -- cgit v1.2.3