From 144e2cec31e2ac1bad6ee6b0afc2a847f380127f Mon Sep 17 00:00:00 2001 From: Patrik Nyblom Date: Fri, 3 Sep 2010 10:36:11 +0200 Subject: Stop leaking memory in nif_SUITE:send* testcases The make_term_n function in nif_SUITE.c created resources that never got released, creating valgrind memcheck Definitely Lost warnings. --- erts/emulator/test/nif_SUITE_data/nif_SUITE.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/erts/emulator/test/nif_SUITE_data/nif_SUITE.c b/erts/emulator/test/nif_SUITE_data/nif_SUITE.c index 5384a32f21..8489124966 100644 --- a/erts/emulator/test/nif_SUITE_data/nif_SUITE.c +++ b/erts/emulator/test/nif_SUITE_data/nif_SUITE.c @@ -1029,8 +1029,11 @@ static ERL_NIF_TERM make_term_list0(struct make_term_info* mti, int n) static ERL_NIF_TERM make_term_resource(struct make_term_info* mti, int n) { void* resource = enif_alloc_resource(mti->resource_type, 10); + ERL_NIF_TERM term; fill(resource, 10, n); - return enif_make_resource(mti->dst_env, resource); + term = enif_make_resource(mti->dst_env, resource); + enif_release_resource(resource); + return term; } static ERL_NIF_TERM make_term_new_binary(struct make_term_info* mti, int n) { -- cgit v1.2.3 From 18e894d86292d580966ee36d8e10028f42d5f39b Mon Sep 17 00:00:00 2001 From: Patrik Nyblom Date: Fri, 3 Sep 2010 10:38:23 +0200 Subject: Remove warning about experimental status of NIFs from erlang.xml Also made the SEEALSO link at the bottom of erl_nif.xml more "erlangish". --- erts/doc/src/erl_nif.xml | 4 ++-- erts/doc/src/erlang.xml | 12 +++++++----- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/erts/doc/src/erl_nif.xml b/erts/doc/src/erl_nif.xml index 8e4d8130f5..27887cbdf6 100644 --- a/erts/doc/src/erl_nif.xml +++ b/erts/doc/src/erl_nif.xml @@ -4,7 +4,7 @@
- 20012009 + 20012010 Ericsson AB. All Rights Reserved. @@ -1130,7 +1130,7 @@ typedef enum {
SEE ALSO -

load_nif(3)

+

erlang:load_nif/2

diff --git a/erts/doc/src/erlang.xml b/erts/doc/src/erlang.xml index cd3bcd3a07..ce7fde05d9 100644 --- a/erts/doc/src/erlang.xml +++ b/erts/doc/src/erlang.xml @@ -2034,12 +2034,14 @@ os_prompt% Text = string() - -

This BIF is still an experimental feature. The interface - may be changed in any way in future releases.

In - R13B03 the return value on failure was + +

In releases older than OTP R14B, NIF's where an + experimental feature. Versions of OTP older than R14B might + have different and possibly incompatible NIF semanticts and + interfaces. For example, in R13B03 the return value on + failure was {error,Reason,Text}.

-
+

Loads and links a dynamic library containing native implemented functions (NIFs) for a module. Path is a file path to the sharable object/dynamic library file minus -- cgit v1.2.3