From 9b25088a6f1494d4ff6cd39653dba155d6639f5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn-Egil=20Dahlberg?= <egil@erlang.org>
Date: Thu, 7 Mar 2013 16:06:46 +0100
Subject: erts: Refactor erlang:insert_element/3 for clarity

---
 erts/emulator/beam/bif.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

(limited to 'erts/emulator/beam')

diff --git a/erts/emulator/beam/bif.c b/erts/emulator/beam/bif.c
index 923bc50c40..ff237b6a78 100644
--- a/erts/emulator/beam/bif.c
+++ b/erts/emulator/beam/bif.c
@@ -2543,7 +2543,7 @@ BIF_RETTYPE insert_element_3(BIF_ALIST_3)
     Eterm* hp;
     Uint arity;
     Eterm res;
-    Sint ix;
+    Sint ix, c1, c2;
 
     if (is_not_tuple(BIF_ARG_2) || is_not_small(BIF_ARG_1)) {
 	BIF_ERROR(BIF_P, BADARG);
@@ -2561,14 +2561,12 @@ BIF_RETTYPE insert_element_3(BIF_ALIST_3)
     res = make_tuple(hp);
     *hp = make_arityval(arity + 1);
 
-    ix--;
-    arity -= ix;
-
-    while (ix--) { *++hp = *++ptr; }
+    c1 = ix - 1;
+    c2 = arity - ix + 1;
 
+    while (c1--) { *++hp = *++ptr; }
     *++hp = BIF_ARG_3;
-
-    while(arity--) { *++hp = *++ptr; }
+    while (c2--) { *++hp = *++ptr; }
 
     BIF_RET(res);
 }
-- 
cgit v1.2.3