From 17bb6bfa8d435300ee2205f1e0c20b0c6b50591a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 15 Aug 2017 13:34:45 +0200
Subject: Slightly optimize updating of maps

The instruction put_map_assoc/5 (used for updating a map) has a
failure operand, but it can't actually fail provided that its "map"
argument is a map.

The following code:

    M#{key=>value}.

will be compiled to:

    {test,is_map,{f,3},[{x,0}]}.
    {line,[...]}.
    {put_map_assoc,{f,0},{x,0},{x,0},1,{list,[{atom,key},{atom,value}]}}.
    return.
  {label,3}.
    %% Code that produces a 'badmap' exception follows.

Because of the is_map instruction, {x,0} always contains a map when
the put_map_assoc instruction is executed. Therefore we can remove
the failure operand. That will save one word, and also eliminate
two tests at run-time.

The only problem is that the compiler in OTP 17 did not emit a
is_map instruction before the put_map_assoc instruction. Therefore,
we must add an instruction that tests for a map if the code was
compiled with the OTP 17 compiler.

Unfortunately, there is no safe and relatively easy way to known that
the OTP 17 compiler was used, so we will check whether a compiler
before OTP 20 was used. OTP 20 introduced a new chunk type for atoms,
which is trivial to check.
---
 erts/emulator/test/map_SUITE_data/badmap_17.erl | 36 +++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

(limited to 'erts/emulator/test/map_SUITE_data/badmap_17.erl')

diff --git a/erts/emulator/test/map_SUITE_data/badmap_17.erl b/erts/emulator/test/map_SUITE_data/badmap_17.erl
index 0ec65e0e33..887fc2e5e3 100644
--- a/erts/emulator/test/map_SUITE_data/badmap_17.erl
+++ b/erts/emulator/test/map_SUITE_data/badmap_17.erl
@@ -1,7 +1,7 @@
 -module(badmap_17).
 -export([update/1]).
 
-%% Compile this source file with OTP 17.
+%% Compile this source file with OTP 17.0.
 
 update(Map) ->
     try
@@ -17,10 +17,42 @@ update(Map) ->
     catch
 	error:{badmap,Map} ->
 	    ok
-    end.
+    end,
+    try
+	update_3(Map),
+	error(update_did_not_fail)
+    catch
+	error:{badmap,Map} ->
+	    ok
+    end,
+    ok = update_4(Map),
+    ok = update_5(Map),
+    ok.
 
 update_1(M) ->
     M#{a=>42}.
 
 update_2(M) ->
     M#{a:=42}.
+
+update_3(M) ->
+    id(M),
+    M#{a=>42}.
+
+update_4(M) when M#{a=>b} =:= M ->
+    did_not_fail;
+update_4(_) ->
+    ok.
+
+update_5(M) ->
+    id(M),
+    case id(true) of
+        true when M#{a=>b} =:= M ->
+            did_not_fail;
+        true ->
+            ok
+    end.
+
+id(I) ->
+    I.
+
-- 
cgit v1.2.3