From 814d38ee1a111caf81e066d290fec455d13dcc9b Mon Sep 17 00:00:00 2001
From: Matt Lewandowsky <matt@greenviolet.net>
Date: Wed, 11 Sep 2013 05:12:32 -0700
Subject: Fix syslog defines

config.h defines HAVE_SYSLOG_H whereas the sources are looking for
NO_SYSLOG to be undefined. As the logic of "if feature is available"
makes more sense than "if feature is not unavailable", I opted for the
config.h define.
---
 erts/epmd/src/epmd.c     | 6 +++---
 erts/epmd/src/epmd_int.h | 4 +---
 2 files changed, 4 insertions(+), 6 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 94bb74c876..2d55b37ff3 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -286,7 +286,7 @@ static void run_daemon(EpmdVars *g)
     /* fork to make sure first child is not a process group leader */
     if (( child_pid = fork()) < 0)
       {
-#ifndef NO_SYSLOG
+#ifdef HAVE_SYSLOG_H
 	syslog(LOG_ERR,"erlang mapper daemon cant fork %m");
 #endif
 	epmd_cleanup_exit(g,1);
@@ -312,7 +312,7 @@ static void run_daemon(EpmdVars *g)
 
     if ((child_pid = fork()) < 0)
       {
-#ifndef NO_SYSLOG
+#ifdef HAVE_SYSLOG_H
 	syslog(LOG_ERR,"erlang mapper daemon cant fork 2'nd time %m");
 #endif
 	epmd_cleanup_exit(g,1);
@@ -483,7 +483,7 @@ static void dbg_gen_printf(int onsyslog,int perr,int from_level,
 
   if (g->is_daemon)
     {
-#ifndef NO_SYSLOG
+#ifdef HAVE_SYSLOG_H
       if (onsyslog)
 	{
 	  erts_vsnprintf(buf, DEBUG_BUFFER_SIZE, format, args);
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index ac354dcc78..656dbd1f45 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -25,13 +25,11 @@
    definitions ourselves */
 
 #ifdef __WIN32__
-#define NO_SYSLOG
 #define NO_SYSCONF
 #define NO_DAEMON
 #endif
 
 #ifdef VXWORKS
-#define NO_SYSLOG
 #define NO_SYSCONF
 #define NO_DAEMON
 #define NO_FCNTL
@@ -98,7 +96,7 @@
 
 #include <errno.h>
 
-#ifndef NO_SYSLOG
+#ifdef HAVE_SYSLOG_H
 #  include <syslog.h>
 #endif
 
-- 
cgit v1.2.3


From 3645c345ac88305140b3474fbbbca5c47236933c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johannes=20Wei=C3=9Fl?= <jargon@molb.org>
Date: Tue, 12 Nov 2013 16:58:02 +0100
Subject: epmd: Fix -names option on Windows

Since 3aa60cc `epmd -names` does not produce any output on Windows
anymore. This patch uses fwrite() instead of write() which adds the
necessary carriage returns to the output so that it is suitable for the
Windows cmd.exe.

A test case is added (fails on Windows without the patch).
---
 erts/epmd/src/epmd_cli.c      |  4 ++--
 erts/epmd/test/epmd_SUITE.erl | 23 ++++++++++++++++++++++-
 2 files changed, 24 insertions(+), 3 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd_cli.c b/erts/epmd/src/epmd_cli.c
index 8817bde8d7..bd30bc35d9 100644
--- a/erts/epmd/src/epmd_cli.c
+++ b/erts/epmd/src/epmd_cli.c
@@ -118,7 +118,7 @@ void epmd_call(EpmdVars *g,int what)
     if (!g->silent) {
 	rval = erts_snprintf(buf, OUTBUF_SIZE,
 			     "epmd: up and running on port %d with data:\n", j);
-	write(1, buf, rval);
+	fwrite(buf, 1, rval, stdout);
     }
     while(1) {
 	if ((rval = read(fd,buf,OUTBUF_SIZE)) <= 0)  {
@@ -126,7 +126,7 @@ void epmd_call(EpmdVars *g,int what)
 	    epmd_cleanup_exit(g,0);
 	}
 	if (!g->silent)
-	    write(1, buf, rval); /* Potentially UTF-8 encoded */
+	    fwrite(buf, 1, rval, stdout); /* Potentially UTF-8 encoded */
     }
 }
 
diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index cc24a556a3..a752abf33b 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -69,6 +69,8 @@
     returns_valid_empty_extra/1,
     returns_valid_populated_extra_with_nulls/1,
 
+    names_stdout/1,
+
     buffer_overrun_1/1,
     buffer_overrun_2/1,
     no_nonlocal_register/1,
@@ -118,6 +120,7 @@ all() ->
      too_large, alive_req_too_small_1, alive_req_too_small_2,
      alive_req_too_large, returns_valid_empty_extra,
      returns_valid_populated_extra_with_nulls,
+     names_stdout,
      {group, buffer_overrun}, no_nonlocal_register,
      no_nonlocal_kill, no_live_killing].
 
@@ -759,6 +762,24 @@ returns_valid_populated_extra_with_nulls(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
+names_stdout(doc) ->
+    ["Test that epmd -names prints registered nodes to stdout"];
+names_stdout(suite) ->
+    [];
+names_stdout(Config) when is_list(Config) ->
+    ?line ok = epmdrun(),
+    ?line {ok,Sock} = register_node("foobar"),
+    ?line ok = epmdrun("-names"),
+    ?line {ok, Data} = receive {_Port, {data, D}} -> {ok, D}
+		       after 10000 -> {error, timeout}
+		       end,
+    ?line {match,_} = re:run(Data, "^epmd: up and running", [multiline]),
+    ?line {match,_} = re:run(Data, "^name foobar at port", [multiline]),
+    ?line ok = close(Sock),
+    ok.
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
 buffer_overrun_1(suite) ->
     [];
 buffer_overrun_1(doc) ->
@@ -968,7 +989,7 @@ epmdrun(Epmd,Args0) ->
 	       O ->
 		   " "++O
 	   end,
-  osrun("\"" ++ Epmd ++ "\"" ++ Args ++ " " ?EPMDARGS " -port " ++ integer_to_list(?PORT)).
+  osrun("\"" ++ Epmd ++ "\"" ++ " " ?EPMDARGS " -port " ++ integer_to_list(?PORT) ++ Args).
 
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
-- 
cgit v1.2.3


From b7c95eabf6017ddb352fb8ce2b3749af108ebf29 Mon Sep 17 00:00:00 2001
From: "Matwey V. Kornilov" <matwey.kornilov@gmail.com>
Date: Tue, 17 Dec 2013 18:16:56 +0400
Subject: Add systemd socket activation for epmd.

Check for systemd libraries and headers in confgiure.
Add -systemd option enabling waiting for sockets from systemd.
---
 erts/epmd/src/epmd.c     | 16 ++++++++++++++--
 erts/epmd/src/epmd_int.h |  7 +++++++
 erts/epmd/src/epmd_srv.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 67 insertions(+), 2 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 2d55b37ff3..fc58882907 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -175,6 +175,9 @@ int main(int argc, char** argv)
     g->nodes.reg = g->nodes.unreg = g->nodes.unreg_tail = NULL;
     g->nodes.unreg_count = 0;
     g->active_conn    = 0;
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+    g->is_systemd     = 0;
+#endif
 
     for (i = 0; i < MAX_LISTEN_SOCKETS; i++)
 	g->listenfd[i] = -1;
@@ -248,8 +251,12 @@ int main(int argc, char** argv)
 	    else
 		usage(g);
 	    epmd_cleanup_exit(g,0);
-	}
-	else
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+	} else if (strcmp(argv[0], "-systemd") == 0) {
+            g->is_systemd = 1;
+            argv++; argc--;
+#endif
+	} else
 	    usage(g);
     }
     dbg_printf(g,1,"epmd running - daemon = %d",g->is_daemon);
@@ -454,6 +461,11 @@ static void usage(EpmdVars *g)
     fprintf(stderr, "        Forcibly unregisters a name with epmd\n");
     fprintf(stderr, "        (only allowed if -relaxed_command_check was given when \n");
     fprintf(stderr, "        epmd was started).\n");
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+    fprintf(stderr, "    -systemd\n");
+    fprintf(stderr, "        Wait for socket from systemd. The option makes sense\n");
+    fprintf(stderr, "        when started from .socket unit.\n");
+#endif
     epmd_cleanup_exit(g,1);
 }
 
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index 656dbd1f45..363923eaa9 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -110,6 +110,10 @@
 
 #include <stdarg.h>
 
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#  include <systemd/sd-daemon.h>
+#endif
+
 /* ************************************************************************ */
 /* Replace some functions by others by making the function name a macro */
 
@@ -321,6 +325,9 @@ typedef struct {
   int listenfd[MAX_LISTEN_SOCKETS];
   char *addresses;
   char **argv;
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+  int is_systemd;
+#endif
 } EpmdVars;
 
 void dbg_printf(EpmdVars*,int,const char*,...);
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 90df7cc25a..cb8ca960de 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -208,6 +208,39 @@ void run(EpmdVars *g)
   node_init(g);
   g->conn = conn_init(g);
 
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+  if (g->is_systemd)
+    {
+      int n;
+      
+      dbg_printf(g,2,"try to obtain sockets from systemd");
+
+      n = sd_listen_fds(0);
+      if (n < 0)
+        {
+          dbg_perror(g,"cannot obtain sockets from systemd");
+          epmd_cleanup_exit(g,1);
+        }
+      else if (n == 0)
+        {
+          dbg_tty_printf(g,0,"systemd provides no sockets");
+          epmd_cleanup_exit(g,1);
+      }
+      else if (n > MAX_LISTEN_SOCKETS)
+      {
+          dbg_tty_printf(g,0,"cannot listen on more than %d IP addresses", MAX_LISTEN_SOCKETS);
+          epmd_cleanup_exit(g,1);
+      } 
+      num_sockets = n;
+      for (i = 0; i < num_sockets; i++)
+        {
+          g->listenfd[i] = listensock[i] = SD_LISTEN_FDS_START + i;
+        }
+    }
+  else
+    {
+#endif
+
   dbg_printf(g,2,"try to initiate listening port %d", g->port);
 
   if (g->addresses != NULL && /* String contains non-separator characters if: */
@@ -272,6 +305,9 @@ void run(EpmdVars *g)
       SET_ADDR(iserv_addr[0],EPMD_ADDR_ANY,sport);
       num_sockets = 1;
     }
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+    }
+#endif
 
 #if !defined(__WIN32__)
   /* We ignore the SIGPIPE signal that is raised when we call write
@@ -289,6 +325,13 @@ void run(EpmdVars *g)
   FD_ZERO(&g->orig_read_mask);
   g->select_fd_top = 0;
 
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+  if (g->is_systemd)
+      for (i = 0; i < num_sockets; i++)
+          select_fd_set(g, listensock[i]);
+  else
+    {
+#endif
   for (i = 0; i < num_sockets; i++)
     {
       if ((listensock[i] = socket(FAMILY,SOCK_STREAM,0)) < 0)
@@ -351,6 +394,9 @@ void run(EpmdVars *g)
       }
       select_fd_set(g, listensock[i]);
     }
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H 
+    }
+#endif
 
   dbg_tty_printf(g,2,"entering the main select() loop");
 
-- 
cgit v1.2.3


From 200fbe924466720bd2a8c5eb05b05d67b0a2414c Mon Sep 17 00:00:00 2001
From: Lukas Larsson <lukas@erlang-solutions.com>
Date: Thu, 14 Mar 2013 15:42:19 +0100
Subject: Added support for ENEA OSE

This port has support for both non-smp and smp.

It contains a new way to do io checking in which erts_poll_wait
receives the payload of the polled entity. This has implications
for all linked-in drivers.
---
 erts/epmd/src/Makefile.in | 24 ++++++++++++++++++++++++
 erts/epmd/src/epmd.c      |  2 +-
 erts/epmd/src/epmd_int.h  | 18 +++++++++++++++++-
 erts/epmd/src/epmd_srv.c  |  7 ++++++-
 4 files changed, 48 insertions(+), 3 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/Makefile.in b/erts/epmd/src/Makefile.in
index e94674e6f4..faf0101ad7 100644
--- a/erts/epmd/src/Makefile.in
+++ b/erts/epmd/src/Makefile.in
@@ -18,6 +18,9 @@
 #
 include $(ERL_TOP)/make/target.mk
 
+ifeq ($(findstring ose,$(TARGET)),ose)
+include $(ERL_TOP)/make/$(TARGET)/ose_lm.mk
+endif
 
 ifeq ($(TYPE),debug)
 PURIFY     =
@@ -64,9 +67,13 @@ else
 ifeq ($(findstring vxworks,$(TARGET)),vxworks)
 ERTS_INTERNAL_LIBS=-L../../lib/internal/$(TARGET) -lerts_internal$(ERTS_LIB_TYPEMARKER) @ERTS_INTERNAL_X_LIBS@
 else
+ifeq ($(findstring ose,$(TARGET)),ose)
+ERTS_INTERNAL_LIBS=-L../../lib/internal/$(TARGET) -lerts_internal$(ERTS_LIB_TYPEMARKER) @ERTS_INTERNAL_X_LIBS@
+else
 ERTS_INTERNAL_LIBS=-L../../lib/internal/$(TARGET) -lerts_internal$(ERTS_LIB_TYPEMARKER) @ERTS_INTERNAL_X_LIBS@ -lm
 endif
 endif
+endif
 
 ERTS_LIB = $(ERL_TOP)/erts/lib_src/obj/$(TARGET)/$(TYPE)/MADE
 
@@ -74,7 +81,11 @@ CC      = @CC@
 WFLAGS  = @WFLAGS@
 CFLAGS  = @CFLAGS@ @DEFS@ $(TYPE_FLAGS) $(WFLAGS) $(ERTS_INCL)
 LD      = @LD@
+ifeq ($(findstring ose,$(TARGET)),ose)
+LIBS    = $(ERTS_INTERNAL_LIBS) @LIBS@
+else
 LIBS    = @LIBS@ $(ERTS_INTERNAL_LIBS)
+endif
 LDFLAGS = @LDFLAGS@
 
 
@@ -123,12 +134,25 @@ clean:
 	rm -f *.o
 	rm -f *~ core
 
+ifeq ($(findstring ose,$(TARGET)),ose)
+$(OBJDIR)/ose_confd.o: $(OSEROOT)/src/ose_confd.c
+	$(V_CC) $(CFLAGS) -o $@ -c $<
+$(OBJDIR)/crt0_lm.o: $(OSEROOT)/src/crt0_lm.c
+	$(V_CC) $(CFLAGS) -o $@ -c $<
+OSE_LM_OBJS += $(OBJDIR)/ose_confd.o $(OBJDIR)/crt0_lm.o
+endif
+
 #
 # Objects & executables
 #
 
+ifeq ($(findstring ose,$(TARGET)),ose)
+$(BINDIR)/$(EPMD): $(EPMD_OBJS) $(ERTS_LIB) $(OSE_LM_OBJS)
+	$(call build-ose-load-module, $@, $(EPMD_OBJS) $(OSE_LM_OBJS), $(LIBS), $(LMCONF))
+else
 $(BINDIR)/$(EPMD): $(EPMD_OBJS) $(ERTS_LIB)
 	$(ld_verbose)$(PURIFY) $(LD) $(LDFLAGS) -o $@ $(EPMD_OBJS) $(LIBS)
+endif
 
 $(OBJDIR)/%.o: %.c epmd.h epmd_int.h
 	$(V_CC) $(CFLAGS) $(EPMD_FLAGS) -o $@ -c $<
diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 2d55b37ff3..5d5c3a1c3c 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -389,7 +389,7 @@ static void run_daemon(EpmdVars *g)
 }
 #endif
 
-#if defined(VXWORKS)
+#if defined(VXWORKS) || defined(__OSE__)
 static void run_daemon(EpmdVars *g)
 {
     run(g);
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index 656dbd1f45..d4597be30c 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -36,6 +36,13 @@
 #define DONT_USE_MAIN
 #endif
 
+#ifdef __OSE__
+#  define NO_DAEMON
+#  define NO_SYSLOG
+#  define NO_SYSCONF
+#  define NO_FCNTL
+#endif
+
 /* ************************************************************************ */
 /* Standard includes                                                        */
 
@@ -92,7 +99,11 @@
 #endif /* ! WIN32 */
 
 #include <ctype.h>
-#include <signal.h>
+
+#if !defined(__OSE__)
+#  include <signal.h>
+#endif
+
 
 #include <errno.h>
 
@@ -110,6 +121,11 @@
 
 #include <stdarg.h>
 
+#ifdef __OSE__
+#  include "sys/select.h"
+#endif
+
+
 /* ************************************************************************ */
 /* Replace some functions by others by making the function name a macro */
 
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 90df7cc25a..247fd34d5a 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -29,6 +29,11 @@
 #  define INADDR_NONE 0xffffffff
 #endif
 
+#if defined(__OSE__)
+#  include "sys/ioctl.h"
+#  define sleep(x) delay(x*1000)
+#endif
+
 /*
  *  
  *  This server is a local name server for Erlang nodes. Erlang nodes can
@@ -273,7 +278,7 @@ void run(EpmdVars *g)
       num_sockets = 1;
     }
 
-#if !defined(__WIN32__)
+#if !defined(__WIN32__) && !defined(__OSE__)
   /* We ignore the SIGPIPE signal that is raised when we call write
      twice on a socket closed by the other end. */
   signal(SIGPIPE, SIG_IGN);
-- 
cgit v1.2.3


From a6788ea337a2319a2d1a42ee4618553a1c7765bf Mon Sep 17 00:00:00 2001
From: Lukas Larsson <lukas@erlang-solutions.com>
Date: Wed, 30 Oct 2013 17:56:37 +0100
Subject: ose: Fix various build environment issues

---
 erts/epmd/src/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/Makefile.in b/erts/epmd/src/Makefile.in
index faf0101ad7..2ea8630491 100644
--- a/erts/epmd/src/Makefile.in
+++ b/erts/epmd/src/Makefile.in
@@ -135,9 +135,9 @@ clean:
 	rm -f *~ core
 
 ifeq ($(findstring ose,$(TARGET)),ose)
-$(OBJDIR)/ose_confd.o: $(OSEROOT)/src/ose_confd.c
+$(OBJDIR)/ose_confd.o: $(OSE_CONFD)
 	$(V_CC) $(CFLAGS) -o $@ -c $<
-$(OBJDIR)/crt0_lm.o: $(OSEROOT)/src/crt0_lm.c
+$(OBJDIR)/crt0_lm.o: $(CRT0_LM)
 	$(V_CC) $(CFLAGS) -o $@ -c $<
 OSE_LM_OBJS += $(OBJDIR)/ose_confd.o $(OBJDIR)/crt0_lm.o
 endif
-- 
cgit v1.2.3


From e444e9a2ac6a2d70a34d95c97c4af0d39aac232d Mon Sep 17 00:00:00 2001
From: Jay True <glacjay@gmail.com>
Date: Wed, 26 Feb 2014 22:29:00 +0800
Subject: ensure argv large enough for all possible args

---
 erts/epmd/src/epmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 2d55b37ff3..eb32a08e0b 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -52,7 +52,7 @@ static int epmd_main(int, char **, int);
 
 int epmd_dbg(int level,int port) /* Utility to debug epmd... */
 {
-  char* argv[MAX_DEBUG+2];
+  char* argv[MAX_DEBUG+4];
   char  ibuff[100];
   int   argc = 0;
   
-- 
cgit v1.2.3


From e2c11e89563f0c11794c91193b29bce00ca9c740 Mon Sep 17 00:00:00 2001
From: Rick Reed <rr@whatsapp.com>
Date: Tue, 22 May 2012 12:28:09 -0700
Subject: Add missing error string to syslog logging in epmd

---
 erts/epmd/src/epmd.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 5d5c3a1c3c..5dd4a2cc2e 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -486,7 +486,11 @@ static void dbg_gen_printf(int onsyslog,int perr,int from_level,
 #ifdef HAVE_SYSLOG_H
       if (onsyslog)
 	{
-	  erts_vsnprintf(buf, DEBUG_BUFFER_SIZE, format, args);
+	  int len;
+	  len = erts_vsnprintf(buf, DEBUG_BUFFER_SIZE, format, args);
+	  if (perr != 0 && len < sizeof(buf)) {
+	      erts_snprintf(buf+len, sizeof(buf)-len, ": %s", strerror(perr));
+	  }
 	  syslog(LOG_ERR,"epmd: %s",buf);
 	}
 #endif
-- 
cgit v1.2.3


From f6570cf6201bf6476d903def9b04fe9c33f13a3d Mon Sep 17 00:00:00 2001
From: Lukas Larsson <lukas@erlang-solutions.com>
Date: Mon, 17 Mar 2014 15:49:50 +0100
Subject: ose: Break lmconf into one per load module

---
 erts/epmd/src/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/Makefile.in b/erts/epmd/src/Makefile.in
index 2ea8630491..8dc8dae5f6 100644
--- a/erts/epmd/src/Makefile.in
+++ b/erts/epmd/src/Makefile.in
@@ -148,7 +148,7 @@ endif
 
 ifeq ($(findstring ose,$(TARGET)),ose)
 $(BINDIR)/$(EPMD): $(EPMD_OBJS) $(ERTS_LIB) $(OSE_LM_OBJS)
-	$(call build-ose-load-module, $@, $(EPMD_OBJS) $(OSE_LM_OBJS), $(LIBS), $(LMCONF))
+	$(call build-ose-load-module, $@, $(EPMD_OBJS) $(OSE_LM_OBJS), $(LIBS), $(EPMD_LMCONF))
 else
 $(BINDIR)/$(EPMD): $(EPMD_OBJS) $(ERTS_LIB)
 	$(ld_verbose)$(PURIFY) $(LD) $(LDFLAGS) -o $@ $(EPMD_OBJS) $(LIBS)
-- 
cgit v1.2.3


From 12cd5e5b394623fab9907622ad99163c5b9350e1 Mon Sep 17 00:00:00 2001
From: Lukas Larsson <lukas@erlang-solutions.com>
Date: Thu, 24 Apr 2014 15:20:08 +0200
Subject: erts: Fix various autoconf issues

* Check of atomics on bsd
* Add --enable-systemd for epmd
* Remove unused --enable-tsp option
---
 erts/epmd/src/Makefile.in | 2 +-
 erts/epmd/src/epmd_srv.c  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/Makefile.in b/erts/epmd/src/Makefile.in
index 8dc8dae5f6..0c7787a3b1 100644
--- a/erts/epmd/src/Makefile.in
+++ b/erts/epmd/src/Makefile.in
@@ -84,7 +84,7 @@ LD      = @LD@
 ifeq ($(findstring ose,$(TARGET)),ose)
 LIBS    = $(ERTS_INTERNAL_LIBS) @LIBS@
 else
-LIBS    = @LIBS@ $(ERTS_INTERNAL_LIBS)
+LIBS    = @LIBS@ @SYSTEMD_DAEMON_LIBS@ $(ERTS_INTERNAL_LIBS)
 endif
 LDFLAGS = @LDFLAGS@
 
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 93982c2f60..48fd7a5f9c 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -213,7 +213,7 @@ void run(EpmdVars *g)
   node_init(g);
   g->conn = conn_init(g);
 
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
   if (g->is_systemd)
     {
       int n;
@@ -310,7 +310,7 @@ void run(EpmdVars *g)
       SET_ADDR(iserv_addr[0],EPMD_ADDR_ANY,sport);
       num_sockets = 1;
     }
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
     }
 #endif
 
-- 
cgit v1.2.3


From 6ace9a5b381fcd6e6efb4d45edeb70f566e24f93 Mon Sep 17 00:00:00 2001
From: Chris Dituri <csdituri@gmail.com>
Date: Fri, 15 Aug 2014 22:38:26 -0500
Subject: epmd: pedantic spelling fix in comments

Correct spelling errors in the run_daemon() comments which describe
the redirection of stdin, stdout, and stderr to /dev/null for safety
reasons.
---
 erts/epmd/src/epmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 9630e0cdf0..0823dcaa4e 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -345,7 +345,7 @@ static void run_daemon(EpmdVars *g)
        inform it of that the log is closed. */
     closelog();
 
-    /* These chouldn't be needed but for safety... */
+    /* These shouldn't be needed but for safety... */
 
     open("/dev/null", O_RDONLY); /* Order is important! */
     open("/dev/null", O_WRONLY);
@@ -386,7 +386,7 @@ static void run_daemon(EpmdVars *g)
     close(1);
     close(2);
 
-    /* These chouldn't be needed but for safety... */
+    /* These shouldn't be needed but for safety... */
 
     open("nul", O_RDONLY);
     open("nul", O_WRONLY);
-- 
cgit v1.2.3


From 59740d8fee66f3326b30ac25882b52ffada4bac2 Mon Sep 17 00:00:00 2001
From: Peter Lemenkov <lemenkov@gmail.com>
Date: Fri, 6 Jun 2014 15:29:49 +0400
Subject: epmd: Added systemd notify support to EPMD

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
---
 erts/epmd/src/epmd.c     | 8 +++++---
 erts/epmd/src/epmd_srv.c | 5 ++++-
 2 files changed, 9 insertions(+), 4 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 9630e0cdf0..dff9bc64de 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -593,9 +593,11 @@ void epmd_cleanup_exit(EpmdVars *g, int exitval)
       for(i=0; g->argv[i] != NULL; ++i)
 	  free(g->argv[i]);
       free(g->argv);
-  }      
-      
-
+  }
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+  sd_notifyf(0, "STATUS=Exited.\n"
+                "ERRNO=%i", exitval);
+#endif // HAVE_SYSTEMD_SD_DAEMON_H
   exit(exitval);
 }
 
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 48fd7a5f9c..18d898a915 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -399,8 +399,11 @@ void run(EpmdVars *g)
       }
       select_fd_set(g, listensock[i]);
     }
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H 
+#ifdef HAVE_SYSTEMD_SD_DAEMON_H
     }
+    sd_notifyf(0, "READY=1\n"
+                  "STATUS=Processing port mapping requests...\n"
+                  "MAINPID=%lu", (unsigned long) getpid());
 #endif
 
   dbg_tty_printf(g,2,"entering the main select() loop");
-- 
cgit v1.2.3


From 5db2345baa3bb9c835f91aafac3dde6e595debc7 Mon Sep 17 00:00:00 2001
From: Peter Lemenkov <lemenkov@gmail.com>
Date: Sun, 2 Nov 2014 18:06:21 +0300
Subject: epmd: Unify systemd autoconf macros usage

Don't use both HAVE_SYSTEMD_DAEMON and HAVE_SYSTEMD_SD_DAEMON - use only
the former one and remove the latter one entirely.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
---
 erts/epmd/src/epmd.c     | 16 ++++++++--------
 erts/epmd/src/epmd_int.h |  8 ++++----
 erts/epmd/src/epmd_srv.c | 12 ++++++------
 3 files changed, 18 insertions(+), 18 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index dff9bc64de..9699491526 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -175,9 +175,9 @@ int main(int argc, char** argv)
     g->nodes.reg = g->nodes.unreg = g->nodes.unreg_tail = NULL;
     g->nodes.unreg_count = 0;
     g->active_conn    = 0;
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
     g->is_systemd     = 0;
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
 
     for (i = 0; i < MAX_LISTEN_SOCKETS; i++)
 	g->listenfd[i] = -1;
@@ -251,11 +251,11 @@ int main(int argc, char** argv)
 	    else
 		usage(g);
 	    epmd_cleanup_exit(g,0);
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
 	} else if (strcmp(argv[0], "-systemd") == 0) {
             g->is_systemd = 1;
             argv++; argc--;
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
 	} else
 	    usage(g);
     }
@@ -461,11 +461,11 @@ static void usage(EpmdVars *g)
     fprintf(stderr, "        Forcibly unregisters a name with epmd\n");
     fprintf(stderr, "        (only allowed if -relaxed_command_check was given when \n");
     fprintf(stderr, "        epmd was started).\n");
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
     fprintf(stderr, "    -systemd\n");
     fprintf(stderr, "        Wait for socket from systemd. The option makes sense\n");
     fprintf(stderr, "        when started from .socket unit.\n");
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
     epmd_cleanup_exit(g,1);
 }
 
@@ -594,10 +594,10 @@ void epmd_cleanup_exit(EpmdVars *g, int exitval)
 	  free(g->argv[i]);
       free(g->argv);
   }
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
   sd_notifyf(0, "STATUS=Exited.\n"
                 "ERRNO=%i", exitval);
-#endif // HAVE_SYSTEMD_SD_DAEMON_H
+#endif /* HAVE_SYSTEMD_DAEMON */
   exit(exitval);
 }
 
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index c8f2192f7f..52badd7086 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -125,9 +125,9 @@
 #  include "sys/select.h"
 #endif
 
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
 #  include <systemd/sd-daemon.h>
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
 
 /* ************************************************************************ */
 /* Replace some functions by others by making the function name a macro */
@@ -340,9 +340,9 @@ typedef struct {
   int listenfd[MAX_LISTEN_SOCKETS];
   char *addresses;
   char **argv;
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
   int is_systemd;
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
 } EpmdVars;
 
 void dbg_printf(EpmdVars*,int,const char*,...);
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 18d898a915..26e42adb19 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -244,7 +244,7 @@ void run(EpmdVars *g)
     }
   else
     {
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
 
   dbg_printf(g,2,"try to initiate listening port %d", g->port);
 
@@ -312,7 +312,7 @@ void run(EpmdVars *g)
     }
 #ifdef HAVE_SYSTEMD_DAEMON
     }
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
 
 #if !defined(__WIN32__) && !defined(__OSE__)
   /* We ignore the SIGPIPE signal that is raised when we call write
@@ -330,13 +330,13 @@ void run(EpmdVars *g)
   FD_ZERO(&g->orig_read_mask);
   g->select_fd_top = 0;
 
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
   if (g->is_systemd)
       for (i = 0; i < num_sockets; i++)
           select_fd_set(g, listensock[i]);
   else
     {
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
   for (i = 0; i < num_sockets; i++)
     {
       if ((listensock[i] = socket(FAMILY,SOCK_STREAM,0)) < 0)
@@ -399,12 +399,12 @@ void run(EpmdVars *g)
       }
       select_fd_set(g, listensock[i]);
     }
-#ifdef HAVE_SYSTEMD_SD_DAEMON_H
+#ifdef HAVE_SYSTEMD_DAEMON
     }
     sd_notifyf(0, "READY=1\n"
                   "STATUS=Processing port mapping requests...\n"
                   "MAINPID=%lu", (unsigned long) getpid());
-#endif
+#endif /* HAVE_SYSTEMD_DAEMON */
 
   dbg_tty_printf(g,2,"entering the main select() loop");
 
-- 
cgit v1.2.3


From eb15bb261a09c7e87707da042887ccfd7ef58417 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn-Egil=20Dahlberg?= <egil@erlang.org>
Date: Tue, 16 Jun 2015 10:12:52 +0200
Subject: Revert "Add missing error string to syslog logging in epmd"

This reverts commit e2c11e89563f0c11794c91193b29bce00ca9c740.
---
 erts/epmd/src/epmd.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 447aae47aa..2fd9845d1a 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -498,11 +498,7 @@ static void dbg_gen_printf(int onsyslog,int perr,int from_level,
 #ifdef HAVE_SYSLOG_H
       if (onsyslog)
 	{
-	  int len;
-	  len = erts_vsnprintf(buf, DEBUG_BUFFER_SIZE, format, args);
-	  if (perr != 0 && len < sizeof(buf)) {
-	      erts_snprintf(buf+len, sizeof(buf)-len, ": %s", strerror(perr));
-	  }
+	  erts_vsnprintf(buf, DEBUG_BUFFER_SIZE, format, args);
 	  syslog(LOG_ERR,"epmd: %s",buf);
 	}
 #endif
-- 
cgit v1.2.3


From 738c34d4bb8f1a3811acd00af8c6c12107f8315b Mon Sep 17 00:00:00 2001
From: Bruce Yinhe <bruce@erlang.org>
Date: Thu, 18 Jun 2015 11:31:02 +0200
Subject: Change license text to APLv2

---
 erts/epmd/Makefile            | 21 +++++++++++----------
 erts/epmd/epmd.mk             | 21 +++++++++++----------
 erts/epmd/src/Makefile        | 21 +++++++++++----------
 erts/epmd/src/Makefile.in     | 21 +++++++++++----------
 erts/epmd/src/epmd.c          | 19 ++++++++++---------
 erts/epmd/src/epmd.h          | 21 +++++++++++----------
 erts/epmd/src/epmd_cli.c      | 21 +++++++++++----------
 erts/epmd/src/epmd_int.h      | 19 ++++++++++---------
 erts/epmd/src/epmd_srv.c      | 19 ++++++++++---------
 erts/epmd/test/Makefile       | 19 ++++++++++---------
 erts/epmd/test/epmd_SUITE.erl | 19 ++++++++++---------
 11 files changed, 116 insertions(+), 105 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/Makefile b/erts/epmd/Makefile
index 4c1af393ac..25a33462ee 100644
--- a/erts/epmd/Makefile
+++ b/erts/epmd/Makefile
@@ -3,16 +3,17 @@
 # 
 # Copyright Ericsson AB 1998-2009. All Rights Reserved.
 # 
-# The contents of this file are subject to the Erlang Public License,
-# Version 1.1, (the "License"); you may not use this file except in
-# compliance with the License. You should have received a copy of the
-# Erlang Public License along with this software. If not, it can be
-# retrieved online at http://www.erlang.org/.
-# 
-# Software distributed under the License is distributed on an "AS IS"
-# basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-# the License for the specific language governing rights and limitations
-# under the License.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 # 
 # %CopyrightEnd%
 # 
diff --git a/erts/epmd/epmd.mk b/erts/epmd/epmd.mk
index a73f4bc077..08245b784e 100644
--- a/erts/epmd/epmd.mk
+++ b/erts/epmd/epmd.mk
@@ -3,16 +3,17 @@
 # 
 # Copyright Ericsson AB 1998-2009. All Rights Reserved.
 # 
-# The contents of this file are subject to the Erlang Public License,
-# Version 1.1, (the "License"); you may not use this file except in
-# compliance with the License. You should have received a copy of the
-# Erlang Public License along with this software. If not, it can be
-# retrieved online at http://www.erlang.org/.
-# 
-# Software distributed under the License is distributed on an "AS IS"
-# basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-# the License for the specific language governing rights and limitations
-# under the License.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 # 
 # %CopyrightEnd%
 # 
diff --git a/erts/epmd/src/Makefile b/erts/epmd/src/Makefile
index 7d586c7438..3e09a40566 100644
--- a/erts/epmd/src/Makefile
+++ b/erts/epmd/src/Makefile
@@ -3,16 +3,17 @@
 # 
 # Copyright Ericsson AB 1998-2009. All Rights Reserved.
 # 
-# The contents of this file are subject to the Erlang Public License,
-# Version 1.1, (the "License"); you may not use this file except in
-# compliance with the License. You should have received a copy of the
-# Erlang Public License along with this software. If not, it can be
-# retrieved online at http://www.erlang.org/.
-# 
-# Software distributed under the License is distributed on an "AS IS"
-# basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-# the License for the specific language governing rights and limitations
-# under the License.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 # 
 # %CopyrightEnd%
 #
diff --git a/erts/epmd/src/Makefile.in b/erts/epmd/src/Makefile.in
index 0c7787a3b1..b6e3ba7762 100644
--- a/erts/epmd/src/Makefile.in
+++ b/erts/epmd/src/Makefile.in
@@ -3,16 +3,17 @@
 # 
 # Copyright Ericsson AB 1998-2012. All Rights Reserved.
 # 
-# The contents of this file are subject to the Erlang Public License,
-# Version 1.1, (the "License"); you may not use this file except in
-# compliance with the License. You should have received a copy of the
-# Erlang Public License along with this software. If not, it can be
-# retrieved online at http://www.erlang.org/.
-# 
-# Software distributed under the License is distributed on an "AS IS"
-# basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-# the License for the specific language governing rights and limitations
-# under the License.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 # 
 # %CopyrightEnd%
 #
diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 2fd9845d1a..132bda725c 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -4,16 +4,17 @@
  *
  * Copyright Ericsson AB 1998-2013. All Rights Reserved.
  *
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  *
  * %CopyrightEnd%
  */
diff --git a/erts/epmd/src/epmd.h b/erts/epmd/src/epmd.h
index 5d6e9ac165..10483bb5a2 100644
--- a/erts/epmd/src/epmd.h
+++ b/erts/epmd/src/epmd.h
@@ -3,16 +3,17 @@
  * 
  * Copyright Ericsson AB 1998-2010. All Rights Reserved.
  * 
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
- * 
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  * 
  * %CopyrightEnd%
  */
diff --git a/erts/epmd/src/epmd_cli.c b/erts/epmd/src/epmd_cli.c
index bd30bc35d9..a8fe865d9a 100644
--- a/erts/epmd/src/epmd_cli.c
+++ b/erts/epmd/src/epmd_cli.c
@@ -3,16 +3,17 @@
  * 
  * Copyright Ericsson AB 1998-2013. All Rights Reserved.
  * 
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
- * 
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  * 
  * %CopyrightEnd%
  */
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index 52badd7086..26100afc93 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -4,16 +4,17 @@
  *
  * Copyright Ericsson AB 1998-2013. All Rights Reserved.
  *
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  *
  * %CopyrightEnd%
  */
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 26e42adb19..8c8d7304f2 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -4,16 +4,17 @@
  *
  * Copyright Ericsson AB 1998-2013. All Rights Reserved.
  *
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  *
  * %CopyrightEnd%
  */
diff --git a/erts/epmd/test/Makefile b/erts/epmd/test/Makefile
index 45c8be6809..7c5302a2f1 100644
--- a/erts/epmd/test/Makefile
+++ b/erts/epmd/test/Makefile
@@ -3,16 +3,17 @@
 #
 # Copyright Ericsson AB 1998-2012. All Rights Reserved.
 #
-# The contents of this file are subject to the Erlang Public License,
-# Version 1.1, (the "License"); you may not use this file except in
-# compliance with the License. You should have received a copy of the
-# Erlang Public License along with this software. If not, it can be
-# retrieved online at http://www.erlang.org/.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
 #
-# Software distributed under the License is distributed on an "AS IS"
-# basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-# the License for the specific language governing rights and limitations
-# under the License.
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 #
 # %CopyrightEnd%
 #
diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index a752abf33b..e8bbfdbb18 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -3,16 +3,17 @@
 %%
 %% Copyright Ericsson AB 1998-2013. All Rights Reserved.
 %%
-%% The contents of this file are subject to the Erlang Public License,
-%% Version 1.1, (the "License"); you may not use this file except in
-%% compliance with the License. You should have received a copy of the
-%% Erlang Public License along with this software. If not, it can be
-%% retrieved online at http://www.erlang.org/.
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
 %%
-%% Software distributed under the License is distributed on an "AS IS"
-%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-%% the License for the specific language governing rights and limitations
-%% under the License.
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
 %%
 %% %CopyrightEnd%
 %%
-- 
cgit v1.2.3


From c431a065ba515d27830f01c852f70940efb3003b Mon Sep 17 00:00:00 2001
From: Lukas Larsson <lukas.larsson@erlang-solutions.com>
Date: Thu, 2 Jul 2015 11:13:32 +0200
Subject: ose: Remove all code related to the OSE port

The OSE port is no longer supported and this commit removed it
and any changes related to it. The things that were general
improvements have been left in the code.
---
 erts/epmd/src/Makefile.in | 37 ++-----------------------------------
 erts/epmd/src/epmd.c      |  2 +-
 erts/epmd/src/epmd_int.h  | 18 +-----------------
 erts/epmd/src/epmd_srv.c  |  7 +------
 4 files changed, 5 insertions(+), 59 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/Makefile.in b/erts/epmd/src/Makefile.in
index b6e3ba7762..1266be44cb 100644
--- a/erts/epmd/src/Makefile.in
+++ b/erts/epmd/src/Makefile.in
@@ -19,10 +19,6 @@
 #
 include $(ERL_TOP)/make/target.mk
 
-ifeq ($(findstring ose,$(TARGET)),ose)
-include $(ERL_TOP)/make/$(TARGET)/ose_lm.mk
-endif
-
 ifeq ($(TYPE),debug)
 PURIFY     =
 TYPEMARKER = .debug
@@ -32,21 +28,13 @@ else
 ifeq ($(TYPE),purify)
 PURIFY     = purify
 TYPEMARKER =
-ifeq ($(findstring ose,$(TARGET)),ose)
-  TYPE_FLAGS = -DPURIFY
-else
-  TYPE_FLAGS = -O2 -DPURIFY
-endif
+TYPE_FLAGS = -O2 -DPURIFY
 else
 
 override TYPE = opt
 PURIFY     =
 TYPEMARKER =
-ifeq ($(findstring ose,$(TARGET)),ose)
-  TYPE_FLAGS =
-else
-  TYPE_FLAGS = -O2
-endif
+TYPE_FLAGS = -O2
 endif
 endif
 
@@ -68,13 +56,9 @@ else
 ifeq ($(findstring vxworks,$(TARGET)),vxworks)
 ERTS_INTERNAL_LIBS=-L../../lib/internal/$(TARGET) -lerts_internal$(ERTS_LIB_TYPEMARKER) @ERTS_INTERNAL_X_LIBS@
 else
-ifeq ($(findstring ose,$(TARGET)),ose)
-ERTS_INTERNAL_LIBS=-L../../lib/internal/$(TARGET) -lerts_internal$(ERTS_LIB_TYPEMARKER) @ERTS_INTERNAL_X_LIBS@
-else
 ERTS_INTERNAL_LIBS=-L../../lib/internal/$(TARGET) -lerts_internal$(ERTS_LIB_TYPEMARKER) @ERTS_INTERNAL_X_LIBS@ -lm
 endif
 endif
-endif
 
 ERTS_LIB = $(ERL_TOP)/erts/lib_src/obj/$(TARGET)/$(TYPE)/MADE
 
@@ -82,11 +66,7 @@ CC      = @CC@
 WFLAGS  = @WFLAGS@
 CFLAGS  = @CFLAGS@ @DEFS@ $(TYPE_FLAGS) $(WFLAGS) $(ERTS_INCL)
 LD      = @LD@
-ifeq ($(findstring ose,$(TARGET)),ose)
-LIBS    = $(ERTS_INTERNAL_LIBS) @LIBS@
-else
 LIBS    = @LIBS@ @SYSTEMD_DAEMON_LIBS@ $(ERTS_INTERNAL_LIBS)
-endif
 LDFLAGS = @LDFLAGS@
 
 
@@ -135,25 +115,12 @@ clean:
 	rm -f *.o
 	rm -f *~ core
 
-ifeq ($(findstring ose,$(TARGET)),ose)
-$(OBJDIR)/ose_confd.o: $(OSE_CONFD)
-	$(V_CC) $(CFLAGS) -o $@ -c $<
-$(OBJDIR)/crt0_lm.o: $(CRT0_LM)
-	$(V_CC) $(CFLAGS) -o $@ -c $<
-OSE_LM_OBJS += $(OBJDIR)/ose_confd.o $(OBJDIR)/crt0_lm.o
-endif
-
 #
 # Objects & executables
 #
 
-ifeq ($(findstring ose,$(TARGET)),ose)
-$(BINDIR)/$(EPMD): $(EPMD_OBJS) $(ERTS_LIB) $(OSE_LM_OBJS)
-	$(call build-ose-load-module, $@, $(EPMD_OBJS) $(OSE_LM_OBJS), $(LIBS), $(EPMD_LMCONF))
-else
 $(BINDIR)/$(EPMD): $(EPMD_OBJS) $(ERTS_LIB)
 	$(ld_verbose)$(PURIFY) $(LD) $(LDFLAGS) -o $@ $(EPMD_OBJS) $(LIBS)
-endif
 
 $(OBJDIR)/%.o: %.c epmd.h epmd_int.h
 	$(V_CC) $(CFLAGS) $(EPMD_FLAGS) -o $@ -c $<
diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 132bda725c..7c373509be 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -397,7 +397,7 @@ static void run_daemon(EpmdVars *g)
 }
 #endif
 
-#if defined(VXWORKS) || defined(__OSE__)
+#if defined(VXWORKS)
 static void run_daemon(EpmdVars *g)
 {
     run(g);
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index 26100afc93..e222abb4b7 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -37,13 +37,6 @@
 #define DONT_USE_MAIN
 #endif
 
-#ifdef __OSE__
-#  define NO_DAEMON
-#  define NO_SYSLOG
-#  define NO_SYSCONF
-#  define NO_FCNTL
-#endif
-
 /* ************************************************************************ */
 /* Standard includes                                                        */
 
@@ -100,12 +93,7 @@
 #endif /* ! WIN32 */
 
 #include <ctype.h>
-
-#if !defined(__OSE__)
-#  include <signal.h>
-#endif
-
-
+#include <signal.h>
 #include <errno.h>
 
 #ifdef HAVE_SYSLOG_H
@@ -122,10 +110,6 @@
 
 #include <stdarg.h>
 
-#ifdef __OSE__
-#  include "sys/select.h"
-#endif
-
 #ifdef HAVE_SYSTEMD_DAEMON
 #  include <systemd/sd-daemon.h>
 #endif /* HAVE_SYSTEMD_DAEMON */
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 8c8d7304f2..829eb4c74d 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -30,11 +30,6 @@
 #  define INADDR_NONE 0xffffffff
 #endif
 
-#if defined(__OSE__)
-#  include "sys/ioctl.h"
-#  define sleep(x) delay(x*1000)
-#endif
-
 /*
  *  
  *  This server is a local name server for Erlang nodes. Erlang nodes can
@@ -315,7 +310,7 @@ void run(EpmdVars *g)
     }
 #endif /* HAVE_SYSTEMD_DAEMON */
 
-#if !defined(__WIN32__) && !defined(__OSE__)
+#if !defined(__WIN32__)
   /* We ignore the SIGPIPE signal that is raised when we call write
      twice on a socket closed by the other end. */
   signal(SIGPIPE, SIG_IGN);
-- 
cgit v1.2.3


From cb62ace6eac881e2b42880c6f645afbc56295ee0 Mon Sep 17 00:00:00 2001
From: Henrik Nord <henrik@erlang.org>
Date: Wed, 4 Nov 2015 16:04:54 +0100
Subject: add missing time.h

---
 erts/epmd/src/epmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 132bda725c..63ec18d939 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -29,7 +29,7 @@
 #ifdef HAVE_STDLIB_H
 #  include <stdlib.h>
 #endif
-
+#include <time.h>
 /* forward declarations */
 
 static void usage(EpmdVars *);
-- 
cgit v1.2.3


From 128fc752a45d51beb71c1aea4d5433efd00ac02a Mon Sep 17 00:00:00 2001
From: Alexey Lebedeff <alebedev@mirantis.com>
Date: Mon, 14 Dec 2015 15:08:15 +0300
Subject: Don't wait for twice the delay_write timeout

This happens only during processing ALIVE2 request. reply() already
performs the same delay as in the deleted code.
---
 erts/epmd/src/epmd_srv.c | 3 ---
 1 file changed, 3 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 8c8d7304f2..5b58554590 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -700,9 +700,6 @@ static void do_request(g, fd, s, buf, bsize)
 	    put_int16(node->creation, wbuf+2);
 	}
   
-	if (g->delay_write)		/* Test of busy server */
-	  sleep(g->delay_write);
-
 	if (reply(g, fd, wbuf, 4) != 4)
 	  {
 	    dbg_tty_printf(g,1,"** failed to send ALIVE2_RESP for \"%s\"",
-- 
cgit v1.2.3


From 8e6d005dcd8f62745d28d1820c4b2a5025634f5f Mon Sep 17 00:00:00 2001
From: Alexey Lebedeff <alebedev@mirantis.com>
Date: Mon, 14 Dec 2015 15:15:52 +0300
Subject: Prevent down nodes going undetected in epmd

In the following (rare) case down node will be always registered in epmd:
- client connects to epmd and sends ALIVE2 request
- epmd reads this request and starts to process it
- during that time client socket closes in such way that subsequent
  write(2) in epmd will result in error
- at this point we have node that was registered in database, but as
  the connection struct has no 'keep' flag set, the do_read() closes
  connection and removes it from select fdset - and so there is no way
  for this node to be cleaned up later.

We've seen several epmd instances in such state on our production
systems. And while I'm not sure what was the exact sequence of events
that leads to failed write(2), issue could be easily reproduced using
SO_LINGER option for socket.
---
 erts/epmd/src/epmd_srv.c      |  1 +
 erts/epmd/test/epmd_SUITE.erl | 58 +++++++++++++++++++++++++++++++++++++------
 2 files changed, 52 insertions(+), 7 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 8c8d7304f2..c9d49e73d0 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -705,6 +705,7 @@ static void do_request(g, fd, s, buf, bsize)
 
 	if (reply(g, fd, wbuf, 4) != 4)
 	  {
+            node_unreg(g, name);
 	    dbg_tty_printf(g,1,"** failed to send ALIVE2_RESP for \"%s\"",
 			   name);
 	    return;
diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index e8bbfdbb18..4de65500e9 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -76,7 +76,9 @@
     buffer_overrun_2/1,
     no_nonlocal_register/1,
     no_nonlocal_kill/1,
-    no_live_killing/1
+    no_live_killing/1,
+
+    socket_reset_before_alive2_reply_is_written/1
    ]).
 
 
@@ -123,7 +125,8 @@ all() ->
      returns_valid_populated_extra_with_nulls,
      names_stdout,
      {group, buffer_overrun}, no_nonlocal_register,
-     no_nonlocal_kill, no_live_killing].
+     no_nonlocal_kill, no_live_killing,
+     socket_reset_before_alive2_reply_is_written].
 
 groups() -> 
     [{buffer_overrun, [],
@@ -243,11 +246,7 @@ register_node(Name,Port) ->
     register_node_v2(Port,$M,0,5,5,Name,"").
 
 register_node_v2(Port, NodeType, Prot, HVsn, LVsn, Name, Extra) ->
-    Utf8Name = unicode:characters_to_binary(Name),
-    Req = [?EPMD_ALIVE2_REQ, put16(Port), NodeType, Prot,
-	   put16(HVsn), put16(LVsn),
-	   put16(size(Utf8Name)), binary_to_list(Utf8Name),
-	   size16(Extra), Extra],
+    Req = alive2_req(Port, NodeType, Prot, HVsn, LVsn, Name, Extra),
     case send_req(Req) of
 	{ok,Sock} ->
 	    case recv(Sock,4) of
@@ -938,6 +937,42 @@ no_live_killing(Config) when is_list(Config) ->
     ?line close(Sock3),
     ok.
 
+socket_reset_before_alive2_reply_is_written(doc) ->
+    ["Check for regression - don't make zombie from node which "
+     "sends TCP RST at wrong time"];
+socket_reset_before_alive2_reply_is_written(suite) ->
+    [];
+socket_reset_before_alive2_reply_is_written(Config) when is_list(Config) ->
+    %% - delay_write for easier triggering of race condition
+    %% - relaxed_command_check for gracefull shutdown of epmd even if there
+    %%   is stuck node.
+    ?line ok = epmdrun("-delay_write 1 -relaxed_command_check"),
+
+    %% We can't use send_req/1 directly as we want to do inet:setopts/2
+    %% on our socket.
+    ?line {ok, Sock} = connect(),
+
+    %% Issuing close/1 on such socket will result in immediate RST packet.
+    ?line ok = inet:setopts(Sock, [{linger, {true, 0}}]),
+
+    Req = alive2_req(4711, 77, 0, 5, 5, "test", []),
+    ?line ok = send(Sock, [size16(Req), Req]),
+
+    timer:sleep(500), %% Wait for the first 1/2 of delay_write before closing
+    ?line ok = close(Sock),
+
+    timer:sleep(500 + ?SHORT_PAUSE), %% Wait for the other 1/2 of delay_write
+
+    %% Wait another delay_write interval, due to delay doubling in epmd.
+    %% Should be removed when this is issue is fixed there.
+    timer:sleep(1000),
+
+    ?line {ok, SockForNames} = connect_active(),
+
+    %% And there should be no stuck nodes
+    ?line {ok, []} = do_get_names(SockForNames),
+    ?line ok = close(SockForNames),
+    ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 % Terminate all tests with killing epmd.
@@ -1200,3 +1235,12 @@ flat_count([_|T], N) ->
     flat_count(T, N);
 flat_count([], N) -> N.
     
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
+alive2_req(Port, NodeType, Prot, HVsn, LVsn, Name, Extra) ->
+    Utf8Name = unicode:characters_to_binary(Name),
+    [?EPMD_ALIVE2_REQ, put16(Port), NodeType, Prot,
+     put16(HVsn), put16(LVsn),
+     put16(size(Utf8Name)), binary_to_list(Utf8Name),
+     size16(Extra), Extra].
-- 
cgit v1.2.3


From 40695d080b0dc0665b01803768ffc74ed2eca207 Mon Sep 17 00:00:00 2001
From: Michael Santos <michael.santos@gmail.com>
Date: Sun, 18 Oct 2015 16:20:37 -0400
Subject: epmd: support IPv6 node registration

Allow IPv6 nodes to register with and query epmd. On systems with
IPv6 support:

* epmd listens on both the IPv4 and IPv6 ANY or loopback sockets

* the epmd cli client connects to epmd over the IPv6 loopback

* distributed nodes started with "-proto_dist inet6_tcp" will register
  with epmd over IPv6

To work on IPv6 capable systems that have IPv6 support disabled,
epmd ignores errors opening the socket if the protocol is not
supported. Similarly, the epmd client will fall back to IPv4 if the IPv6
socket is not available.

Update the minimum supported version of Windows to Windows Vista to
support IPv6.
---
 erts/epmd/src/epmd.c          |   2 +-
 erts/epmd/src/epmd_cli.c      |  30 +++++--
 erts/epmd/src/epmd_int.h      |  63 ++++++++-----
 erts/epmd/src/epmd_srv.c      | 201 +++++++++++++++++++++++++++++-------------
 erts/epmd/test/epmd_SUITE.erl |  33 ++++++-
 5 files changed, 238 insertions(+), 91 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 63ec18d939..5513cb2d7e 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -343,7 +343,7 @@ static void run_daemon(EpmdVars *g)
     for (fd = 0; fd < g->max_conn ; fd++) /* close all files ... */
         close(fd);
     /* Syslog on linux will try to write to whatever if we dont
-       inform it of that the log is closed. */
+       inform it that the log is closed. */
     closelog();
 
     /* These shouldn't be needed but for safety... */
diff --git a/erts/epmd/src/epmd_cli.c b/erts/epmd/src/epmd_cli.c
index a8fe865d9a..6fc05e153e 100644
--- a/erts/epmd/src/epmd_cli.c
+++ b/erts/epmd/src/epmd_cli.c
@@ -136,19 +136,33 @@ void epmd_call(EpmdVars *g,int what)
 static int conn_to_epmd(EpmdVars *g)
 {
     struct EPMD_SOCKADDR_IN address;
+    size_t salen = 0;
     int connect_sock;
-    
-    connect_sock = socket(FAMILY, SOCK_STREAM, 0);
-    if (connect_sock<0)
-	goto error;
+    unsigned short sport = g->port;
+
+#if defined(EPMD6)
+    SET_ADDR6(address, in6addr_loopback, sport);
+    salen = sizeof(struct sockaddr_in6);
+
+    connect_sock = socket(AF_INET6, SOCK_STREAM, 0);
+    if (connect_sock>=0) {
+
+    if (connect(connect_sock, (struct sockaddr*)&address, salen) == 0)
+	return connect_sock;
 
-    { /* store port number in unsigned short */
-      unsigned short sport = g->port;
-      SET_ADDR(address, EPMD_ADDR_LOOPBACK, sport);
+    close(connect_sock);
     }
+#endif
+    SET_ADDR(address, htonl(INADDR_LOOPBACK), sport);
+    salen = sizeof(struct sockaddr_in);
 
-    if (connect(connect_sock, (struct sockaddr*)&address, sizeof address) < 0) 
+    connect_sock = socket(AF_INET, SOCK_STREAM, 0);
+    if (connect_sock<0)
 	goto error;
+
+    if (connect(connect_sock, (struct sockaddr*)&address, salen) < 0)
+	goto error;
+
     return connect_sock;
 
  error:
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index 26100afc93..09317094c7 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -55,6 +55,7 @@
 #  ifndef WINDOWS_H_INCLUDES_WINSOCK2_H
 #    include <winsock2.h>
 #  endif
+#  include <ws2tcpip.h>
 #  include <windows.h>
 #  include <process.h>
 #endif
@@ -130,6 +131,10 @@
 #  include <systemd/sd-daemon.h>
 #endif /* HAVE_SYSTEMD_DAEMON */
 
+#if defined(HAVE_IN6) && defined(AF_INET6) && defined(HAVE_INET_PTON)
+#  define EPMD6
+#endif
+
 /* ************************************************************************ */
 /* Replace some functions by others by making the function name a macro */
 
@@ -183,33 +188,53 @@
 /* ************************************************************************ */
 /* Macros that let us use IPv6                                              */
 
-#if defined(HAVE_IN6) && defined(AF_INET6) && defined(EPMD6)
+#if HAVE_IN6
+#  if ! defined(HAVE_IN6ADDR_ANY) || ! HAVE_IN6ADDR_ANY
+#    if HAVE_DECL_IN6ADDR_ANY_INIT
+static const struct in6_addr in6addr_any = { { IN6ADDR_ANY_INIT } };
+#    else
+static const struct in6_addr in6addr_any =
+    { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } };
+#    endif /* HAVE_IN6ADDR_ANY_INIT */
+#  endif /* ! HAVE_DECL_IN6ADDR_ANY */
+
+#  if ! defined(HAVE_IN6ADDR_LOOPBACK) || ! HAVE_IN6ADDR_LOOPBACK
+#    if HAVE_DECL_IN6ADDR_LOOPBACK_INIT
+static const struct in6_addr in6addr_loopback =
+    { { IN6ADDR_LOOPBACK_INIT } };
+#    else
+static const struct in6_addr in6addr_loopback =
+    { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } };
+#    endif /* HAVE_IN6ADDR_LOOPBACK_INIT */
+#  endif /* ! HAVE_DECL_IN6ADDR_LOOPBACK */
+#endif /* HAVE_IN6 */
+
+#define IS_ADDR_LOOPBACK(addr) ((addr).s_addr == htonl(INADDR_LOOPBACK))
+
+#if defined(EPMD6)
 
-#define EPMD_SOCKADDR_IN sockaddr_in6
-#define EPMD_IN_ADDR in6_addr
-#define EPMD_S_ADDR s6_addr
-#define EPMD_ADDR_LOOPBACK in6addr_loopback.s6_addr
-#define EPMD_ADDR_ANY in6addr_any.s6_addr
+#define EPMD_SOCKADDR_IN sockaddr_storage
 #define FAMILY AF_INET6
 
-#define SET_ADDR(dst, addr, port) do { \
-    memset((char*)&(dst), 0, sizeof(dst)); \
-    memcpy((char*)&(dst).sin6_addr.s6_addr, (char*)&(addr), 16); \
-    (dst).sin6_family = AF_INET6; \
-    (dst).sin6_flowinfo = 0; \
-    (dst).sin6_port = htons(port); \
+#define SET_ADDR6(dst, addr, port) do { \
+    struct sockaddr_in6 *sa = (struct sockaddr_in6 *)&(dst); \
+    memset(sa, 0, sizeof(dst)); \
+    sa->sin6_family = AF_INET6; \
+    sa->sin6_addr = (addr); \
+    sa->sin6_port = htons(port); \
  } while(0)
 
-#define IS_ADDR_LOOPBACK(addr) \
-    (memcmp((addr).s6_addr, in6addr_loopback.s6_addr, 16) == 0)
+#define SET_ADDR(dst, addr, port) do { \
+    struct sockaddr_in *sa = (struct sockaddr_in *)&(dst); \
+    memset(sa, 0, sizeof(dst)); \
+    sa->sin_family = AF_INET; \
+    sa->sin_addr.s_addr = (addr); \
+    sa->sin_port = htons(port); \
+ } while(0)
 
 #else /* Not IP v6 */
 
 #define EPMD_SOCKADDR_IN sockaddr_in
-#define EPMD_IN_ADDR in_addr
-#define EPMD_S_ADDR s_addr
-#define EPMD_ADDR_LOOPBACK htonl(INADDR_LOOPBACK)
-#define EPMD_ADDR_ANY htonl(INADDR_ANY)
 #define FAMILY AF_INET
 
 #define SET_ADDR(dst, addr, port) do { \
@@ -219,8 +244,6 @@
     (dst).sin_port = htons(port); \
  } while(0)
 
-#define IS_ADDR_LOOPBACK(addr) ((addr).s_addr == htonl(INADDR_LOOPBACK))
-
 #endif /* Not IP v6 */
 
 /* ************************************************************************ */
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 7100855407..55ec0f7b6c 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -76,6 +76,7 @@ static time_t current_time(EpmdVars*);
 
 static Connection *conn_init(EpmdVars*);
 static int conn_open(EpmdVars*,int);
+static int conn_local_peer_check(EpmdVars*, int);
 static int conn_close_fd(EpmdVars*,int);
 
 static void node_init(EpmdVars*);
@@ -206,10 +207,11 @@ void run(EpmdVars *g)
 {
   struct EPMD_SOCKADDR_IN iserv_addr[MAX_LISTEN_SOCKETS];
   int listensock[MAX_LISTEN_SOCKETS];
-  int num_sockets;
+  int num_sockets = 0;
   int i;
   int opt;
   unsigned short sport = g->port;
+  int bound = 0;
 
   node_init(g);
   g->conn = conn_init(g);
@@ -252,64 +254,82 @@ void run(EpmdVars *g)
   if (g->addresses != NULL && /* String contains non-separator characters if: */
       g->addresses[strspn(g->addresses," ,")] != '\000')
     {
-      char *tmp;
-      char *token;
-      int loopback_ok = 0;
+      char *tmp = NULL;
+      char *token = NULL;
+
+      /* Always listen on the loopback. */
+      SET_ADDR(iserv_addr[num_sockets],htonl(INADDR_LOOPBACK),sport);
+      num_sockets++;
+#if defined(EPMD6)
+      SET_ADDR6(iserv_addr[num_sockets],in6addr_loopback,sport);
+      num_sockets++;
+#endif
 
-      if ((tmp = (char *)malloc(strlen(g->addresses) + 1)) == NULL)
+	  if ((tmp = strdup(g->addresses)) == NULL)
 	{
 	  dbg_perror(g,"cannot allocate memory");
 	  epmd_cleanup_exit(g,1);
 	}
-      strcpy(tmp,g->addresses);
 
-      for(token = strtok(tmp,", "), num_sockets = 0;
+      for(token = strtok(tmp,", ");
 	  token != NULL;
-	  token = strtok(NULL,", "), num_sockets++)
+	  token = strtok(NULL,", "))
 	{
-	  struct EPMD_IN_ADDR addr;
-#ifdef HAVE_INET_PTON
-	  int ret;
+	  struct in_addr addr;
+#if defined(EPMD6)
+	  struct in6_addr addr6;
+	  struct sockaddr_storage *sa = &iserv_addr[num_sockets];
 
-	  if ((ret = inet_pton(FAMILY,token,&addr)) == -1)
+	  if (inet_pton(AF_INET6,token,&addr6) == 1)
 	    {
-	      dbg_perror(g,"cannot convert IP address to network format");
-	      epmd_cleanup_exit(g,1);
+	      SET_ADDR6(iserv_addr[num_sockets],addr6,sport);
+	    }
+	  else if (inet_pton(AF_INET,token,&addr) == 1)
+	    {
+	      SET_ADDR(iserv_addr[num_sockets],addr.s_addr,sport);
+	    }
+	  else
+#else
+	  if ((addr.s_addr = inet_addr(token)) != INADDR_NONE)
+	    {
+	      SET_ADDR(iserv_addr[num_sockets],addr.s_addr,sport);
 	    }
-	  else if (ret == 0)
-#elif !defined(EPMD6)
-	  if ((addr.EPMD_S_ADDR = inet_addr(token)) == INADDR_NONE)
+	  else
 #endif
 	    {
 	      dbg_tty_printf(g,0,"cannot parse IP address \"%s\"",token);
 	      epmd_cleanup_exit(g,1);
 	    }
 
+#if defined(EPMD6)
+	  if (sa->ss_family == AF_INET6 && IN6_IS_ADDR_LOOPBACK(&addr6))
+	      continue;
+
+	  if (sa->ss_family == AF_INET)
+#endif
 	  if (IS_ADDR_LOOPBACK(addr))
-	    loopback_ok = 1;
+	    continue;
+
+	  num_sockets++;
 
-	  if (num_sockets - loopback_ok == MAX_LISTEN_SOCKETS - 1)
+	  if (num_sockets >= MAX_LISTEN_SOCKETS)
 	    {
 	      dbg_tty_printf(g,0,"cannot listen on more than %d IP addresses",
 			     MAX_LISTEN_SOCKETS);
 	      epmd_cleanup_exit(g,1);
 	    }
-
-	  SET_ADDR(iserv_addr[num_sockets],addr.EPMD_S_ADDR,sport);
 	}
 
       free(tmp);
-
-      if (!loopback_ok)
-	{
-	  SET_ADDR(iserv_addr[num_sockets],EPMD_ADDR_LOOPBACK,sport);
-	  num_sockets++;
-	}
     }
   else
     {
-      SET_ADDR(iserv_addr[0],EPMD_ADDR_ANY,sport);
-      num_sockets = 1;
+      SET_ADDR(iserv_addr[num_sockets],htonl(INADDR_ANY),sport);
+      num_sockets++;
+#if defined(EPMD6)
+      SET_ADDR6(iserv_addr[num_sockets],in6addr_any,sport);
+      num_sockets++;
+#endif
     }
 #ifdef HAVE_SYSTEMD_DAEMON
     }
@@ -340,13 +360,39 @@ void run(EpmdVars *g)
 #endif /* HAVE_SYSTEMD_DAEMON */
   for (i = 0; i < num_sockets; i++)
     {
-      if ((listensock[i] = socket(FAMILY,SOCK_STREAM,0)) < 0)
+      struct sockaddr *sa = (struct sockaddr *)&iserv_addr[i];
+#if defined(EPMD6)
+      size_t salen = (sa->sa_family == AF_INET6 ?
+              sizeof(struct sockaddr_in6) :
+              sizeof(struct sockaddr_in));
+#else
+      size_t salen = sizeof(struct sockaddr_in);
+#endif
+
+      if ((listensock[i] = socket(sa->sa_family,SOCK_STREAM,0)) < 0)
 	{
-	  dbg_perror(g,"error opening stream socket");
-	  epmd_cleanup_exit(g,1);
+	  switch (errno) {
+	      case EAFNOSUPPORT:
+	      case EPROTONOSUPPORT:
+	          continue;
+	      default:
+	          dbg_perror(g,"error opening stream socket");
+	          epmd_cleanup_exit(g,1);
+	  }
 	}
       g->listenfd[i] = listensock[i];
-  
+
+#if HAVE_DECL_IPV6_V6ONLY
+      opt = 1;
+      if (sa->sa_family == AF_INET6 &&
+          setsockopt(listensock[i],IPPROTO_IPV6,IPV6_V6ONLY,&opt,
+              sizeof(opt)) <0)
+	{
+	  dbg_perror(g,"can't set IPv6 only socket option");
+	  epmd_cleanup_exit(g,1);
+	}
+#endif
+
       /*
        * Note that we must not enable the SO_REUSEADDR on Windows,
        * because addresses will be reused even if they are still in use.
@@ -378,8 +424,7 @@ void run(EpmdVars *g)
 	dbg_perror(g,"failed to set non-blocking mode of listening socket %d",
 		   listensock[i]);
 
-      if (bind(listensock[i], (struct sockaddr*) &iserv_addr[i],
-	  sizeof(iserv_addr[i])) < 0)
+      if (bind(listensock[i], (struct sockaddr*) &iserv_addr[i], salen) < 0)
 	{
 	  if (errno == EADDRINUSE)
 	    {
@@ -394,12 +439,18 @@ void run(EpmdVars *g)
 	    }
 	}
 
+      bound++;
+
       if(listen(listensock[i], SOMAXCONN) < 0) {
           dbg_perror(g,"failed to listen on socket");
           epmd_cleanup_exit(g,1);
       }
       select_fd_set(g, listensock[i]);
     }
+  if (bound == 0) {
+      dbg_perror(g,"unable to bind any address");
+      epmd_cleanup_exit(g,1);
+  }
 #ifdef HAVE_SYSTEMD_DAEMON
     }
     sd_notifyf(0, "READY=1\n"
@@ -1005,15 +1056,6 @@ static int conn_open(EpmdVars *g,int fd)
 
   for (i = 0; i < g->max_conn; i++) {
     if (g->conn[i].open == EPMD_FALSE) {
-      struct sockaddr_in si;
-      struct sockaddr_in di;
-#ifdef HAVE_SOCKLEN_T
-      socklen_t st;
-#else
-      int st;
-#endif
-      st = sizeof(si);
-
       g->active_conn++;
       s = &g->conn[i];
      
@@ -1024,20 +1066,7 @@ static int conn_open(EpmdVars *g,int fd)
       s->open = EPMD_TRUE;
       s->keep = EPMD_FALSE;
 
-      /* Determine if connection is from localhost */
-      if (getpeername(s->fd,(struct sockaddr*) &si,&st) ||
-	  st < sizeof(si)) {
-	  /* Failure to get peername is regarded as non local host */
-	  s->local_peer = EPMD_FALSE;
-      } else {
-	  /* Only 127.x.x.x and connections from the host's IP address
-	     allowed, no false positives */
-	  s->local_peer =
-	      (((((unsigned) ntohl(si.sin_addr.s_addr)) & 0xFF000000U) ==
-	       0x7F000000U) ||
-	       (getsockname(s->fd,(struct sockaddr*) &di,&st) ?
-	       EPMD_FALSE : si.sin_addr.s_addr == di.sin_addr.s_addr));
-      }
+      s->local_peer = conn_local_peer_check(g, s->fd);
       dbg_tty_printf(g,2,(s->local_peer) ? "Local peer connected" :
 		     "Non-local peer connected");
 
@@ -1045,7 +1074,7 @@ static int conn_open(EpmdVars *g,int fd)
       s->got  = 0;
       s->mod_time = current_time(g); /* Note activity */
 
-      s->buf = (char *)malloc(INBUF_SIZE);
+      s->buf = malloc(INBUF_SIZE);
 
       if (s->buf == NULL) {
 	dbg_printf(g,0,"epmd: Insufficient memory");
@@ -1063,6 +1092,60 @@ static int conn_open(EpmdVars *g,int fd)
   return EPMD_FALSE;
 }
 
+static int conn_local_peer_check(EpmdVars *g, int fd)
+{
+  struct EPMD_SOCKADDR_IN si;
+  struct EPMD_SOCKADDR_IN di;
+
+  struct sockaddr_in *si4 = (struct sockaddr_in *)&si;
+  struct sockaddr_in *di4 = (struct sockaddr_in *)&di;
+
+#if defined(EPMD6)
+  struct sockaddr_in6 *si6 = (struct sockaddr_in6 *)&si;
+  struct sockaddr_in6 *di6 = (struct sockaddr_in6 *)&di;
+#endif
+
+#ifdef HAVE_SOCKLEN_T
+  socklen_t st;
+#else
+  int st;
+#endif
+
+  st = sizeof(si);
+
+  /* Determine if connection is from localhost */
+  if (getpeername(fd,(struct sockaddr*) &si,&st) ||
+	  st > sizeof(si)) {
+	  /* Failure to get peername is regarded as non local host */
+	  return EPMD_FALSE;
+  }
+
+  /* Only 127.x.x.x and connections from the host's IP address
+	 allowed, no false positives */
+#if defined(EPMD6)
+  if (si.ss_family == AF_INET6 && IN6_IS_ADDR_LOOPBACK(&(si6->sin6_addr)))
+	  return EPMD_TRUE;
+
+  if (si.ss_family == AF_INET)
+#endif
+  if ((((unsigned) ntohl(si4->sin_addr.s_addr)) & 0xFF000000U) ==
+	  0x7F000000U)
+	  return EPMD_TRUE;
+
+  if (getsockname(fd,(struct sockaddr*) &di,&st))
+	  return EPMD_FALSE;
+
+#if defined(EPMD6)
+  if (si.ss_family == AF_INET6)
+      return IN6_ARE_ADDR_EQUAL( &(si6->sin6_addr), &(di6->sin6_addr));
+  if (si.ss_family == AF_INET)
+#endif
+  return si4->sin_addr.s_addr == di4->sin_addr.s_addr;
+#if defined(EPMD6)
+  return EPMD_FALSE;
+#endif
+}
+
 static int conn_close_fd(EpmdVars *g,int fd)
 {
   int i;
diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index 4de65500e9..d5837e5b8c 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -43,6 +43,7 @@
 -export(
    [
     register_name/1,
+    register_name_ipv6/1,
     register_names_1/1,
     register_names_2/1,
     register_duplicate_name/1,
@@ -113,7 +114,8 @@
 suite() -> [{ct_hooks,[ts_install_cth]}].
 
 all() -> 
-    [register_name, register_names_1, register_names_2,
+    [register_name, register_name_ipv6,
+     register_names_1, register_names_2,
      register_duplicate_name, unicode_name, long_unicode_name,
      get_port_nr, slow_get_port_nr,
      unregister_others_name_1, unregister_others_name_2,
@@ -172,6 +174,24 @@ register_name(Config) when is_list(Config) ->
     ?line ok = close(Sock),			% Unregister
     ok.
 
+register_name_ipv6(doc) ->
+    ["Register a name over IPv6"];
+register_name_ipv6(suite) ->
+    [];
+register_name_ipv6(Config) when is_list(Config) ->
+    % Test if the host has an IPv6 loopback address
+    Res = gen_tcp:listen(0, [inet6, {ip, {0,0,0,0,0,0,0,1}}]),
+    case Res of
+    {ok,LSock} ->
+	    gen_tcp:close(LSock),
+	    ?line ok = epmdrun(),
+	    ?line {ok,Sock} = register_node6("foobar6"),
+	    ?line ok = close(Sock),         % Unregister
+	    ok;
+    _Error ->
+	    {skip, "Host does not have an IPv6 loopback address"}
+    end.
+
 register_names_1(doc) ->
     ["Register and unregister two nodes"];
 register_names_1(suite) ->
@@ -245,9 +265,14 @@ register_node(Name) ->
 register_node(Name,Port) ->
     register_node_v2(Port,$M,0,5,5,Name,"").
 
+register_node6(Name) ->
+    register_node_v2({0,0,0,0,0,0,0,1},?DUMMY_PORT,$M,0,5,5,Name,"").
+
 register_node_v2(Port, NodeType, Prot, HVsn, LVsn, Name, Extra) ->
+    register_node_v2("localhost", Port, NodeType, Prot, HVsn, LVsn, Name, Extra).
+register_node_v2(Addr, Port, NodeType, Prot, HVsn, LVsn, Name, Extra) ->
     Req = alive2_req(Port, NodeType, Prot, HVsn, LVsn, Name, Extra),
-    case send_req(Req) of
+    case send_req(Req, Addr) of
 	{ok,Sock} ->
 	    case recv(Sock,4) of
 		{ok, [?EPMD_ALIVE2_RESP,_Res=0,_C0,_C1]} ->
@@ -1186,7 +1211,9 @@ send_direct(Sock, Bytes) ->
     end.
 
 send_req(Req) ->
-    case connect() of
+    send_req(Req, "localhost").
+send_req(Req, Addr) ->
+    case connect(Addr) of
 	{ok,Sock} ->
 	    case send(Sock, [size16(Req), Req]) of
 		ok ->
-- 
cgit v1.2.3


From 03fcb7dabf8861e60ffab4121a909b347bccfec9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Mon, 15 Feb 2016 15:33:12 +0100
Subject: Eliminate use of test_server.hrl and test_server_line.hrl

As a first step to removing the test_server application as
as its own separate application, change the inclusion of
test_server.hrl to an inclusion of ct.hrl and remove the
inclusion of test_server_line.hrl.
---
 erts/epmd/test/epmd_SUITE.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index 4de65500e9..0c8f01ef6b 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -18,7 +18,7 @@
 %% %CopyrightEnd%
 %%
 -module(epmd_SUITE).
--include_lib("test_server/include/test_server.hrl").
+-include_lib("common_test/include/ct.hrl").
 -include_lib("kernel/include/file.hrl").
 
 
-- 
cgit v1.2.3


From b1e4836bcfbfdec0504219ed490c5f53860d8106 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Tue, 1 Mar 2016 15:19:36 +0100
Subject: Skips any sockets with unsupported protocols.

Patch from end of PR 864
Fixes problem reported in the PR by jeckersb

In this error case, a negative file descriptor is now saved at
listensock[i], which leads to a buffer overflow later on at
https://github.com/msantos/otp/blob/epmd-IPv6-node-reg2/erts/epmd/src/epmd_srv.c#L498
when calling FD_ISSET(listensock[i],&read_mask).

To reproduce this:

    Completely disable IPv6 with ipv6.disable=1 on the kernel command line
    Build with fortified code (RHEL/CentOS default): CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fno-strict-aliasing'
---
 erts/epmd/src/epmd_srv.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 55ec0f7b6c..e1bac99ef9 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -380,7 +380,7 @@ void run(EpmdVars *g)
 	          epmd_cleanup_exit(g,1);
 	  }
 	}
-      g->listenfd[i] = listensock[i];
+      g->listenfd[bound++] = listensock[i];
 
 #if HAVE_DECL_IPV6_V6ONLY
       opt = 1;
@@ -439,8 +439,6 @@ void run(EpmdVars *g)
 	    }
 	}
 
-      bound++;
-
       if(listen(listensock[i], SOMAXCONN) < 0) {
           dbg_perror(g,"failed to listen on socket");
           epmd_cleanup_exit(g,1);
@@ -451,6 +449,7 @@ void run(EpmdVars *g)
       dbg_perror(g,"unable to bind any address");
       epmd_cleanup_exit(g,1);
   }
+  num_sockets = bound;
 #ifdef HAVE_SYSTEMD_DAEMON
     }
     sd_notifyf(0, "READY=1\n"
@@ -495,8 +494,8 @@ void run(EpmdVars *g)
 	}
 
 	for (i = 0; i < num_sockets; i++)
-	  if (FD_ISSET(listensock[i],&read_mask)) {
-	    if (do_accept(g, listensock[i]) && g->active_conn < g->max_conn) {
+	  if (FD_ISSET(g->listenfd[i],&read_mask)) {
+	    if (do_accept(g, g->listenfd[i]) && g->active_conn < g->max_conn) {
 	      /*
 	       * The accept() succeeded, and we have at least one file
 	       * descriptor still free, which means that another accept()
-- 
cgit v1.2.3


From 6664eed554974336909d3ffe03f20349cc4c38fd Mon Sep 17 00:00:00 2001
From: Henrik Nord <henrik@erlang.org>
Date: Tue, 15 Mar 2016 15:19:56 +0100
Subject: update copyright-year

---
 erts/epmd/Makefile            | 2 +-
 erts/epmd/epmd.mk             | 2 +-
 erts/epmd/src/Makefile        | 2 +-
 erts/epmd/src/Makefile.in     | 2 +-
 erts/epmd/src/epmd.c          | 2 +-
 erts/epmd/src/epmd.h          | 2 +-
 erts/epmd/src/epmd_cli.c      | 2 +-
 erts/epmd/src/epmd_int.h      | 2 +-
 erts/epmd/src/epmd_srv.c      | 2 +-
 erts/epmd/test/Makefile       | 2 +-
 erts/epmd/test/epmd_SUITE.erl | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/Makefile b/erts/epmd/Makefile
index 25a33462ee..d3308ddedc 100644
--- a/erts/epmd/Makefile
+++ b/erts/epmd/Makefile
@@ -1,7 +1,7 @@
 # 
 # %CopyrightBegin%
 # 
-# Copyright Ericsson AB 1998-2009. All Rights Reserved.
+# Copyright Ericsson AB 1998-2016. All Rights Reserved.
 # 
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
diff --git a/erts/epmd/epmd.mk b/erts/epmd/epmd.mk
index 08245b784e..b1fd04dc04 100644
--- a/erts/epmd/epmd.mk
+++ b/erts/epmd/epmd.mk
@@ -1,7 +1,7 @@
 # 
 # %CopyrightBegin%
 # 
-# Copyright Ericsson AB 1998-2009. All Rights Reserved.
+# Copyright Ericsson AB 1998-2016. All Rights Reserved.
 # 
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
diff --git a/erts/epmd/src/Makefile b/erts/epmd/src/Makefile
index 3e09a40566..4ae13fe05a 100644
--- a/erts/epmd/src/Makefile
+++ b/erts/epmd/src/Makefile
@@ -1,7 +1,7 @@
 # 
 # %CopyrightBegin%
 # 
-# Copyright Ericsson AB 1998-2009. All Rights Reserved.
+# Copyright Ericsson AB 1998-2016. All Rights Reserved.
 # 
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
diff --git a/erts/epmd/src/Makefile.in b/erts/epmd/src/Makefile.in
index 1266be44cb..da4370d5f9 100644
--- a/erts/epmd/src/Makefile.in
+++ b/erts/epmd/src/Makefile.in
@@ -1,7 +1,7 @@
 #
 # %CopyrightBegin%
 # 
-# Copyright Ericsson AB 1998-2012. All Rights Reserved.
+# Copyright Ericsson AB 1998-2016. All Rights Reserved.
 # 
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 324ae6ac40..b36f4ccd40 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -2,7 +2,7 @@
 /*
  * %CopyrightBegin%
  *
- * Copyright Ericsson AB 1998-2013. All Rights Reserved.
+ * Copyright Ericsson AB 1998-2016. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
diff --git a/erts/epmd/src/epmd.h b/erts/epmd/src/epmd.h
index 10483bb5a2..cffcd4ae7a 100644
--- a/erts/epmd/src/epmd.h
+++ b/erts/epmd/src/epmd.h
@@ -1,7 +1,7 @@
 /*
  * %CopyrightBegin%
  * 
- * Copyright Ericsson AB 1998-2010. All Rights Reserved.
+ * Copyright Ericsson AB 1998-2016. All Rights Reserved.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
diff --git a/erts/epmd/src/epmd_cli.c b/erts/epmd/src/epmd_cli.c
index 6fc05e153e..6fd27d46ea 100644
--- a/erts/epmd/src/epmd_cli.c
+++ b/erts/epmd/src/epmd_cli.c
@@ -1,7 +1,7 @@
 /*
  * %CopyrightBegin%
  * 
- * Copyright Ericsson AB 1998-2013. All Rights Reserved.
+ * Copyright Ericsson AB 1998-2016. All Rights Reserved.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index e127eff097..26b3e3379d 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -2,7 +2,7 @@
 /*
  * %CopyrightBegin%
  *
- * Copyright Ericsson AB 1998-2013. All Rights Reserved.
+ * Copyright Ericsson AB 1998-2016. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index 75a33f28cb..38ed137575 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -2,7 +2,7 @@
 /*
  * %CopyrightBegin%
  *
- * Copyright Ericsson AB 1998-2013. All Rights Reserved.
+ * Copyright Ericsson AB 1998-2016. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
diff --git a/erts/epmd/test/Makefile b/erts/epmd/test/Makefile
index 7c5302a2f1..ad1315440f 100644
--- a/erts/epmd/test/Makefile
+++ b/erts/epmd/test/Makefile
@@ -1,7 +1,7 @@
 #
 # %CopyrightBegin%
 #
-# Copyright Ericsson AB 1998-2012. All Rights Reserved.
+# Copyright Ericsson AB 1998-2016. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index 44d3c5a880..763984267a 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1998-2013. All Rights Reserved.
+%% Copyright Ericsson AB 1998-2016. All Rights Reserved.
 %%
 %% Licensed under the Apache License, Version 2.0 (the "License");
 %% you may not use this file except in compliance with the License.
-- 
cgit v1.2.3


From 16b921ad1c847ba0754adc10d2d45b17973dcd19 Mon Sep 17 00:00:00 2001
From: Alexey Lebedeff <alebedev@mirantis.com>
Date: Tue, 29 Mar 2016 20:30:22 +0300
Subject: Don't send unasked for systemd notifications

Suppose we have some erlang system that uses systemd unit with
Type=notify - so this should send startup confirmation itself. But if
systemd-enabled epmd will be started as a first step of that system
startup, empd startup confirmation will be misinterpeted by systemd. And
our erlang service will be considered 'ready' to early. Also this will
interefere with systemd MAINPID detection: systemd will be monitoring
`epmd` process instead of `beam` one.

For example, rabbitmq works around this issue by starting epmd using
separate short-lived beam process, with NOTIFY_SOCKET environment
variable reset - only in this way we could be sure that epmd will not
interfere with rabbit startup sequence.

This patch disables indiscriminate confirmation sending, and does it
only when it was explicitly asked to do so.
---
 erts/epmd/src/epmd.c     | 6 ++++--
 erts/epmd/src/epmd_srv.c | 8 +++++---
 2 files changed, 9 insertions(+), 5 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c
index 5513cb2d7e..4740ce8534 100644
--- a/erts/epmd/src/epmd.c
+++ b/erts/epmd/src/epmd.c
@@ -592,8 +592,10 @@ void epmd_cleanup_exit(EpmdVars *g, int exitval)
       free(g->argv);
   }
 #ifdef HAVE_SYSTEMD_DAEMON
-  sd_notifyf(0, "STATUS=Exited.\n"
-                "ERRNO=%i", exitval);
+  if (g->is_systemd){
+    sd_notifyf(0, "STATUS=Exited.\n"
+               "ERRNO=%i", exitval);
+  }
 #endif /* HAVE_SYSTEMD_DAEMON */
   exit(exitval);
 }
diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c
index e1bac99ef9..59d59ad0f7 100644
--- a/erts/epmd/src/epmd_srv.c
+++ b/erts/epmd/src/epmd_srv.c
@@ -452,9 +452,11 @@ void run(EpmdVars *g)
   num_sockets = bound;
 #ifdef HAVE_SYSTEMD_DAEMON
     }
-    sd_notifyf(0, "READY=1\n"
-                  "STATUS=Processing port mapping requests...\n"
-                  "MAINPID=%lu", (unsigned long) getpid());
+    if (g->is_systemd) {
+      sd_notifyf(0, "READY=1\n"
+                    "STATUS=Processing port mapping requests...\n"
+                    "MAINPID=%lu", (unsigned long) getpid());
+    }
 #endif /* HAVE_SYSTEMD_DAEMON */
 
   dbg_tty_printf(g,2,"entering the main select() loop");
-- 
cgit v1.2.3


From 415dc5b637624b8f3dc08fcf881e941a555f93da Mon Sep 17 00:00:00 2001
From: Michael Klishin <michael@novemberain.com>
Date: Sun, 10 Apr 2016 04:52:52 +0300
Subject: Typos correction, minor wording change

---
 erts/epmd/src/epmd_int.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h
index 09317094c7..574e2b5403 100644
--- a/erts/epmd/src/epmd_int.h
+++ b/erts/epmd/src/epmd_int.h
@@ -253,8 +253,8 @@ static const struct in6_addr in6addr_loopback =
 #define EPMD_TRUE 1
 
 /* If no activity we let select() return every IDLE_TIMEOUT second
-   A file descriptor that are idle for CLOSE_TIMEOUT seconds and
-   isn't a ALIVE socket is probably hanging and we close it */
+   A file descriptor that has been idle for CLOSE_TIMEOUT seconds and
+   isn't an ALIVE socket has probably hanged and should be closed */
 
 #define IDLE_TIMEOUT 5
 #define CLOSE_TIMEOUT 60
-- 
cgit v1.2.3


From 403a8f3e042ba5183efcbd33c5ff293f72f62037 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn-Egil=20Dahlberg?= <egil@erlang.org>
Date: Wed, 4 May 2016 17:50:52 +0200
Subject: Remove ?line macros

---
 erts/epmd/test/epmd_SUITE.erl | 994 +++++++++++++++++++++---------------------
 1 file changed, 494 insertions(+), 500 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index 763984267a..aeafe4326c 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -37,50 +37,47 @@
 
 % Test server specific exports
 -export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1, 
-	 init_per_group/2,end_per_group/2, 
-	 init_per_testcase/2, end_per_testcase/2]).
-
--export(
-   [
-    register_name/1,
-    register_name_ipv6/1,
-    register_names_1/1,
-    register_names_2/1,
-    register_duplicate_name/1,
-    unicode_name/1,
-    long_unicode_name/1,
-    get_port_nr/1,
-    slow_get_port_nr/1,
-    unregister_others_name_1/1,
-    unregister_others_name_2/1,
-    register_overflow/1,
-    name_with_null_inside/1,
-    name_null_terminated/1,
-    stupid_names_req/1,
-
-    no_data/1,
-    one_byte/1,
-    two_bytes/1,
-    partial_packet/1,
-    zero_length/1,
-    too_large/1,
-    alive_req_too_small_1/1,
-    alive_req_too_small_2/1,
-    alive_req_too_large/1,
-
-    returns_valid_empty_extra/1,
-    returns_valid_populated_extra_with_nulls/1,
-
-    names_stdout/1,
-
-    buffer_overrun_1/1,
-    buffer_overrun_2/1,
-    no_nonlocal_register/1,
-    no_nonlocal_kill/1,
-    no_live_killing/1,
-
-    socket_reset_before_alive2_reply_is_written/1
-   ]).
+         init_per_group/2,end_per_group/2,
+         init_per_testcase/2, end_per_testcase/2]).
+
+-export([register_name/1,
+         register_name_ipv6/1,
+         register_names_1/1,
+         register_names_2/1,
+         register_duplicate_name/1,
+         unicode_name/1,
+         long_unicode_name/1,
+         get_port_nr/1,
+         slow_get_port_nr/1,
+         unregister_others_name_1/1,
+         unregister_others_name_2/1,
+         register_overflow/1,
+         name_with_null_inside/1,
+         name_null_terminated/1,
+         stupid_names_req/1,
+
+         no_data/1,
+         one_byte/1,
+         two_bytes/1,
+         partial_packet/1,
+         zero_length/1,
+         too_large/1,
+         alive_req_too_small_1/1,
+         alive_req_too_small_2/1,
+         alive_req_too_large/1,
+
+         returns_valid_empty_extra/1,
+         returns_valid_populated_extra_with_nulls/1,
+
+         names_stdout/1,
+
+         buffer_overrun_1/1,
+         buffer_overrun_2/1,
+         no_nonlocal_register/1,
+         no_nonlocal_kill/1,
+         no_live_killing/1,
+
+         socket_reset_before_alive2_reply_is_written/1]).
 
 
 % Port we use for testing
@@ -88,7 +85,7 @@
 -define(EPMDARGS,"-packet_timeout 1").
 
 -define(DUMMY_PORT, 1000).			% Port number to register
-						% not in real use.
+% not in real use.
 
 % Timeouts etc inside test cases. Time is in milliseconds.
 -define(CONN_RETRY, 4).				% Times to retry connecting
@@ -169,9 +166,9 @@ register_name(doc) ->
 register_name(suite) ->
     [];
 register_name(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = register_node("foobar"),
-    ?line ok = close(Sock),			% Unregister
+    ok = epmdrun(),
+    {ok,Sock} = register_node("foobar"),
+    ok = close(Sock),			% Unregister
     ok.
 
 register_name_ipv6(doc) ->
@@ -182,14 +179,14 @@ register_name_ipv6(Config) when is_list(Config) ->
     % Test if the host has an IPv6 loopback address
     Res = gen_tcp:listen(0, [inet6, {ip, {0,0,0,0,0,0,0,1}}]),
     case Res of
-    {ok,LSock} ->
-	    gen_tcp:close(LSock),
-	    ?line ok = epmdrun(),
-	    ?line {ok,Sock} = register_node6("foobar6"),
-	    ?line ok = close(Sock),         % Unregister
-	    ok;
-    _Error ->
-	    {skip, "Host does not have an IPv6 loopback address"}
+        {ok,LSock} ->
+            gen_tcp:close(LSock),
+            ok = epmdrun(),
+            {ok,Sock} = register_node6("foobar6"),
+            ok = close(Sock),         % Unregister
+            ok;
+        _Error ->
+            {skip, "Host does not have an IPv6 loopback address"}
     end.
 
 register_names_1(doc) ->
@@ -197,11 +194,11 @@ register_names_1(doc) ->
 register_names_1(suite) ->
     [];
 register_names_1(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock1} = register_node("foobar"),
-    ?line {ok,Sock2} = register_node("foozap"),
-    ?line ok = close(Sock1),			% Unregister
-    ?line ok = close(Sock2),			% Unregister
+    ok = epmdrun(),
+    {ok,Sock1} = register_node("foobar"),
+    {ok,Sock2} = register_node("foozap"),
+    ok = close(Sock1),			% Unregister
+    ok = close(Sock2),			% Unregister
     ok.
 
 register_names_2(doc) ->
@@ -209,11 +206,11 @@ register_names_2(doc) ->
 register_names_2(suite) ->
     [];
 register_names_2(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock1} = register_node("foobar"),
-    ?line {ok,Sock2} = register_node("foozap"),
-    ?line ok = close(Sock2),			% Unregister
-    ?line ok = close(Sock1),			% Unregister
+    ok = epmdrun(),
+    {ok,Sock1} = register_node("foobar"),
+    {ok,Sock2} = register_node("foozap"),
+    ok = close(Sock2),			% Unregister
+    ok = close(Sock1),			% Unregister
     ok.
 
 register_duplicate_name(doc) ->
@@ -221,10 +218,10 @@ register_duplicate_name(doc) ->
 register_duplicate_name(suite) ->
     [];
 register_duplicate_name(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = register_node("foobar"),
-    ?line error = register_node("foobar"),
-    ?line ok = close(Sock),			% Unregister
+    ok = epmdrun(),
+    {ok,Sock} = register_node("foobar"),
+    error = register_node("foobar"),
+    ok = close(Sock),			% Unregister
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -273,50 +270,50 @@ register_node_v2(Port, NodeType, Prot, HVsn, LVsn, Name, Extra) ->
 register_node_v2(Addr, Port, NodeType, Prot, HVsn, LVsn, Name, Extra) ->
     Req = alive2_req(Port, NodeType, Prot, HVsn, LVsn, Name, Extra),
     case send_req(Req, Addr) of
-	{ok,Sock} ->
-	    case recv(Sock,4) of
-		{ok, [?EPMD_ALIVE2_RESP,_Res=0,_C0,_C1]} ->
-		    {ok,Sock};
-		Other ->
-		    test_server:format("recv on sock ~w: ~p~n",
-				       [Sock,Other]),
-		    error
-	    end;
-	error ->
-	    error
+        {ok,Sock} ->
+            case recv(Sock,4) of
+                {ok, [?EPMD_ALIVE2_RESP,_Res=0,_C0,_C1]} ->
+                    {ok,Sock};
+                Other ->
+                    test_server:format("recv on sock ~w: ~p~n",
+                                       [Sock,Other]),
+                    error
+            end;
+        error ->
+            error
     end.
 
 % Internal function to fetch information about a node
 
 port_please_v2(Name) ->
     case send_req([?EPMD_PORT_PLEASE2_REQ,
-		   binary_to_list(unicode:characters_to_binary(Name))]) of
-	{ok,Sock} ->
-	    case recv_until_sock_closes(Sock) of
-		{ok, Resp} ->
-		    parse_port2_resp(Resp);
-		Other ->
-		    test_server:format("recv on sock ~w: ~p~n",
-				       [Sock,Other]),
-		    error
-	    end;
-	error ->
-	    error
+                   binary_to_list(unicode:characters_to_binary(Name))]) of
+        {ok,Sock} ->
+            case recv_until_sock_closes(Sock) of
+                {ok, Resp} ->
+                    parse_port2_resp(Resp);
+                Other ->
+                    test_server:format("recv on sock ~w: ~p~n",
+                                       [Sock,Other]),
+                    error
+            end;
+        error ->
+            error
     end.
 
 parse_port2_resp(Resp) ->
     case list_to_binary(Resp) of
-	<<?EPMD_PORT2_RESP,Res,Port:16,NodeType,Prot,HVsn:16,LVsn:16,
-	  NLen:16,NodeName:NLen/binary,
-	  ELen:16,Extra:ELen/binary>> when Res =:= 0 ->
-	    {ok, #node_info{port=Port,node_type=NodeType,prot=Prot,
-			    hvsn=HVsn,lvsn=LVsn,
-			    node_name=unicode:characters_to_list(NodeName),
-			    extra=binary_to_list(Extra)}};
-	_Other ->
-	    test_server:format("invalid port2 resp: ~p~n",
-			       [Resp]),
-	    error
+        <<?EPMD_PORT2_RESP,Res,Port:16,NodeType,Prot,HVsn:16,LVsn:16,
+          NLen:16,NodeName:NLen/binary,
+          ELen:16,Extra:ELen/binary>> when Res =:= 0 ->
+            {ok, #node_info{port=Port,node_type=NodeType,prot=Prot,
+                            hvsn=HVsn,lvsn=LVsn,
+                            node_name=unicode:characters_to_list(NodeName),
+                            extra=binary_to_list(Extra)}};
+        _Other ->
+            test_server:format("invalid port2 resp: ~p~n",
+                               [Resp]),
+            error
     end.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -326,8 +323,8 @@ name_with_null_inside(doc) ->
 name_with_null_inside(suite) ->
     [];
 name_with_null_inside(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line error = register_node("foo\000bar"),
+    ok = epmdrun(),
+    error = register_node("foo\000bar"),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -337,8 +334,8 @@ name_null_terminated(doc) ->
 name_null_terminated(suite) ->
     [];
 name_null_terminated(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line error = register_node("foobar\000"),
+    ok = epmdrun(),
+    error = register_node("foobar\000"),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -351,23 +348,23 @@ stupid_names_req(Config) when is_list(Config) ->
     Dog = ?config(watchdog, Config),
     test_server:timetrap_cancel(Dog),
     LongDog = test_server:timetrap(?MEDIUM_TEST_TIMEOUT),
-    ?line ok = epmdrun(),
-    ?line [FirstConn | Conn] = register_many(1, ?REG_REPEAT_LIM, "foo"),
-    ?line unregister_many([FirstConn]),
+    ok = epmdrun(),
+    [FirstConn | Conn] = register_many(1, ?REG_REPEAT_LIM, "foo"),
+    unregister_many([FirstConn]),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = check_names(Conn),
-    ?line ok = unregister_many(Conn),
+    ok = check_names(Conn),
+    ok = unregister_many(Conn),
     test_server:timetrap_cancel(LongDog),
     ok.
 
 check_names(Conn) ->
-    ?line {ok,Sock} = connect_active(),
-    ?line {ok,Reply} = do_get_names(Sock),
-    ?line SortConn  = lists:sort(Conn),
-    ?line SortReply = lists:sort(Reply),
-    ?line ok = check_names_cmp(SortConn, SortReply),
+    {ok,Sock} = connect_active(),
+    {ok,Reply} = do_get_names(Sock),
+    SortConn  = lists:sort(Conn),
+    SortReply = lists:sort(Reply),
+    ok = check_names_cmp(SortConn, SortReply),
     ok.
-    
+
 
 % Compare if the result was the same as was registered
 
@@ -381,43 +378,43 @@ check_names_cmp([{Name,Port,_Sock} | Conn], [{Name,Port} | Reply]) ->
 
 -define(int16(X), [(X bsr 8) band 16#ff, X band 16#ff]).
 -define(u32(X1,X2,X3,X4), 
-	(((X1) bsl 24) bor ((X2) bsl 16) bor ((X3) bsl 8) bor X4)).
+        (((X1) bsl 24) bor ((X2) bsl 16) bor ((X3) bsl 8) bor X4)).
 
 do_get_names(Socket) ->
     inet_tcp:send(Socket, [?int16(1),?EPMD_NAMES_REQ]),
     receive
-	{tcp, Socket, [P0,P1,P2,P3 | T]} ->
-	    EpmdPort = ?u32(P0,P1,P2,P3),
-	    if EpmdPort == ?PORT ->
-		    names_loop(Socket, T, []);
-	       true ->
-		    close(Socket),
-		    {error, address}
-	    end;
-	{tcp_closed, Socket} ->
-	    {ok, []}
+        {tcp, Socket, [P0,P1,P2,P3 | T]} ->
+            EpmdPort = ?u32(P0,P1,P2,P3),
+            if EpmdPort == ?PORT ->
+                   names_loop(Socket, T, []);
+               true ->
+                   close(Socket),
+                   {error, address}
+            end;
+        {tcp_closed, Socket} ->
+            {ok, []}
     end.
 
 names_loop(Socket, Acc, Ps) ->
     receive
-	{tcp, Socket, Bytes} ->
-	    {NAcc, NPs} = scan_names(Acc ++ Bytes, Ps),
-	    names_loop(Socket, NAcc, NPs);
-	{tcp_closed, Socket} ->
-	    {_, NPs} = scan_names(Acc, Ps),	% Really needed?
-	    {ok, NPs}
+        {tcp, Socket, Bytes} ->
+            {NAcc, NPs} = scan_names(Acc ++ Bytes, Ps),
+            names_loop(Socket, NAcc, NPs);
+        {tcp_closed, Socket} ->
+            {_, NPs} = scan_names(Acc, Ps),	% Really needed?
+            {ok, NPs}
     end.
 
 scan_names(Buf, Ps) ->
     case scan_line(Buf, []) of
-	{Line, NBuf} ->
-	    case parse_line(Line) of
-		{ok, Entry} -> 
-		    scan_names(NBuf, [Entry | Ps]);
-		error ->
-		    scan_names(NBuf, Ps)
-	    end;
-	[] -> {Buf, Ps}
+        {Line, NBuf} ->
+            case parse_line(Line) of
+                {ok, Entry} ->
+                    scan_names(NBuf, [Entry | Ps]);
+                error ->
+                    scan_names(NBuf, Ps)
+            end;
+        [] -> {Buf, Ps}
     end.
 
 scan_line([$\n | Buf], Line) -> {lists:reverse(Line), Buf};
@@ -426,16 +423,16 @@ scan_line([], _) -> [].
 
 parse_line([$n,$a,$m,$e,$ | Buf0]) ->
     case parse_name(Buf0, []) of
-	{Name, Buf1}  ->
-	    case Buf1 of
-		[$a,$t,$ ,$p,$o,$r,$t,$ | Buf2] ->
-		    case catch list_to_integer(Buf2) of
-			{'EXIT', _} -> error;
-			Port -> {ok, {Name, Port}}
-		    end;
-		_ -> error
-	    end;
-	error -> error
+        {Name, Buf1}  ->
+            case Buf1 of
+                [$a,$t,$ ,$p,$o,$r,$t,$ | Buf2] ->
+                    case catch list_to_integer(Buf2) of
+                        {'EXIT', _} -> error;
+                        Port -> {ok, {Name, Port}}
+                    end;
+                _ -> error
+            end;
+        error -> error
     end;
 parse_line(_) -> error.
 
@@ -465,23 +462,23 @@ slow_get_port_nr(Config) when is_list(Config) ->
 % Internal function used above
 
 port_request(M) ->
-    ?line ok = epmdrun(),
+    ok = epmdrun(),
     Port = 1042,
-    ?line {ok,RSock} = register_node("foo", Port),
-    ?line {ok,Sock} = connect(),
-    ?line ok = send(Sock,[size16(M),M]),
-    ?line case recv_until_sock_closes(Sock) of
-	      {ok, Resp} ->
-		  ?line close(RSock),
-		  ?line {ok,Rec} = parse_port2_resp(Resp),
-		  ?line Port = Rec#node_info.port,
-		  ok;
-	      Other ->
-		  ?line close(RSock),
-		  ?line test_server:format("recv on sock ~w: ~p~n",
-					   [Sock,Other]),
-		  ?line throw({error,Other})
-	  end,
+    {ok,RSock} = register_node("foo", Port),
+    {ok,Sock} = connect(),
+    ok = send(Sock,[size16(M),M]),
+    case recv_until_sock_closes(Sock) of
+        {ok, Resp} ->
+            close(RSock),
+            {ok,Rec} = parse_port2_resp(Resp),
+            Port = Rec#node_info.port,
+            ok;
+        Other ->
+            close(RSock),
+            test_server:format("recv on sock ~w: ~p~n",
+                               [Sock,Other]),
+            throw({error,Other})
+    end,
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -491,14 +488,14 @@ unregister_others_name_1(doc) ->
 unregister_others_name_1(suite) ->
     [];
 unregister_others_name_1(Config) when is_list(Config) ->
-    ?line ok = epmdrun("-relaxed_command_check"),
-    ?line {ok,RSock} = register_node("foo"),
-    ?line {ok,Sock} = connect(),
+    ok = epmdrun("-relaxed_command_check"),
+    {ok,RSock} = register_node("foo"),
+    {ok,Sock} = connect(),
     M = [?EPMD_STOP_REQ,"foo"],
-    ?line ok = send(Sock,[size16(M),M]),
+    ok = send(Sock,[size16(M),M]),
     R = "STOPPED",
-    ?line {ok,R} = recv(Sock,length(R)),
-    ?line ok = close(RSock),
+    {ok,R} = recv(Sock,length(R)),
+    ok = close(RSock),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -508,12 +505,12 @@ unregister_others_name_2(doc) ->
 unregister_others_name_2(suite) ->
     [];
 unregister_others_name_2(Config) when is_list(Config) ->
-    ?line ok = epmdrun("-relaxed_command_check"),
-    ?line {ok,Sock} = connect(),
+    ok = epmdrun("-relaxed_command_check"),
+    {ok,Sock} = connect(),
     M = [?EPMD_STOP_REQ,"xxx42"],
-    ?line ok = send(Sock,[size16(M),M]),
+    ok = send(Sock,[size16(M),M]),
     R = "NOEXIST",
-    ?line {ok,R} = recv(Sock,length(R)),
+    {ok,R} = recv(Sock,length(R)),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -526,32 +523,32 @@ register_overflow(Config) when is_list(Config) ->
     Dog = ?config(watchdog, Config),
     test_server:timetrap_cancel(Dog),
     LongDog = test_server:timetrap(?LONG_TEST_TIMEOUT),
-    ?line ok = epmdrun(),
-    ?line Conn = register_many(1, ?REG_REPEAT_LIM, "foo"),
+    ok = epmdrun(),
+    Conn = register_many(1, ?REG_REPEAT_LIM, "foo"),
     Count = length(Conn),
-    ?line ok = unregister_many(Conn),
+    ok = unregister_many(Conn),
     sleep(?MEDIUM_PAUSE),
     test_server:format("Limit was ~w names, now reg/unreg all 10 times~n",
-		       [Count]),
-    ?line ok = register_repeat(Count),
+                       [Count]),
+    ok = register_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = rregister_repeat(Count),
+    ok = rregister_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = register_repeat(Count),
+    ok = register_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = rregister_repeat(Count),
+    ok = rregister_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = register_repeat(Count),
+    ok = register_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = rregister_repeat(Count),
+    ok = rregister_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = register_repeat(Count),
+    ok = register_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = rregister_repeat(Count),
+    ok = rregister_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = register_repeat(Count),
+    ok = register_repeat(Count),
     sleep(?MEDIUM_PAUSE),
-    ?line ok = rregister_repeat(Count),
+    ok = rregister_repeat(Count),
     test_server:timetrap_cancel(LongDog),
     ok.
 
@@ -559,20 +556,20 @@ register_repeat(Count) ->
     Conn = register_many(1, ?REG_REPEAT_LIM, "foo"),
     ok = unregister_many(Conn),
     if
-	length(Conn) == Count ->
-	    ok;
-	true ->
-	    error
+        length(Conn) == Count ->
+            ok;
+        true ->
+            error
     end.
 
 rregister_repeat(Count) ->
     Conn = register_many(1, ?REG_REPEAT_LIM, "foo"),
     ok = unregister_many(lists:reverse(Conn)),
     if
-	length(Conn) == Count ->
-	    ok;
-	true ->
-	    error
+        length(Conn) == Count ->
+            ok;
+        true ->
+            error
     end.
 
 % Return count of successful registrations
@@ -584,23 +581,22 @@ register_many(I, N, Prefix) ->
     Name = gen_name(Prefix, I),
     Port = ?DUMMY_PORT + I,				% Just make it up
     case register_node(Name, Port) of
-	{ok,Sock} ->
-	    [{Name,Port,Sock} | register_many(I + 1, N, Prefix)];
-	Any ->
-	    test_server:format("Can't register: ~w of 1..~w ~w~n", 
-			       [Name,N,Any]),
-	    []
+        {ok,Sock} ->
+            [{Name,Port,Sock} | register_many(I + 1, N, Prefix)];
+        Any ->
+            test_server:format("Can't register: ~w of 1..~w ~w~n", [Name,N,Any]),
+            []
     end.
 
 unregister_many([]) ->
     ok;
 unregister_many([{Name,_Port,Sock} | Socks]) ->
     case close(Sock) of
-	ok ->
-	    unregister_many(Socks);
-	Any ->
-	    test_server:format("Can't unregister: ~w reason ~w~n", [Name,Any]),
-	    error
+        ok ->
+            unregister_many(Socks);
+        Any ->
+            test_server:format("Can't unregister: ~w reason ~w~n", [Name,Any]),
+            error
     end.
 
 gen_name(Str,Int) ->
@@ -613,10 +609,10 @@ no_data(doc) ->
 no_data(suite) ->
     [];
 no_data(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
     sleep(?LONG_PAUSE),
-    ?line closed = recv(Sock,1),
+    closed = recv(Sock,1),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -626,11 +622,11 @@ one_byte(doc) ->
 one_byte(suite) ->
     [];
 one_byte(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
-    ?line ok = send(Sock,[0]),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
+    ok = send(Sock,[0]),
     sleep(?LONG_PAUSE),
-    ?line closed = recv(Sock,1),
+    closed = recv(Sock,1),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -640,11 +636,11 @@ two_bytes(doc) ->
 two_bytes(suite) ->
     [];
 two_bytes(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
-    ?line ok = send(Sock,[put16(3)]),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
+    ok = send(Sock,[put16(3)]),
     sleep(?LONG_PAUSE),
-    ?line closed = recv(Sock,1),
+    closed = recv(Sock,1),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -654,11 +650,11 @@ partial_packet(doc) ->
 partial_packet(suite) ->
     [];
 partial_packet(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
-    ?line ok = send(Sock,[put16(100),"only a few bytes"]),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
+    ok = send(Sock,[put16(100),"only a few bytes"]),
     sleep(?LONG_PAUSE),
-    ?line closed = recv(Sock,1),
+    closed = recv(Sock,1),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -668,11 +664,11 @@ zero_length(doc) ->
 zero_length(suite) ->
     [];
 zero_length(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
-    ?line ok = send(Sock,[0,0,0,0,0,0,0,0,0,0]),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
+    ok = send(Sock,[0,0,0,0,0,0,0,0,0,0]),
     sleep(?MEDIUM_PAUSE),
-    ?line closed = recv(Sock,1),
+    closed = recv(Sock,1),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -682,18 +678,18 @@ too_large(doc) ->
 too_large(suite) ->
     [];
 too_large(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
     Size = 63000,
     M = lists:duplicate(Size, $z),
-    ?line ok = send(Sock,[put16(Size),M]),
+    ok = send(Sock,[put16(Size),M]),
     sleep(?MEDIUM_PAUSE),
     % With such a large packet, even the writes can fail as the
     % daemon closes before everything is delivered -> econnaborted
     case recv(Sock,1) of
-	closed -> ok;
-	{error,econnaborted} -> ok;
-	Other -> exit({unexpected,Other})
+        closed -> ok;
+        {error,econnaborted} -> ok;
+        Other -> exit({unexpected,Other})
     end.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -703,13 +699,13 @@ alive_req_too_small_1(doc) ->
 alive_req_too_small_1(suite) ->
     [];
 alive_req_too_small_1(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
     M = [?EPMD_ALIVE2_REQ, put16(?DUMMY_PORT),$M,0, put16(5),
-	 put16(5),put16(0)],
-    ?line ok = send(Sock, [size16(M), M]),
+         put16(5),put16(0)],
+    ok = send(Sock, [size16(M), M]),
     sleep(?MEDIUM_PAUSE),
-    ?line closed = recv(Sock,1),
+    closed = recv(Sock,1),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -719,13 +715,13 @@ alive_req_too_small_2(doc) ->
 alive_req_too_small_2(suite) ->
     [];
 alive_req_too_small_2(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
     M =  [?EPMD_ALIVE2_REQ, put16(?DUMMY_PORT),$M,0, put16(5),
-	  put16(5)],
-    ?line ok = send(Sock, [size16(M), M]),
+          put16(5)],
+    ok = send(Sock, [size16(M), M]),
     sleep(?MEDIUM_PAUSE),
-    ?line closed = recv(Sock,1),
+    closed = recv(Sock,1),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -735,28 +731,26 @@ alive_req_too_large(doc) ->
 alive_req_too_large(suite) ->
     [];
 alive_req_too_large(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = connect(),
-    L = [
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-	 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
-	 ],
+    ok = epmdrun(),
+    {ok,Sock} = connect(),
+    L = ["aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+         "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"],
     S = length(lists:flatten(L)),
     M = [?EPMD_ALIVE2_REQ, put16(?DUMMY_PORT),$M,0, put16(5),
-	 put16(5), put16(S),L,put16(0)],
-    ?line ok = send(Sock, [size16(M), M]),
+         put16(5), put16(S),L,put16(0)],
+    ok = send(Sock, [size16(M), M]),
     sleep(?MEDIUM_PAUSE),
-    ?line {ok,[?EPMD_ALIVE2_RESP,1]} = recv(Sock,2),
+    {ok,[?EPMD_ALIVE2_RESP,1]} = recv(Sock,2),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -766,10 +760,10 @@ returns_valid_empty_extra(doc) ->
 returns_valid_empty_extra(suite) ->
     [];
 returns_valid_empty_extra(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = register_node_v2(4711, 72, 0, 5, 5, "foo", []),
-    ?line {ok,#node_info{extra=[]}} = port_please_v2("foo"),
-    ?line ok = close(Sock),
+    ok = epmdrun(),
+    {ok,Sock} = register_node_v2(4711, 72, 0, 5, 5, "foo", []),
+    {ok,#node_info{extra=[]}} = port_please_v2("foo"),
+    ok = close(Sock),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -779,10 +773,10 @@ returns_valid_populated_extra_with_nulls(doc) ->
 returns_valid_populated_extra_with_nulls(suite) ->
     [];
 returns_valid_populated_extra_with_nulls(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = register_node_v2(4711, 72, 0, 5, 5, "foo", "ABC\000\000"),
-    ?line {ok,#node_info{extra="ABC\000\000"}} = port_please_v2("foo"),
-    ?line ok = close(Sock),
+    ok = epmdrun(),
+    {ok,Sock} = register_node_v2(4711, 72, 0, 5, 5, "foo", "ABC\000\000"),
+    {ok,#node_info{extra="ABC\000\000"}} = port_please_v2("foo"),
+    ok = close(Sock),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -792,15 +786,15 @@ names_stdout(doc) ->
 names_stdout(suite) ->
     [];
 names_stdout(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,Sock} = register_node("foobar"),
-    ?line ok = epmdrun("-names"),
-    ?line {ok, Data} = receive {_Port, {data, D}} -> {ok, D}
-		       after 10000 -> {error, timeout}
-		       end,
-    ?line {match,_} = re:run(Data, "^epmd: up and running", [multiline]),
-    ?line {match,_} = re:run(Data, "^name foobar at port", [multiline]),
-    ?line ok = close(Sock),
+    ok = epmdrun(),
+    {ok,Sock} = register_node("foobar"),
+    ok = epmdrun("-names"),
+    {ok, Data} = receive {_Port, {data, D}} -> {ok, D}
+                 after 10000 -> {error, timeout}
+                 end,
+    {match,_} = re:run(Data, "^epmd: up and running", [multiline]),
+    {match,_} = re:run(Data, "^name foobar at port", [multiline]),
+    ok = close(Sock),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -810,44 +804,44 @@ buffer_overrun_1(suite) ->
 buffer_overrun_1(doc) ->
     ["Test security vulnerability in fake extra lengths in alive2_req"];
 buffer_overrun_1(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line true = alltrue([hostile(N) || N <- lists:seq(1,10000)]),
+    ok = epmdrun(),
+    true = alltrue([hostile(N) || N <- lists:seq(1,10000)]),
     ok.
 buffer_overrun_2(suite) ->
     [];
 buffer_overrun_2(doc) ->
     ["Test security vulnerability in fake extra lengths in alive2_req"];
 buffer_overrun_2(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line [false | Rest] = [hostile2(N) || N <- lists:seq(255*4,10000)],
-    ?line true = alltrue(Rest),
+    ok = epmdrun(),
+    [false | Rest] = [hostile2(N) || N <- lists:seq(255*4,10000)],
+    true = alltrue(Rest),
     ok.
 hostile(N) ->
     try
-	Bin= <<$x:8,4747:16,$M:8,0:8,5:16,5:16,5:16,"gurka",N:16>>,
-	S = size(Bin),
-	{ok,E}=connect_sturdy(),
-	gen_tcp:send(E,[<<S:16>>,Bin]),
-	closed = recv(E,1),
-	gen_tcp:close(E),
-	true
+        Bin= <<$x:8,4747:16,$M:8,0:8,5:16,5:16,5:16,"gurka",N:16>>,
+        S = size(Bin),
+        {ok,E}=connect_sturdy(),
+        gen_tcp:send(E,[<<S:16>>,Bin]),
+        closed = recv(E,1),
+        gen_tcp:close(E),
+        true
     catch
-	_:_ ->
-	    false
+        _:_ ->
+            false
     end.
 hostile2(N) ->
     try
-	B2 = list_to_binary(lists:duplicate(N,255)),
-	Bin= <<$x:8,4747:16,$M:8,0:8,5:16,5:16,5:16,"gurka",N:16,B2/binary>>,
-	S = size(Bin),
-	{ok,E}=connect_sturdy(),
-	gen_tcp:send(E,[<<S:16>>,Bin]),
-	Z = recv(E,2),
-	gen_tcp:close(E),
-	(Z =:= closed) or (Z =:= {ok, [$y,1]})
+        B2 = list_to_binary(lists:duplicate(N,255)),
+        Bin= <<$x:8,4747:16,$M:8,0:8,5:16,5:16,5:16,"gurka",N:16,B2/binary>>,
+        S = size(Bin),
+        {ok,E}=connect_sturdy(),
+        gen_tcp:send(E,[<<S:16>>,Bin]),
+        Z = recv(E,2),
+        gen_tcp:close(E),
+        (Z =:= closed) or (Z =:= {ok, [$y,1]})
     catch
-	_A:_B ->
-	    false
+        _A:_B ->
+            false
     end.
 
 alltrue([]) ->
@@ -862,41 +856,41 @@ no_nonlocal_register(suite) ->
 no_nonlocal_register(doc) ->
     ["Ensure that we cannot register throug a nonlocal connection"];
 no_nonlocal_register(Config) when is_list(Config) ->
-    ?line case {os:find_executable("ssh"),ct:get_config(ssh_proxy_host)} of
-	      {SSH,Name} when is_list(Name), is_list(SSH) ->
-		  do_no_nonlocal_register(Config,Name);
-	      {false,_} ->
-		  {skip, "No ssh command found to create proxy"};
-	      _ ->
-		  {skip, "No ssh_proxy_host configured in ts.config"}
-	  end.
+    case {os:find_executable("ssh"),ct:get_config(ssh_proxy_host)} of
+        {SSH,Name} when is_list(Name), is_list(SSH) ->
+            do_no_nonlocal_register(Config,Name);
+        {false,_} ->
+            {skip, "No ssh command found to create proxy"};
+        _ ->
+            {skip, "No ssh_proxy_host configured in ts.config"}
+    end.
 do_no_nonlocal_register(Config,SSHHost) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line ProxyPort = proxy_port(),
-    ?line ok = ssh_proxy(SSHHost,ProxyPort),
+    ok = epmdrun(),
+    ProxyPort = proxy_port(),
+    ok = ssh_proxy(SSHHost,ProxyPort),
     Res = try
-	      ?line Name = "gurka_"
-	      %++
-	      %integer_to_list(A1)++"_"++
-	      %integer_to_list(A2)++"_"++
-	      %integer_to_list(A3)++"_"++
-	      %integer_to_list(A4)
-	      ,
-	      ?line Bname = list_to_binary(Name),
-	      ?line NameS = byte_size(Bname),
-	      ?line Bin= <<$x:8,4747:16,$M:8,0:8,5:16,
-			  5:16,NameS:16,Bname/binary,
-			  0:16>>,
-	      ?line S = size(Bin),
-	      ?line {ok, E} = connect("localhost",ProxyPort,passive),
-	      ?line gen_tcp:send(E,[<<S:16>>,Bin]),
-	      ?line closed = recv(E,1),
-	      ?line gen_tcp:close(E),
-	      true
-	  catch
-	      _:_ ->
-		  false
-	  end,
+              Name = "gurka_"
+              %++
+              %integer_to_list(A1)++"_"++
+              %integer_to_list(A2)++"_"++
+              %integer_to_list(A3)++"_"++
+              %integer_to_list(A4)
+              ,
+              Bname = list_to_binary(Name),
+              NameS = byte_size(Bname),
+              Bin= <<$x:8,4747:16,$M:8,0:8,5:16,
+                     5:16,NameS:16,Bname/binary,
+                     0:16>>,
+              S = size(Bin),
+              {ok, E} = connect("localhost",ProxyPort,passive),
+              gen_tcp:send(E,[<<S:16>>,Bin]),
+              closed = recv(E,1),
+              gen_tcp:close(E),
+              true
+          catch
+              _:_ ->
+                  false
+          end,
     %erlang:display(Res),
     true = Res,
     ok.
@@ -906,32 +900,32 @@ no_nonlocal_kill(suite) ->
 no_nonlocal_kill(doc) ->
     ["Ensure that we cannot kill through nonlocal connection"];
 no_nonlocal_kill(Config) when is_list(Config) ->
-    ?line case {os:find_executable("ssh"),ct:get_config(ssh_proxy_host)} of
-	      {SSH,Name} when is_list(Name), is_list(SSH) ->
-		  do_no_nonlocal_kill(Config,Name);
-	      {false,_} ->
-		  {skip, "No ssh command found to create proxy"};
-	      _ ->
-		  {skip, "No ssh_proxy_host configured in ts.config"}
-	  end.
+    case {os:find_executable("ssh"),ct:get_config(ssh_proxy_host)} of
+        {SSH,Name} when is_list(Name), is_list(SSH) ->
+            do_no_nonlocal_kill(Config,Name);
+        {false,_} ->
+            {skip, "No ssh command found to create proxy"};
+        _ ->
+            {skip, "No ssh_proxy_host configured in ts.config"}
+    end.
 do_no_nonlocal_kill(Config,SSHHost) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line ProxyPort = proxy_port(),
-    ?line ok = ssh_proxy(SSHHost,ProxyPort),
+    ok = epmdrun(),
+    ProxyPort = proxy_port(),
+    ok = ssh_proxy(SSHHost,ProxyPort),
     Res = try
-	      {ok, E} = connect("localhost",ProxyPort,passive),
-	      M = [?EPMD_KILL_REQ],
-	      send(E, [size16(M), M]),
-	      closed = recv(E,2),
-	      gen_tcp:close(E),
-	      sleep(?MEDIUM_PAUSE),
-	      {ok, E2} = connect("localhost",ProxyPort,passive),
-	      gen_tcp:close(E2),
-	      true
-	  catch
-	      _:_ ->
-		  false
-	  end,
+              {ok, E} = connect("localhost",ProxyPort,passive),
+              M = [?EPMD_KILL_REQ],
+              send(E, [size16(M), M]),
+              closed = recv(E,2),
+              gen_tcp:close(E),
+              sleep(?MEDIUM_PAUSE),
+              {ok, E2} = connect("localhost",ProxyPort,passive),
+              gen_tcp:close(E2),
+              true
+          catch
+              _:_ ->
+                  false
+          end,
     %erlang:display(Res),
     true = Res,
     ok.
@@ -941,25 +935,25 @@ no_live_killing(doc) ->
 no_live_killing(suite) ->
     [];
 no_live_killing(Config) when is_list(Config) ->
-    ?line ok = epmdrun(),
-    ?line {ok,RSock} = register_node("foo"),
-    ?line {ok,Sock} = connect(),
-    ?line M = [?EPMD_KILL_REQ],
-    ?line ok = send(Sock,[size16(M),M]),
-    ?line {ok,"NO"} = recv(Sock,2),
-    ?line close(Sock),
-    ?line {ok,Sock2} = connect(),
-    ?line M2 = [?EPMD_STOP_REQ,"foo"],
-    ?line ok = send(Sock2,[size16(M2),M2]),
-    ?line closed = recv(Sock2,1),
-    ?line close(Sock2),
-    ?line close(RSock),
-    ?line sleep(?MEDIUM_PAUSE),
-    ?line {ok,Sock3} = connect(),
-    ?line M3 = [?EPMD_KILL_REQ],
-    ?line ok = send(Sock3,[size16(M3),M3]),
-    ?line {ok,"OK"} = recv(Sock3,2),
-    ?line close(Sock3),
+    ok = epmdrun(),
+    {ok,RSock} = register_node("foo"),
+    {ok,Sock} = connect(),
+    M = [?EPMD_KILL_REQ],
+    ok = send(Sock,[size16(M),M]),
+    {ok,"NO"} = recv(Sock,2),
+    close(Sock),
+    {ok,Sock2} = connect(),
+    M2 = [?EPMD_STOP_REQ,"foo"],
+    ok = send(Sock2,[size16(M2),M2]),
+    closed = recv(Sock2,1),
+    close(Sock2),
+    close(RSock),
+    sleep(?MEDIUM_PAUSE),
+    {ok,Sock3} = connect(),
+    M3 = [?EPMD_KILL_REQ],
+    ok = send(Sock3,[size16(M3),M3]),
+    {ok,"OK"} = recv(Sock3,2),
+    close(Sock3),
     ok.
 
 socket_reset_before_alive2_reply_is_written(doc) ->
@@ -971,20 +965,20 @@ socket_reset_before_alive2_reply_is_written(Config) when is_list(Config) ->
     %% - delay_write for easier triggering of race condition
     %% - relaxed_command_check for gracefull shutdown of epmd even if there
     %%   is stuck node.
-    ?line ok = epmdrun("-delay_write 1 -relaxed_command_check"),
+    ok = epmdrun("-delay_write 1 -relaxed_command_check"),
 
     %% We can't use send_req/1 directly as we want to do inet:setopts/2
     %% on our socket.
-    ?line {ok, Sock} = connect(),
+    {ok, Sock} = connect(),
 
     %% Issuing close/1 on such socket will result in immediate RST packet.
-    ?line ok = inet:setopts(Sock, [{linger, {true, 0}}]),
+    ok = inet:setopts(Sock, [{linger, {true, 0}}]),
 
     Req = alive2_req(4711, 77, 0, 5, 5, "test", []),
-    ?line ok = send(Sock, [size16(Req), Req]),
+    ok = send(Sock, [size16(Req), Req]),
 
     timer:sleep(500), %% Wait for the first 1/2 of delay_write before closing
-    ?line ok = close(Sock),
+    ok = close(Sock),
 
     timer:sleep(500 + ?SHORT_PAUSE), %% Wait for the other 1/2 of delay_write
 
@@ -992,11 +986,11 @@ socket_reset_before_alive2_reply_is_written(Config) when is_list(Config) ->
     %% Should be removed when this is issue is fixed there.
     timer:sleep(1000),
 
-    ?line {ok, SockForNames} = connect_active(),
+    {ok, SockForNames} = connect_active(),
 
     %% And there should be no stuck nodes
-    ?line {ok, []} = do_get_names(SockForNames),
-    ?line ok = close(SockForNames),
+    {ok, []} = do_get_names(SockForNames),
+    ok = close(SockForNames),
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -1005,14 +999,14 @@ socket_reset_before_alive2_reply_is_written(Config) when is_list(Config) ->
 cleanup() ->
     sleep(?MEDIUM_PAUSE),
     case connect() of
-	{ok,Sock} ->
-	    M = [?EPMD_KILL_REQ],
-	    send(Sock, [size16(M), M]),
-	    recv(Sock,length("OK")),
-	    close(Sock),
-	    sleep(?MEDIUM_PAUSE);
-	_ ->
-	    true
+        {ok,Sock} ->
+            M = [?EPMD_KILL_REQ],
+            send(Sock, [size16(M), M]),
+            recv(Sock,length("OK")),
+            close(Sock),
+            sleep(?MEDIUM_PAUSE);
+        _ ->
+            true
     end.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -1022,11 +1016,11 @@ proxy_port() ->
     ?PORT+1.
 
 ssh_proxy(SSHHost,ProxyPort) ->
-    ?line Host = lists:nth(2,string:tokens(atom_to_list(node()),"@")),
+    Host = lists:nth(2,string:tokens(atom_to_list(node()),"@")),
     % Requires proxy to be a unix host with the command 'read' accessible
-    ?line osrun("ssh -L "++integer_to_list(ProxyPort)++":"++Host++":"
-		++integer_to_list(?PORT)++" "++SSHHost++" read").
-    
+    osrun("ssh -L "++integer_to_list(ProxyPort)++":"++Host++":"
+          ++integer_to_list(?PORT)++" "++SSHHost++" read").
+
 
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -1036,21 +1030,21 @@ epmdrun() ->
     epmdrun([]).
 epmdrun(Args) ->
     case os:find_executable(epmd) of
-	false ->
-	    {error, {could_not_find_epmd_in_path}};
-	Path ->
-	    epmdrun(Path,Args)
+        false ->
+            {error, {could_not_find_epmd_in_path}};
+        Path ->
+            epmdrun(Path,Args)
     end.
 
 epmdrun(Epmd,Args0) ->
-  %% test_server:format("epmdrun() => Epmd = ~p",[Epmd]),
+    %% test_server:format("epmdrun() => Epmd = ~p",[Epmd]),
     Args = case Args0 of
-	       [] ->
-		   [];
-	       O ->
-		   " "++O
-	   end,
-  osrun("\"" ++ Epmd ++ "\"" ++ " " ?EPMDARGS " -port " ++ integer_to_list(?PORT) ++ Args).
+               [] ->
+                   [];
+               O ->
+                   " "++O
+           end,
+    osrun("\"" ++ Epmd ++ "\"" ++ " " ?EPMDARGS " -port " ++ integer_to_list(?PORT) ++ Args).
 
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -1059,7 +1053,7 @@ epmdrun(Epmd,Args0) ->
 osrun(Cmd) ->
     _ = open_port({spawn, Cmd}, []),
     ok.
-    
+
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 % Wrappers of TCP functions
 
@@ -1084,16 +1078,16 @@ connect(Addr, Port, Mode) ->
     connect(Addr, Port, Mode, ?CONN_SLEEP, ?CONN_RETRY).
 connect(Addr, Port, Mode, Sleep, Retry) ->
     case connect_repeat(Addr, Retry, Port, Mode, Sleep) of
-	{ok,Sock} ->
-	    {ok,Sock};
-	{error,timeout} ->
-	    timeout;
-	{error,Reason} ->
-	    test_server:format("connect: error: ~w~n",[Reason]),
-	    error;
-	Any ->
-	    test_server:format("connect: unknown message: ~w~n",[Any]),
-	    exit(1)
+        {ok,Sock} ->
+            {ok,Sock};
+        {error,timeout} ->
+            timeout;
+        {error,Reason} ->
+            test_server:format("connect: error: ~w~n",[Reason]),
+            error;
+        Any ->
+            test_server:format("connect: unknown message: ~w~n",[Any]),
+            exit(1)
     end.
 
 
@@ -1104,33 +1098,33 @@ connect_repeat(Addr, 1, Port, Mode, _Sleep) ->
     connect_mode(Addr,Port, Mode);
 connect_repeat(Addr,Retry, Port, Mode, Sleep) ->
     case connect_mode(Addr,Port, Mode) of
-	{ok,Sock} ->
-	    {ok,Sock};
-	{error,Reason} ->
-	    test_server:format("connect: error: ~w~n",[Reason]),
-	    timer:sleep(Sleep),
-	    connect_repeat(Addr, Retry - 1, Port, Mode, Sleep);
-	Any ->
-	    test_server:format("connect: unknown message: ~w~n",[Any]),
-	    exit(1)
+        {ok,Sock} ->
+            {ok,Sock};
+        {error,Reason} ->
+            test_server:format("connect: error: ~w~n",[Reason]),
+            timer:sleep(Sleep),
+            connect_repeat(Addr, Retry - 1, Port, Mode, Sleep);
+        Any ->
+            test_server:format("connect: unknown message: ~w~n",[Any]),
+            exit(1)
     end.
 
 connect_mode(Addr,Port, active) ->
     gen_tcp:connect(Addr, Port, [{packet, 0}], ?CONN_TIMEOUT);
 connect_mode(Addr, Port, passive) ->
     gen_tcp:connect(Addr, Port, [{packet, 0}, {active, false}],
-		    ?CONN_TIMEOUT).
+                    ?CONN_TIMEOUT).
 
 
 close(Sock) ->
     case gen_tcp:close(Sock) of
-	{error,_} ->
-	    error;
-	ok ->
-	    ok;
-	Any ->
-	    test_server:format("unknown message: ~w~n",[Any]),
-	    exit(1)
+        {error,_} ->
+            error;
+        ok ->
+            ok;
+        Any ->
+            test_server:format("unknown message: ~w~n",[Any]),
+            exit(1)
     end.
 
 recv(Sock, Len) ->
@@ -1138,19 +1132,19 @@ recv(Sock, Len) ->
 
 recv(Sock, Len, Timeout) ->
     case gen_tcp:recv(Sock, Len, Timeout) of
-	{ok,[]} ->				% Should not be the case
-	    recv(Sock, 1, 1);			% any longer
-	{ok,Data} ->
-	    {ok,Data};
-	{error,timeout} ->
-	    timeout;
-	{error,closed} ->
-	    closed;
-	{error,_}=Error ->
-	    Error;
-	Any ->
-	    test_server:format("unknown message: ~w~n",[Any]),
-	    exit(1)
+        {ok,[]} ->				% Should not be the case
+            recv(Sock, 1, 1);			% any longer
+        {ok,Data} ->
+            {ok,Data};
+        {error,timeout} ->
+            timeout;
+        {error,closed} ->
+            closed;
+        {error,_}=Error ->
+            Error;
+        Any ->
+            test_server:format("unknown message: ~w~n",[Any]),
+            exit(1)
     end.
 
 %% Send data to socket. The list can be non flat and contain
@@ -1159,12 +1153,12 @@ recv(Sock, Len, Timeout) ->
 
 send(Sock, SendSpec) ->
     case send(SendSpec, [], Sock) of
-	{ok,[]} ->
-	    ok;
-	{ok,RevBytes} ->
-	    send_direct(Sock, lists:reverse(RevBytes));
-	Any ->
-	    Any
+        {ok,[]} ->
+            ok;
+        {ok,RevBytes} ->
+            send_direct(Sock, lists:reverse(RevBytes));
+        Any ->
+            Any
     end.
 
 
@@ -1179,54 +1173,54 @@ send([Byte | Spec], RevBytes, Sock) when is_integer(Byte) ->
     send(Spec, [Byte | RevBytes], Sock);
 send([List | Spec], RevBytes, Sock) when is_list(List) ->
     case send(List, RevBytes, Sock) of
-	{ok,Left} ->
-	    send(Spec, Left, Sock);
-	Other ->
-	    Other
+        {ok,Left} ->
+            send(Spec, Left, Sock);
+        Other ->
+            Other
     end;
 send([d | Spec], RevBytes, Sock) ->
     send([{d,1000} | Spec], RevBytes, Sock);
 send([{d,S} | Spec], RevBytes, Sock) ->
     case send_direct(Sock, lists:reverse(RevBytes)) of
-	ok ->
-	    timer:sleep(S),
-	    send(Spec, [], Sock);
-	Any ->
-	    Any
+        ok ->
+            timer:sleep(S),
+            send(Spec, [], Sock);
+        Any ->
+            Any
     end.
 
 %%%%
 
 send_direct(Sock, Bytes) ->
     case gen_tcp:send(Sock, Bytes) of
-	ok ->
-	    ok;
-	{error, closed} ->
-	    closed;
-	{error, _Reason} ->
-	    error;
-	Any ->
-	    test_server:format("unknown message: ~w~n",[Any]),
-	    Any
+        ok ->
+            ok;
+        {error, closed} ->
+            closed;
+        {error, _Reason} ->
+            error;
+        Any ->
+            test_server:format("unknown message: ~w~n",[Any]),
+            Any
     end.
 
 send_req(Req) ->
     send_req(Req, "localhost").
 send_req(Req, Addr) ->
     case connect(Addr) of
-	{ok,Sock} ->
-	    case send(Sock, [size16(Req), Req]) of
-		ok ->
-		    {ok,Sock};
-		Other ->
-		    test_server:format("Failed to send ~w on sock ~w: ~w~n",
-				       [Req,Sock,Other]),
-		    error
-	    end;
-	Other ->
-	    test_server:format("Connect failed when sending ~w: ~p~n",
-			       [Req, Other]),
-	    error
+        {ok,Sock} ->
+            case send(Sock, [size16(Req), Req]) of
+                ok ->
+                    {ok,Sock};
+                Other ->
+                    test_server:format("Failed to send ~w on sock ~w: ~w~n",
+                                       [Req,Sock,Other]),
+                    error
+            end;
+        Other ->
+            test_server:format("Connect failed when sending ~w: ~p~n",
+                               [Req, Other]),
+            error
     end.
 
 recv_until_sock_closes(Sock) ->
@@ -1234,12 +1228,12 @@ recv_until_sock_closes(Sock) ->
 
 recv_until_sock_closes_2(Sock,AccData) ->
     case recv(Sock,0) of
-	{ok,Data} ->
-	    recv_until_sock_closes_2(Sock,AccData++Data);
-	closed ->
-	    {ok,AccData};
-	Other ->
-	    Other
+        {ok,Data} ->
+            recv_until_sock_closes_2(Sock,AccData++Data);
+        closed ->
+            {ok,AccData};
+        Other ->
+            Other
     end.
 
 sleep(MilliSeconds) ->
@@ -1261,7 +1255,7 @@ flat_count([H|T], N) when is_list(H) ->
 flat_count([_|T], N) ->
     flat_count(T, N);
 flat_count([], N) -> N.
-    
+
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-- 
cgit v1.2.3


From 56b7f0078a269973f6cc90b63667e61c1f9dbedd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn-Egil=20Dahlberg?= <egil@erlang.org>
Date: Wed, 4 May 2016 17:59:33 +0200
Subject: Modernize use of timetraps

---
 erts/epmd/test/epmd_SUITE.erl | 46 +++++++++++--------------------------------
 1 file changed, 11 insertions(+), 35 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index aeafe4326c..29b10f2d29 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -23,22 +23,19 @@
 
 
 % Timeout for test cases (rather long to work on slow machines)
--define(SHORT_TEST_TIMEOUT, ?t:seconds(30)).	% Default
--define(MEDIUM_TEST_TIMEOUT, ?t:minutes(3)).
--define(LONG_TEST_TIMEOUT, ?t:minutes(10)).
+-define(MEDIUM_TEST_TIMEOUT, {minutes,3}).
+-define(LONG_TEST_TIMEOUT, {minutes,10}).
 
 % Delay inserted into code
 -define(SHORT_PAUSE, 100).
--define(MEDIUM_PAUSE, ?t:seconds(1)).
--define(LONG_PAUSE, ?t:seconds(5)).
+-define(MEDIUM_PAUSE, 1000).
+-define(LONG_PAUSE, 5000).
 
 % Information about nodes
 -record(node_info, {port, node_type, prot, lvsn, hvsn, node_name, extra}).
 
 % Test server specific exports
--export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1, 
-         init_per_group/2,end_per_group/2,
-         init_per_testcase/2, end_per_testcase/2]).
+-export([all/0, suite/0, groups/0, init_per_testcase/2, end_per_testcase/2]).
 
 -export([register_name/1,
          register_name_ipv6/1,
@@ -108,7 +105,9 @@
 %% all/1
 %%
 
-suite() -> [{ct_hooks,[ts_install_cth]}].
+suite() ->
+    [{ct_hooks,[ts_install_cth]},
+     {timetrap, ?MEDIUM_TEST_TIMEOUT}].
 
 all() -> 
     [register_name, register_name_ipv6,
@@ -131,32 +130,16 @@ groups() ->
     [{buffer_overrun, [],
       [buffer_overrun_1, buffer_overrun_2]}].
 
-init_per_suite(Config) ->
-    Config.
-
-end_per_suite(_Config) ->
-    ok.
-
-init_per_group(_GroupName, Config) ->
-    Config.
-
-end_per_group(_GroupName, Config) ->
-    Config.
-
-
 %%
 %% Run before and after each test case
 %%
 
 init_per_testcase(_Func, Config) ->
-    Dog = test_server:timetrap(?MEDIUM_TEST_TIMEOUT),
     cleanup(),
-    [{watchdog, Dog} | Config].
+    Config.
 
-end_per_testcase(_Func, Config) ->
+end_per_testcase(_Func, _Config) ->
     cleanup(),
-    Dog = ?config(watchdog, Config),
-    catch test_server:timetrap_cancel(Dog),	% We may have canceled already
     ok.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -345,16 +328,12 @@ stupid_names_req(doc) ->
 stupid_names_req(suite) ->
     [];
 stupid_names_req(Config) when is_list(Config) ->
-    Dog = ?config(watchdog, Config),
-    test_server:timetrap_cancel(Dog),
-    LongDog = test_server:timetrap(?MEDIUM_TEST_TIMEOUT),
     ok = epmdrun(),
     [FirstConn | Conn] = register_many(1, ?REG_REPEAT_LIM, "foo"),
     unregister_many([FirstConn]),
     sleep(?MEDIUM_PAUSE),
     ok = check_names(Conn),
     ok = unregister_many(Conn),
-    test_server:timetrap_cancel(LongDog),
     ok.
 
 check_names(Conn) ->
@@ -520,9 +499,7 @@ register_overflow(doc) ->
 register_overflow(suite) ->
     [];
 register_overflow(Config) when is_list(Config) ->
-    Dog = ?config(watchdog, Config),
-    test_server:timetrap_cancel(Dog),
-    LongDog = test_server:timetrap(?LONG_TEST_TIMEOUT),
+    ct:timetrap(?LONG_TEST_TIMEOUT),
     ok = epmdrun(),
     Conn = register_many(1, ?REG_REPEAT_LIM, "foo"),
     Count = length(Conn),
@@ -549,7 +526,6 @@ register_overflow(Config) when is_list(Config) ->
     ok = register_repeat(Count),
     sleep(?MEDIUM_PAUSE),
     ok = rregister_repeat(Count),
-    test_server:timetrap_cancel(LongDog),
     ok.
 
 register_repeat(Count) ->
-- 
cgit v1.2.3


From 58ee80fc615e19d1c2f2a1f69aa1c92fa9ab4f43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn-Egil=20Dahlberg?= <egil@erlang.org>
Date: Wed, 4 May 2016 18:01:28 +0200
Subject: Replace use of test_server:format/2 with io:format/2

There is no practial difference.
---
 erts/epmd/test/epmd_SUITE.erl | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index 29b10f2d29..4fb8875cde 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -258,8 +258,7 @@ register_node_v2(Addr, Port, NodeType, Prot, HVsn, LVsn, Name, Extra) ->
                 {ok, [?EPMD_ALIVE2_RESP,_Res=0,_C0,_C1]} ->
                     {ok,Sock};
                 Other ->
-                    test_server:format("recv on sock ~w: ~p~n",
-                                       [Sock,Other]),
+                    io:format("recv on sock ~w: ~p~n", [Sock,Other]),
                     error
             end;
         error ->
@@ -276,8 +275,7 @@ port_please_v2(Name) ->
                 {ok, Resp} ->
                     parse_port2_resp(Resp);
                 Other ->
-                    test_server:format("recv on sock ~w: ~p~n",
-                                       [Sock,Other]),
+                    io:format("recv on sock ~w: ~p~n", [Sock,Other]),
                     error
             end;
         error ->
@@ -294,8 +292,7 @@ parse_port2_resp(Resp) ->
                             node_name=unicode:characters_to_list(NodeName),
                             extra=binary_to_list(Extra)}};
         _Other ->
-            test_server:format("invalid port2 resp: ~p~n",
-                               [Resp]),
+            io:format("invalid port2 resp: ~p~n", [Resp]),
             error
     end.
 
@@ -454,8 +451,7 @@ port_request(M) ->
             ok;
         Other ->
             close(RSock),
-            test_server:format("recv on sock ~w: ~p~n",
-                               [Sock,Other]),
+            io:format("recv on sock ~w: ~p~n", [Sock,Other]),
             throw({error,Other})
     end,
     ok.
@@ -505,8 +501,7 @@ register_overflow(Config) when is_list(Config) ->
     Count = length(Conn),
     ok = unregister_many(Conn),
     sleep(?MEDIUM_PAUSE),
-    test_server:format("Limit was ~w names, now reg/unreg all 10 times~n",
-                       [Count]),
+    io:format("Limit was ~w names, now reg/unreg all 10 times~n", [Count]),
     ok = register_repeat(Count),
     sleep(?MEDIUM_PAUSE),
     ok = rregister_repeat(Count),
@@ -551,7 +546,7 @@ rregister_repeat(Count) ->
 % Return count of successful registrations
 
 register_many(I, N, _Prefix) when I > N ->
-    test_server:format("Done with all ~n", []),
+    io:format("Done with all ~n", []),
     [];
 register_many(I, N, Prefix) ->
     Name = gen_name(Prefix, I),
-- 
cgit v1.2.3


From 4bf79507bc911bf619e906e6ff294128a0c398a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn-Egil=20Dahlberg?= <egil@erlang.org>
Date: Wed, 4 May 2016 18:09:08 +0200
Subject: Eliminate use of doc and suite clauses

Those clause are obsolete and never used by common_test.
---
 erts/epmd/test/epmd_SUITE.erl | 170 +++++++++---------------------------------
 1 file changed, 37 insertions(+), 133 deletions(-)

(limited to 'erts/epmd')

diff --git a/erts/epmd/test/epmd_SUITE.erl b/erts/epmd/test/epmd_SUITE.erl
index 4fb8875cde..0f0a5acde7 100644
--- a/erts/epmd/test/epmd_SUITE.erl
+++ b/erts/epmd/test/epmd_SUITE.erl
@@ -144,20 +144,14 @@ end_per_testcase(_Func, _Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-register_name(doc) ->
-    ["Register a name"];
-register_name(suite) ->
-    [];
+%% Register a name
 register_name(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = register_node("foobar"),
     ok = close(Sock),			% Unregister
     ok.
 
-register_name_ipv6(doc) ->
-    ["Register a name over IPv6"];
-register_name_ipv6(suite) ->
-    [];
+%% Register a name over IPv6
 register_name_ipv6(Config) when is_list(Config) ->
     % Test if the host has an IPv6 loopback address
     Res = gen_tcp:listen(0, [inet6, {ip, {0,0,0,0,0,0,0,1}}]),
@@ -172,10 +166,7 @@ register_name_ipv6(Config) when is_list(Config) ->
             {skip, "Host does not have an IPv6 loopback address"}
     end.
 
-register_names_1(doc) ->
-    ["Register and unregister two nodes"];
-register_names_1(suite) ->
-    [];
+%% Register and unregister two nodes
 register_names_1(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock1} = register_node("foobar"),
@@ -184,10 +175,7 @@ register_names_1(Config) when is_list(Config) ->
     ok = close(Sock2),			% Unregister
     ok.
 
-register_names_2(doc) ->
-    ["Register and unregister two nodes"];
-register_names_2(suite) ->
-    [];
+%% Register and unregister two nodes
 register_names_2(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock1} = register_node("foobar"),
@@ -196,10 +184,7 @@ register_names_2(Config) when is_list(Config) ->
     ok = close(Sock1),			% Unregister
     ok.
 
-register_duplicate_name(doc) ->
-    ["Two nodes with the same name"];
-register_duplicate_name(suite) ->
-    [];
+%% Two nodes with the same name
 register_duplicate_name(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = register_node("foobar"),
@@ -209,10 +194,7 @@ register_duplicate_name(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-unicode_name(doc) ->
-    ["Check that we can register and lookup a unicode name"];
-unicode_name(suite) ->
-    [];
+%% Check that we can register and lookup a unicode name
 unicode_name(Config) when is_list(Config) ->
     ok = epmdrun(),
     NodeName = [16#1f608],
@@ -224,10 +206,7 @@ unicode_name(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-long_unicode_name(doc) ->
-    ["Check that we can register and lookup a long unicode name"];
-long_unicode_name(suite) ->
-    [];
+%% Check that we can register and lookup a long unicode name
 long_unicode_name(Config) when is_list(Config) ->
     ok = epmdrun(),
     BaseChar = 16#1f600,
@@ -298,10 +277,7 @@ parse_port2_resp(Resp) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-name_with_null_inside(doc) ->
-    ["Register a name with a null char in it"];
-name_with_null_inside(suite) ->
-    [];
+%% Register a name with a null char in it
 name_with_null_inside(Config) when is_list(Config) ->
     ok = epmdrun(),
     error = register_node("foo\000bar"),
@@ -309,10 +285,7 @@ name_with_null_inside(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-name_null_terminated(doc) ->
-    ["Register a name with terminating null byte"];
-name_null_terminated(suite) ->
-    [];
+%% Register a name with terminating null byte
 name_null_terminated(Config) when is_list(Config) ->
     ok = epmdrun(),
     error = register_node("foobar\000"),
@@ -320,10 +293,7 @@ name_null_terminated(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-stupid_names_req(doc) ->
-    ["Read names from epmd in a stupid way"];
-stupid_names_req(suite) ->
-    [];
+%% Read names from epmd in a stupid way
 stupid_names_req(Config) when is_list(Config) ->
     ok = epmdrun(),
     [FirstConn | Conn] = register_many(1, ?REG_REPEAT_LIM, "foo"),
@@ -420,17 +390,11 @@ parse_name([], _Name) -> error.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-get_port_nr(doc) ->
-    ["Register a name on a port and ask about port nr"];
-get_port_nr(suite) ->
-    [];
+%% Register a name on a port and ask about port nr
 get_port_nr(Config) when is_list(Config) ->
     port_request([?EPMD_PORT_PLEASE2_REQ,"foo"]).
 
-slow_get_port_nr(doc) ->
-    ["Register with slow write and ask about port nr"];
-slow_get_port_nr(suite) ->
-    [];
+%% Register with slow write and ask about port nr
 slow_get_port_nr(Config) when is_list(Config) ->
     port_request([?EPMD_PORT_PLEASE2_REQ,d,$f,d,$o,d,$o]).
 
@@ -458,10 +422,7 @@ port_request(M) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-unregister_others_name_1(doc) ->
-    ["Unregister name of other node"];
-unregister_others_name_1(suite) ->
-    [];
+%% Unregister name of other node
 unregister_others_name_1(Config) when is_list(Config) ->
     ok = epmdrun("-relaxed_command_check"),
     {ok,RSock} = register_node("foo"),
@@ -475,10 +436,7 @@ unregister_others_name_1(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-unregister_others_name_2(doc) ->
-    ["Unregister name of other node"];
-unregister_others_name_2(suite) ->
-    [];
+%% Unregister name of other node
 unregister_others_name_2(Config) when is_list(Config) ->
     ok = epmdrun("-relaxed_command_check"),
     {ok,Sock} = connect(),
@@ -490,10 +448,7 @@ unregister_others_name_2(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-register_overflow(doc) ->
-    ["Register too many, clean and redo 10 times"];
-register_overflow(suite) ->
-    [];
+%% Register too many, clean and redo 10 times
 register_overflow(Config) when is_list(Config) ->
     ct:timetrap(?LONG_TEST_TIMEOUT),
     ok = epmdrun(),
@@ -575,10 +530,7 @@ gen_name(Str,Int) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-no_data(doc) ->
-    ["Open but send no data"];
-no_data(suite) ->
-    [];
+%% Open but send no data
 no_data(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -588,10 +540,7 @@ no_data(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-one_byte(doc) ->
-    ["Send one byte only"];
-one_byte(suite) ->
-    [];
+%% Send one byte only
 one_byte(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -602,10 +551,7 @@ one_byte(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-two_bytes(doc) ->
-    ["Send packet size only"];
-two_bytes(suite) ->
-    [];
+%% Send packet size only
 two_bytes(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -616,10 +562,7 @@ two_bytes(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-partial_packet(doc) ->
-    ["Got only part of a packet"];
-partial_packet(suite) ->
-    [];
+%% Got only part of a packet
 partial_packet(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -630,10 +573,7 @@ partial_packet(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-zero_length(doc) ->
-    ["Invalid zero packet size"];
-zero_length(suite) ->
-    [];
+%% Invalid zero packet size
 zero_length(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -644,10 +584,7 @@ zero_length(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-too_large(doc) ->
-    ["Invalid large packet"];
-too_large(suite) ->
-    [];
+%% Invalid large packet
 too_large(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -665,10 +602,7 @@ too_large(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-alive_req_too_small_1(doc) ->
-    ["Try to register but not enough data"];
-alive_req_too_small_1(suite) ->
-    [];
+%% Try to register but not enough data
 alive_req_too_small_1(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -681,10 +615,7 @@ alive_req_too_small_1(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-alive_req_too_small_2(doc) ->
-    ["Try to register but not enough data"];
-alive_req_too_small_2(suite) ->
-    [];
+%% Try to register but not enough data
 alive_req_too_small_2(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -697,10 +628,7 @@ alive_req_too_small_2(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-alive_req_too_large(doc) ->
-    ["Try to register but node name too large"];
-alive_req_too_large(suite) ->
-    [];
+%% Try to register but node name too large
 alive_req_too_large(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = connect(),
@@ -726,10 +654,7 @@ alive_req_too_large(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-returns_valid_empty_extra(doc) ->
-    ["Check that an empty extra is prefixed by a two byte length"];
-returns_valid_empty_extra(suite) ->
-    [];
+%% Check that an empty extra is prefixed by a two byte length
 returns_valid_empty_extra(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = register_node_v2(4711, 72, 0, 5, 5, "foo", []),
@@ -739,10 +664,7 @@ returns_valid_empty_extra(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-returns_valid_populated_extra_with_nulls(doc) ->
-    ["Check a populated extra with embedded null characters"];
-returns_valid_populated_extra_with_nulls(suite) ->
-    [];
+%% Check a populated extra with embedded null characters
 returns_valid_populated_extra_with_nulls(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = register_node_v2(4711, 72, 0, 5, 5, "foo", "ABC\000\000"),
@@ -752,10 +674,7 @@ returns_valid_populated_extra_with_nulls(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-names_stdout(doc) ->
-    ["Test that epmd -names prints registered nodes to stdout"];
-names_stdout(suite) ->
-    [];
+%% Test that epmd -names prints registered nodes to stdout
 names_stdout(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,Sock} = register_node("foobar"),
@@ -770,18 +689,13 @@ names_stdout(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-buffer_overrun_1(suite) ->
-    [];
-buffer_overrun_1(doc) ->
-    ["Test security vulnerability in fake extra lengths in alive2_req"];
+%% Test security vulnerability in fake extra lengths in alive2_req
 buffer_overrun_1(Config) when is_list(Config) ->
     ok = epmdrun(),
     true = alltrue([hostile(N) || N <- lists:seq(1,10000)]),
     ok.
-buffer_overrun_2(suite) ->
-    [];
-buffer_overrun_2(doc) ->
-    ["Test security vulnerability in fake extra lengths in alive2_req"];
+
+%% Test security vulnerability in fake extra lengths in alive2_req
 buffer_overrun_2(Config) when is_list(Config) ->
     ok = epmdrun(),
     [false | Rest] = [hostile2(N) || N <- lists:seq(255*4,10000)],
@@ -822,10 +736,8 @@ alltrue([true|T]) ->
 alltrue([_|_]) ->
     false.
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
-no_nonlocal_register(suite) ->
-    [];
-no_nonlocal_register(doc) ->
-    ["Ensure that we cannot register throug a nonlocal connection"];
+
+%% Ensure that we cannot register throug a nonlocal connection
 no_nonlocal_register(Config) when is_list(Config) ->
     case {os:find_executable("ssh"),ct:get_config(ssh_proxy_host)} of
         {SSH,Name} when is_list(Name), is_list(SSH) ->
@@ -866,10 +778,7 @@ do_no_nonlocal_register(Config,SSHHost) when is_list(Config) ->
     true = Res,
     ok.
 
-no_nonlocal_kill(suite) ->
-    [];
-no_nonlocal_kill(doc) ->
-    ["Ensure that we cannot kill through nonlocal connection"];
+%% Ensure that we cannot kill through nonlocal connection
 no_nonlocal_kill(Config) when is_list(Config) ->
     case {os:find_executable("ssh"),ct:get_config(ssh_proxy_host)} of
         {SSH,Name} when is_list(Name), is_list(SSH) ->
@@ -901,10 +810,8 @@ do_no_nonlocal_kill(Config,SSHHost) when is_list(Config) ->
     true = Res,
     ok.
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
-no_live_killing(doc) ->
-    ["Dont allow killing with live nodes or any unregistering w/o -relaxed_command_check"];
-no_live_killing(suite) ->
-    [];
+
+%% Dont allow killing with live nodes or any unregistering w/o -relaxed_command_check
 no_live_killing(Config) when is_list(Config) ->
     ok = epmdrun(),
     {ok,RSock} = register_node("foo"),
@@ -927,11 +834,8 @@ no_live_killing(Config) when is_list(Config) ->
     close(Sock3),
     ok.
 
-socket_reset_before_alive2_reply_is_written(doc) ->
-    ["Check for regression - don't make zombie from node which "
-     "sends TCP RST at wrong time"];
-socket_reset_before_alive2_reply_is_written(suite) ->
-    [];
+%% Check for regression - don't make zombie from node which
+%% sends TCP RST at wrong time
 socket_reset_before_alive2_reply_is_written(Config) when is_list(Config) ->
     %% - delay_write for easier triggering of race condition
     %% - relaxed_command_check for gracefull shutdown of epmd even if there
-- 
cgit v1.2.3