From ae6eb243f95d4fb1bdc83d31613a36c53323b9ee Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Wed, 24 Jul 2019 18:03:19 +0200
Subject: [esock] Dialyzer related cleanup

Removed unnecessary spec's causing dialyzer warnings.
---
 erts/preloaded/src/Makefile   | 10 ++++++++++
 erts/preloaded/src/socket.erl | 10 +++++-----
 2 files changed, 15 insertions(+), 5 deletions(-)

(limited to 'erts/preloaded/src')

diff --git a/erts/preloaded/src/Makefile b/erts/preloaded/src/Makefile
index e1bb2ee5c4..38b85915cc 100644
--- a/erts/preloaded/src/Makefile
+++ b/erts/preloaded/src/Makefile
@@ -95,6 +95,15 @@ ERL_COMPILE_FLAGS += +debug_info -I$(KERNEL_SRC) -I$(KERNEL_INCLUDE)
 
 DIA_PLT      = erts-preloaded.plt
 DIA_ANALYSIS = $(basename $(DIA_PLT)).dialyzer_analysis
+ifeq ($(DIAW_EH),true)
+DIA_WARNINGS += -Werror_handling
+endif
+ifeq ($(DIAW_US),true)
+DIA_WARNINGS += -Wunderspecs
+endif
+ifeq ($(DIAW_UR),true)
+DIA_WARNINGS += -Wunmatched_returns
+endif
 
 
 debug opt: $(TARGET_FILES) 
@@ -144,6 +153,7 @@ dialyzer: $(DIA_PLT)
 	@echo "Running dialyzer on $(basename $(DIA_PLT))"
 	@dialyzer --plt $< \
                   ../ebin \
+                  $(DIA_WARNINGS) \
                   --verbose
 
 #
diff --git a/erts/preloaded/src/socket.erl b/erts/preloaded/src/socket.erl
index 57b9f54a4e..e01c85d5d1 100644
--- a/erts/preloaded/src/socket.erl
+++ b/erts/preloaded/src/socket.erl
@@ -2696,17 +2696,17 @@ cancel(#socket{ref = SockRef}, #select_info{tag = Tag, ref = Ref}) ->
 %%
 %% ===========================================================================
 
--spec enc_domain(Domain) -> non_neg_integer() when
-      Domain :: domain().
+%% -spec enc_domain(Domain) -> non_neg_integer() when
+%%       Domain :: domain().
 
 enc_domain(local)  -> ?SOCKET_DOMAIN_LOCAL;
 enc_domain(inet)   -> ?SOCKET_DOMAIN_INET;
 enc_domain(inet6)  -> ?SOCKET_DOMAIN_INET6;
 enc_domain(Domain) -> invalid_domain(Domain).
 
--spec enc_type(Domain, Type) -> non_neg_integer() when
-      Domain :: domain(),
-      Type   :: type().
+%% -spec enc_type(Domain, Type) -> non_neg_integer() when
+%%       Domain :: domain(),
+%%       Type   :: type().
 
 %% What combos are valid?
 enc_type(_, stream)    -> ?SOCKET_TYPE_STREAM;
-- 
cgit v1.2.3