From 588ed7d503f7f607ec91d102f16573ee5d64ea7b Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Wed, 13 Apr 2016 15:20:53 +0200
Subject: erts: Improve port_SUITE:bad_env

It's not just ok to throw badarg, it MUST throw badarg.
---
 erts/emulator/test/port_SUITE.erl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'erts')

diff --git a/erts/emulator/test/port_SUITE.erl b/erts/emulator/test/port_SUITE.erl
index c0c0470c94..a40d9a4d1f 100644
--- a/erts/emulator/test/port_SUITE.erl
+++ b/erts/emulator/test/port_SUITE.erl
@@ -920,10 +920,10 @@ bad_env(Config) when is_list(Config) ->
     ok.
 
 try_bad_env(Env) ->
-    try open_port({spawn,"ls"}, [{env,Env}])
-    catch
-	error:badarg -> ok
-    end.
+    badarg = try open_port({spawn,"ls"}, [{env,Env}])
+	     catch
+		 error:badarg -> badarg
+	     end.
 
 %%  Test bad 'args' options.
 bad_args(Config) when is_list(Config) ->
-- 
cgit v1.2.3