From ffd59fbd9ac262b7aba4b86e7da4992a3e668e24 Mon Sep 17 00:00:00 2001 From: Rickard Green Date: Tue, 1 Aug 2017 18:34:58 +0200 Subject: Introduce sender in distributed signals and dflag configuration --- erts/doc/src/alt_dist.xml | 69 ++++++++++++++++++++++++++++++++++++ erts/doc/src/erl_dist_protocol.xml | 70 ++++++++++++++++++++++++++++++++++++ erts/doc/src/erlang.xml | 19 +++------- erts/emulator/beam/bif.c | 1 + erts/emulator/beam/dist.c | 72 ++++++++++++++++++++++++++++---------- erts/emulator/beam/dist.h | 5 +++ 6 files changed, 202 insertions(+), 34 deletions(-) (limited to 'erts') diff --git a/erts/doc/src/alt_dist.xml b/erts/doc/src/alt_dist.xml index 300f75dc13..d3731a5391 100644 --- a/erts/doc/src/alt_dist.xml +++ b/erts/doc/src/alt_dist.xml @@ -760,10 +760,79 @@

Only used during handshake phase.

+ + add_flags + +

+ Distribution flags + to add to the connection. Currently all (non obsolete) flags will + automatically be enabled. +

+

+ This flag field is optional. +

+ + + reject_flags + +

+ Distribution flags + to reject. Currently the following distribution flags can be rejected: +

+ + DFLAG_DIST_HDR_ATOM_CACHE + Do not use atom cache over this connection. + DFLAGS_STRICT_ORDER_DELIVERY + Do not use any features that require strict + order delivery. + +

+ This flag field is optional. +

+ + + require_flags + +

+ Require these distribution + flags to be used. The connection will be aborted during the + handshake if the other end does not use them. +

+

+ This flag field is optional. +

+ +
+ + Distribution Data Delivery +

+ When using the default configuration, the data to pass + over a connection needs to be delivered as is + to the node on the receiving end in the exact same + order, with no loss of data what so ever, as sent + from the sending node. +

+

+ The data delivery order can be relaxed by disabling + features that require strict ordering. This is done by + passing the ?DFLAGS_STRICT_ORDER_DELIVERY + distribution + flags in the + reject_flags + field of the #hs_data{} + record used when setting up the connection. When relaxed + ordering is used, only the order of signals with the same + sender/receiver pair has to be preserved. + However, note that disabling the features that require + strict ordering may have a negative impact on performance, + throughput, and/or latency. +

+
+
Enable Your Distribution Module diff --git a/erts/doc/src/erl_dist_protocol.xml b/erts/doc/src/erl_dist_protocol.xml index 610351db6c..a78b13aaa4 100644 --- a/erts/doc/src/erl_dist_protocol.xml +++ b/erts/doc/src/erl_dist_protocol.xml @@ -829,7 +829,31 @@ DiB == gen_digest(ChA, ICA)?

The node understand UTF-8 encoded atoms.

 + -define(DFLAG_MAP_TAG, 16#20000). + +

The node understand the map tag.

+ + -define(DFLAG_BIG_CREATION, 16#40000). + +

The node understand big node creation.

+ + -define(DFLAG_SEND_SENDER, 16#80000). + +

+ Use the SEND_SENDER + control message + instead of the SEND control message and use the + SEND_SENDER_TT control message instead + of the SEND_TT control message. +

+ +

+ There are also a collection of DFLAGs bitwise or:ed + together in the DFLAGS_STRICT_ORDER_DELIVERY macro. + These flags corresponds to features that require strict + ordering of data over distribution channels. +

@@ -922,6 +946,7 @@ DiB == gen_digest(ChA, ICA)? +

The ControlMessage is a tuple, where the first element indicates which distributed operation it encodes:

@@ -1028,4 +1053,49 @@ DiB == gen_digest(ChA, ICA)? + +
+ New Ctrlmessages for Erlang/OTP 21 + + SEND_SENDER + +

{22, FromPid, ToPid}

+

Followed by Message.

+

+ This control messages replace the SEND control + message and will be sent when the distribution flag + DFLAG_SEND_SENDER + has been negotiated in the connection setup handshake. +

+

+ Messages encoded before the connection has + been set up may still use the SEND control + message. However, once a SEND_SENDER or SEND_SENDER_TT + control message has been sent, no more SEND + control messages will be sent in the same direction + on the connection. +

+ + SEND_SENDER_TT + +

{23, FromPid, ToPid, TraceToken}

+

Followed by Message.

+

+ This control messages replace the SEND_TT control + message and will be sent when the distribution flag + DFLAG_SEND_SENDER + has been negotiated in the connection setup handshake. +

+

+ Messages encoded before the connection has + been set up may still use the SEND_TT control + message. However, once a SEND_SENDER or SEND_SENDER_TT + control message has been sent, no more SEND_TT + control messages will be sent in the same direction + on the connection. +

+ + +
+ diff --git a/erts/doc/src/erlang.xml b/erts/doc/src/erlang.xml index 8b0f97f30f..f1fcbd7532 100644 --- a/erts/doc/src/erlang.xml +++ b/erts/doc/src/erlang.xml @@ -1235,12 +1235,6 @@ end data is available by calling erlang:dist_ctrl_get_data_notification(DHandle).

-

- The data retreived from this function needs to be delivered - as is to the node on the other end in the exact same order, - with no loss of data what so ever, as retrived from this - function. -

Only the process registered as distribution controller for the distribution channel identified by @@ -1253,7 +1247,7 @@ end controllers. DHandle is retrived via the callback f_handshake_complete. - More information about this can be found in the documentation of + More information can be found in the documentation of ERTS User's Guide ➜ How to implement an Alternative Carrier for the Erlang Distribution ➜ Distribution Module. @@ -1289,7 +1283,7 @@ end controllers. DHandle is retrived via the callback f_handshake_complete. - More information about this can be found in the documentation of + More information can be found in the documentation of ERTS User's Guide ➜ How to implement an Alternative Carrier for the Erlang Distribution ➜ Distribution Module. @@ -1322,7 +1316,7 @@ end controllers. DHandle is retrived via the callback f_handshake_complete. - More information about this can be found in the documentation of + More information can be found in the documentation of ERTS User's Guide ➜ How to implement an Alternative Carrier for the Erlang Distribution ➜ Distribution Module. @@ -1338,11 +1332,6 @@ end Deliver distribution channel data from a remote node to the local node.

-

- The data passed to the VM using this function needs to be - passed in the exact same order, and with no loss of data - what so ever, as sent from the node on the other end. -

Only the process registered as distribution controller for the distribution channel identified by @@ -1360,7 +1349,7 @@ end controllers. DHandle is retrived via the callback f_handshake_complete. - More information about this can be found in the documentation of + More information can be found in the documentation of ERTS User's Guide ➜ How to implement an Alternative Carrier for the Erlang Distribution ➜ Distribution Module. diff --git a/erts/emulator/beam/bif.c b/erts/emulator/beam/bif.c index b1f915b133..53b48ba6e1 100644 --- a/erts/emulator/beam/bif.c +++ b/erts/emulator/beam/bif.c @@ -2035,6 +2035,7 @@ static Sint remote_send(Process *p, DistEntry *dep, ASSERT(is_atom(to) || is_external_pid(to)); + ctx->dep = dep; code = erts_dsig_prepare(&ctx->dsd, dep, p, ERTS_DSP_NO_LOCK, !ctx->suspend); switch (code) { case ERTS_DSIG_PREP_NOT_ALIVE: diff --git a/erts/emulator/beam/dist.c b/erts/emulator/beam/dist.c index d5c39485d0..a50072fe98 100644 --- a/erts/emulator/beam/dist.c +++ b/erts/emulator/beam/dist.c @@ -953,11 +953,30 @@ erts_dsig_send_msg(Eterm remote, Eterm message, ErtsSendContext* ctx) } #endif - if (token != NIL) - ctl = TUPLE4(&ctx->ctl_heap[0], - make_small(DOP_SEND_TT), am_Empty, remote, token); - else - ctl = TUPLE3(&ctx->ctl_heap[0], make_small(DOP_SEND), am_Empty, remote); + if (token != NIL) { + Eterm el1, el2; + if (ctx->dep->flags & DFLAG_SEND_SENDER) { + el1 = make_small(DOP_SEND_SENDER_TT); + el2 = sender->common.id; + } + else { + el1 = make_small(DOP_SEND_TT); + el2 = am_Empty; + } + ctl = TUPLE4(&ctx->ctl_heap[0], el1, el2, remote, token); + } + else { + Eterm el1, el2; + if (ctx->dep->flags & DFLAG_SEND_SENDER) { + el1 = make_small(DOP_SEND_SENDER); + el2 = sender->common.id; + } + else { + el1 = make_small(DOP_SEND); + el2 = am_Empty; + } + ctl = TUPLE3(&ctx->ctl_heap[0], el1, el2, remote); + } DTRACE6(message_send, sender_name, receiver_name, msize, tok_label, tok_lastcnt, tok_serial); DTRACE7(message_send_remote, sender_name, node_name, receiver_name, @@ -1292,6 +1311,7 @@ int erts_net_message(Port *prt, } token_size = 0; + token = NIL; switch (type = unsigned_val(tuple[1])) { case DOP_LINK: @@ -1521,38 +1541,52 @@ int erts_net_message(Port *prt, } break; + case DOP_SEND_SENDER_TT: { + Uint xsize; case DOP_SEND_TT: + if (tuple_arity != 4) { goto invalid_message; } - - token_size = size_object(tuple[4]); - /* Fall through ... */ + + token = tuple[4]; + token_size = size_object(token); + xsize = ERTS_HEAP_FRAG_SIZE(token_size); + goto send_common; + + case DOP_SEND_SENDER: case DOP_SEND: + + token = NIL; + xsize = 0; + if (tuple_arity != 3) + goto invalid_message; + + send_common: + /* - * There is intentionally no testing of the cookie (it is always '') - * from R9B and onwards. + * If DOP_SEND_SENDER or DOP_SEND_SENDER_TT element 2 contains + * the sender pid (i.e. DFLAG_SEND_SENDER is set); otherwise, + * the atom '' (empty cookie). */ + ASSERT((type == DOP_SEND_SENDER || type == DOP_SEND_SENDER_TT) + ? (is_pid(tuple[2]) && (dep->flags & DFLAG_SEND_SENDER)) + : tuple[2] == am_Empty); + #ifdef ERTS_DIST_MSG_DBG dist_msg_dbg(&ede, "MSG", buf, orig_len); #endif - if (type != DOP_SEND_TT && tuple_arity != 3) { - goto invalid_message; - } to = tuple[3]; if (is_not_pid(to)) { goto invalid_message; } rp = erts_proc_lookup(to); if (rp) { - Uint xsize = type == DOP_SEND ? 0 : ERTS_HEAP_FRAG_SIZE(token_size); ErtsProcLocks locks = 0; ErtsDistExternal *ede_copy; ede_copy = erts_make_dist_ext_copy(&ede, xsize); - if (type == DOP_SEND) { - token = NIL; - } else { + if (is_not_nil(token)) { ErlHeapFragment *heap_frag; ErlOffHeap *ohp; ASSERT(xsize); @@ -1560,15 +1594,15 @@ int erts_net_message(Port *prt, ERTS_INIT_HEAP_FRAG(heap_frag, token_size, token_size); hp = heap_frag->mem; ohp = &heap_frag->off_heap; - token = tuple[4]; token = copy_struct(token, token_size, &hp, ohp); } - erts_queue_dist_message(rp, locks, ede_copy, token, tuple[2]); + erts_queue_dist_message(rp, locks, ede_copy, token, am_Empty); if (locks) erts_smp_proc_unlock(rp, locks); } break; + } case DOP_MONITOR_P_EXIT: { /* We are monitoring a process on the remote node which dies, we get diff --git a/erts/emulator/beam/dist.h b/erts/emulator/beam/dist.h index dcd5846ca5..06c13a9f2b 100644 --- a/erts/emulator/beam/dist.h +++ b/erts/emulator/beam/dist.h @@ -44,6 +44,7 @@ #define DFLAG_UTF8_ATOMS 0x10000 #define DFLAG_MAP_TAG 0x20000 #define DFLAG_BIG_CREATION 0x40000 +#define DFLAG_SEND_SENDER 0x80000 /* All flags that should be enabled when term_to_binary/1 is used. */ #define TERM_TO_BINARY_DFLAGS (DFLAG_EXTENDED_REFERENCES \ @@ -74,6 +75,9 @@ #define DOP_DEMONITOR_P 20 #define DOP_MONITOR_P_EXIT 21 +#define DOP_SEND_SENDER 22 +#define DOP_SEND_SENDER_TT 23 + /* distribution trap functions */ extern Export* dsend2_trap; extern Export* dsend3_trap; @@ -346,6 +350,7 @@ typedef struct { Eterm ctl_heap[6]; ErtsDSigData dsd; DistEntry* dep_to_deref; + DistEntry *dep; struct erts_dsig_send_context dss; Eterm return_term; -- cgit v1.2.3