From d3597d31c3b26a6269ed37b7856425a1d0641a90 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Fri, 8 Feb 2013 09:29:18 +0100
Subject: BER: Fix broken table constraints inside a SET OF/SEQUENCE OF

---
 lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl |  9 +--------
 lib/asn1/test/Makefile                         |  1 +
 lib/asn1/test/asn1_SUITE.erl                   |  4 +++-
 lib/asn1/test/testWSParamClass.erl             | 17 +++++++++++++++++
 4 files changed, 22 insertions(+), 9 deletions(-)
 create mode 100644 lib/asn1/test/testWSParamClass.erl

(limited to 'lib/asn1')

diff --git a/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl b/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl
index e82212f0d8..341a04761b 100644
--- a/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl
+++ b/lib/asn1/src/asn1ct_constructed_ber_bin_v2.erl
@@ -528,14 +528,7 @@ gen_decode_sof(Erules,TypeName,_InnerTypeName,D) when is_record(D,type) ->
 		   Atom when is_atom(Atom) -> Atom;
 		   _ -> TypeNameSuffix
 	       end,
-%% fix me
-    ObjFun =
-	case D#type.tablecinf of
-	    [{objfun,_}|_R] ->
-		", ObjFun";
-	    _ ->
-		[]
-	end,
+    ObjFun = false,
     gen_dec_line(Erules,TypeName,ContName,[],Cont,mandatory,ObjFun),
     %%    gen_dec_line_sof(Erules,Typename,ContName,Cont,ObjFun),
     emit([" || ",{curr,v}," <- ",{curr,tlv},"].",nl,nl,nl]).
diff --git a/lib/asn1/test/Makefile b/lib/asn1/test/Makefile
index 1fa495d8f1..10f8e2833b 100644
--- a/lib/asn1/test/Makefile
+++ b/lib/asn1/test/Makefile
@@ -109,6 +109,7 @@ MODULES= \
 	test_modified_x420 \
 	testX420 \
 	test_x691 \
+	testWSParamClass \
 	asn1_test_lib \
 	asn1_app_test \
 	asn1_appup_test \
diff --git a/lib/asn1/test/asn1_SUITE.erl b/lib/asn1/test/asn1_SUITE.erl
index abf1ba83a5..d66f395adb 100644
--- a/lib/asn1/test/asn1_SUITE.erl
+++ b/lib/asn1/test/asn1_SUITE.erl
@@ -991,7 +991,9 @@ test_ParamTypeInfObj(Config) ->
 
 test_WS_ParamClass(Config) -> test(Config, fun test_WS_ParamClass/3).
 test_WS_ParamClass(Config, Rule, Opts) ->
-    asn1_test_lib:compile("InformationFramework", Config, [Rule|Opts]).
+    asn1_test_lib:compile("InformationFramework", Config, [Rule|Opts]),
+    ?only_ber(testWSParamClass:main(Rule)),
+    ok.
 
 test_Defed_ObjectIdentifier(Config) ->
     asn1_test_lib:compile("UsefulDefinitions", Config, [ber]).
diff --git a/lib/asn1/test/testWSParamClass.erl b/lib/asn1/test/testWSParamClass.erl
new file mode 100644
index 0000000000..ae67ca8b81
--- /dev/null
+++ b/lib/asn1/test/testWSParamClass.erl
@@ -0,0 +1,17 @@
+-module(testWSParamClass).
+-export([main/1]).
+
+main(_) ->
+    IF = 'InformationFramework',
+    roundtrip({'Attribute',IF:'id-at-objectClass'(),
+	       [IF:'id-at-objectClass'()],
+	       asn1_NOVALUE}),
+    roundtrip({'Attribute',IF:'id-at-objectClass'(),
+	       [],[]}),
+    ok.
+
+roundtrip(Data) ->
+    IF = 'InformationFramework',
+    {ok,Enc} = asn1_wrapper:encode(IF, 'Attribute', Data),
+    {ok,Data} = IF:decode('Attribute', Enc),
+    ok.
-- 
cgit v1.2.3