From fcabdd0426fdf194e652a995e8407daad80c130a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 16 Sep 2014 13:39:19 +0200
Subject: Use the #objectclass{} record instead of a tuple

Don't build a record using the tuple syntax. It is bad in case
we would want to change the record definition later.
---
 lib/asn1/src/asn1ct_check.erl | 71 +++++++++++++++++++++----------------------
 1 file changed, 34 insertions(+), 37 deletions(-)

(limited to 'lib/asn1')

diff --git a/lib/asn1/src/asn1ct_check.erl b/lib/asn1/src/asn1ct_check.erl
index ba89b67098..a0253dba44 100644
--- a/lib/asn1/src/asn1ct_check.erl
+++ b/lib/asn1/src/asn1ct_check.erl
@@ -6971,44 +6971,41 @@ include_default_class1(Module,[{Name,TS}|Rest]) ->
 
 default_class_list(S) ->
     [{'TYPE-IDENTIFIER',
-      {objectclass,
-       [{fixedtypevaluefield,
-	 id,
-	 #type{tag=?TAG_PRIMITIVE(?N_OBJECT_IDENTIFIER),
-	       def='OBJECT IDENTIFIER'},
-	 'UNIQUE',
-	 'MANDATORY'},
-	{typefield,'Type','MANDATORY'}],
-       {'WITH SYNTAX',
-	[{typefieldreference,'Type'},
-	 'IDENTIFIED',
-	 'BY',
-	 {valuefieldreference,id}]}}},
+      #objectclass{fields=[{fixedtypevaluefield,
+			    id,
+			    #type{tag=?TAG_PRIMITIVE(?N_OBJECT_IDENTIFIER),
+				  def='OBJECT IDENTIFIER'},
+			    'UNIQUE',
+			    'MANDATORY'},
+			   {typefield,'Type','MANDATORY'}],
+		   syntax={'WITH SYNTAX',
+			   [{typefieldreference,'Type'},
+			    'IDENTIFIED',
+			    'BY',
+			    {valuefieldreference,id}]}}},
      {'ABSTRACT-SYNTAX',
-      {objectclass,
-       [{fixedtypevaluefield,
-	 id,
-	 #type{tag=?TAG_PRIMITIVE(?N_OBJECT_IDENTIFIER),
-	       def='OBJECT IDENTIFIER'},
-	 'UNIQUE',
-	 'MANDATORY'},
-	{typefield,'Type','MANDATORY'},
-	{fixedtypevaluefield,
-	 property,
-	 #type{tag=?TAG_PRIMITIVE(?N_BIT_STRING),
-	       def={'BIT STRING',[]}},
-	 undefined,
-	 {'DEFAULT',
-	  [0,1,0]}}],
-       {'WITH SYNTAX',
-	[{typefieldreference,'Type'},
-	 'IDENTIFIED',
-	 'BY',
-	 {valuefieldreference,id},
-	 ['HAS',
-	  'PROPERTY',
-	  {valuefieldreference,property}]]}}}].
-
+      #objectclass{fields=[{fixedtypevaluefield,
+			    id,
+			    #type{tag=?TAG_PRIMITIVE(?N_OBJECT_IDENTIFIER),
+				  def='OBJECT IDENTIFIER'},
+			    'UNIQUE',
+			    'MANDATORY'},
+			   {typefield,'Type','MANDATORY'},
+			   {fixedtypevaluefield,
+			    property,
+			    #type{tag=?TAG_PRIMITIVE(?N_BIT_STRING),
+				  def={'BIT STRING',[]}},
+			    undefined,
+			    {'DEFAULT',
+			     [0,1,0]}}],
+		   syntax={'WITH SYNTAX',
+			   [{typefieldreference,'Type'},
+			    'IDENTIFIED',
+			    'BY',
+			    {valuefieldreference,id},
+			    ['HAS',
+			     'PROPERTY',
+			     {valuefieldreference,property}]]}}}].
 
 new_reference_name(Name) ->
     case get(asn1_reference) of
-- 
cgit v1.2.3