From 291cf6d8530f4e0ad2f22f199b5ae6975135bbb3 Mon Sep 17 00:00:00 2001
From: Siri Hansen <siri@erlang.org>
Date: Tue, 24 Apr 2018 15:18:31 +0200
Subject: Test cuddle for logger

---
 lib/common_test/test/ct_hooks_SUITE.erl             | 21 +++++++++++++--------
 .../ct_hooks_SUITE_data/cth/tests/cth_log_SUITE.erl |  2 +-
 lib/common_test/test/ct_pre_post_test_io_SUITE.erl  |  4 ++--
 3 files changed, 16 insertions(+), 11 deletions(-)

(limited to 'lib/common_test')

diff --git a/lib/common_test/test/ct_hooks_SUITE.erl b/lib/common_test/test/ct_hooks_SUITE.erl
index 3c1e887f65..6228524a88 100644
--- a/lib/common_test/test/ct_hooks_SUITE.erl
+++ b/lib/common_test/test/ct_hooks_SUITE.erl
@@ -258,15 +258,20 @@ cth_log(Config) when is_list(Config) ->
       fun(UnexpIoLog) ->
 	      {ok,Bin} = file:read_file(UnexpIoLog),
 	      Ts = string:lexemes(binary_to_list(Bin),[$\n]),
-	      Matches = lists:foldl(fun([$=,$E,$R,$R,$O,$R|_],  N) ->
-					    N+1;
-				       ([$L,$o,$g,$g,$e,$r|_],  N) ->
-					    N+1;
+	      Matches = lists:foldl(fun([$=,$E,$R,$R,$O,$R|_],  {E,I,L}) ->
+					    {E+1,I,L};
+				       ([$=,$I,$N,$F,$O|_],  {E,I,L}) ->
+					    {E,I+1,L};
+				       ([$L,$o,$g,$g,$e,$r|_],  {E,I,L}) ->
+					    {E,I,L+1};
 				       (_, N) -> N
-				    end, 0, Ts),
-	      ct:pal("~p matches in ~tp", [Matches,UnexpIoLog]),
-	      if Matches > 10 -> ok;
-		 true -> exit({no_unexpected_io_found,UnexpIoLog})
+				    end, {0,0,0}, Ts),
+	      ct:pal("~p ({Error,Info,Log}) matches in ~tp",
+                     [Matches,UnexpIoLog]),
+              MatchList = tuple_to_list(Matches),
+              case [N || N <- MatchList, N<3] of
+                  [] -> ok;
+                  _ -> exit({missing_unexpected_io,UnexpIoLog})
 	      end
       end, UnexpIoLogs),
     ok.
diff --git a/lib/common_test/test/ct_hooks_SUITE_data/cth/tests/cth_log_SUITE.erl b/lib/common_test/test/ct_hooks_SUITE_data/cth/tests/cth_log_SUITE.erl
index bd1ac54781..a0cd77b88b 100644
--- a/lib/common_test/test/ct_hooks_SUITE_data/cth/tests/cth_log_SUITE.erl
+++ b/lib/common_test/test/ct_hooks_SUITE_data/cth/tests/cth_log_SUITE.erl
@@ -124,6 +124,6 @@ gen() ->
 gen_loop(N) ->
     ct:log("Logger iteration: ~p", [N]),
     error_logger:error_report(N),
-    error_logger:info_report(progress, N),
+    error_logger:info_report(N),
     ct:sleep(150),
     gen_loop(N+1).
diff --git a/lib/common_test/test/ct_pre_post_test_io_SUITE.erl b/lib/common_test/test/ct_pre_post_test_io_SUITE.erl
index 0b85392009..538fd822c1 100644
--- a/lib/common_test/test/ct_pre_post_test_io_SUITE.erl
+++ b/lib/common_test/test/ct_pre_post_test_io_SUITE.erl
@@ -241,7 +241,7 @@ try_loop(_Fun, 0) ->
     gave_up;
 try_loop(Fun, N) ->
     try Fun() of
-	{error,_} ->
+	{Error,_} when Error==error; Error==badrpc ->
 	    timer:sleep(10),
 	    try_loop(Fun, N-1);
 	Result ->
@@ -257,7 +257,7 @@ try_loop(M, F, _A, 0) ->
     gave_up;
 try_loop(M, F, A, N) ->
     try apply(M, F, A) of
-	{error,_} ->
+	{Error,_Reason} when Error==error; Error==badrpc ->
 	    timer:sleep(10),
 	    try_loop(M, F, A, N-1);
 	Result ->
-- 
cgit v1.2.3